From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020132.outbound.protection.outlook.com [52.101.84.132]) by lore.virtuozzo.com (Postfix) with ESMTPS id 41D67803BB for ; Tue, 17 Nov 2026 17:37:43 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aQIPVY4J+FSlE1scKS3opGygfbkI1Fk9bQx8fBMLVkCqEhSRaQIuFwZBDQ5UXPFvTRBsMzieEovATbf+7vf/dG0Un/vl/USDVZG8XlJeHxBRbuMVU/TGCGjo7AszRPQMrz75/S9QuOtdXxlKa+FDdpRInlvprjDM8VvvYZh16hgWkDWEwUf7AtMFUzLFxib53rd/vka6VeM7t4TXZsYRsHUgeH5jm53jzyFQpW8yoslgF4PeHMpgdm2o/96KIy853icGGM04JYPTQtVKGXEtrPWro0ZC4iva7xOWuNVhFCddmH9FQYeO0nvOjQq8XCdk3nFtwVAHaoe/fDT/u005dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qRkTwXX12F+tGGJpYBjZeA39XfY1VbMvPZo5MXdqJ9U=; b=M2lJHk9HzBSsEHPNd0O6r3r+53NEMvjHOZK2yCoiMtHvACgLxtZTkenw1ioFboufAdxHELAQEs23W035N4v3DOg06M6Au+d3cE7jeGjQIrEtrG9U/YO4GrW9wvloKDRdTgTlltdB0vu5DC3DyoEYL3LddLk0IbkFgRzU3e1bbmhqDlX9puheWBqCdzEKSR7883oybwE5MJ01g8EQOHI21MKgQyFuw6pUhZM9CptmZKjQq5OGCGznj2XaOExRV5nhjJvQyW2pbBRVAWWxBPlHUkDh9dng1c7BL44WqXXEeqXPjOhe+yxgiKjkSD9YSD44kzelF6eCkXNU5S10o4iNnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 130.117.225.111) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=virtuozzo.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=virtuozzo.com; dkim=pass (signature was verified) header.d=virtuozzo.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qRkTwXX12F+tGGJpYBjZeA39XfY1VbMvPZo5MXdqJ9U=; b=TI5JSH+kjZCzltCxzbprx/G/1f1Rzs8Y3L7IsJpF6PZSbQhsdwU32AukeM03SHOFP7HRWsnMBxixBAGk54PHtlN1ql2wU3CELWzaAlB6wTmjFW3yKYRifatLXw/muQ5LJBXn6UPiW8vB0oEQXJ4IohunVrIl+RNno3sgcTnF+kIFr00BopUyoezs3q1wYqqXULnRmdRib/bdOR9flWAAP2A/iYIGGcpXTMpePSupY8lkzbNug05PL2UIyyMyI62IqzWeImji6+gyMtvaEukh0mxCWzU59maN8U90hx6tLJfLfyXMHzAe8x/7fPRodliQbmhYXERM7OsOWeowN/TtYg== Received: from DUZPR01CA0300.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b7::24) by PAVPR08MB9329.eurprd08.prod.outlook.com (2603:10a6:102:305::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.14; Tue, 17 Nov 2026 17:37:38 +0000 Received: from DB1PEPF000509F4.eurprd02.prod.outlook.com (2603:10a6:10:4b7:cafe::2c) by DUZPR01CA0300.outlook.office365.com (2603:10a6:10:4b7::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.615.14 via Frontend Transport; Tue, 17 Nov 2026 17:37:38 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 130.117.225.111) smtp.mailfrom=virtuozzo.com; dkim=pass (signature was verified) header.d=virtuozzo.com;dmarc=pass action=none header.from=virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of virtuozzo.com designates 130.117.225.111 as permitted sender) receiver=protection.outlook.com; client-ip=130.117.225.111; helo=relay.virtuozzo.com; pr=C Received: from relay.virtuozzo.com (130.117.225.111) by DB1PEPF000509F4.mail.protection.outlook.com (10.167.242.150) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.615.4 via Frontend Transport; Tue, 17 Nov 2026 17:37:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=qRkTwXX12F+tGGJpYBjZeA39XfY1VbMvPZo5MXdqJ9U=; b=jJ+ShxsZsb4H g2KlTS6B+qzkWssVVH5LB2WuV9PNt2YbxXZ8Ai6eWRCog4doUoRrvmOXH4NuX42LQjU6vcIe7LbRm UQPUIDpVxjbgkiShZ5UMLRGQtMC8yEpKPwoguglnzI1utT5AzIa4faeelTNO5lquzOicf7PTfSZan XwEBs7dFVlWs4LhlrD4XI9AcSwOlMnv1C3FpDbB3skUxOAV9yAjh3+FDzGf5UUnOXG54H3GoqFXkT /6FrZjMjMBcel2Yc5NwFaTGJoehYtONNCJiu1j3j/Tgn1FDfXdU99muMUahtSjH2HKY4K23hCHavd RwGVbDpZsDTJIXyxSjf+BA==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xTN3R-000AxI-0M; Tue, 17 Nov 2026 18:37:27 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com, svt-core@virtuozzo.com Subject: [PATCH hci-8.1 v6 4/7] vhost-blk: fix vhost_blk_start() returning 0 on failure Date: Tue, 17 Nov 2026 18:37:31 +0100 Message-ID: <20261117173734.3225443-5-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261117173734.3225443-1-alexander.ivanov@virtuozzo.com> References: <20261117173734.3225443-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF000509F4:EE_|PAVPR08MB9329:EE_ X-MS-Office365-Filtering-Correlation-Id: 8b2a4e0c-1aa6-46b1-89a9-08df44d17949 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|82310400026|376014|36860700016|1800799024|22082099003|18002099003|5113699003|261009223027099003|13003099007|5023799004|261028144727099003|56012099006|261102123227099003|261026140227099003|261021123027099003|261022105027099003|261021121427099003|10067099003; X-Microsoft-Antispam-Message-Info: 8lv0f5zvlk/Wb8eA/x81MzIil1pEjNhO9nrwAR6OcMmRMIvx9bEi8EpiMYr/+lVaaPJhdolTzSAAgJOlT3uicPnApmk/mhIFdBOgHs+0AjYm46YficV0pNb3CswfonrWU2ieQuTnooZAZo8qLv7YlKjdezYIYL/tPV1bx9Xt5TEEyZFuEgRdX5+PgLyX6P+XIKweuZm+s7rce+PyUPyfHOKfo2Okqq4E5n6jpSAM2RqeWIi0/BMhaFH9jjV3vj9hISG4SKVkh9WJErQbszaHha2NjFx3MAI0wZj/Oqhn2BQ5rKT4H5AiCtq0IIzqZ1eO79Emg/A4TI/ByH+ANoaxm0EFRIopEaNCVemJb8ycAzp8FzluMJ63yP1RZVrsZAvybaFstxfZA/vpMB3G69rvFdNb65+dFiZyaBgzD/jlsfS8YdAsv+CbSZN79Iv3kGYSNDl3ZJsX3MGGVO6cAxvRFPwkmO1DCYxaCn/Pktw5KNtluvRLTokLKgCp5IlvrZfKdphwzNDRLhLZ06j2W8hsZPVrmq9FWLckEpLc8MSzcqhI0bV3qSEb42g3Kzoppv91lBIuHHsJTl98oMOc2Yrl9GjJvbklPT+y7uwT1+I9T4Fjqbfx3o3cTt5FqaCme2AhVzbemfMkPejrx8LwzZq3Lw== X-Forefront-Antispam-Report: CIP:130.117.225.111;CTRY:CH;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:relay.virtuozzo.com;PTR:relay.virtuozzo.com;CAT:NONE;SFS:(13230040)(23010399003)(82310400026)(376014)(36860700016)(1800799024)(22082099003)(18002099003)(5113699003)(261009223027099003)(13003099007)(5023799004)(261028144727099003)(56012099006)(261102123227099003)(261026140227099003)(261021123027099003)(261022105027099003)(261021121427099003)(10067099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 8hoPil3zufhv9hlTb3LzGu6kqBc8MlX7JMY3UXr+deAIyVlJaH3ncu+sQIqVoTuLnxfTj13R0RFnlZ6Jnqjwm07RMYENEL5S1/u7bI56YAM/6at7/T5xrnufOfvrjkkiXusKX3Hsr9hvsEzeuK09ajinhVfiXpJG6T+d3O/vmUnnzcQS0q5K8ix8J9jrSbJG8kMYyWa6qoSUW1t6GpD7zObg/Z/aJaSlG50vR5e+kbIJKznwdutVyNg4y96lKbWjOmuCsgLVuXuarIsD2Gfk8kBWVr8FTTbycpwmGRUEmfBOqAgv8xBd3z8BM+XlerkIH37jWcC6az/qO31mR2zWIqGntbo4R0LYhHshpqaQ1X1ZWLgQbIG2n/QdfeVQD9HULa89iVXrA2vrz+MEaGsRZMIoI6/Xkk0jAmpkWGZYGsyuoIdMr0bnJYJxot2rqw6m X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2026 17:37:38.3332 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8b2a4e0c-1aa6-46b1-89a9-08df44d17949 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0bc7f26d-0264-416e-a6fc-8352af79c58f;Ip=[130.117.225.111];Helo=[relay.virtuozzo.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509F4.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9329 The error path stores the result of unbinding the guest notifiers in ret, so a failure after binding them is reported as success once the unbind succeeds: vhost_blk_set_status() logs nothing and the device stays dead. Keep the original error in ret. https://virtuozzo.atlassian.net/browse/VSTOR-107537 Fixes: 0ff3cb5ff28f ("block: add vhost-blk backend") Signed-off-by: Alexander Ivanov --- hw/block/vhost-blk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/block/vhost-blk.c b/hw/block/vhost-blk.c index b3eb181ceae..1db8cfc7445 100644 --- a/hw/block/vhost-blk.c +++ b/hw/block/vhost-blk.c @@ -118,8 +118,7 @@ err_stop: err_disable: vhost_dev_disable_notifiers(hdev, vdev); err_set: - ret = k->set_guest_notifiers(qbus->parent, hdev->nvqs, false); - if (ret < 0) { + if (k->set_guest_notifiers(qbus->parent, hdev->nvqs, false) < 0) { error_report("vhost-blk: unable to unbind guest notifiers"); } -- 2.53.0