From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id ECB4B80726 for ; Tue, 6 Oct 2026 22:43:57 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 696Mghei028630; Wed, 7 Oct 2026 01:42:43 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 696Mghei028630 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="JWrm/bW8" Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 696MgeHL028626 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 7 Oct 2026 01:42:41 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 696MgeHL028626 Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-ccacc75a997so1469073a12.0 for ; Tue, 06 Oct 2026 15:42:41 -0700 (PDT) X-Gm-Message-State: AFuF++l6eiv6yAW7FPDvs9wH1XKESNLqDkWylPJjSznWQqGwbr4TjHYu KuTsGios1F4P8TOFsvGsNwvQo7tTxnm81maI++lQyS5d23u4BsUPwDozcla9QIiZ7EtyZYu7y5i DijHt2dRnCrXfy/08F7sfXXbT6mAFPDSWXuMFHhLQ7jdNF2MeddtvvA== X-Gm-Gg: AYBFou36J6vPbHbkR94cMTLjz44o0DYiEj2QDhgK6tU+Cgok2tJNzy8bKewNeHngtig 4KIDHSeQNg3hFXIGV5/WzEMBZP62v5I9/q7bq2KxBh9cvFrjiAuuSRIllCIb0CSRv3VDA7PJxSy fzCh+8tajwxUet6n/G6c8g29Inf3CWvTLhdLnHG8MnpuRo8rPZuQIe2atLq3EIR3OI/tgUkVslS ZpMpsAUtFuaQRzuRSvDgRvRKlIE10mavBxSNDF2qXDLUAVVqTRk9jP/aV9v+E+VYnlA5TtYfL14 Fd6wgNsUJNjOK551fM1v7BOF1O9msIypY6u1vMx8wDVnBo7DgwxvXQEOfW1td73O1yf1Gs0h9sb WPSSjCuPEJq2bx04aTCdCNVt+eWNTLspzurYT7oNXtBgkJOfeYztTzF3IJTBR6yud608PPTQmoA m7yLw0BWeDsIlvxIep0pxfmGLvNWvd X-Received: by 2002:a05:6a20:748c:b0:3dd:a009:317f with SMTP id adf61e73a8af0-3e1340934cdmr310257637.39.1791326559649; Tue, 06 Oct 2026 15:42:39 -0700 (PDT) X-Received: by 2002:a05:6a20:748c:b0:3dd:a009:317f with SMTP id adf61e73a8af0-3e1340934cdmr310209637.39.1791326557019; Tue, 06 Oct 2026 15:42:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1791326557; cv=pass; d=google.com; s=arc-20260327; b=kiuEXTTk6o1iKDU12a6Ypcbd4+nr7c2/iY5TSWHDco7MlIMBJWIvpvLu2nUKMm8x0E mNmPcR+psBQCUyppGx9kaNKrnckPjbZNYilH2Pq1DiP4nc0olXP+mKdBsbB5dJS9uqPE FbZL4OzhLia6OOeoJE5Ou0kzbIS31QCAZwBUEpy9E6qHrtp4tQ3qUu08Uo58A0kJmaR6 pG8yp6Qm7k0zrtIJUAEJk9s9BGzFc2uxbqALCjEw4JsIPpVZMD+cV+Gpl50h/2cjuVIZ CptWxUecUpHhodtGUYhY0TizN+wJ55xbWkDxQh/eqVlzyaMS2HBVHm0LCZ3vLApHX2MC /p1A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=3kJK08DxWVpF9cef7czMwHsi9dXhtgR+T9IGL+dorVY=; fh=/b0OCvJkPsVoW3lAtK7S1vFCz6wT18YFUFRxjV0ocU0=; b=MbgGUf1oJpwxzLjTjWuDehQm/FCkDM6zPKPcm5hrdnCfHjcB/TcM5NgZyEQ7ixTYU5 PQEnlh8UP/qGQpbOp9dUk0Fn/AwQZPnW78J0ung5tpAJd7dCImJXyS1IV2hpl4kHpwh2 ioTpcwhBZY7QR7H9eEZXx9jGcldhPbAqSVSBdRrL/34thZFoKEr8cjDKvkQqKA6oKHSM /RUp0qaxgo3de5+G43hKD0Jo+SbbO/CUbXr+OI5Kd8PPuCpste/+mVoYnz+q7rGPwNMd oNxDNMH8sIOJtmAlVs9n1VwIOY2k3CvspzPqhPzvIMs8IbVs47subwzQL4HVhX2o9Ul7 M1xg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b="JWrm/bW8"; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 2a01:111:f403:c201::6 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazlp170130006.outbound.protection.outlook.com. [2a01:111:f403:c201::6]) by mx.google.com with ESMTPS id d2e1a72fcca58-8918abad1a0si1601764b3a.224.2026.10.06.15.42.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2026 15:42:36 -0700 (PDT) Received-SPF: pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 2a01:111:f403:c201::6 as permitted sender) client-ip=2a01:111:f403:c201::6; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b="JWrm/bW8"; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 2a01:111:f403:c201::6 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xm36MructLpHxFinTEBEpYD+EYsN7FVXaJoejD4hcQHAg6ZMj1oBGeM37E6ALf7MxM5tOf9n2a3L1eUIWh+lZXKcmIeF4We96Q2qXulntp+reueORrJomZiwuzuqQv+2GTbLAcsVF40w5H6ZICfVQCtz15xdLwGnQt207zepYy50lMjnh22eaWZQ3rn65m5lVnASCykCg2AmZIZ6Q7rwAFIcKD6MZKXegqjAPpIYpAegbh9nVvvT5uO5imMENAzC+chGToTwZY08e2s65gZ+D9aaI3GFEWuqU4Fv4tQ4aMzW5GIjmRpPcIo4GHvmMDld6akWb+MNHP0R8HLIp9e9qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3kJK08DxWVpF9cef7czMwHsi9dXhtgR+T9IGL+dorVY=; b=JuHyBPMOE6USnDkMFNmk5543ia6x8/LY/5Xm/Q4qaDHfJZxdTbm7KpyDYJ/SHtTWuSCdZ9XMMCwRXF5/YPJm0b/Ft6PmMQlBsyXVugTgFnaLdSFWxWgZVAUfAqtDWBv7vlLuazQIW9snpVN8gBRiC1KEFk/LuwS4QpxBy468Ptpp2DvPPGCMfn5v7nmMJlq2a9WH8325CYSjlpGxn61afe58O0bN6nbQiAfYp6cKB/IJTNyV1yvYmebN7mdwSuYag/Yl5QydKf8//pvm1TUQTscYQj1Sr5BbX+xLsESj2rzU5lHDfjrFwOqUGAOAkKcmIZ1CUp11V1nvfMXB/L1X1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3kJK08DxWVpF9cef7czMwHsi9dXhtgR+T9IGL+dorVY=; b=JWrm/bW8vbUP7xNssa187HHCz5W6MRYkewGsuzEQiicotkghdafEEFlFN3yjAPFLiX6YB1v0n6R6Lfv7TqkmheBowGDSuBhUM/YW8UStNuOBZMXFkEfpTETgRJH2j05i+7dzrAIZgZpRhH5jZsmCa80RgZLucgTVmuLECaQWeKYnAC+CQBB/YNk7jjqcDKYqUA/QVRHSqj5A758X7b+ShYTD6/akVV9/Vet37885OzDWgWknCgw6sPJUWPzPqSPAOjOxVqQGY/87o19FKA9Sngy6N5cNa9aYI8M2KLEVMyrn2+jB9D0uXabfli3eFcx3cKNtrRTslyTowVDVkdrzvA== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from DBBPR08MB5929.eurprd08.prod.outlook.com (2603:10a6:10:208::8) by GV1PR08MB7987.eurprd08.prod.outlook.com (2603:10a6:150:9d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.472.14; Tue, 6 Oct 2026 22:42:32 +0000 Received: from DBBPR08MB5929.eurprd08.prod.outlook.com ([fe80::8c14:5279:76ab:8d35]) by DBBPR08MB5929.eurprd08.prod.outlook.com ([fe80::8c14:5279:76ab:8d35%3]) with mapi id 15.21.0472.016; Tue, 6 Oct 2026 22:42:31 +0000 Message-ID: <2710d3de-218c-449e-a7c4-0004e3a60879@virtuozzo.com> Date: Wed, 7 Oct 2026 01:42:29 +0300 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, khorenko@virtuozzo.com References: <20261006221704.2507107-1-eva.kurchatova@virtuozzo.com> <20261006221704.2507107-3-eva.kurchatova@virtuozzo.com> <010701a113529f6f-5fdc0168-31d1-4819-80ce-ccd514ae0344-000000@eu-central-1.amazonses.com> Content-Language: en-US From: "Eva Kurchatova (Virtuozzo)" In-Reply-To: <010701a113529f6f-5fdc0168-31d1-4819-80ce-ccd514ae0344-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR3P281CA0206.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::10) To DBBPR08MB5929.eurprd08.prod.outlook.com (2603:10a6:10:208::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR08MB5929:EE_|GV1PR08MB7987:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e062490-d751-4796-34f7-08df23fb1b65 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|366016|23010399003|1800799024|6133799003|22082099003|18002099003|5023799004|56012099006|10067099003|4143699003; X-Microsoft-Antispam-Message-Info: pN06OnMZRsimN/KTUiZK4OBc1uV/R01Jl65wvd3Fh+QskRvxE2CdsanQ8pxKWtBFdO7FbL/7D0tuq0/9Am8vKM/9q7gaWURiSlYx5F1fxWtPYqRMrdhoCxTIHU0wxZXSaMwLd6xFTZ2oe16kE2RJW66BqjbUH7ktR3cZLUzrmN4X/Y67afYWdgpbuJpQqTgV3I+MldHEQ3ZqipzHBXV/1HXSBex5cHL2owpfrexEHLN0oioZz2hHRICOQvFU0VwRF9Exh2w9z3OULdCbiIiAvm0ipuw/2f6FXQiTS+jfsg9oErYPr4SHNDgm3Hc4fqLUPriJOpgE4S8bVL+FQNpQ7Ep+d3Ot3SZx6MhrRs+JNnDEgAoit3b4KgS/X1HoAz4lPL7Zbi2QTepN3mf0qxk0yH+m6PQnwhkmp5cNT7plDGcN9YaH55XwjhshQaVzxmqGN5LPUJ26x3SCabRT4A7Y+uwnC3D3EZ6hY9JEmBd3nqZpK6EgnGgbqwLuNKvouBWOQ4GgCrxev+VuAe6oTic1cbjPHdU3k/bFdt9WXXooTZqNaFeUIXj6FZFuJtku1v5KRu/EvPfNw6EoBPWCr0j6awnxwXGd8rQODroZpus2uXok3de/PeV3ItNMn8FI+ceMPSKaXlO88qNrk6gyOKsjVagbY7jCa+GUnzUn9y7LQkc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR08MB5929.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(23010399003)(1800799024)(6133799003)(22082099003)(18002099003)(5023799004)(56012099006)(10067099003)(4143699003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjdScjU4ZEJ1c2gxVW9FRllweWY2ejlsYmxxQjN1d2R4Y3BMYmpOL0YvdmIw?= =?utf-8?B?dEFldlRNazEyWlNQSkllWWZPbHlQNHJMbUx5UEN4ZHVzT0pRUnRnUEQvWGl5?= =?utf-8?B?UVhhc0Q3ejlyNTUyMUFwMytTTE5FRUtyd1V1RmVFcG1FWDhmUkJHZ3J0L20z?= =?utf-8?B?S0wrdlk3SVdSbDNQaVdJWWtmUGtVYWJQemtjUjBUYkdaeWw1d2FLU05FSGZv?= =?utf-8?B?RDFXSjRnN1BqNkxrTXZHQzMvZjlsaGcwL3VTY1RmSGRrOVFWK0ppb09lMUJP?= =?utf-8?B?ejRpRk5MVlJWODMzT1VKZHd4dGJXQUxKVGFMQjQxWjliTC9CcDQrQTBwbXFm?= =?utf-8?B?dlVnUE1VRVVDV0Y0Wk1VRzhMWURGQ0JwMXRWZW5SWExsZ1NFUmoxblFlM210?= =?utf-8?B?R1B1d1h3ZUxRajdSTGg5Ymsyc01PcnNENGV2SzkzWkZxQ3N4OHlHNWJuRWtJ?= =?utf-8?B?QllZUEdtb05pa29HOElPYWJNeDFsN0RRU3dEN1FRMGI4bDZDSE1OUXY5Qk9L?= =?utf-8?B?aGNnWFdwckp4MkpaeVAzMUZVeExTOXl4UHVOdjhxYmxjWUdTZm9zU2RlcUhu?= =?utf-8?B?RDZEbTQyYWJiSWFRS2liOGt0NjMza3liYmRSSGtlOW1CWVVHTER1OUJJSm9r?= =?utf-8?B?UjVzMERPamoyWGNzMExJNFllYmorMDV3ZE51dDhDUU80Tk1xRFJaMFkzRzhu?= =?utf-8?B?ZmVhMlNaTUhPeGNmK0pRU2tIMXBhWXhkWGFBQlZyM2pjdzUyQVNxOEJTMEdu?= =?utf-8?B?MVJMZThmZHVVSm5uZndRZW1yVkVlNEo0SC84a3haNDZaQ0pEc2xCZXlzcWFF?= =?utf-8?B?SkhFa1NuTVNqQlVCVmNjQWFVT0ViUm12U3lIQTZNUHV6WTM2MkhBbFhSRFNm?= =?utf-8?B?NE1yQlhtZ0lmRUFncGlOYnRvem80di9ZekVxenZqdE1DeWFabEIxVlNMSXNJ?= =?utf-8?B?WE1laEFLNEdIaFNFZUkwOTk2Z2ZFVWpEclQ4L3pBTk0rVnZ3cVA5NktWRkQ0?= =?utf-8?B?ZlM1VU1CZ1lpK05yR0hnUGhKT2JBUHVRZ1FaYm1pRXBPK1IvOThEd0laM1Iy?= =?utf-8?B?dHJCRlczcDNYV1hoTUdMSWhOWXFHelBHSEMydjNMRHNEMEZOS1RXMVVISVB5?= =?utf-8?B?dDNIMFRqVUcveXJjZGVWTlo3cmFrYmZlS1NrczhXYURvR0pnUXRtN294OVpa?= =?utf-8?B?VU4vdkM3N0lHNTIxcGNORjlOcnliVWorUW12ZVBPOGd2bzBDZ3ZBSVEvbWRr?= =?utf-8?B?R3hEZ3djWk5CODYxNFBMUGhSdFRjeHFrQVpKU3Z4Z2RvVWdNMHB2cFg2YjIv?= =?utf-8?B?UWJWODUyVWsxZ2tIcTJsM0hjbXd5bDZNa1lTbytZeWRQWEZiVm15N2Zpcmh4?= =?utf-8?B?NHpTWmIzZ2o1R3BXR01GdVVHeE5NTjY1QXVPU0pmblU3NDl1di94TW5CaHpX?= =?utf-8?B?NXpoT3VDdVJuTTFIUE9HdWVWZnFCRnYyaU9uWmVxZnlYT2QzTjdxYUthZjFz?= =?utf-8?B?aXhmaDlXN1RIb2dDeHJXbnAvdjllcFBXVkV4STFQVytTQyszU1g3djVxZnF5?= =?utf-8?B?TS9hL0kycWVQYlpBVXEyMGxzOFVLREg2eUVpTDQyS2JhQVdpWm5JV1ArSERs?= =?utf-8?B?WUx1OGJBOEVTK0xDOHZGVXd6czE5NmdxekNRRlRaSGI5UmlDR2dLQnVkZ1Zn?= =?utf-8?B?eE1BZDBPVFlMdENVUUFzNzRCcnhKZlVFMVRuY251TzBxV0J6NThWY1BVeEhT?= =?utf-8?B?TW93a2d0aHg1VlM5NmIwU0RZQ3hKUjAxVnlFTytPK1gwN1czQjBUSWp2bmdh?= =?utf-8?B?WXFQTWlWTXFHeDlTR3JGT3NnQ2pXbnU0MkkyVVgyRVN1dmZ3MzNlSzh3MUxV?= =?utf-8?B?ZnBNdHlwUVNPalZnWjkzK0IvWFpwYW1kQ2pxMmF3ZE4rVWx2cksxQ01kQytN?= =?utf-8?B?VWEwUHZkUjJQbGRuWkV6cFBTOFEzd1dmeWVRclFPSnFKUEU1WHZJTXdQYjdK?= =?utf-8?B?QkNGUzBBQmNRN1p3NnErWktzZGNBb1RTVzVrcmJPQ2tScXgxNEM4cFMrUEdH?= =?utf-8?B?TE9DNS95Sko0QSs4YzB1N3orVk5zMHRKN1NPcWFIZHZ5MUpXcmRGa3lDTm1q?= =?utf-8?B?UUVHd2h6RE5KZXQyT2FlTUlocW9LZlFDTlFRKy8ydE9nUGlaQm1XbzBwZThu?= =?utf-8?B?a05PQ21XL3VOWmd5S2MxUnpBbEhiMlJsZUZYR2JyMGxHNDUzQ3dtTjBGeVdn?= =?utf-8?B?TGVBQktTR2R0SG1pYkxDZHBIUlpzMlJnbSs4SzNCZm9DaURVQ09uZmcrZSts?= =?utf-8?B?ZGpGYS81VzZ3YzZzL2NMakFWSUptVzlRUi9nVS9ENnlNbkVoWCs2OFFQRjZR?= =?utf-8?Q?BkOxSXNmlrKUTrgQ=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e062490-d751-4796-34f7-08df23fb1b65 X-MS-Exchange-CrossTenant-AuthSource: DBBPR08MB5929.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2026 22:42:31.4767 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AqfSRWrv4ptKgS6dLQVfo1awFBS5PeLErCWBw5MEgj8PCCQteflIla1y+ItSdlU4WOPSxP2mUDiaidMqZ08M60aKQ0b9aSXJ0JddVT4/FpI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7987 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v7 2/2] selftests: ve: introduce vtty pair teardown stress test X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/7/26 01:25, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: > - [Medium] selftests/ve: kmsg_check() fails on any unrelated kernel warning or log overrun > - [Low] selftests/ve: veid_in_use() relies on ENOKEY from an ioctl key marked unused > - [Low] selftests/ve: 30s default run has little margin under the 45s runner timeout > -- > > commit cfcd5cbc2bcb13ed42052dd5ac26511475fe149f > Author: Eva Kurchatova > > selftests: ve: introduce vtty pair teardown stress test > > This adds ve_vtty_stress, a selftest that opens and closes a vtty pair from > the master end (vzctl ioctl) and the slave end (inside a VE) at the same > time. It also scans /dev/kmsg for warnings and splats while the test runs. > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-144771 > >> diff --git a/tools/testing/selftests/ve/Makefile b/tools/testing/selftests/ve/Makefile >> --- a/tools/testing/selftests/ve/Makefile >> +++ b/tools/testing/selftests/ve/Makefile > [ ... ] > >> TEST_GEN_PROGS += ve_vtty_stress > [Severity: Low] > The ve selftest directory has no settings file, so the kselftest runner's > default per-test timeout applies. I believe that default is 45 seconds, > but I have not checked it in this tree. > > The test runs for 30 seconds by default. > > After that it blocks reading the child's count and then runs destroy_ve(), > which may retry for about a second. Setup also happens before the run. > > Is there enough margin on a slow or loaded host? A timeout kill would be > reported as a failure that has nothing to do with vtty. > > A larger VE_VTTY_SECS or argv[1] value would exceed the default timeout > unless the runner is configured otherwise. The commit message says the > default stays "under the timeout of the suite". Could a settings file be > added to back that up? Yes, the test run time is 30 seconds, which gives enough room to shut down before the 45 second timeout, and I am not sure why would we need a settings file to extend that. Whenever this test is invoked with altered duration, it is expected to be ran manually for bisecting purposes, etc. >> diff --git a/tools/testing/selftests/ve/ve_vtty_stress.c b/tools/testing/selftests/ve/ve_vtty_stress.c >> new file mode 100644 >> --- /dev/null >> +++ b/tools/testing/selftests/ve/ve_vtty_stress.c > [ ... ] > >> +/* Any key but the tty one makes ve_configure() look a running VE up */ >> +static bool veid_in_use(int ctl_fd, unsigned int veid) >> +{ >> + struct vzctl_ve_configure c = { >> + .veid = veid, >> + .key = VE_CONFIGURE_OS_RELEASE, >> + }; >> + >> + return ioctl(ctl_fd, VZCTL_VE_CONFIGURE, &c) < 0 && errno == ENOKEY; >> +} > [Severity: Low] > VE_CONFIGURE_OS_RELEASE is defined as "2 /* unused */" in > include/uapi/linux/vzcalluser.h. In kernel/ve/vecalls.c, ve_configure() > behaves like this: > > if (key == VE_CONFIGURE_OPEN_TTY) > return vtty_open_master(veid, val); > > ve = get_ve_by_id(veid); > if (!ve) > return -EINVAL; > > put_ve(ve); > return err; /* err is -ENOKEY */ > > So veid_in_use() treats ENOKEY as "a running VE holds this veid". Is it > safe to depend on the return code of a key that is documented as unused? > > If that key is later rejected earlier, for example with -ENOTTY or -EINVAL, > veid_in_use() will always return false. The only guard against taking over > a running container's vtty pair would then disappear without any notice. > > Also, a VE that has ve.veid set but is not started is not in ve_idr, so the > probe cannot see it. The commit message only mentions "one started later" > as the case that is not seen. > > [ ... ] I would like to hear Konstantin Khorenko opinion, as I am not sure about this ioctl() API stability or why it would be marked as unused. Either this patch un-obsoletes that call, or a dedicated ioctl() for checking VEID state should be implemented. >> +static int kmsg_check(int fd) >> +{ >> + /* How a warning, a splat or a sanitizer report starts in a record */ >> + static const char *const reports[] = { >> + "WARNING: ", "Oops", ";BUG", "kernel BUG at", "UBSAN: ", >> + "soft lockup - ", "general protection fault", "INFO: task ", >> + "rcu: INFO: ", >> + }; > [ ... ] > >> + for (;;) { >> + r = read(fd, buf, sizeof(buf) - 1); >> + if (r < 0) { >> + /* The ring wrapped since the last read, records are gone */ >> + if (errno == EPIPE) { >> + ksft_print_msg("kernel log overrun, records lost\n"); >> + found++; >> + continue; >> + } > [ ... ] > >> + for (i = 0; i < ARRAY_SIZE(reports); i++) { >> + if (!strstr(buf, reports[i])) >> + continue; >> + ksft_print_msg("kernel log: %s", buf); >> + found++; >> + break; >> + } >> + } >> + return found; >> +} > [Severity: Medium] > Only the "vtty" checks in kmsg_check() are tied to vtty. The reports[] > patterns are matched with strstr() anywhere in a record. kmsg_open() seeks > to the end of /dev/kmsg, so every record from any subsystem is read for the > whole run. > > Can a warning or hung-task report from an unrelated subsystem, or from a > test running at the same time on a shared CI host, fail this test even when > the vtty code is correct? > > The EPIPE branch counts a ring overrun as a complaint. If other log traffic > overruns the ring, does the verdict then depend on host log volume instead > of on vtty behaviour? > > The log is drained only about once per second from the master loop. The > final message "kernel complained %d time(s)" does not say that the cause > may be unrelated to vtty. > > The commit message accepts the overrun rule deliberately. Could the > matching be narrowed, or the failure message made to say that the report > may be unrelated? The test intentionally considers any symptom of a buggy kernel a problem, since memory corruption in the original issue can surface in various ways. Sure, this can report a failure due to some unrelated kernel bug, but that would be still a kernel bug that will be investigated and fixed. An overrun of the kernel kmsg ring during 1-second interval is an enormous amount of messages that can't appear under normal circumstances. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel