From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id D61868017D for ; Mon, 16 Nov 2026 16:54:17 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGGqx2V028674; Mon, 16 Nov 2026 19:53:00 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGGqx2V028674 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="XwpG/IMB" Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGGqvJ4028664 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 19:52:58 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGGqvJ4028664 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2e942b1cc86so33161685ad.1 for ; Mon, 16 Nov 2026 08:52:58 -0800 (PST) X-Gm-Message-State: APuU4Z8N4SeE51mWxueiqJXZC6nfI6c59OobnNGHLiRAqkxyfXy8TjW+ Iw92bZbi5YTL2UkV9aczUKu7zxB4GG4nzeWUuERfjam8bxeByiu7x5lwLeE4JpuMkxPZLxoFgBL TJKRPUlbA6tcTQ83pGRcqPnV18Q4KPofZnqolNakeZz0ylls1NKvJYQ== X-Gm-Gg: AZFdTZdR0roYq6ojssWeKv4ARMCEy2vPhy5LOYUraH8DRzLDD3eoz+foyOwDJCV5NMh JunjjlkujTjIgN65cSs6WxVADkw1oYnbHuFgS4JCei7CmiMeQTAS11fsl8d9AxnQwzM8ap6XQ06 nZr38HjvfvdPm2iWxpfcjilrzJgZvd3FW5uQ6Wt/wF0DE8XhG+93YvH6yJlusDKJ7ERBg1w8HkP IqzO/R0kvP4QsROWVCSQKjJncWnGguGeXxNEnB3u6aWtFCz80X12Pjj5kx47NKgAqfTT5/Jchnl D2oM/RmqJCEm7D5dZMFRT0c0iStr3x1a9fk1FwSAOa46I4pXwXYDOS4P3O0FDsk7NgcQCw2gswf hFKgONR+u3bfEanl2FvbaoGNIjguff4E6xGGsUSnxiS2MlYso7b++dP9TSHIW5XuaLCXvY3ievx ljTKrhmdjp2sg3F8wpwSd9kosHh5y2Prjd X-Received: by 2002:a17:903:22d1:b0:2ed:2cfc:2064 with SMTP id d9443c01a7336-2ee0dd2444fmr91855855ad.46.1794847976566; Mon, 16 Nov 2026 08:52:56 -0800 (PST) X-Received: by 2002:a17:903:22d1:b0:2ed:2cfc:2064 with SMTP id d9443c01a7336-2ee0dd2444fmr91855645ad.46.1794847975956; Mon, 16 Nov 2026 08:52:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1794847975; cv=pass; d=google.com; s=arc-20260327; b=Kp1z5Y4Or2U6JgUS8KQWc0gFxYnYWtWcPX1iNEDlNZVFWhp2BQzY5jJGYYInxLyImu 1rrSDeovcAPuyVhC7cECP2i+nHkjpj8idhzkOx1yfMNABJA6obEKERsPcVShjg9GHlP3 eeaBwU7RhCmwlF84lpMT1yh+kfXi7KOQIvGFRFbJtmCfwYdbpozwph4lgC1tABWT3EhF qvAroRYMF3CXBkoLcCmIhlxvIlRJcr+WL2qpjqAadmoHsEFWEy0L5PKLNAR5cYjfBo/A RGoBUgX1t3txyl495JKVY0aeX+VZcgvJOAK2udeEL3Jn9HYZPCuA7kCFb42oW6F6N2fx CQ1A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=UoK4tyzJA8dCSu5vVYhwJ+S55L4p/Ye9kSXMvbx8gnI=; fh=91b2/9q/cefKEu0mVukf/qWpRlVAgc1JV6Sy7+brjsI=; b=nHZl8/GA7QMD+1TkzJE6/9oc0rKxZtsdAQrmxCSDxMnSiAwt/eN63xBzzj5qDgDWgw IRm4UTaDK4DRc8b1Yyvg+T4/qjy+xO1nvTYYduqam+/B6zM7D97mDFK0OqP3qA00c65I ITkhRevQLI2+UVZ+jJWeiGm2NRTZAcinWdB9XtithyLteyR3erifUfpk+XAeN4y8kwdD yEdvV0pRczVIx+grMoDPVtvKNDk4gjQeLDm/dVON3YHFNT24cayAONoOF/GqROAobDuh 3gLDbyW5UY0/xSArz3LugRG/+DpMwE7v7eukkzCz8TLy25DeFejQ9j7G8VKtpr/zt3eY Mh2w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b="XwpG/IMB"; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazlp170100001.outbound.protection.outlook.com. [2a01:111:f403:c201::1]) by mx.google.com with ESMTPS id d9443c01a7336-2efd7ca2fdbsi8815165ad.84.2026.11.16.08.52.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 08:52:55 -0800 (PST) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) client-ip=2a01:111:f403:c201::1; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b="XwpG/IMB"; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dnAOeraezlFhrptfOLlIUqUdj4P/8vOFltu/Oe+IbCnTVsPRuXjmsKRWX94l3eYdC+GSSrcUsJhsH5epaiYu4sqA1iTyZ4NDPBHIq2ncuFKNgPK83Mv9SsWe/0Y7WWY9VIKhVrp9FhHGp1B4tHTKB/JDqDKx7BQvT7oMjZUD5RECYISkl8/noGsEmhQExuyWRguKAtHr5ILpK09tjBl+RZinUXqu06R46xS9J4t38aHqAGML4ljP8LzfqiMR4Gih+n/bHul+m226EqaDRZNn4Q1d3DYHeLlVQxd+EVk0YuSSKwMtMzlLKoEiP0pVfl3iKe/4c+I2CWFfPzN3l2JLuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UoK4tyzJA8dCSu5vVYhwJ+S55L4p/Ye9kSXMvbx8gnI=; b=QEZarHVLuUdd++u4cutr7R9SmiIflZXUkshO3oe+brUjjGvQeciNys0PtQb+eBpvtI/S5eaY1p26DDxIGxc0DOry2dn64esr6YQJSASp7HSU4oQo7vA2R/OoWlilZ/gpuLdDifCOv8CkFNnP2v03cqjEtxU7/DHG+qPvg4PNP26mTBb5l1OOQ6jXjqm6FrW1315757VaXMSJOAfB9YRyXbBwe7B4mGpCLvxQgwY7hmBa9XiDJF8Y1fA2cVop2gDba5xUznHxKLcAlenDphCaHMn7467LdDstcny8i28wmPLKM+boSywJ1uyFsBsJM2oikI2qcOWPcVTBe+z7laVcLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UoK4tyzJA8dCSu5vVYhwJ+S55L4p/Ye9kSXMvbx8gnI=; b=XwpG/IMBtkWewRM0eSESMl+WFjQbSMrjZi9IqR5DnsrCiYTQ4e19ro1hP42XOBhz5jc47LkJaEq9tBwSScK38ZYdfgvuUK6guT0l9w1UAvdwtPmc/C4YG1kSUVxNCJm18We2xQ0woG5RCU46R7hKDT2XabZsSjYG3ev78AY5YFPY67fWI0wWZIJUC0+u1PHzykOoYEg25MvzWzHa5pNpiZi6I5Avj4wH0fdF0RTfQ/VvSMC8zVVIAruLHZbIryIsml1BWa/sT1m85QMNyhvPFvcJfdxm27afE3O8XSITkeR2TEII7SZPDd1Rubs9CInp7YtDqAUHmivMKCPh5SKwGQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) by GV1PR08MB9915.eurprd08.prod.outlook.com (2603:10a6:150:3d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.10; Mon, 16 Nov 2026 16:52:50 +0000 Received: from MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa]) by MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa%3]) with mapi id 15.21.0615.013; Mon, 16 Nov 2026 16:52:50 +0000 Message-ID: <3e303ceb-691f-48e3-a739-628585c150b4@virtuozzo.com> Date: Mon, 16 Nov 2026 17:52:49 +0100 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, vasileios.almpanis@virtuozzo.com, ptikhomirov@virtuozzo.com, Konstantin Khorenko References: <20261116-ovl-use-orig-ve-v6-0-7cfb41c8c973@virtuozzo.com> <20261116-ovl-use-orig-ve-v6-5-7cfb41c8c973@virtuozzo.com> <010701a1e5284447-b31d6973-b049-4d23-a230-4a76e40a14be-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Vladimir Riabchun In-Reply-To: <010701a1e5284447-b31d6973-b049-4d23-a230-4a76e40a14be-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR4P281CA0299.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:e7::10) To MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI7PR08MB201474:EE_|GV1PR08MB9915:EE_ X-MS-Office365-Filtering-Correlation-Id: a3cf827f-ebcf-4a58-4c3b-08df44020c94 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|23010399003|366016|18002099003|22082099003|261009223027099003|3023799007|56012099006|5023799004|4143699003|10067099003|261022075727099003|261102123227099003|261028144727099003|261026140227099003|261022105027099003|261021121427099003|261026121527099003; X-Microsoft-Antispam-Message-Info: ZejNwRdhiQBCoKZxUkI/C0AyNsJmt0IxDv0QaBNgj620qFp/lnO0sMN5/mX85rN2KaGGqePEfZqIT08L/LHP2SALmlpuZfxwNf64xhSwJfpWc9eTU5C+KNR2AIUboRdDObC84iW50blwWgBwwq3AtUVT0fDKWs+x0p9Cy/XIc0mWiqQUm2xmcTXBRzGjul/K19lIkqH4ZVqSaf3cH5932B1drHr/9iiPPNGZsqQt+L89+FRHInTTPSsOZvF7iGmt57KOF0YYbk0RihotBAvZIriRTrfq52FEGo7oZCw3KH3dfO1eehkL7UFT6JUIRp6sQ9DqXtlfh4hDabtL66v3isdmZ9rn73WfGz5/7CBRoDYkN5ln2lYObyeeXj6f60oAiq0NTKP6yY5ABaMsarhvxFjwLCNaShxgNePk5Zfbs9VUexbEQtHD9iJ7Q5UZfD8HvNtgAYdi/qAcNK1s8Oe6XBp+q1mCVN8/MWumLgly5qLAUs/Tco6OydHumabUzS/Ddwey3gaA7Ox6tGpUE/+SkDbrFSH7j9AXT8dinXwP9Sm8hFUYXuAbY1YnNt33zqfWvpsQjte0VCHI8AytreEAJDcMnXyHV4GhlNB3/rpMrMCxZ5tWTttlGDikG48X72hF X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MI7PR08MB201474.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(23010399003)(366016)(18002099003)(22082099003)(261009223027099003)(3023799007)(56012099006)(5023799004)(4143699003)(10067099003)(261022075727099003)(261102123227099003)(261028144727099003)(261026140227099003)(261022105027099003)(261021121427099003)(261026121527099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWJsOWZ6SFordlhKaWZpUW9kZnI5bmZNWnNDb25YOGpNYjA2cGNzcnpLdVA4?= =?utf-8?B?UG9NZmFFUGh0WGYvWTlobE9EYXJGV1gvY3pMQktqalVDSFdzd2taeEJIaWd4?= =?utf-8?B?VFpqZURZUFh6dG9mWjZrMWtVTW1kd1NLWWhsNGZDeGZQcjFxbzh1ZVBRelpa?= =?utf-8?B?K0lFUzE1Q3krZFNWQ1RwSndhbm5lSjE5bWFpZ3VNaU56UE9HMmFlU3MzbnVt?= =?utf-8?B?b0ptdG93RjY4MHE0NkxFK01MMXdZRFQ4ZXNuekw0cEdldVhPUEd5bVV3cTBt?= =?utf-8?B?d29rUHdWclNyaUx2UGtVZGdYSWt4ZTRaaDVMdzFhOUthUUFFMm9nOUpWdG5p?= =?utf-8?B?MGQvY2ZrSmROOWxoMkZFMk5YWFUwb09hK2N4dWlxNks3ZTNFRThCQ1cwZ2hu?= =?utf-8?B?djF6ZzlaL2JERUhicG4vRDFlbTI0Z1FaMjNHRjVUUVVwR0dwZ3dWNHZNNDIz?= =?utf-8?B?VHNJS0VQSGhmUXhrNUdCMGZNUlpwSVVFdFd1OUZFM2E2VWtRbmsrSzhNTm0v?= =?utf-8?B?WDBwMW1FZURvL0RUOUFxZlRFNkhKSzEyNUdwc1RldnJreUo3VEp2Wmhnc1FO?= =?utf-8?B?TjhTRFEzQVJ6VndDOTQrNVpSMklubCs3ejFEcnR0NEl2Y29tdHg3NjRmMlJH?= =?utf-8?B?RnpSZmZKQ0lCZzJ3TzNlazljUXExSTNRNGRGdzdiSXhKa2hBZEc2QzI2Zm1k?= =?utf-8?B?ZnJpM1dSK2tveFJ0RjEvQWFySGZtYmFNY2hPOERRZWxNcmdoQ3FrNHkwT1Uz?= =?utf-8?B?SUtaZHpIK3VFZUpySlpwSDdWN1JUL2tZQUcrbnJOVUZ6Rk9CV3VhSkJlZk50?= =?utf-8?B?TTRSMXMrZDAzcEVnNzBrNWNoNjN1SXhzR09qVzBHZUVBVE1qWW95SWM5bHE3?= =?utf-8?B?RmIzVE5yZEQzcFFVN3VlQ2w5bG9SbHJubVJDMktja2lEVk5OSVcrTEJNOWFm?= =?utf-8?B?b0Y4c1dLSXZwaVl1Wjl5bnFNRHljUXdwaUNTN3V2djIvb0VCdGNleU5RUldo?= =?utf-8?B?OUJnQTUrMFdJMlBlTU5nWk1nejRLcUFtVkl0NXdzTHRyUjlWMmRuNm56eGw4?= =?utf-8?B?NlBVSitUdmwvY1dwYyt4NXk3dm14UFhSSVl1cXhoY2FwVk5VRDRlMFhhUXVP?= =?utf-8?B?RjNDQ3kvemhKRkpwNTROdmd1YWhRVnpMOURBbDVtVkZsOE4zUTRYQk1oU3Zr?= =?utf-8?B?U2svakZuWjFFVEpydVh1alRoenFjVWtkTkhHRmV4dlh5M1JJQlh5ZmNJVkxk?= =?utf-8?B?UjZPbDdBcyt1UTJVRnM0aTQ1VzFsVTJJYlBtWGV4TGdTNEVuV3EzZ0ZKOTk1?= =?utf-8?B?S3BzOE5xRGVIbHdzZC9DZFRDM1NVQldwMGtsSSsxcU5sUnQ4QWhtUEM3ZC9O?= =?utf-8?B?S3psMWlYc1RHaHFPbVZQbjNBSFhxOERNM1FUTWg5SE1uU0pVUVBYNVZOTkda?= =?utf-8?B?MjFHMHRXdC82am1mMk4vNG1HUE9DajlPQVNRUE5ibXk4Sk4yZ3piMCsxTjJG?= =?utf-8?B?UzBuaTIwTFBwN2t6eEFIcEN4T1BJQ242RWUzZEtQT21HSjc5MkNBVTh6cE80?= =?utf-8?B?QWdNbFBEWjJlOHdVbGhsWDZFdndCNDE1NkJkTHMzZDBEUWd3d0xrc1NUSmk3?= =?utf-8?B?WURiZ0ZrZDhDSVpuVmJiZURkQjUraVFsamJQQ1YzN3c3K1RRVHpCMkw5WlN1?= =?utf-8?B?NXVqV3ROY2VKLysyV013ejBOSHZWbm5yaXB2T1BHaTRNQXFkZTB4WmI4N2VL?= =?utf-8?B?YWxkZzFZaVYzemtHZ2Z0RFhONXNvUms2SXEvTW5QYnM3dngyOHRJaXJtWUVv?= =?utf-8?B?d3J4Y1lsOFowQUVUTUZOd24xS1hxdk9OT0x2NG4zOU1xaXp1NHE1OXRMOVY5?= =?utf-8?B?RnF1SFdZRTJoOFRiR2Jwc0J3MDN4Q0JHa2o4bFRvbmdKb1pOMFp0ZUl4eWJy?= =?utf-8?B?SkVWUHVQWXlTb0U2bXRZNncvKzRzUWFxVnVTb3dmM1oyNmxTNHE5T3p5SDRx?= =?utf-8?B?OUhKK3kyeXE0aGNHRUNRZ2l0ajUwK2JqZ3dISjJ1bTJFSVhvanYyTHZkL0Nq?= =?utf-8?B?eTdJTW5XNWc0ZDdXOEM1bWF2Y3hjdmNhclhJUzVFT1MvZS82TkJlTTBBQzZR?= =?utf-8?B?cGtkdDRBc0FPVHJGWE51MnkzQ3R1Sys4QmNrZDF1NzQ4S0M3NzRHY3UxNzQr?= =?utf-8?B?UTF2L1pramF0NzREb3RzeHhRd0k2ekF4Nit0MzZFUkdpbFA5L2tzZjFrdkNi?= =?utf-8?B?Zkh3TnFlUTZnYTRZMndYNmRBSklndE5CVi84dWRXYlRaTld2ajFLZ3FwYkdB?= =?utf-8?B?ZVN4QUZHRXcrZWVGZ1RwdWZURjlkUmRtUXVnbkV6ZHlwTkdITXBpQllTZ0N5?= =?utf-8?Q?8mhqIvvDUXR8r45I=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3cf827f-ebcf-4a58-4c3b-08df44020c94 X-MS-Exchange-CrossTenant-AuthSource: MI7PR08MB201474.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2026 16:52:50.2441 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pgZnzd65rEkk7NXyvc4lwc7sJtV/bUgpzgrpRBdlnkr6SLi70i3SdorQMmluYkIT2gQlFLQ3Nh2zuIUFRu6F0Fu+g3kqT8JpUrqCHPfptjQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB9915 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v6 5/5] ve/overlayfs: Override VE together with creds X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 11/16/26 17:19, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 4 potential > issues to consider: > - [Medium] ovl: ovl_copyfile() leaks real_in/real_out refs when override > fails > - [Medium] ve/overlayfs: backing-file I/O switches creds without the > matching VE override > - [Low] ovl: ovl_lower_positive() returns false when > ovl_override_creds() fails > - [Low] ovl: ovl_nlink_end() silently skips index cleanup on override > failure > -- > > commit 9665af403c75ade64577a4c77c18a22fb272209d > Author: Vladimir Riabchun > > ve/overlayfs: Override VE together with creds > > ovl_override_creds() now returns an error and fills a struct ovl_creds_desc holding both the old cred and the old VE. ovl_revert_creds() restores both. Every caller is converted, so overlayfs switches the VE together with the creator creds. Access to an overlayfs created in a different CT is rejected with -EPERM. > >> diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c >> index 2531433f47bf..464699e51695 100644 >> --- a/fs/overlayfs/file.c >> +++ b/fs/overlayfs/file.c > > [ ... ] > >> @@ -520,14 +527,19 @@ static loff_t ovl_copyfile(struct file *file_in, loff_t pos_in, >> * verify read access with the source mounter creds. >> */ >> if (unlikely(inode_in->i_sb != inode_out->i_sb)) { >> - old_cred = ovl_override_creds(inode_in->i_sb); >> + ret = ovl_override_creds(inode_in->i_sb, &old_cred); >> + if (ret) >> + goto out_unlock; >> ret = rw_verify_area(READ, fd_file(real_in), &pos_in, len); >> - revert_creds(old_cred); >> + ovl_revert_creds(&old_cred); >> if (unlikely(ret)) >> goto out_unlock; >> } > > [Severity: Medium] > Does this new error exit leak the real_in and real_out file references? > > Both were taken by ovl_real_fdget() earlier in ovl_copyfile(), but out_unlock only calls inode_unlock(inode_out), so fdput() is never reached. Before this patch the override could not fail, so the leak is a regression. A task in one CT doing copy_file_range() between its own overlayfs and one created by another CT gets -EPERM from override_VE() and leaks both files on every attempt. The second ovl_override_creds() failure below already uses skip_switch, which reaches the fdput() calls. > There is a leak and this is a rebase bug. https://github.com/torvalds/linux/commit/a1e0eb8f55cfe09bb31a202a388babc411292656 We don't have with_ovl_creds helper. I'll send a fix for this in v7. > [ ... ] > >> diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c >> index efa2a072aa69..edc11a7b27ee 100644 >> --- a/fs/overlayfs/namei.c >> +++ b/fs/overlayfs/namei.c > > [ ... ] > >> @@ -1426,7 +1436,10 @@ bool ovl_lower_positive(struct dentry *dentry) >> if (!ovl_dentry_upper(dentry)) >> return true; >> >> - old_cred = ovl_override_creds(dentry->d_sb); >> + /* Ugh, hard - we can't pass an error from here. */ >> + if (ovl_override_creds(dentry->d_sb, &old_cred)) >> + return false; >> + > > [Severity: Low] > Is false the safe answer when the override fails? > > Returning false means "no lower entry exists", so ovl_do_remove() would choose ovl_remove_upper() instead of ovl_remove_and_whiteout(), and ovl_rename() would skip RENAME_WHITEOUT. A lower file could then reappear after unlink. In practice the later override calls in the same operation fail the same way, but correctness then depends on call ordering. > > The lookup-error branch of this function already assumes "something is there" and sets positive = true. Would returning true here be consistent with that? > > [ ... ] > >> diff --git a/fs/overlayfs/util.c b/fs/overlayfs/util.c >> index 817563215001..273b2e2e17eb 100644 >> --- a/fs/overlayfs/util.c >> +++ b/fs/overlayfs/util.c >> @@ -63,11 +63,38 @@ struct dentry *ovl_workdir(struct dentry *dentry) >> return ofs->workdir; >> } >> >> -const struct cred *ovl_override_creds(struct super_block *sb) >> +/* On error no revert is needed. */ >> +int ovl_override_creds(struct super_block *sb, struct ovl_creds_desc *desc) >> { >> struct ovl_fs *ofs = OVL_FS(sb); >> >> - return override_creds(ofs->creator_cred); >> + /* Cleanup after previous users */ >> + *desc = (struct ovl_creds_desc) {}; >> + >> + if (ve_is_super(ofs->creator_ve) && !ve_is_super(get_exec_env())) { >> + /* Host overlayfs used from a CT: host creds work there. */ >> + desc->ve = NULL; >> + desc->ve_overridden = false; >> + } else { >> + desc->ve = override_ve(ofs->creator_ve); >> + if (IS_ERR(desc->ve)) >> + return PTR_ERR(desc->ve); >> + desc->ve_overridden = true; >> + } >> + >> + desc->cred = override_creds(ofs->creator_cred); >> + return 0; >> +} > > [Severity: Medium] > As reported by Pavel Tikhomirov on v2 [1], the conversion is incomplete. Are the users of ovl_creds() still left with the cred/VE mismatch this patch describes? Yes. https://virtuozzo.atlassian.net/browse/VSTOR-155347 > > ovl_read_iter(), ovl_write_iter(), ovl_splice_read(), ovl_splice_write() and ovl_mmap() set backing_file_ctx.cred = ovl_creds(sb). The helpers in fs/backing-file.c then call only override_creds(ctx->cred), with no override_ve(). ve_capable() uses current->overrided_ve ?: get_exec_env(), so on these paths the creator creds are still checked against the caller's VE. A host task reading a file on a CT overlayfs is one such case. Cross-CT access is also not rejected there with -EPERM, unlike the paths converted here. The commit message suggests all users of the old cred are covered, which is not the case. > >> + >> +/* Accepts desc from a failed ovl_override_creds and does nothing. */ >> +void ovl_revert_creds(struct ovl_creds_desc *old_creds) >> +{ >> + if (IS_ERR(old_creds->ve)) >> + return; >> + >> + revert_creds(old_creds->cred); >> + if (old_creds->ve_overridden) >> + revert_ve(old_creds->ve); >> } > > [ ... ] > >> @@ -1228,11 +1258,15 @@ void ovl_nlink_end(struct dentry *dentry) >> ovl_drop_write(dentry); >> >> if (ovl_test_flag(OVL_INDEX, inode) && inode->i_nlink == 0) { >> - const struct cred *old_cred; >> + struct ovl_creds_desc old_cred; >> + int err; >> >> - old_cred = ovl_override_creds(dentry->d_sb); >> - ovl_cleanup_index(dentry); >> - revert_creds(old_cred); >> + err = ovl_override_creds(dentry->d_sb, &old_cred); >> + if (err) >> + pr_err("%s: skipping ovl_cleanup_index.\n", __func__); >> + else >> + ovl_cleanup_index(dentry); >> + ovl_revert_creds(&old_cred); >> } > > [Severity: Low] > Is it acceptable to silently skip ovl_cleanup_index() here? > > ovl_nlink_end() is void and runs after the upper unlink or rename has already succeeded. If the override fails, an orphan index entry is left behind with i_nlink at 0, and only a pr_err() records it. The old code could not fail at this point. ovl_nlink_start() would normally have failed first for the same task, sb and VE, so this looks mostly unreachable. But it is an error path that now leaves stale state. Nothing we can do here. Everything is bad already. And we shouldn't be able to get there anyway. > > [1] https://lore.kernel.org/r/179318868950.3559520.6473416824609223980.b4-review@b4 > -- Best regards, Riabchun Vladimir Linux Kernel Developer, Virtuozzo _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel