From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 65B1C8017D for ; Thu, 29 Oct 2026 14:00:47 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69TDxSDG000848; Thu, 29 Oct 2026 16:59:29 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69TDxSDG000848 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="Wb8GuKUQ" Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69TDxR1B000844 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 29 Oct 2026 16:59:27 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69TDxR1B000844 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-8b0cfe694c3so35030827b3.2 for ; Thu, 29 Oct 2026 06:59:27 -0700 (PDT) X-Gm-Message-State: AFq9FYIgr2JyOTUj4LLVGDKuwHJQHGVqWaiS4zPPOe1GLsTqTy0VltqP seNKgtPJmRPX0oB1JK8nraOcjjzlVyfzvmOnaAs1372rLd4AbkPD/m3G7JlrDme8Z4fpdykGyzX dRD146SJ+lhkMsKk3hiHFDMHDAukxEWk8o+0iX3fRISYPLZ6lH7A0eg== X-Gm-Gg: AYBFou1Haslw+OKfJAHvTxeYClIuOpat2GFQ1pXSnHNLnxj180cPl/QI/ioPtDRN0qu veg82HHINuR6fOLzNCIZZpOagpLhPWcXILDIM6rBslMfmQHVmhYMfMTJNhSSz/HGwA5u6/hpGZa Qi4brAmAuVvky1VlQSNZgqcO0kgqrHbRXSyhn9O9FIRVDWTyL5V+ZRyfTGWuProTYT9LpBqPgur ZM+AhCieKCCcSjgn7n7OnomeOML6ISf8gOBZdLgxGy7ajqobGmjZz4VSSBH6sIXbkDCEKEi1AK4 guCd4037+5FX0f6AILR0+tfYPb3QrxkUNsj1ShxMGYsgaIxk5MuIhGzIoWWNzttLepCnlt0AKR0 LB9Z4OXw/ovTwoCPwQnNStD/QSwo0KzFqXMfbR72mm/NXFYxWz/catqUqdefg9xz3lSZDbHAbie tehY3jH8mRb9xKee6vm1CC2C6Q61B/mi0= X-Received: by 2002:a53:c712:0:b0:675:47ba:21a4 with SMTP id 956f58d0204a3-67a7bd3e821mr3699307d50.47.1793282366859; Thu, 29 Oct 2026 06:59:26 -0700 (PDT) X-Received: by 2002:a53:c712:0:b0:675:47ba:21a4 with SMTP id 956f58d0204a3-67a7bd3e821mr3699295d50.47.1793282366312; Thu, 29 Oct 2026 06:59:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1793282366; cv=pass; d=google.com; s=arc-20260327; b=UFtx+8C1UUoxszwXleTWc1QHAuXKP1X7Joavh1u5LZTU40nYP9oZQIwFInxm0RrnBL hQHSLXUS0QZYxSUMyopV68bZM+8cQ8rgjllOrc78bSvOv54iWfi4vbpKuVPMoB0mdsRT cMiqUk3zEeli/ejt1TGyxOw1FDqQHAiHEq4CulpyW6L0zXa1ICcD+GscPJDXzj2sdp0H CnzgVqAanTkdlnvYofCxHt5786dbWrNPVftaitTX03arZ2OiogRTD4X7muoB8eGQYaK+ TuNQbLx9ut+2FjorU51bu2ABaBz0IDdrZb8mBHhYvM3O1KsdMt+Ez1VmWvyCL+Lm/H9E lsag== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=P5K+VAFRl3hlzFkcpUSZoPLDtmwmFfO4fgbpn3SFKmc=; fh=IlzoM7xapMIT9vjIu8V1YxnmOSGAT8hvLuDm+hjUGIo=; b=oLJS1sSrZ6L60A7Tb+GwO5P3M0CPxBffrYCOFFozvr0SzmTOhSv+avhLVKPG/s/Uz+ IT184FmhtDBIXW9UbrhUbxTGwe9Y2PpJfN/JM6r3HHhFt0JyCQsBeRIWAPjT3K/+6nE4 R4ij55njDX9CkkNhJJcvcngRvOMcMil95eONhRZ0vYNph1I0Dp1hWBH9oTVkX7Y2EUNQ udsFV/CHeXzTHzqmdvSQ3ehgypx2wJIW7NlTSvaGHaOm4BWMqji8FK85Rd++VBAyJky7 kJd9FvdEt486uj7FF+jLyyWHhdj5wukSOmWtMTCMF+7xMn4thQu0e3QBgLw+GPaPXptR 43bg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=Wb8GuKUQ; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazlp170100001.outbound.protection.outlook.com. [2a01:111:f403:c201::1]) by mx.google.com with ESMTPS id 956f58d0204a3-67a7a0a5e4fsi4673861d50.135.2026.10.29.06.59.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2026 06:59:26 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) client-ip=2a01:111:f403:c201::1; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=Wb8GuKUQ; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lA9pXEClDwsG6sYjuVaRuBRrUAkp5VPJVZaq6FQ8fUTpe7SL4cxFP7bNuXgBN4TI9DF4ji18BY8utLjw93x+JdZ5cQNLmBspCEXfTVB3W6+JUvU4Fbz+yzZMIi7wTV4/BTh2uLsvZbjQuH/RxZidpksSFkdKPSoyNLK7R9aAlEnivhMMJwC3Pt4CuMwK57R0tR4NyMvHC6vthO9cUGK40iqpwu+lBgv0mcl1/GozcnuwubDo7rsAuQwOxIu+QSzGib2Kq2WbU3e5PLnRzoIh9v4rS+lLV7hzbv6FTfxogn+GglfdA6/i4nvEvS0u42p4PMwHJ5Ymx8hylXlaer+aNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P5K+VAFRl3hlzFkcpUSZoPLDtmwmFfO4fgbpn3SFKmc=; b=heO9SL+M4Bd6wv3iTQppKPX8EAHRY+pDpYciDvDCLBUh8AxsHxY+LCh6MY9jk2y+NJib0oRzEIBX02xBSV0ugaIHthzuFELmRqjWY7tAya5uVmbENVsrRWPQtW7lhZaCPbF+B2WBNMpvcFIZrwHpgi9ku3XiOzF3pKFIeu6LjgOjgIF8qg0YcWYnkp6ERyDyJVCwxwNQ/WngiSGW9It+ortSyf/wzfKHc1v7Gp5NRJ17kms6l1n0Lrbfof6HMfAirmXGLBsmNkr3iNg/zQZWQ9TIr6vwqmzAhf8sdLWFgVSycmyBgUGDTLastnqBHApoNdMhASxTkxr77mHwX1rE+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P5K+VAFRl3hlzFkcpUSZoPLDtmwmFfO4fgbpn3SFKmc=; b=Wb8GuKUQjFEL4uI0zwy/idavWVs3sAAedw7hmqJfrIU/Fthxg3xq7zIGPcF0gypLo6a4zIad03dZcaZdsn9vqBRtm49jNF34WouyO4UQ4rHj7hL31wBdHqOyJTfIuKQeQnEoZCBJTNOka1RT0Dbfd/uqZBrztjKcfoztowR/7appUVnYB25ALIp57kRJSsIIojlHVTAwo6nuiqmxLzWZK9kbzUwhicYpoh5M1MgaPVg/ob2EKBLgJHeOLlcHoRp0d0Z29LtCOg74yhIHDklklMkLxs1cd0hwDBYWbsBgngiDmLO090qv9fdIYbOaTTZ1LFdKLBa4ioeuoSoIxRh1fw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) by DB9PR08MB7793.eurprd08.prod.outlook.com (2603:10a6:10:398::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Thu, 29 Oct 2026 13:59:21 +0000 Received: from VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a]) by VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a%6]) with mapi id 15.21.0546.017; Thu, 29 Oct 2026 13:59:21 +0000 Message-ID: <3e50af49-fc25-4582-a6ef-0cdb9fc3659c@virtuozzo.com> Date: Thu, 29 Oct 2026 14:59:20 +0100 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, andrey.zhadchenko@virtuozzo.com References: <20261029134822.3367197-1-alexander.ivanov@virtuozzo.com> <010701a187ef0e39-9ebdb65b-5f60-46e0-9a46-ae71a8f62bfa-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Alexander Ivanov In-Reply-To: <010701a187ef0e39-9ebdb65b-5f60-46e0-9a46-ae71a8f62bfa-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: ZR1PEPF000077BC.CHEP278.PROD.OUTLOOK.COM (2603:10a6:918::477) To VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10743:EE_|DB9PR08MB7793:EE_ X-MS-Office365-Filtering-Correlation-Id: 6dc92e26-a077-43a0-5e1c-08df35c4d519 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|23010399003|376014|261026140227099003|261022075727099003|56012099006|261022105027099003|261009223027099003|4143699003|261028144727099003|10067099003|261022113327099003|22082099003|261026121527099003|18002099003; X-Microsoft-Antispam-Message-Info: b/ZG/i1bm3tgDrp0ule2jCc3P2MR/JZXqH+JUY1WQiJpGgParlo3OVRsO2+TZ9Y4sPLf5tcklZNukKgXZieb6dhqwcORPNZlHUfj1TNJD9gobGmyJQANa3U0W2dCWi48dqtvIIiX231NHGue/a61gAhULMJIV3RdeRD1yJH3u/Z7STdNZjGlY8/n3HqUBfMNnr0GfVHl1rqHKMKqhpeWTKg7Zpq41R6PMTxTWDsk3pKJ4yymB9KOM9sedySVFNEGnOS21p6brWW8emW+2n5O9t3B1UZL8snNqKt7MCDs+K0xKiEotkfI0oksqKfytNMVD5KJahzA5uqm/I3UW2t/lvcLbaMIBnheusbzKC2MLabNGU/ixed4cPUwYlrN7vze/bu6AC0TQJxSGDtIpR+zL7gR4jcgMcCWvx8H3L9Cs7hpG42UTlI9LV3x3QmM59L5pPBt5QEcpQjJFKQADuMqUAFoE3LStOEoVbGTsWBXa2g+FHpe5o5eF0Fgx2XjmGBShK2DV94kG87LEK7B3U4zJ5RYB4Y63ML90dyg+tgZaz+iHAI1VOlcnzWRDIdSApnnW7ar+bNkI7OVtY0NAnfVLnWE5JzoGckAPvEihxV2D+fx+BQmBl7B2O5AYIS3Dd5l+CgJNzhF/zPhQplh1z+0JFX9jWS/sqHhwaAyvmnqtkg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10743.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(23010399003)(376014)(261026140227099003)(261022075727099003)(56012099006)(261022105027099003)(261009223027099003)(4143699003)(261028144727099003)(10067099003)(261022113327099003)(22082099003)(261026121527099003)(18002099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?andaTllhZUdZTmlsTnFOWFRWWUZjR1dPdFJuRXNKN2RwV1lrMVdieWxsWE9n?= =?utf-8?B?VUwxTHV4WDFJR01wVS9MQ2pKM1FNaU8vYUx4VzVyelRIbGNmMzRMdGxGd004?= =?utf-8?B?L0hiT1Y0bDNZMzdPd2FNNHU2NTlXU0d5Ui9mWWtTTVlCL0VyK1JHUkIxZWgz?= =?utf-8?B?MFFDSGJvdEIzbHQwWWdEQ2hxeHVncGQ2VEZiOWdUMDF1dDhBVXp1NnluOWJF?= =?utf-8?B?L0VldWF5Yy8xVTdXSklZaXpWUi94VjNicDlFMDl5NW5QMFZJV201WHdham1N?= =?utf-8?B?eXhHSXZpcDd2dmViVFdtN2NSWWRQQTllRkw4dG1nTE53ZVBhSTJDSEJ5N2lD?= =?utf-8?B?YS9xWk5PWnF6Ty9pNUFkckRqUjJBU0pjb2dCeDZnK2ZnY1lyc0F5bTFVRjg2?= =?utf-8?B?Y21CeDR3NjF6aDJOalhhNnJiOTE4TnN2KzZyQUd1WjVJMWhVNDBRcFY4WFht?= =?utf-8?B?TnlGUDBTZlRnVW1Jdzl6cWpTdE1DOFVZSzZWcnVpNTR5cm8rU0pkenBRbnZS?= =?utf-8?B?TStJVTNEWUNJL3A3MXVPcFlPK2VSMVk3dHp5TEYwRWo2S0hzRDErNEwwZ0Fj?= =?utf-8?B?bjVFMkw5OHdpdEFiUDVrMWZib2RkMVNXWmdOMGhVdy9HcGg4anZoMkJoYjlQ?= =?utf-8?B?NFBpWGhKeldCZE9rVTVNZ09zSTM4OE05OWg1UkJOL3JOL0t1VXRBMlhwbkdD?= =?utf-8?B?M1FNR3Jkak13S3Rha2Y2cTFjNEZCaSs5cjNGeVZ1Mnh4aGZXU1J6a3REbWNX?= =?utf-8?B?MVNGWlF4SHQ2Y3dtOXY0QVJlSStqWmo4SGE2N083V3IxY09pSjFmcTdyUVZE?= =?utf-8?B?M0VNOVE5bVduNXlZekhKb2RDL0pOak5kQVFqYlMxNENwVEVYVGYyT0xpVFpG?= =?utf-8?B?b25pamEza1VNZEp5MEF2MEhEbW9qL094cXBlRjZpQWUwNmt3ODFLNEZvTnZ5?= =?utf-8?B?emcvU2M5QUJQQjQxUisyMGtBSExmcTBDSTk3V0QyM1FJN2dIaE9Nc2dmdGJx?= =?utf-8?B?RzhJaWtTZk1lcU1ucHk0b0VTUTJYYjFkeXF6OWNzekYrRk1vRTdpV2Q4aEJN?= =?utf-8?B?M0l0TkExd3h0aWpTQ1hsUkhsWHQ5VkxlMTByTnRRdTdaZUkxT0JLSjdGdWZy?= =?utf-8?B?bzV5ZklJY2JpVnVNKzM4TklLb1R2emxwaFlxSWpLTVY0QTlPSmZFajlFWWNJ?= =?utf-8?B?ZS9qTTdHdWdNazNVKzJxWjl1QVF2eWo5eDlLOCtHN3dRY2cxYXVSdnp1cUVa?= =?utf-8?B?MkpUbFN2TElCSTQyMlpVVjhkeStadE0wVHFtMzNVSmVlT21Zdkg5TFo5aG50?= =?utf-8?B?bno3VlhFc0hoOXp2dUtLNTdaaFlpNnJSMTNEcm1wNVdJd2ZKOG5FclZ5VkNm?= =?utf-8?B?aFpsc3JGQnpzQ3ZndERmdWs3VEthWXYwM25ML1F1TmpuYnorTCtlcHEvUWpk?= =?utf-8?B?TWcwbDlRVlh2b1VwclhvOFpYM2VBWjhkQmdTOGRXS0ZKcUFuMUlTQ1FkZi9P?= =?utf-8?B?bS9vcXRybi9rRWJ5aHpjck1sSGZuWmtsL1ZqTGN0bVJscXQrVTFkR0hlTnlW?= =?utf-8?B?N1BRQ1NMQjZ3SHdvbDNTT1BOTTZ3MkM5N1FaN3ZsQXoxVHJaQ3lBOVFyUHdz?= =?utf-8?B?d3J0ZjRXSm9pV1J5UWwvNjA5Rmx0bkdtZlRSQVVKSVgvQ05MaVJBdXJYT2Z2?= =?utf-8?B?Rjd6S2hhcjEvMnN2QitLVmRnYUYrclFIb2U3QXFKOGx6ODEzemd5QjdqN1lS?= =?utf-8?B?OVYyVTJscm4yZE1sY293WDgvYkNqWWRaZFN1c3hmdURZV3Z3bTZYcGlrOEJp?= =?utf-8?B?RldMTXM0UzNGcG1MWUlBSWoxcWVhdkhOeWpCZXVYcUJjRUhNeEZMemNoeTk0?= =?utf-8?B?WGFnUjFUMzNSVFZ6dXFEUm9FbVhEdjRIVkJBV3JCL3hXbUtpbytwVFREa21J?= =?utf-8?B?aENaOTkrSjFKcFpUL2toRjdzZmJSd3cxRmNVUVNsTW4xaUhudFo4NFIrOTFS?= =?utf-8?B?cnBsa1U4cm1xb1YrbS9sallXN2NMUVdVbWNvRUoxRlVwdlkybjZnQjF2enhs?= =?utf-8?B?a2lKeGNISHRYMnJpd0s4OTkxenkrTERiTWxFQ01CUUVUb2lhZ1BxQTBrek1N?= =?utf-8?B?UVlDWVVWZjFrRi93U2kyWjAybGd0UXJacTVpcU10b2hqekFGdHhSNDNXZHdo?= =?utf-8?B?a3NwUThZbWdBYW5YQ2xHMWV0MFlRZmk4Vks5c0lycThNQ0RUVTdSNkxwMDBT?= =?utf-8?B?citSUTM0ZVR1Q1NRbjAwZUVzNGx0cmppMDA3by9Ybnp3d0hTQ2dEMkNmK0Yy?= =?utf-8?B?MVRoczg2MzBad1pXMEV0dFdORnJVU0NtYzQxQmpiMXNEY2NhWC9ETDhSNmQy?= =?utf-8?Q?WTKnxpXaENE35kqY=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6dc92e26-a077-43a0-5e1c-08df35c4d519 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10743.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2026 13:59:21.6269 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HG+0PKsDJwO8kpn7Sk9DwBE6DAtTGkWT6f6gpvHWkTVZtaz81GPUS7cmPbfzJxpRFkxj6NzjBqjhX5QTCG//Idq8VyGvDOPYQL7asmJciCk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7793 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2] drivers/vhost/blk: reject a head that is still in flight X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org >> @@ -457,6 +459,11 @@ static int vhost_blk_req_handle(struct vhost_virtqueue *vq, >> u8 status; >> >> req = &blk_vq->req[head]; >> + if (unlikely(req->inflight)) { >> + vhostblk_vq_err(blk, vq, "Guest reused in-flight head %d", head); >> + return -EBUSY; >> + } >> + > [Severity: Low] > Is this error reported twice? vhostblk_vq_err() here already calls > pr_warn_ratelimited() and eventfd_signal() on vq->error_ctx, and then > -EBUSY is returned. > > In vhost_blk_handle_guest_kick(), only -EAGAIN and -ENOMEM are special-cased: > > ret = vhost_blk_req_handle(vq, &hdr, head, out, in); > if (ret == -EAGAIN || ret == -ENOMEM) { > ... > } else if (ret < 0) { > vhostblk_vq_err(blk, vq, "Failed to process guest request (head %d) with %d", > head, ret); > break; > } > > So -EBUSY reaches the second branch, which calls vhostblk_vq_err() again. > That gives a second warning and a second eventfd_signal() for one guest > misbehaviour. > > The commit message says "Log the head and let the caller report the error on > the vq error eventfd". Should the vhostblk_vq_err() in vhost_blk_req_handle() > be a plain log message, such as pr_warn_ratelimited(), so that only the > caller signals the eventfd? Other early errors in this function, such as > -EINVAL, are reported only by the caller. The vhostblk_vq_err() was added at an earlier reviewer's request. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel