From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Liu Kui <kui.liu@virtuozzo.com>
Cc: azaitsev@virtuozzo.com, devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.0] fs/fuse: wake close_wait waiters when fuse_writepage_locked() bails out
Date: Thu, 24 Sep 2026 13:33:34 +0200 [thread overview]
Message-ID: <3e73f134-7a8c-4f25-89e0-b22e9b85073b@virtuozzo.com> (raw)
In-Reply-To: <20260924-vstor-145614-wpl-fix-v1-1-aba86330d06c@virtuozzo.com>
Committed to branch-rh10-6.12.0-211.52.1.22.x.vz10-ovz, will be released in rh10-6.12.0-211.52.1.22.3.vz10
3b2cc738990e
fs/fuse: wake close_wait waiters when fuse_writepage_locked() bails out
The error path of fuse_writepage_locked() drops the fuse file
reference with a bare fuse_file_put(), which does not wake up the
releaser waiting on fi->page_waitq for ff->count to drain on
close_wait, so fuse_release() can hang. Use fuse_release_ff() instead.
The bare put came with mainline commit 0acad9289be3 ("fuse: refactor
out shared logic in fuse_writepages_fill() and fuse_writepage_locked()"),
which added a failure point after the fuse file is taken; before it
nothing could fail there. It is the last one left on the writeback path
after commit 6a30a2b00fee ("fs/fuse: unify dropping the fuse file
reference of a writeback request"), which covers the wpa death paths
only.
Fixes: 0acad9289be3 ("fuse: refactor out shared logic in fuse_writepages_fill() and fuse_writepage_locked()")
https://virtuozzo.atlassian.net/browse/VSTOR-145614
Feature: vStorage
Signed-off-by: Liu Kui <kui.liu@virtuozzo.com>
Link: http://lore.virtuozzo.com/20260924-vstor-145614-wpl-fix-v1-1-aba86330d06c@virtuozzo.com
--
Best regards,
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
prev parent reply other threads:[~2026-09-24 11:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 4:05 Liu Kui
2026-09-24 11:21 ` Konstantin Khorenko
2026-09-24 11:33 ` Konstantin Khorenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e73f134-7a8c-4f25-89e0-b22e9b85073b@virtuozzo.com \
--to=khorenko@virtuozzo.com \
--cc=azaitsev@virtuozzo.com \
--cc=devel@openvz.org \
--cc=kui.liu@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.