From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 52F7C8017D for ; Mon, 9 Nov 2026 12:26:33 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9CPEDN031726; Mon, 9 Nov 2026 15:25:15 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9CPEDN031726 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="cl/XUiSY" Received: from mail-yx1-f69.google.com (mail-yx1-f69.google.com [74.125.224.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9CPCRL031722 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 9 Nov 2026 15:25:13 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9CPCRL031722 Received: by mail-yx1-f69.google.com with SMTP id 956f58d0204a3-677d10671b7so1001126d50.1 for ; Mon, 09 Nov 2026 04:25:13 -0800 (PST) X-Gm-Message-State: APuU4Z9DsDZ22wAmaNyfdjd54FVRTPX7QuBMlmEdiYmX8ZrjRH2k/91O Bll22ET6sRWGsiLEM9KazaKZkeOtl6UVXiCLJwv/TrzeCkWVVvYRb97ZSaVYcxOAUy67JSW1vi7 M32e5M0YnZpOnh5nS6uThNK7ZbRao45NAL5oHIkm8i/LQ0Ub6IbR9GA== X-Gm-Gg: AYBFou2yuXQLoyWH+wno9Xw09meQKOHVsbM7MjY459q0/tmBsEy+/r/aTPN2e/Xe2jk XR6kiP+bW8XIEAGhKaThEsghpmZGvNNzij1zxCis1oBvPqaxusKwJATRUMvYB2FPI9LWfVQ5vO4 +fDx2GPNuasTLIGKQdpRZ2kL8gDpo+e7+Vh5SaaKdjyKUm8fIzg2QbqeNH1tgdlntO5EVItsVQ3 diXDeeCe6Ucq811lhNeU3N3LTmYNvP5yua3FQYgCwl8C51XuFPY5ncc3qUn5O/9gkoeyAipmVon CILALnKcPgFe010Gqw9rdqU8AvMnWSP8QhlRWA+YEEYsa4iwqQanF52tsYsN8EP7bHKeVpzQ8uT Z0fd4Yeq2tbJKUJ4vJui2/YufYUOAyYuTKLg2yWDuacdrac1VfQ83KLAjGOn5TzIuTxpkfCc7h2 ldaOiZFsdr9lE/Rj5uVtqfxm5OoGjUhGg= X-Received: by 2002:a05:690e:13cc:b0:67c:2674:ec72 with SMTP id 956f58d0204a3-67c3d7aeb1fmr3042417d50.4.1794227111958; Mon, 09 Nov 2026 04:25:11 -0800 (PST) X-Received: by 2002:a05:690e:13cc:b0:67c:2674:ec72 with SMTP id 956f58d0204a3-67c3d7aeb1fmr3042404d50.4.1794227111429; Mon, 09 Nov 2026 04:25:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1794227111; cv=pass; d=google.com; s=arc-20260327; b=oupOg9CcA/UmhrreZYEPvlEMExPVHKYih/9mkfRp07lTtkkktAUd9BmX/FneF9L/A8 e7CD9qItIN5Ndb3+oFK2zaaGlkf1epHfu3klH8dyLCd0G6XZWJy+ukGi28PyGMHEI3tn v8+K20ybKzN+ohxhOhNnM2UpHR9VfgcmUciv0hIi8L8WZf+ua6vOGCBcG9DMmUNw7kiR Tz2ZMntxZhm5POrqhp0a6Z2RtS3Dzqn2ArHubbHxPQy/eMj93YsjeRUbR32g+CXi58FT fYouWG4LbT7h2Hmpzy610EE2A8Bgrjc8Hb50IT9TiQyAIfLmWTqS0bPWSwqPgSk9FrHC GDeA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=aiODPtwAQtgKrdeOtRoWkIw+tmi59JoDPLZbY36TPNs=; fh=IlzoM7xapMIT9vjIu8V1YxnmOSGAT8hvLuDm+hjUGIo=; b=giQQy3E8hEErXcvDRVpb1WoVb1MNBf/B3g9gNjZPJrtL5gO+3/BJeBZN7GFLOzAmCo JdZxI8I351Kpu2ptKtyFWZtTayZ57qDHPNWFgOS+uyBY0BYeHxZceSwfYgAcp96tfXlA rVQJno++Il47+QWjh0OzYocgAH7uAtrPeO+IZDCfbIMlRqDNet0DWyNnDWqTpNMjATbv ypczRZyIGTneoAHvIsO+CFzeoy6XwrPkwsXXwQ1B1k6aBIB3vL95KJc+GNxElU2Orbce Vkaq6P3is8t54FeWRmjlFKWA3+UgyvaV3w4JkCqJu8VScJx9OS+B1+J0ah5TDl8dgN6J 0OPw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b="cl/XUiSY"; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazlp170110003.outbound.protection.outlook.com. [2a01:111:f403:c201::3]) by mx.google.com with ESMTPS id 00721157ae682-8b36c0aa2a6si23453157b3.85.2026.11.09.04.25.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2026 04:25:11 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) client-ip=2a01:111:f403:c201::3; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b="cl/XUiSY"; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=epbh7KhJG/n1OEk75pPon6Hh+eo6psjLfeAN5DH1ah6wOzLj9Rg1bS80xNwtz8yggqQrDiNmoDVexuFziXmkxg7kEU0QthyQz6Y3G6+44QTxmipN5uwGR6eZ7sYgiJh9UNtkIwFVciaO0B2gpadRQsNkV28cLAkOpEIgGv9suEz5Lqs6WJXTXo0XLNl0XecJDUZuhzmMgl5tDld/drI6cp4ikjLrdhwhEBK3T2QIuOzpeWwlr9fqsc0ej+USO5EjbegjU2/S3cl/s3A9MqKdAt/aGIDrEfsxV+eQFrKELEZKJKQ5P7uUS+qBDdv5lijRackqALPxFhlrhVdwUkgxsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aiODPtwAQtgKrdeOtRoWkIw+tmi59JoDPLZbY36TPNs=; b=XaSVRxrKEExpfeRSqzzO4PLNHkkOhmeWQSU504W43ZrYtiEnuz7qtw4CoSZdKHBHbpolL6aFYLOi4Vb15f9JnKW2xuA8AqK960IhycKOHh9W7Etig9XA+QdAoOKsj/Ryxm7HUoxVeZG8EYpoBZylZSnaFx5/yqCoo/SqbX0Tu2o0hKOjFtN3LPlhmQt0/XLN7mZXdcYYOgAGBuwXrEKWRjourLoCrbRYxHQ2wIl/ePsMUpbb4/KaHglhpXDHk387wAk7/LWeMp8mWlb9SrTJPU8FeFH9dLsRF/YQ03n0npa7r+H6tCqcz8BEJi1R+gT43vfB6ZnZzR4i6tDHPdG1hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aiODPtwAQtgKrdeOtRoWkIw+tmi59JoDPLZbY36TPNs=; b=cl/XUiSYmSVGyzrgnXdfsUCLlLCpADZfoHlnUDqRYfHIrVwT7zB5oaqQ8S23uyPb3011CNb3q7NvuFL6KFNC96W1o90AMIrkNnWYdDrdQW7NCv7Ippw+ncQp+aQhTHL6lHOtojz0+rTVXqlgrm7+0nYn5a57RN4PcAA0p0esjZVmaIrh8MIwLkfN+g22pdpINi7U56oPFsLKhJ2LAk5LRdxXo8ta7FC206W+zTx+yZoXfhduOW1eykPT05ahj+JIyipwp0fIYNiSZRb1QIvGNXDQScDpFUwrlm0cBELN0dovqUNVidkM4OV8eomcgNE0ShEdUbb2PS0zBdUUS9zfgA== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) by AM8PR08MB6418.eurprd08.prod.outlook.com (2603:10a6:20b:360::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.592.10; Mon, 9 Nov 2026 12:25:08 +0000 Received: from VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a]) by VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a%6]) with mapi id 15.21.0592.009; Mon, 9 Nov 2026 12:25:08 +0000 Message-ID: <3f61d68d-e2e9-4ef2-96f3-4c42194c5a87@virtuozzo.com> Date: Mon, 9 Nov 2026 13:25:07 +0100 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, andrey.zhadchenko@virtuozzo.com References: <20261109115856.1362416-1-alexander.ivanov@virtuozzo.com> <20261109115856.1362416-8-alexander.ivanov@virtuozzo.com> <010701a1c0368b68-7bad95c2-54fd-4771-afaf-0035c8183372-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Alexander Ivanov In-Reply-To: <010701a1c0368b68-7bad95c2-54fd-4771-afaf-0035c8183372-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: ZR0P278CA0097.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::12) To VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10743:EE_|AM8PR08MB6418:EE_ X-MS-Office365-Filtering-Correlation-Id: f4429806-6825-4c71-d7fd-08df3e5c7e40 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|23010399003|366016|22082099003|10067099003|18002099003|3023799007|261022075727099003|56012099006|261026140227099003|261022115727099003|4143699003|261009223027099003|5023799004|261028144727099003|261022105027099003|261021121427099003|261102123227099003|261026121527099003; X-Microsoft-Antispam-Message-Info: Al5+zSXbQb6gTy8LXrRqjqI4U4DfAu8MUwDZ56zLZ7TU8M1qoHQf3BQMXtlJbRy+bQ7MFbjCLFa0rpCcPfsza841/a1vNX4zIxahHrCMgJ6yp5Owt8VXF/YJ/7mMTHU/KHo/r59wB8JzBXivhyEDhBK5VHivBpLIawBM51AJ/4hUQuskdB5biat3PS+A28j9avyWwbc41r9Dxvqdc0R1x/Mz7VMfsTUXj9IcCfmHpMmf6QYe2rLh4IOecPOlo7HegbNm4apdG3REoo/V7FGMTtkgua1q1w3V+Iq85zAm23Yii7Sklwyaa4CC5lP0F606YOUKLZnnKHUjVOcbQ2vo04Pff0bzIv/JolzZ0Gr8Q98vZHk4SUA1jWxnArNcK+J1pQ/6hKfffPurqaYP/q9RO1pgOhGvH4fmhX1CS4PBsUNT+PPlaUPxm6kcRvty+3mJglOQaozW9yN+4bfxZf5MTPKAeraDB6kGvUv71+qoz0bjJIORitsiAeCA1cEeCcAcv3VW6cv1hjsn3ouEG0RZc4GyIVpaAvBGOosB5qn1abbMesIK488OW2tWFW1qtXvi/CBbqqhnnAZkeZ15myu2dOQwDXIuQbNQlbEOdWkhaT3de4jOZDPtrNqG8RYNDPI17ks8lanJAVvGBPtUSfWwR9euJWCGbR3/A9vnbvEjakU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10743.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(23010399003)(366016)(22082099003)(10067099003)(18002099003)(3023799007)(261022075727099003)(56012099006)(261026140227099003)(261022115727099003)(4143699003)(261009223027099003)(5023799004)(261028144727099003)(261022105027099003)(261021121427099003)(261102123227099003)(261026121527099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFdwS1NrZWhoRktrZjNtV0xCWUpuclRnOVVIb2NQRVMxSzNsY0lwYmpjNHFh?= =?utf-8?B?a1Fmb0JDZVZMQVR4b2JxZEVBMG1Wb3RmRVE4V2tMSjcrRmd6RjhwUS8rMWlY?= =?utf-8?B?TFZzdUFuQUlXU2VqaG1KMkVwUnFXTFoxRVM0c3RjMEoybkc4NFk2OFR5dTdN?= =?utf-8?B?VkttYjhWdFpXS2pxQlRpOWFzcFNsYUNzWDloMmJaUU44R1QxTTBLa0lWcElT?= =?utf-8?B?RHdIQ0ZaRnVEZzJQK2ZtVXpueGE1UXhDTkpZT1Z2aU4vMGhwUUxMTkR6SVRj?= =?utf-8?B?Y1RzUk5pNC8vMUpzdWxQNHdKUVczVTAwanB2VXdyNGttS2JQWEpPUnFqUy9k?= =?utf-8?B?akRKUWltL0phRlVNOXZxbnl5bnJ5NU1zR3c1WDlBZk5zbm1YTmRKRzhJM3Zo?= =?utf-8?B?TEpnUU5sVndqb29mK3R2YnU3QVNaYjNGZllNY0tNY2FZV2lFb2tjd3F6WUIv?= =?utf-8?B?UDZGZWY3T04vZWFTalZWMGptL1VLdGM0ak84bmw1U2JGSVlOcnVuVGVqNkZL?= =?utf-8?B?TmpFL1RZcEVxbVVSSHovTVdNY2dsVjNEL2dKQ2xYbnNjUmZ5K2c2UFFDNDJx?= =?utf-8?B?eGNNSG9kMFg1NHc2OXFJYnliRVNkTmp1K3RpSDF3V3Rvc1JEb2xlTTIrWFQy?= =?utf-8?B?SUphTnUyWlA4ditOMkJGdGE1Rzh2Smtrci9RTEY4WDRYRlQyNENzSTVNT29r?= =?utf-8?B?QTZsVUtDL3MrZzVBT0M5Z1ZuckdEenZtbjkySmtwbEFYQko1RUEwc1hiZFBO?= =?utf-8?B?cDBKbzhqQXN6ZmRKZzRpRktxV1BPaVdKblVxazBRNDJsTmsreEMyL0hZSWpm?= =?utf-8?B?aUZSYTQraEdSa1J5Yy8wSXJ1S2dTWWE2QkozS2ZZZzg0aHdzYjhqc282M3Za?= =?utf-8?B?YU5HN0sydFBYeUJmUGRnREh6NmM0eEw5azFEOEpRVzVLWWtpQ3pNdEY0cU9M?= =?utf-8?B?dGF4QXJQYnplYWltci9UZFJVekVjZFJsaHk3cFZtNEwzcnUvSXhyQWxUaW1M?= =?utf-8?B?OTJuUmMrWHdDSlpkamFUQTYyWmszOVpCaGxWdzBHZmJKMDgyYTRnMFRtbGJj?= =?utf-8?B?MFR0dEI1eHJ4TFB5WDFvKzJ4aHlvcjVMU2FqWDBpaXM5ZnJtb2trQUpFeEVw?= =?utf-8?B?bEVaZDV4QVZoYnhacnQ1aW5BUUhIRHlYU1Nqc3hDbGs1dGc2TkJEbFREdTVi?= =?utf-8?B?UC9ZOSswelhWVU93eFFpVFhlQTVNOTR4cURXaE9sbUVPbnNTRzdoTDkrODl5?= =?utf-8?B?djlKanVqNHVSV2pnWklLVFRIZEhDZ2tiZVFwaWt5K2c0aVBPbUtHNFlMcktP?= =?utf-8?B?Y0Y5ZGJnd0lZTnl3dU1ZOUIwTU1iYlkrYVBoUHZHTS9nMDlRU3B6VnYxc2dq?= =?utf-8?B?bHBUaW5yenJnd1QySnJncjU4NHQzby9hVWlkZ1FlajBNYkNNVGNGZ01GaURv?= =?utf-8?B?WDBSMXpTdi8rZzVhZjhvaVVaVDViWitSV0VWQ21zZTdwM1dUcVBtaEJibGJn?= =?utf-8?B?TXE3aE9sbkFESmZBSXk3eTlSTXFNRWdjTzhBRzRsdGJrelNaSDNNbWdUNkVF?= =?utf-8?B?amhWVERBSC9qTHQrTHorTjVnamF1M2xjcHhyUHYwMXdvcXRBWWF3VzBZNmxn?= =?utf-8?B?SmM5a1MxMHNGUi9mNlZkd0Fwczg1UUhTeVF0RkVJZVVmQzh2eUtMN0lFTU9U?= =?utf-8?B?QUlaRVBYemU1elpEdkZqcFRkL2V2ckx6eVJUZ21FT1hjNDFla2xMUXg2ZjhN?= =?utf-8?B?a1VEWkJPWUE0d05YZXF2R1E3NkdNRmdzL1R5M3lrRlh4Ukwzay9kMEhaSE8w?= =?utf-8?B?bnpabFIyUmZ3anI4RzVROHlZVjVMdmNXNUJGcEZMNVZnZlZyNHJETVBPOW0w?= =?utf-8?B?YllyaW1JUk1FcU9UR2EyR1NkMjk5b0hMWHVMNEg2dnB4bUdhc1hQUy82Z01q?= =?utf-8?B?WnFiSWRpMFF0bkZ3b0pBSzVLSDREQWYxdERwL1IyWlR2dFpiQnQ1b1VjRHlQ?= =?utf-8?B?cG1nSmJldmpobXR1d0k1eE9KcWxLNXI0TStDT0E2a3RPc25icTdXbzN0dmt6?= =?utf-8?B?a2VZWVF5SjE1TXJQZ3FRUUprcTJuWW80bzgrZ2pra0oxVDBobThPaHN5SVNR?= =?utf-8?B?K000ejZZU1A1VmUxQWhvVlZPNVFWNXZuT3FBM2IvNVVxM3Q3MUduMXZUbHYz?= =?utf-8?B?cVNTUkRJeDMvWGV1L3BweXhaZXBhTUpUQmdqSzdEMTU2WXdkc3RDRGpMdE53?= =?utf-8?B?dTdGUEFMcjF3SVNacEs4QVl0K0RobGJZaFFqN1gxNmhRNFlsUHJ4SkdDWDBp?= =?utf-8?B?NmdiM3cxV3ZtTXJ2eDNlaW4yYlVHODdyczJxTXh1NVFnMTZCNytFb2ZFUjJT?= =?utf-8?Q?PdFDvhbh8/GcIU1M=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4429806-6825-4c71-d7fd-08df3e5c7e40 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10743.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2026 12:25:08.7401 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JPKWyPuEVWB6WVGiJQqOE92gelzyzSFW2fcxgT6C0hfjjBd/W2BdyYI3j5QJQof3x+vW4Dpu1NpDs2oZjBeEl983WuMpMl/OfQEcswB6Utg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6418 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v10 07/10] dm-qcow2: flag the image for check if reftable relocation fails late X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org >> @@ -2351,6 +2351,10 @@ static int relocate_refcount_table(struct qcow2 *qcow2, struct qio **qio) >> if (ret) { >> /* Restore old R1 */ >> set_reftable_in_raw_hdr(md0->page, old_pos, old_clus); >> + QC_ERR(qcow2->tgt->ti, >> + "failed to write header with relocated refcount table: %d", >> + ret); >> + qcow2->tgt->md_writeback_error = true; >> goto err_free_r2_pages; >> } > [Severity: Low] > This isn't a bug, but the block comment above relocate_refcount_table() > is now out of date: > > * Then, we try to write new hdr on disk. In case of failure, we > * restore old hdr in memory and do safe rollback. In case of success, > > A failure of the header write now also sets md_writeback_error, so the > image is reported by wants_check and resume is refused. Could the comment > be updated to say so? > > The comment at the top of the function also says "We act in the way to > provide safe rollback throughout whole function", which is no longer > accurate. Fixed. >> @@ -2372,24 +2376,25 @@ static int relocate_refcount_table(struct qcow2 *qcow2, struct qio **qio) > [ ... ] > >> /* Connect new R2 to new R1: one for each group new R1 and R2 span */ >> group_size = (u64)qcow2->refblock_entries * clu_size; >> for (i = pos, r2_pos = end; i < r2_end; i += group_size, r2_pos += clu_size) { >> if (WARN_ON_ONCE(r2_pos >= r2_end)) >> - goto err_eio; >> + goto err_hdr_written; > [Severity: Low] > Is ret assigned on this path before the jump? In > relocate_refcount_table(), the WARN_ON_ONCE(r2_pos >= r2_end) branch goes > to err_hdr_written without setting ret. > > At that point ret holds either 0 (from the header write or from > calc_refcounters_map()) or the positive value left by handle_md_page() in > an earlier iteration. > > The label then logs: > > QC_ERR(qcow2->tgt->ti, "failed to fill relocated refcount table: %d", > ret ?: -ENOENT); > > The ?: operator only replaces 0, so a stale positive ret is printed as if > it were an error code, for example "failed to fill relocated refcount > table: 1". Could this branch set ret to a real errno, as the other > converted err_eio sites do? Fixed. >> @@ -2408,12 +2413,18 @@ static int relocate_refcount_table(struct qcow2 *qcow2, struct qio **qio) >> for (i = old_pos; i < old_end; i += clu_size) { >> ret = qcow2_handle_r1r2_maps(qcow2, i, NULL, &r1, &r2, false); >> if (WARN_ON_ONCE(ret <= 0)) >> - goto err_eio; >> + goto err_hdr_written; >> mark_cluster_unused(qcow2, r2.md, r2.index_in_page, i); >> } >> >> return 1; >> >> +err_hdr_written: >> + /* 0: md page is not cached */ >> + QC_ERR(qcow2->tgt->ti, "failed to fill relocated refcount table: %d", >> + ret ?: -ENOENT); >> + qcow2->tgt->md_writeback_error = true; >> + return -EIO; > [Severity: Medium] > Does this path leave a half-updated reftable live while the target keeps > running? > > When control reaches err_hdr_written, qcow2->hdr.refcount_table_offset and > refcount_table_clusters already point at the new reftable. Only some of the > R1 pages may have been renumbered. The new R2 clusters may not be linked > into R1. The new R1 and R2 clusters may not be marked used, and the old R1 > clusters may or may not be marked unused. Nothing rolls this back. > > The caller is allocate_cluster(): > > allocate_cluster() > find_unused_cluster() returns -ENOENT > relocate_refcount_table() > -> err_hdr_written, returns -EIO > if (ret <= 0) return ret; > > The -EIO only fails the current qio. As far as I can see, md_writeback_error > is read only by the status output, qcow2_truncate_unused_tail() and > wants_check(). No allocator or map path reads it. Later qios can therefore > keep calling find_unused_cluster() and mark_cluster_used() against the > inconsistent refcounts. > > Could those qios hand out clusters that belong to the new reftable or R2 > area, or call relocate_refcount_table() again on the corrupt state and > overwrite metadata or data? > > The commit message only claims that the image is flagged and that resume is > refused, and that claim holds. But the "/* TODO: switch to RO */" comment > now remains only on the err_free_r2_pages path. Should the late-failure > path also stop further allocations, for example by switching the target to > read-only? The late failure path is not a regression. Before this patch the same branches went to err_eio, returned -EIO with no rollback, and left no trace at all. The patch only flags the image and logs the failure, which is what the commit message claims. These branches are also reachable only through a driver bug: every md page they use is cached before the header write, and each failure is under WARN_ON_ONCE. Switching the target to read-only would need a separate "in-memory metadata is inconsistent" state and refusing writes on it, since md_writeback_error is also set when in-memory state is consistent. That is out of scope for this fix, so no changes here. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel