From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 788638017D for ; Mon, 9 Nov 2026 14:38:02 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9Eahkp000446; Mon, 9 Nov 2026 17:36:44 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9Eahkp000446 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="vHQ0ITcb" Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9Eadr1000442 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 9 Nov 2026 17:36:40 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9Eadr1000442 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-8b691cf0eeaso1335130b3a.1 for ; Mon, 09 Nov 2026 06:36:40 -0800 (PST) X-Gm-Message-State: APuU4Z83DeVOQSzuf70fOl7WnFWwMxXo8d5xf9C0GsIGiwUtdvfN/pnS XaKRKf+iOKNfh2SdwAx2hCF124zOOwh49BdeuddtOfxiMvZk0A1JAMiMF4IFe3+iIeG+80ro/id CPQTR12vlyuCzWBwXOaih6vz11VK+Eqtloee1VUJzg0dz9a/YVyV2hQ== X-Gm-Gg: AYBFou3STkpKf86Ezd+vhhQnj+p5xkCcZGtvMfk5I+zFgHiaiKWTg6ah3tFcN175HqV PQ+6AQVl4mHoZt573dWl5RF8ehRa+nCvRRnrbXz5orwzVElfSsFJZRTeeVvkR69mHc9dfPEhAIx vvkYKif89jibGkcMmOAlHXmXjkVaCu7IBOHLF8LcNESW9mlF0ug2m78ccdlPH3olSgBxZwZPsLU z9/ENGkhLUsPMLl4JYVI2hrIQrX2STW9NLcSfIoDoXhBogP6NYYFzQqB1Y2MevgLN/XULqs830T Cnj+jjCwxHr8TWEo6Zn0KDRrGgoye3y24k1uKs8WZzpGE9ywTtjEUkCnc4kMJ4tBunyYevdb1Hq jN22tx8tuaxv5pjC8P3ZiZuapuBisQ4oCzc56DwN1SENv0RNys65BqZEZtqzFWcz6QLN2CpbyTy c6ca5w96apDRRLsPoqusAee4tmLOGbZ3U= X-Received: by 2002:a05:6a00:138a:b0:8b5:7fc8:867a with SMTP id d2e1a72fcca58-8b66faad067mr3957543b3a.36.1794234998675; Mon, 09 Nov 2026 06:36:38 -0800 (PST) X-Received: by 2002:a05:6a00:138a:b0:8b5:7fc8:867a with SMTP id d2e1a72fcca58-8b66faad067mr3957508b3a.36.1794234997980; Mon, 09 Nov 2026 06:36:37 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1794234997; cv=pass; d=google.com; s=arc-20260327; b=Xxn60ZEvn/mtL1FQDTCS+zHKFzesYHqb2b7tyJOdDn3cgz5KI/I6Y58ARImUY3iJrF 4zfj+zLg6FDkWyvW7v1rL4yONELisAoZkwP07D9vCrOc+zL5sAoeSx6smRbzTS3f9SIk qJ4ou+GjXYueaQrhdZIpm+ujRVKX4TFzdppkmYUAoAYK0yVhuj0OhwpZXN13H7sED1Me MSQXS3qEpFJyhgvNqoIvDJKyYj9Qz2di2TC6PMOJOtMOmgSNYZvpvHK/6W+UNdS5BXUu vU701sF7fQdAppkIfQh63AXVxFN/mpZu51wh7A756Eu5JYu0LgnVFkHYx9/PI6K01wNT 849A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=aKcBT/ZHZukXho4Vsy1uIBAGyNx+HCbFuFZWlAR1fwU=; fh=IlzoM7xapMIT9vjIu8V1YxnmOSGAT8hvLuDm+hjUGIo=; b=FTBOoYWnMpWTsMPOOWuP+CFAL0C8dw0FuOhcb5sPwYt5ueG9vjJUmUo1VMPbX5QMEg SJljOBKLe7V+R+XLwEaKflSxmEdi+v7Mjh2AZCreShKmQRI5VggDOu3NhSkBRSOQPuuj d6i8yLdSsxTu2xljqG8rltNZamhhKdbNbWIveh3JuCaMTdJ7VfopOBstMNQWUvUT6fbZ Jrc2ioILFsvPRdLnyPx/5J2YUGCtLvTQh9wa74SJSYcC7znx0DD34VCwGzDYM3w0X2DC g4M0Z+fkbyuX/ReQVQE9j/Do/WFKEk3Ceuv7n8NPSWFDzilM6Qttk4rSvs86UIcNpfb7 alSw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=vHQ0ITcb; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazlp170100001.outbound.protection.outlook.com. [2a01:111:f403:c201::1]) by mx.google.com with ESMTPS id d2e1a72fcca58-8b649dfb506si8143932b3a.234.2026.11.09.06.36.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2026 06:36:37 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) client-ip=2a01:111:f403:c201::1; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=vHQ0ITcb; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=U1uu4lNkYEJAsm/kuB2iICu9Hi2rSqmmqmbhQzNttMtbOELl68onCpgzudXKySVfAe0ZZbwQ0uQBe/iob6tXu/KT0yt+Hzm3ANXj2jn5gGlwxVHximrspQxPth4P8BzmcBQBcYwzwfR+930reNoDH1my+/3dKCZwMMNhpHaKv/QL3E348PmYKRolWDJTiwmj8XP4vE2uVAzUSC7l0iwmadhnHThM261o5HFYDvKZNpDQwwCzuhbv1eOVs8gOnkvkyDYfxYRCNFTtF8+Hj/ZfSb5GCuex5MaJ/+OAalA9Zf0ZXBHldIE91Iad7FyaAcTEDLfeogeTR/DbErJOY1DE2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aKcBT/ZHZukXho4Vsy1uIBAGyNx+HCbFuFZWlAR1fwU=; b=ZgsnCAlfOnUibkcZl89ml/wm2FvVzaTZadc9qFsCHIwccFKEca6drLQpRjOKpCz7s0QCeADwxC79Q11WIcge/RJsIpt9LuwXrX2HzQ984Nas3PbEwDNjVNiyU64AGTD6sO9mvTe9x+oWfCtjsAkoq47nvUqwzNCuXV1S5htrxpV7cBgGnk+ug69qYlFfgBxzV8csiDfK9L97JUe30OHOCKR4H7oKsNTfbwb1uPDRiK5p5E82qua8rVkzHLkwpp81hTsecK0BRQj6eDzPKAJyGnUAaU6NMnhtz8dfTQ87+/176Do8UxmaZwmmSYvXwl5H0Glc5LW59dRONPUrkdNrag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aKcBT/ZHZukXho4Vsy1uIBAGyNx+HCbFuFZWlAR1fwU=; b=vHQ0ITcbW8jP7wilJdXpULrbK6H1uSca3ELJQ/NOlBN6qRdAsO7Ztxod8ZyHXjVS3RnQa6sUrO+nMrh0NuX120b7u8yWXwwpgyxrSaf3+GvVHMp8C5sNgAuHcPYYpatjPKRcx4VZDY1erh9FJIBC7pdy9upHf40jNUulNMVPy/JMSjCVbz9jzb8QdUCEfKijE8VJ8B8VbAguCTpNcMMMc45wvVF+FkdhjkeW80/JRkSK/FvUrTN8v+sedk3VF946Fi/8mA0Ok6dyo5STF9z7XE2ifxmEnNw+5ZrD9VfrHl2/1sSAZJFOuX32wjgJLn6QzWgW4gFsLoEl27P09ugOhg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) by AM9PR08MB6227.eurprd08.prod.outlook.com (2603:10a6:20b:285::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.592.13; Mon, 9 Nov 2026 14:36:33 +0000 Received: from VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a]) by VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a%6]) with mapi id 15.21.0592.009; Mon, 9 Nov 2026 14:36:33 +0000 Message-ID: <47b6dec5-95d6-44ea-b476-42a68b08484e@virtuozzo.com> Date: Mon, 9 Nov 2026 15:36:31 +0100 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, andrey.zhadchenko@virtuozzo.com References: <20261109140143.1408038-1-alexander.ivanov@virtuozzo.com> <20261109140143.1408038-9-alexander.ivanov@virtuozzo.com> <010701a1c0a8f85c-7043eee0-2e44-4161-b5f9-932dfa76eaef-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Alexander Ivanov In-Reply-To: <010701a1c0a8f85c-7043eee0-2e44-4161-b5f9-932dfa76eaef-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: ZR0P278CA0043.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1d::12) To VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10743:EE_|AM9PR08MB6227:EE_ X-MS-Office365-Filtering-Correlation-Id: 96274405-bce8-4ec7-ef29-08df3e6ed9b3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|23010399003|376014|1800799024|18002099003|22082099003|10067099003|4143699003|5023799004|261028144727099003|261102123227099003|261022075727099003|261022105027099003|261022115727099003|56012099006|261021121427099003|261026121527099003|261026140227099003; X-Microsoft-Antispam-Message-Info: jz1sOD9X9YqAsmVlCDaTVl9pt07NV48TeXQnkrdntQRLJyD+YXqJVqty/du8jDkIW/IuUfQi1112jQSK9oXi8avjkvAThVWJBWXdEGXYAOKL4rd9MkpVrCquVgjmzl9dmiA7dwU2iVmSK37zugs0455FL8PR+lrPsoBHg2BcT6ynp87SuBFyov3WU4vGHg18ORDds1p1g57HEBQPnyJtPFYnleVhZDZPlZugewYGM/j+BxDZhe1KFPlgwfP3DY8PnuPae7xEQ6b8RveM0m1ITzGp9ZNjvMtfo9hl8drt7n0iWQJg/dba3c9OFmMKw2kAClXOFNIo3YajiGPy9Qyk2odHU6tFk1HcY8XR7RyTqbg/A0Cz42jWsbttNFkB3LGAvG09phLSBhDxs4Fsh0n2R7Xpo3IHcqiKAGYRqOe3CPyKOOsGXveMHmOp1+uJ59XJ1yq/AAP43NlBbNwHCrnAnt8VoEy9pTZPxyl6sZB3VSHW3yn36MRAaK+Hz31E2Y0+fUos8dXXBwAEpg44Yuz2dRRH3dtnu+AFsG3EacgHZpGtL2YfAiO4XN+E7varnlJ7hxxCty+NnUJEt0t54A5biPo845U5iaLP9PvTza8wiDF0ZRHwgYFXramRFYUIuTzmRTiBnYxF960lx4lSxApisahJ3nivw2LY5ie94KU3HHw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10743.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(23010399003)(376014)(1800799024)(18002099003)(22082099003)(10067099003)(4143699003)(5023799004)(261028144727099003)(261102123227099003)(261022075727099003)(261022105027099003)(261022115727099003)(56012099006)(261021121427099003)(261026121527099003)(261026140227099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGw0bWhoY1VZY2pQVUR4VWVPQW5HNUdYWGc3bnBvTWtueitRUjdRbVJ0UVJ1?= =?utf-8?B?ZkZvZEgyOFpPSzcxSkhlclQyb1FGZnhBMGNRQmJQV3RYRGVwS29GTUVGVzVo?= =?utf-8?B?a2NENDBXQVAzNWFuckMrajBuYmphR01vZ1VvNzlIbzEwYVBJTDB5Wm5mN1J1?= =?utf-8?B?emMxd1M3Z2xJcjFab1lUODZQb05oTkJocEZ6dDNSYnJwYnRjeFR3VEtEQndM?= =?utf-8?B?TkxWUnZQd2oxbkxxSXJYUWs1c0dJUUlYYWNqc2lDZ04wbDNGSjlWVDhrN082?= =?utf-8?B?NzZEZnY5VXZhTHlITnBYWmtnYzE2QTBJcnNrNGZOWERWa04wV3FyNi9LbFAv?= =?utf-8?B?NVl1R2d4aWpFT21FQTRQeVNYWStkVWJSaWpGVkVWRGcwV25YcUdGTTNib2Vr?= =?utf-8?B?Y2EyYTM2d2RlWmlhNWZEUzlLRnQ3TnhJTTNHQU1wMXYzQ2ZWbTM2U2FKcmFa?= =?utf-8?B?M2JWTHlwM3k0QWU4U3VibWtZVkhSemFlUnMxaUtHZzhwb3FTSktFaFhCWW5o?= =?utf-8?B?ZllwN1BpMjNXcmpwNFhKcjJJR1BrT2U0MDZCTXZYSjhadERtYnpBcDc1dUZ2?= =?utf-8?B?dVc3UU42RXd2dVQvZDJIb3IyWm9tdVZ5NmMwaUxyS0lZSWc1VWxKUTlvbGJR?= =?utf-8?B?TUtTWHpsQUM1Q2RlQ2RQRzlQSCtwUlplMTB2WmwwRUI0LzNrWC9wREdNUGNP?= =?utf-8?B?R0dPWms2Q0p4SllsM1N5WFJacXpicDFSN09LUFJEczVUSG56bDh5SUV2Z05O?= =?utf-8?B?a2ZGRExpNEh2YzRlb0JEWWV6cXk3aFRNTUp6eDRCN2p4ZHdJbVZCVmdmdnZQ?= =?utf-8?B?VktpSHlDYW1sUzZPNkJsVzY2MEwyQ2NUNEg5YzhXSDJkS09aZ2k1Y3VFQkRn?= =?utf-8?B?enVkZkdoR2ZOdjVEV2VqMjhUS2VQbDNEYXRoTVV1VVVJbTJ4OGdhK25PbFFX?= =?utf-8?B?OW1qckZQWmxTYWlRUG9aenRJeHhJdzV1N2tCR3QrOEt5bU1YanlEalFPT3ly?= =?utf-8?B?N2kzaU5aYTAzN1dSaE5sU0NKRkVYZHlOcXVSOUkwL1Fybm1mQml4M0gzdXlt?= =?utf-8?B?b0ZQKzFDVlZ4ckZaNW1PakZMdkJwZ0Zwdy9qa0lBLzN3SnRNUm1FazArUERs?= =?utf-8?B?ZVdYeWd0R0JFbzFkWUhyM3JoNjdMVjRLZGNsT1JtOTA2Yk5sajNNd21obVpq?= =?utf-8?B?eHVpM2U4UUtOaDdLYVVOeEtuVlRtZ2ZpSVZXNnU4Y0J0WHRjN2ZXT3ppK25s?= =?utf-8?B?aHBtVW5iOHBtc3ZEVWpOcmptM2JHQTIzcm5tc29pemlPRzVFOW9wNm9XL0Rk?= =?utf-8?B?bVNhQWM0aTNpaWhIOUFhSVREQm5vUElQMDM5UzBaOFl1ZVQ1ck1OaUxuWVha?= =?utf-8?B?UCtxVUQ1YmlPTGJmU3hSbGRSK0xsL3kvTUtOdGFjNkFhSzZQWFkvVXkwVkJH?= =?utf-8?B?VkNBU0ZXSWxTZlFhbmNlQ09iM2RRbDhPSFVuaEVWeXJ2TDJwUXpmbkhZVG1y?= =?utf-8?B?RFNVMCtyNm05aWhnQjJCMmo3VEpadENVeEl1YlFxREdQL0RmdE93NUd0TDY2?= =?utf-8?B?T00rd3hCeTFKb0Q3T1BWQlArVE40MVJZK3VZRTJ3UTJsZG9wZTZQbHBQZE9Z?= =?utf-8?B?R1ZyV201NnRPWFdJM1FWUnhlQXVBOXRyMFdtZWJUYXRNRmQxUUZLMW8rN2Nm?= =?utf-8?B?MFozbzRRMHNGbTBsM2ltM3kxT21vWTFjK2w4LytqL00rWWo2bzBxSTZnbmpm?= =?utf-8?B?L1pKdDJkZkwrV3NmRWhmODVKV2NJbEZGSUN3NHVEZ3paK1grTHRxcnZNSHhp?= =?utf-8?B?RksrTHUxdUJpUmtGQXR4QWJXZHorMysxWG4zcFdQQ2lEQzRUeUtXaml0cUs0?= =?utf-8?B?UjJsb2RsOE9WY2dvcnM5cFlvbWtlcFVSMlJ6WG9PajhEWFVDY08zOGN1UjRT?= =?utf-8?B?ZmpDOSt3V3RiRlBuajhDNDQyVHJXTlpXZDh6VzN2c1ppb3ptak5EUWhVWm1B?= =?utf-8?B?STd0ejhXM2RBbzgraWVUdGRZVE0wOG9BdER5VFZWd2RJMGNTTmxKak5Hd0JP?= =?utf-8?B?dEFFUWVrTnQwL081MnlkYUMrclZwcVNxNW9WTExTdFY5NEFESzdRbVZ3T0pO?= =?utf-8?B?Y29DRGtDTnRqMm1SY0tqUkxWUXlVb2VvdUhZcW4zWVdHdEN4YVovc1Yzak9S?= =?utf-8?B?aDR2cW9iUElDV2lqOFZNVktyWDFWdU5QRWFRSVVxcmpINDNqNUU2MFFjbEJV?= =?utf-8?B?L1ZBZHcrVHlxSXQxWkRRa1h5Wjl4V0NTVHNkUWlKek53TFJhZTJWdHFMMGll?= =?utf-8?B?MzFuQjUrb0ZPK2xWcTVJeElRRXlTTkJ3V2lKZU5zNHE3eUJFSGU4VDlSOFJp?= =?utf-8?Q?hHHDiqZM4oueJmcM=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96274405-bce8-4ec7-ef29-08df3e6ed9b3 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10743.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2026 14:36:33.2598 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ms9fQzJzUdUHaneaPc6Neohg794lbV7nkSteKpJvfqdxy1jtQD3oOeID8d/Q/dVBZW5aCyOMJyHdCJho6Uv3TsSz4jpUAqLFUp3nBgb+lHI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6227 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v11 08/10] dm-qcow2: leak clusters allocated for a failed L1/L2 writeback X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org >> @@ -1408,6 +1373,7 @@ static void complete_wbd(struct qcow2 *qcow2, struct wb_desc *wbd) >> LIST_HEAD(wait_list); >> LIST_HEAD(end_list); >> unsigned long flags; >> + struct qio *qio; >> >> spin_lock_irqsave(&qcow2->md_pages_lock, flags); >> revert_l_entries_update(qcow2, wbd); >> @@ -1415,6 +1381,8 @@ static void complete_wbd(struct qcow2 *qcow2, struct wb_desc *wbd) >> &wait_list, &end_list); >> spin_unlock_irqrestore(&qcow2->md_pages_lock, flags); >> >> + list_for_each_entry(qio, &end_list, link) >> + qio->ext->cleanup_mask &= ~FREE_ALLOCATED_CLU; >> qcow2_dispatch_qios(qcow2, NULL, &wait_list); >> end_qios(&end_list, errno_to_blk_status(wbd->ret)); > [Severity: Medium] > Can this leak more than one cluster per failed writeback in the L1 case? > > In prepare_l1l2_allocation(), the qio that allocated an L2-table cluster is > queued on the L1 page wait list, not on wbd->dependent_list: > > list_add_tail(&qio->link, &map->l1.md->wait_list); > > On a failed writeback, complete_wbd() calls clear_writeback_status(), which > does: > > list_splice_init(&md->wait_list, wait_list); > ... > list_splice_init(&md->wbd->dependent_list, end_list); > > Only dependent_list is ended with the error. The qios on md->wait_list are > re-dispatched through qcow2_dispatch_qios(). > > revert_l_entries_update() has already reset the L1 entry to 0, so the > re-dispatched qio finds it empty and allocates another L2-table cluster, > dirties L1 and attempts writeback again. The cluster from the earlier attempt > is no longer freed, since mark_cluster_unused() is gone. > > With a persistent L1 writeback error, does each retry cycle leak one more > cluster? Before this patch the cluster was freed, so the retry reused the > same one. > > The L2 data-cluster and COW cases look bounded, since those qios sit on > dependent_list and end with the error, losing one cluster per failed request. > > I did not find anything later in the series that reclaims the leaked > clusters. Nothing appears to roll back free_cluster_search_pos either. > > The commit message says: > >> So the image needs no check and resume needs no refusal. > Is this accurate? The leaked case is exactly the one that check repairs, > and the message does not mention that a repeated L1 allocation retry can > leak further clusters. Added "fail the L2 table allocation request on L1 writeback error" patch. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel