From: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
To: "Denis V. Lunev" <den@openvz.org>, svt-core@virtuozzo.com
Subject: Re: [PATCH hci-8.1 2/2] i386: hide la57 at fresh start on pc-q35-vz10.1.0 too #VSTOR-154986
Date: Tue, 17 Nov 2026 19:03:15 +0200 [thread overview]
Message-ID: <51bab6b2-042b-4d31-bdf8-e368bbff2252@virtuozzo.com> (raw)
In-Reply-To: <20261116175002.844361-3-den@openvz.org>
On 11/16/26 7:50 PM, Denis V. Lunev wrote:
> From: Denis V. Lunev <den@openvz.org>
>
> x-no-la57-on-start covers pc-q35-vz10.0.0 and older and every
> pc-i440fx type, but not pc-q35-vz10.1.0. A Linux guest built with
> CONFIG_X86_5LEVEL switches to 5-level paging whenever the CPU reports
> la57, whatever its RAM size, so on hosts with la57 (Ice Lake SP and
> newer, EPYC 9004/9005) every vz10.1.0 guest gets the extra page table
> level. That lengthens the KVM software walk of guest page tables used
> by emulated string I/O, and adds to page table setup and teardown in
> every exec.
>
> Our guests do not need a 57-bit address space. Hide la57 on
> pc-q35-vz10.1.0 as well. pc_vz_10_0_compat is left with nothing of its
> own, so fold it into pc_vz_10_1_compat. A guest that needs la57 gets
> it only with la57=on, "-cpu host" included. A running guest keeps la57
> on incoming migration.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> ---
> hw/i386/pc.c | 6 +-----
> hw/i386/pc_piix.c | 2 +-
> hw/i386/pc_q35.c | 2 +-
> include/hw/i386/pc.h | 3 ---
> target/i386/cpu.h | 2 +-
> 5 files changed, 4 insertions(+), 11 deletions(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 8b39c5621c6..797a0b22184 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -550,13 +550,9 @@ const size_t pc_vz_compat_len = G_N_ELEMENTS(pc_vz_compat);
>
> GlobalProperty pc_vz_10_1_compat[] = {
> { TYPE_X86_CPU, "x-consistent-cache", "false" },
> -};
> -const size_t pc_vz_10_1_compat_len = G_N_ELEMENTS(pc_vz_10_1_compat);
> -
> -GlobalProperty pc_vz_10_0_compat[] = {
> { TYPE_X86_CPU, "x-no-la57-on-start", "on" },
> };
> -const size_t pc_vz_10_0_compat_len = G_N_ELEMENTS(pc_vz_10_0_compat);
> +const size_t pc_vz_10_1_compat_len = G_N_ELEMENTS(pc_vz_10_1_compat);
Same here. Looks like we might want to set x-no-la57-on-start=on for all
VZ MTs. If so - let's move it into pc_vz_compat so it doesn't get
missed on the next rebase.
Also subject line is misleading as it's not only q35, but pc as well.
> GlobalProperty pc_vz_9_2_compat[] = {
> { TYPE_X86_CPU, "x-tsx-compat", "on" },
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index 768c6e47f53..4e350e8cc35 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -1056,7 +1056,7 @@ DEFINE_I440FX_RHEL_MACHINE(7, 2, 0);
>
> /* maj min mic basemt isdefault */
> #define VZ_PC_MT(X) \
> - X(10, 1, 0, MT_VER_SYM(10, 0, 0), true, pc_vz_10_0_compat) \
> + X(10, 1, 0, MT_VER_SYM(10, 0, 0), true, pc_vz_10_1_compat) \
> X(10, 0, 0, MT_VER_SYM(10, 0, 0), false) \
> X(7, 16, 0, MT_VER_SYM(7, 6, 0), false, pc_vz_9_2_compat, \
> hw_compat_vz_9_1, \
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index ae8298e0503..89f8def8cd4 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -973,7 +973,7 @@ DEFINE_Q35_RHEL_MACHINE(7, 3, 0);
> /* maj min mic basemt isdefault */
> #define VZ_Q35_MT(X) \
> X(10, 1, 0, MT_VER_SYM(10, 2, 0), true, pc_vz_10_1_compat) \
> - X(10, 0, 0, MT_VER_SYM(10, 0, 0), false, pc_vz_10_0_compat) \
> + X(10, 0, 0, MT_VER_SYM(10, 0, 0), false) \
> X(9, 2, 0, MT_VER_SYM(9, 6, 0), false, pc_vz_9_2_compat) \
> X(9, 1, 0, MT_VER_SYM(9, 4, 0), false, hw_compat_vz_9_1) \
> X(9, 0, 0, MT_VER_SYM(9, 2, 0), false) \
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 276d0cdb3fa..cceff5345e7 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -367,9 +367,6 @@ extern const size_t pc_vz_compat_len;
> extern GlobalProperty pc_vz_10_1_compat[];
> extern const size_t pc_vz_10_1_compat_len;
>
> -extern GlobalProperty pc_vz_10_0_compat[];
> -extern const size_t pc_vz_10_0_compat_len;
> -
> extern GlobalProperty pc_vz_9_2_compat[];
> extern const size_t pc_vz_9_2_compat_len;
>
> diff --git a/target/i386/cpu.h b/target/i386/cpu.h
> index cbea9cf63d9..05ea4808237 100644
> --- a/target/i386/cpu.h
> +++ b/target/i386/cpu.h
> @@ -2343,7 +2343,7 @@ struct ArchCPU {
> bool svm_features_compat;
>
> /*
> - * Virtuozzo machine types up to vz10.0.0: hide la57 unless requested
> + * Virtuozzo machine types up to vz10.1.0: hide la57 unless requested
If we move the prop into pc_vz_compat - this comment shouldn't mention
versions.
Andrey
prev parent reply other threads:[~2026-11-17 17:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 17:50 [PATCH hci-8.1 0/2] i386: fix the exec slowdown of pc-q35-vz10.1.0 guests #VSTOR-154986 Denis V. Lunev
2026-11-16 17:50 ` [PATCH hci-8.1 1/2] i386: turn off x-consistent-cache on pc-q35-vz10.1.0 #VSTOR-154986 Denis V. Lunev
2026-11-16 17:53 ` no-reply
2026-11-17 17:03 ` Andrey Drobyshev
2026-11-16 17:50 ` [PATCH hci-8.1 2/2] i386: hide la57 at fresh start on pc-q35-vz10.1.0 too #VSTOR-154986 Denis V. Lunev
2026-11-16 17:53 ` no-reply
2026-11-17 17:03 ` Andrey Drobyshev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51bab6b2-042b-4d31-bdf8-e368bbff2252@virtuozzo.com \
--to=andrey.drobyshev@virtuozzo.com \
--cc=den@openvz.org \
--cc=svt-core@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.