From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id AA120803BB for ; Mon, 16 Nov 2026 20:05:13 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGK41C2031272; Mon, 16 Nov 2026 23:04:02 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGK41C2031272 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="lII8KjkT" Received: from mail-yx1-f69.google.com (mail-yx1-f69.google.com [74.125.224.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGK3xYg031268 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 23:04:00 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGK3xYg031268 Received: by mail-yx1-f69.google.com with SMTP id 956f58d0204a3-679f81d5d7bso6547145d50.2 for ; Mon, 16 Nov 2026 12:04:00 -0800 (PST) X-Gm-Message-State: APuU4Z+Xg/C6dOlBlaEdfv0cocijInrfDZFSBIctj+rH9P8Id25SDCfB pKx9tnY63kq6HuUF0JP5aCyYrdqcY+QCr9S/njGESpK2yzran7HJlan6Y8453E3GlTXy0gi5T6o g7Q8CVQtKY2PLl/UvqC1ZGGSbzHppcPt1mXozZs4E/kvxwQlksqE6CQ== X-Gm-Gg: AZFdTZfYWee5dqA84P78BWxO1J+L+9grtyHO6w1DtY3tQEwzBoSkOQUhEJtJEjwzFqU iigmpiyny53O8SdfLqIju0s4EJKBurLLV6ZZ6+Q75ak49wgDJ57Zk12bGxRd3/T/Z9wnhviaMol 3fbXxGf0hL0HCnLhu6HLFgEdLJx3OI0wVBVAHM5qVqQG21P/KP/+iODsMpqz3ZV6kSs45oJ2AGT QB2w3Hu1/H6VV/8T84PWLrlf8eCrILxcfg91r5F5e9BLyEfPEq6+KGzGp7tVY8eF2/UZITqzjhI 2340nKaaJgsVxjBEXWmaUGWwPci+CpZo7LmpPFgCkNy1FjhmkYBl2+F8ZmUtPbOHB+hEBwVdLGI QMtD4g9kjY7RNZjsUZzM152BgqQd57zYjJ2Cu00/ztZWvOPa+xAEPXnuGQc2V9U8JvQWKQzp+bH 9rXzTn7Zo5JAvINKKepYvWWhuzZ1Ss27xT X-Received: by 2002:a05:690e:191a:b0:67d:b5e1:1813 with SMTP id 956f58d0204a3-67db5e13f20mr1948222d50.27.1794859438964; Mon, 16 Nov 2026 12:03:58 -0800 (PST) X-Received: by 2002:a05:690e:191a:b0:67d:b5e1:1813 with SMTP id 956f58d0204a3-67db5e13f20mr1948215d50.27.1794859438443; Mon, 16 Nov 2026 12:03:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1794859438; cv=pass; d=google.com; s=arc-20260327; b=Ruk5Sn6WrG+J5FEYwj31AJG2qSiPkBn+5DYv3YCrixwTZ52HJQu3W7kt9oDeHx6rr2 cD9Uw5tCvWypbSqNKS4Wy0pZ6Nj5+tv58QJfktz4jhrwGLvyYAOQxhpoqUQVIFwU2KTz NolHAl95e3+K2qSkt8KjBC59jNnUNpnT39tmyPHi83jFxhqgQ8k4xFxzg5HmFDw9xKSj oB5L67CDWxEHBXp4/D21YdS7GFsFVWCUFWxYcHZPbb554IgdmN0xMI+e67shPYB86btp OrzTF32qvaNktCEF3yDX5J7GqMywYP/XJK8MQdx/F+f9j9ZFYnArC1x5ft48b3C9+2zD vO+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=TSQPB/TfQOUkc08cQGYk+hnbx89z4iAoKJKPmlL965g=; fh=MPbb/fYAXD7RpgTj7uvhvDOA4h8fFgXedFicSITGHIE=; b=OswC9T39zEHUckuh9xSmXt7BYBD0+ih0oDsG/oSlqLgmHEBH4agAJDJet7EHZsP0R3 n8RF5amVDeWfQQ8ZysK3HEheuGdu2DrNeCDoT28mcmtVSkWfEgoVvkQ5/jMHkK7fruSe ZY7+jZ/oWBRGNHTxjszVZdGbo1iujZ5wQI+eUWjaqoTNlt5M+xRTXSwIpgecMJ0xAYCo eEIzshfjBKLl7vCU1S9kNJnQKHrsecPqmqFGuNTgk86KYoV5DHJbtPXbODU9oza7El15 hUVF2KYHANJ1gwIrvzSrNCuM7YgBOV/tT7XSqXjUyY6m2FQIKNILjnupG2fXiunMekXh jGnQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=lII8KjkT; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c200::5 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazlp170120005.outbound.protection.outlook.com. [2a01:111:f403:c200::5]) by mx.google.com with ESMTPS id 956f58d0204a3-67d8a5d7435si7535248d50.137.2026.11.16.12.03.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 12:03:58 -0800 (PST) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c200::5 as permitted sender) client-ip=2a01:111:f403:c200::5; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=lII8KjkT; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c200::5 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MxSYW5fuUqoN1aRucb3jO2Xceld/jquPpakbne76KnFvgO9wWaJ2NEF5ENJq5Q3Z8VKFmohW694XQVuXVj6ONacNIFHWtIjhFQbG2myJrHqU0++kcnkW4p3d2nSOIor0cBAVdKl+Fy37pSqzyp57o8CzXlSVuPayHsCx0aO0q2h4tlSc/iXv43afAnaH+iria6vF3i4IUH8nHOEdE+6ZY3b2c2omO6DziQRVHgl40Ve59PJcrWL2Fl877k0jraLrTd0GWZW2X6quwroRGGtGD+5xlICCzP2lUiRC6U+TqnvENma6vJHo281HwYBxZVY54kqi8ouR0+umvxptljoHSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TSQPB/TfQOUkc08cQGYk+hnbx89z4iAoKJKPmlL965g=; b=FPaP9WKSpuoUpXkkPPARflGVH4nMGXBWyG+MIFK/eA8FCFd/oZh1INjd62OPt+YT+gApQMDJ5AXBZnU69TFXDjK1AkIIhhjy8C6ilfJQXDsMYoE0X+W7a4KrwcRAGHX8wN3QYFB8cjFhFx93AKNQ5F3mBZGt2R3iCPShGcgggAqIjXeodleTeMwL0f1S7Twm6uYm8lAaYiftVCJa0usH6TSfLgiSTQ39H11TyoJj1SAUyRj+MBf+DAUPP25LZmDqhrZphSbGdk5ttxEH4PB3KqfvvlHjDsR2ineuURtVSZ5WO7a2OGRfBOgKFmVtJYHE3ymgtnwJ1tqJ3l3Hde2JCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TSQPB/TfQOUkc08cQGYk+hnbx89z4iAoKJKPmlL965g=; b=lII8KjkT0Xo+/Nn0824W8Bg6CFDNx4+hALoaSYML2wSR6PXbu6qdbbWzXexRe2Tjgp3K1JzWUQhDBuTM366tP4vfSCi+m+2b/NjLLFo9tgVqaoKUqFuea7gvDspuU3ryS6dVNiLXJVyuKSIACVeGJtQckjL3HbcZg/0ntu71UXt7hVGgpcH0jSg5bKs8T8ZJFmRyF6ciKybGhBgjF/yc2P9CrFq10wsVKrVjA7HZzXwdFjZv3HAFwLBTT4xIR8m+ICgYPHuod65wChrxasLgnpMnxALXzDnqSDuUV/DGeOpu3jR4okPD/yhArvz0Fo4+8CfCUeKtZhJMKefyV95n9g== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) by MI3PR08MB11878.eurprd08.prod.outlook.com (2603:10a6:290:77::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.13; Mon, 16 Nov 2026 20:03:56 +0000 Received: from MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa]) by MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa%3]) with mapi id 15.21.0615.013; Mon, 16 Nov 2026 20:03:56 +0000 Message-ID: <603d6808-e87e-4725-9b85-6da9802747ef@virtuozzo.com> Date: Mon, 16 Nov 2026 21:03:55 +0100 User-Agent: Mozilla Thunderbird To: vasileios.almpanis@virtuozzo.com, ptikhomirov@virtuozzo.com, Konstantin Khorenko References: <20261116-ovl-use-orig-ve-v8-0-dfe427bfd902@virtuozzo.com> <20261116-ovl-use-orig-ve-v8-6-dfe427bfd902@virtuozzo.com> <010701a1e5dc1e83-34af28a6-7b0a-466a-a250-37c67359906a-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Vladimir Riabchun In-Reply-To: <010701a1e5dc1e83-34af28a6-7b0a-466a-a250-37c67359906a-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR3P281CA0053.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::6) To MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI7PR08MB201474:EE_|MI3PR08MB11878:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f6d46f7-e2e0-4f35-b9a5-08df441cbee6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|366016|376014|1800799024|10067099003|56012099006|5023799004|4143699003|261026121527099003|261026140227099003|261028144727099003|261022105027099003|261021121427099003|261102123227099003|261009223027099003|18002099003|22082099003|6133799003|3023799007; X-Microsoft-Antispam-Message-Info: /NXuq7U3R+czlws02uf0XEYYxkjzNaCxq4ahYMXyk6v4BERHe5yXgqYROFlQ6apsE6SRpcKsnKHkHbbGt5S7A6brN8AQsH4XM2vlIx4ghCzvrOf12rSPtu6K1Gjx3AC2e0Z0LMkc4r8lrbCLF/2wlbUcqK0nptsK/dGIjhcVVS5S1rwvViQJO+lBIKb0AB5e3+/mZ6rx4a6ng9vHstOCk1+/JaoKa6NpqwsE28swf232coEp85yj4wKcECQLHkjFfzeHHMtcoqg+xNgsTcc1hz0G6UpAg3EhPO2ln9MZuhRQEiOToHpo3mUGhm+uUCaS1WMVkrCSbEDy5OPdOqgMrVCTRcHU3sFE61ikRDL93zjp6hC6/9rwQRVWF+g6IBh7q8CANXLq9lXI06TfrICf8rBKLVg2KUB2BUIaYlREztdFPHT5+g68C2ILSvDfNZkESjpD733c+B0gWL4RnLDwLAbzTVBNRirqgFJ2Z21SMf9zEu0/WaVrYmzXeadwfp4Uk2a6fWYqOOMtdj+Gts7orxrSUg58E1aWdAGxZRrW7KHNvqMLhSvdkb+a9+mbNsbBN0idzv6f4ZxXEGKEwZ4XZkX5D0S5ZOB2xpVSeF5DAMF0HqE88RqQ7SV86Bbw48I4c1JQamq+MWbx2a/iOmMqogiWrn1ZPuiWH6dUzXOqriA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MI7PR08MB201474.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(366016)(376014)(1800799024)(10067099003)(56012099006)(5023799004)(4143699003)(261026121527099003)(261026140227099003)(261028144727099003)(261022105027099003)(261021121427099003)(261102123227099003)(261009223027099003)(18002099003)(22082099003)(6133799003)(3023799007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVBOZUloM1FNOWk4NkxtQ3RVbm9VNkVrWkJlNjVncEpIL1pnOFVRcUI4ZHNj?= =?utf-8?B?SGhTQlJwV0kxaDVIWkQ4WnRaK0g0NUdJNlFwVTNYUThZcjlEMGFFMlFrYXZH?= =?utf-8?B?VTdkQkhHejlyY2NqWDZyYkQ2UWlpTzBPbS9QcmFQWVQvRG95bS96TnZ2a1FN?= =?utf-8?B?NUJ5Nkx3NnlINzZFcE4reVZ6M1c5TjB2VCtBWDFrQlFZWExHdlNYbDI3Snp6?= =?utf-8?B?d2J3YTlpeTVjM0VLZEsxTFRQWUVLQnNaMTJnU3daYjBMMTdIZzJ5OHF5M3Uy?= =?utf-8?B?OVpBa0crRmYwaHlhR2pxd0xxd3NENVBpWjJseTNpTUtKcXR0SmtTVHN3L2k2?= =?utf-8?B?MGl4aEo2N1JLVVRXTXA1dEJNZU12NHJrck1TOURLQllMZTc0V3lkQTM3eWx3?= =?utf-8?B?eXpGUVl0dVZQMmJDd0g3RXdjTEQ2ZGpNRE14dTBlSDFPU3VwQnZpdVhpQ2dC?= =?utf-8?B?YXd3VktFcUZPeDc0QlRlMjZHaFd6WG53ei92bVJxMHRnS3M1LzdnZFBpS3Yw?= =?utf-8?B?QWxQcnBkait6cHpIVVdrWFM0czdzOFhVZlg2aGErNk5pNlg4QUQ0ZVhwSGlI?= =?utf-8?B?M0IyeW1id01YK3hBY0h1a3RzK0pHMGVaUEVRcXNjWU1PUDRpcW41amxoaE8z?= =?utf-8?B?MzRRVkxGVk1rOUpRVWhaZDhqU0xzVks5UGdYemh6WEN2YzJCd1FpbFN3d0R0?= =?utf-8?B?QkZIUHJJNm9IT1N2VUozbDc5RnZnMGlVMWthMXY1eUJuV2hCdFVaUG9RRDI4?= =?utf-8?B?R3RUR3NncmNlaGxRODArTnl5b3RzRjBaVHlCR2FvcnpPSFg4Rnp3TmFUSEE2?= =?utf-8?B?R1h2YW1RaU14WGN2bFUvZVN5L2xkcGloLzZjSmVJemhrOG1zVGlZakZDM0Rw?= =?utf-8?B?VHUyWTF4UnR6Rko5SmxHdS9IcUJ0VHpWYjBhR0hvWVpxeWxqOUxyaXVjK0pF?= =?utf-8?B?RlgxNXJEK0NvTEsyampBTnhWa0RvOUdWN0JxeDUvaTg2QTB3Ym1tUUVabU5a?= =?utf-8?B?MWppYkdtZHNmeHlDMWt3YzlXb3ZDWTJKNzhBWHJWSDV6M1VWNXhXbis0YmFn?= =?utf-8?B?SEMwUW5qbXF2WHE4OTNHcnNoRGErNkZvOXVZRUFZOWY5Qk9mRks1dERhNFNo?= =?utf-8?B?aSt2cFBYenduaWJoUzFwY0VvRWNlc1BoeE9hVEFUbnZCRnZ5REd6bjhDbU9N?= =?utf-8?B?RG9yT2VYWUt4VytNeG5Od2NKc08zZ2hnbDIrdjkvRjlCdVNhYXdSc2Z2T3ov?= =?utf-8?B?cUhNWmdqTTNoRHRyYlFralJyT1NMYURlMXB2cGpYK0tsL0hKQjRtelV5YTJS?= =?utf-8?B?WmR2WlNScG04d3ozdnFGb3h1YVdVVVpZVURoZktVakFZZENQcFBIeHhxaVMx?= =?utf-8?B?bEtCV0JzaXZ1VFVkYWFid054SlNnZ1NOMi9obWc1Y1pXSW9BOGNEZUw5WHF0?= =?utf-8?B?TVdFTlFZNXgrU21adjE2d2VtN1BzVjZZcmdPL0syQW91U2NSNkhVeFlIKzF6?= =?utf-8?B?VWJiZjV0Qmt2UEd2ekdqdnUrazdGQXE3QmY5ejFhVVpxblBNMmdGa2RSRERa?= =?utf-8?B?d1ozcS80dHZyNVFCd2JIU2ZCQWpuOFpJRXU0dkdHa25ZbDBidGFQc2UyN3dy?= =?utf-8?B?TjVkcmxQRHlYc2NkQmo5T1JnQ1grME53WHNhZWgvSVBoa1VwYWhBam45WDQ2?= =?utf-8?B?KzdLZy9NTk1ZODZlcEo1VHRTWVBvL09NaFU2QkY0SjJ6S29JdGVCTnliZE15?= =?utf-8?B?cEhxQmF6UzRrNEhKams5ck9WVDc0ZzVORXpYaUNlR0lFZldERzYyb0tFa2Nx?= =?utf-8?B?eGdMb3dwcU1BOTk3WFdiNTNrTEN6a1hmRVgwSWhMVWh6RW9NV0NURElrZUZH?= =?utf-8?B?dUMxd2U4OVB4RElFdkcxTzEwVURPK3NFbkN1UFQyV3dETTIwNjRadkp0THFS?= =?utf-8?B?TG93SDkxVXZGYVdkY0QxZGpSc3JBa1BvMHdlQkxsN3NiTktpZ3hGOWtiUkl1?= =?utf-8?B?WXhXYTFrZUZoU0t2TE92bTNXM2xGaVg4WVh5ZCtYNlljamVMekxwRmI0UzZ6?= =?utf-8?B?dDBRdzBRU2N2RkFpaUdoeENuVVZNN3k4eFNoQ1A0NlI1b2t5Uk5BU2tKUjV1?= =?utf-8?B?MXlpNGUyVDJacmJmSG1GOXJITHZIbzhsVXpRaFU0SnlpWEJOUm5PN1JTazg2?= =?utf-8?B?RXpNaEM1RzVsUjNJMnluS2djTGF3UXFYdmNOWWhIT2FHUG50MlBCa0VyenV3?= =?utf-8?B?OWhTa1dwVVJwc3BXY1dMN3VjUTViaXA3OGNjN3JtM0pjZDhKNlRQS3llblVi?= =?utf-8?B?TkFGejdJVTd4TDBONVNTS2p6ME9SZlhaMitiY2ZWL291aUhwL3N5R2Zuak9j?= =?utf-8?Q?t9Bkrdqs+yfcNgLk=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f6d46f7-e2e0-4f35-b9a5-08df441cbee6 X-MS-Exchange-CrossTenant-AuthSource: MI7PR08MB201474.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2026 20:03:56.3262 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: krH7ADe8GIGeAZegEmMoOkjH+NGPA8CSpP/1//iHQ6VOyCVp846Xyp9uDQ/HiUn0oDcwCzLlrwhBicYG6oWmBZlWFsrvvKwD6Vlst6pCArY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MI3PR08MB11878 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v8 6/6] ve/overlayfs: Override VE together with creds X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 11/16/26 20:36, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 1 potential > issue to consider: > - [Low] ovl: failed-override state is signalled only by an ERR_PTR > sentinel Already replied, ignoring. > -- > > commit a0d9d382fd928f27fac00bc80946b595505573d9 > Author: Vladimir Riabchun > > ve/overlayfs: Override VE together with creds > > This commit changes ovl_override_creds() to switch the VE together with the credentials. It now returns an int and fills a struct ovl_creds_desc, and a new ovl_revert_creds() undoes both. All overlayfs callers are converted. > >> diff --git a/fs/overlayfs/util.c b/fs/overlayfs/util.c >> index 817563215001..6c244ab2cbf1 100644 >> --- a/fs/overlayfs/util.c >> +++ b/fs/overlayfs/util.c > > [ ... ] > >> +/* Accepts desc from a failed ovl_override_creds and does nothing. */ >> +void ovl_revert_creds(struct ovl_creds_desc *old_creds) >> +{ >> + if (IS_ERR(old_creds->ve)) >> + return; >> + >> + revert_creds(old_creds->cred); >> + if (old_creds->ve_overridden) >> + revert_ve(old_creds->ve); >> +} > > [Severity: Low] > Is the ERR_PTR check on old_creds->ve a safe way to tell a failed override from a valid one? > > Callers such as ovl_llseek(), ovl_fsync(), ovl_getattr() and ovl_copyfile() call ovl_revert_creds() unconditionally after a failed ovl_override_creds(). That is only a no-op because override_ve() leaves an ERR_PTR in desc->ve and ovl_override_creds() returns before override_creds() runs. struct ovl_creds_desc does not document this contract. A descriptor that never went through ovl_override_creds() would reach revert_creds() with a NULL cred. A comment on the struct, or an explicit valid flag, would make this robust. > > Also, the commit message says ovl_override_creds "returns both old cred and old VE". It now returns an int and fills in a descriptor, so the message is out of date. > -- Best regards, Riabchun Vladimir Linux Kernel Developer, Virtuozzo _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel