From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11023083.outbound.protection.outlook.com [40.107.159.83]) by lore.virtuozzo.com (Postfix) with ESMTPS id 5E123803BB for ; Wed, 11 Nov 2026 14:26:48 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sIqFGN5DEA/6XC7WpxLDiG0VrSZ/4H6Z6W+vkXeBMJUGIWQgbmh6vFRZmtegNtwEk1C4ax/e2Ar9bEvdbayyNY/cNPdvp9nH8Yd+fyooyek8jJGq55fk/xJ6rbp6kJdyFYLL8M9knKOo1bifW1SqnC5h6bgkeHUpT7olvwLvnSVzzmKJzf2lleIr76UR1La2ktLD3M693tQCCQcdDFNwly1cGTgNcSJG5k4LmW/m020ykU7PgI+mCGOMAIsqX5CLn/QF+QkZEgh4qPsIFKjBtCtgFzq5JGg023b8E+pnVQu1urG5wEkPrRSa1luVIsMTyFPc235Nf/iq+58tgmLqYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ahi0vjJpSe6rKkB+jS6tCQ+eHizvNUVkQ2qfVS7p+Vg=; b=lXS0Vf18iXOq1XT73j7n16WsRMccLS2dvFNmhQldirfQqMDAhLiV9TTtod7BKtIHNJ8ooesqFiP+ZcU12psOC6O49SAPBCQh62RCL+DFGRkA2nevCGNIUorp9z+kWXjDh3uafymGHdOSvDpe+VXx4R1DeqezwvUhn6TFK0jqAYzzguKARccPvWKcXEqN/i+UOJlybRDUTgyyofjG5UNUteLb0S/DE1MbJxp+YDBhwxfKccprp9wjZLufjVipDlIJpAndTIz4JCG4TrQOP5lE8TPpIr3PEcUtledviExUJmjquBHRrP47jTxzT5Ypbz9UM74jP0qKTBXDHHPAVcB/Aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ahi0vjJpSe6rKkB+jS6tCQ+eHizvNUVkQ2qfVS7p+Vg=; b=JnwENFiTFnzLkCnNoLat/7rrItBs8BaH2blSXNWgfv62Dl3dt9XopUou/XXOuR1nzqhIjqNT+AobpiIwznapv8gRhKTXKSBhFGmOqXBCOGS6uodQYOUGmR6FkthuoFwybEYwmZOHdQMC4VBGdmRvLv6W0NIsUntAqysoKFGl7uHlIoqtC5lmUOqFyCGbLGL5QDLUkA3BSGD01BqjvQ6y0vYRQcjyRtRnObgSdgaur3MPcWI7FLX82KS1e7nP1XSdiz3hA2QwddU2rt9Nsrp5EthSN5y1g//Rdpfhltw4fw5y68vq9sBp6+ZHc1HZCoH2/olLf20yKVC3GHTrpTTpxQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by VI1PR08MB5374.eurprd08.prod.outlook.com (2603:10a6:803:12f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.592.12; Wed, 11 Nov 2026 14:26:45 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%4]) with mapi id 15.21.0592.013; Wed, 11 Nov 2026 14:26:45 +0000 Message-ID: <62182083-d959-4cbc-9bbf-2859307fdf20@virtuozzo.com> Date: Wed, 11 Nov 2026 16:26:43 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH hci-8.0/8.1 1/1] i386: keep only requested SVM leaf features in x-svm-features-compat #VSTOR-154398 To: "Denis V. Lunev" , svt-core@virtuozzo.com References: <20261111111917.4012602-1-den@openvz.org> <20261111111917.4012602-2-den@openvz.org> Content-Language: en-US From: Andrey Drobyshev In-Reply-To: <20261111111917.4012602-2-den@openvz.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: ZR2P278CA0053.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:53::11) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|VI1PR08MB5374:EE_ X-MS-Office365-Filtering-Correlation-Id: 74d22638-cd07-4faf-42ad-08df3fffd00c X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|1800799024|366016|4143699003|10067099003|56012099006|261028144727099003|261021123027099003|261022105027099003|261026121527099003|261021121427099003|261026140227099003|261102123227099003|261009223027099003|22082099003|18002099003|5113699003; X-Microsoft-Antispam-Message-Info: sL54MQVq9JrqfeCGZXhK9WEuY5crim0gBfzEuYQBQ+I2AMhL/YC/3Oq6mVhJKl+d01lbD97To1Mql0YWboInPrzOPe9cl8yEJMgy2Pq/3qd+yAQjcqfm0uSSyqMPQs0SOrfH4UdwVOQwqIitWv5sruynhcpkWLQI1WQqpy4OmVcSvtSmMxAEDXwu4ZUVsmjEnHLsFJC+btSHHhlMLFeipvUlCLdoXvOW2txb1E3VOKVGHnoVF85bbHTGLy+o0Elwv04zOn8Mcc4ufDGw0iu8+/alNwP1ad8eSN0HMl9QDwvDWPMNcbOoOCPF4Euj0dGLnaMEiGIPM9oOedh19VBIfyzX9m+omF0LMd/tAQJrLpxpRryF1a1JKDFcEDkrz+hpVi1pxDpoZZZz6k5OWpBBZuMkHJL4GzYlZkdR/6N7hwo2Ml1sNQQyKgac0fkTUeRTZgTffgSxe4jg0g2J4BlVOh9JuY7NPu+8ZAeOY5O5YRzOg1iDaPN89lqWB4LHjmUN9nB2AG/wSv+Zo+86hE/0KOfK8N3YKJ3nXgNVo1ZYmNreldV7bE75hE+0QhbJSbqz8UI+mD5NoaOwnpacvBuFL7YFk717TeMuuMCVAkCRVL0kpCY6U3qxutE6nJ6v6Sxo86ur1wB4Bp2c95zXISJwpGOWfHZesb3CPYEQbvGukHc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(4143699003)(10067099003)(56012099006)(261028144727099003)(261021123027099003)(261022105027099003)(261026121527099003)(261021121427099003)(261026140227099003)(261102123227099003)(261009223027099003)(22082099003)(18002099003)(5113699003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OFpEOTI3TlpEWSt1YzlMaGJmTFdJMHhmUm9vb1VSMFlCaVNHRGZ2WW1YZVdo?= =?utf-8?B?S3I4MTBvMlFkQ0ZLcERYckhQVXlIZzdFSU80RThSRytqRlpBRWUyd2t4cmVu?= =?utf-8?B?R0Q0M0ZEUk9BQmhIOG15aGlRUm9IVVVtMDNEaU1oY1IrOWU5Mk9PNWZvcWNv?= =?utf-8?B?M0RreTRNK3FRVXg2NERHUTBYSCt2bTNJTmpzWC8zRmxTVWNxVFV0ZnlPTVJ3?= =?utf-8?B?ZVltNkZhOFBRd1BJc2R5YXRyWDRuNStGREgvZVloWndBZnlRWVZnaU9GZTBz?= =?utf-8?B?b21vd2FTSm5uWm9iUTBEWGlkTXE5blVPQXFlaTZIYktzZlZNc0NnTEthb1BL?= =?utf-8?B?MThXZjJVK2NjTTBSTjdpaFNIbFhadDYyS3JtZUNpYU8xN202dzhjbGRGeXla?= =?utf-8?B?OFFYcGxVNWIzZnVwUy9HRmlqNWZ2bjJuWlRPenJLMHFzWmpvcis0bWZrVjNx?= =?utf-8?B?MTcyVEoxOERZVHlaOHhpeFppYlppRStxMHpheVVrbW9EUTU1d05VQ3pOdTcr?= =?utf-8?B?akJydW1BdTlOTW81SU02U1hrOGhONUVRY0pxQXBxajhyektyM1NYbFRaZ29y?= =?utf-8?B?WDM1azJ6NW5sNUVISDB5VUMrZVkybFk4S29CY3NvS0wycFYrbnlZcmY1OVds?= =?utf-8?B?VDVWdjhqbzFUdEYvQTJCWGR6UnRZTklCa3JxMFBWT083U2FLTDRTbEFiUjZk?= =?utf-8?B?UGY2SXQ5Q0VqeEJyNTZ0NG1rMUtrYXhDVnZOaWV1S1Zyc0dSQTl4Ukl4T2xX?= =?utf-8?B?cFMwbDkvamJjbzBaNFYwRnRrYUZ3dFBpNmJtM0xPZFF1WXE0bThGM3hwR0ly?= =?utf-8?B?NkpxOFNxa2ZBV0wweWZGdHA0ZDJ6dkowL0c0bDRETDdmNG5lRGVvVElEamty?= =?utf-8?B?UE5ZUG9QcFU2QVYrTmlxRCt2ZzhibnZFZWNtSHhUWEpXQ2E3czZ4OWNra0RC?= =?utf-8?B?cXc0cURSb1NZSFFrWURpYWduempWZEtUMWhqT0lPa3RjK3lua0ZFUTA2VW1K?= =?utf-8?B?R3RKbFNralR6TkluL0N6dURIbFFZKzhTZ0FwdnFLVjNVZzdXa2JMeWhreFlM?= =?utf-8?B?YmJVU3VPMWptcTk2T3BQZE10OWlBN2c3WW5UK2tFNnNEYjJoUXNuQ3JKeFkv?= =?utf-8?B?dXNjVjRsbnRIYXRPVCtxY1RLQU5VQW1RdVFmNG9TeVh4TDJyci9qMkRIcHll?= =?utf-8?B?aUxCVlNlY2w5QWc4N1p1WExrL1dvTFJqbDc4dXhDbUJoa1YyNjVvcGlOQXd2?= =?utf-8?B?aDNRN25vZzF5MUFtSVZIZk11ZXc5Z2thak4zdUFDWTl0bTZHb2UyMzB6Q1E5?= =?utf-8?B?K3kzd3RGZ2svT1Fqa3dqdkcvVkk2ZTkxY2EyZi9XN2d6RmV1ZklnZlM0dmlC?= =?utf-8?B?VGY5aVpyWXN2VTNkUXh1d3dIOHJYUTNacUpCbWtPRE9sbThwMXF2aEplbjlu?= =?utf-8?B?Q2dmUkhrS1N6ZThxWmh4TEpNNGlLV2xLWGQwNUtudlZIV0xhT3piL1Z1R2dT?= =?utf-8?B?bHU2dXhXTHc1dng2aU1jR2t5UXdCL1ZyZ3VUcnhWTWxWVDV2dE91Ly83K216?= =?utf-8?B?YmlUdFZxT0gvYjhXRGlMTE5HNHMyclA3S3lTOHIxNXZjVkYzM2Q4R3VTN3d4?= =?utf-8?B?Z0FVWVZIa25ad0lnTzVvK2VvR3Rxclgyb2NrYTI2TzI4dGpQMDh5aU1KTzFC?= =?utf-8?B?cUw1M1dkSWNscWhEYWhLWXhiVDg4dkxwU2luSkNYSlJnaUlhUnBuam1oVzR2?= =?utf-8?B?bVF1aHM2dDFRVDRZaEVJTG1iRlRNRHg3bUMydmZXcExEWnY3dDVWaXBCT1Fl?= =?utf-8?B?aVFWVnI5TGJoeThualY0U054Mi9PSTBicmQ0VTRiekZNcUpCVU0rWHBnUmRw?= =?utf-8?B?TlFQeURJaUdlbm5Bd21kbjMxUTlPSzhPRUhSWVdRdnh4bUZBUHczendRdzVR?= =?utf-8?B?dWloT21sbTc4aVU2K2RmZWl1Q0xhVWo1a1Q0SW9FdWovU1VjSFBCcjc2dWRR?= =?utf-8?B?cmUwWFJ5Y09leWdIbDNtTkhvUkdxQmM0NHRNcGN4ZEo4d2Zadkh4TytjbmpJ?= =?utf-8?B?SE1tckV6ZnJoQjRkdXI5Mk9XcVFONTg1MkpDbU9JVllCdS8wazd3d1dON0RW?= =?utf-8?B?Q1dkM1R1Z2NERTJBQ1ZjTmFRd3dObDd5em9QYncyeVNqa1RUUXQ3Y0JFTGUy?= =?utf-8?B?Q2RNRk5ReWI0OTZxQ3c0aDNZNFFwYUNzd3R0MkcvN2VUYnJvV1dkVU1Cbjls?= =?utf-8?B?WU9JZm5WaTlpM1A2OHdlU2N6VXVuK0VLQUhGUDFianZwcG16aExrVm92Zytr?= =?utf-8?B?WlNPZUJveklTaVdiM293b253NCt0YlVKd1RTSXdqb0w5dFVPcUN2YkR0REov?= =?utf-8?Q?TqQ6SHZFHJC1N6oY=3D?= X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74d22638-cd07-4faf-42ad-08df3fffd00c X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2026 14:26:45.1317 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yDqNajltwQhEFV5bh8CEzZEWDmKDhT9uaOItEb83cu1+FnGfwJdrcLYsmoc2+LExkar6Ne2lNfl7vDx5BU/vcZLwKE5GGnhllDxONeF3mpk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5374 Ack Applied to hci-8.0 and hci-dev On 11/11/26 1:19 PM, Denis V. Lunev wrote: > From: Denis V. Lunev > > x-svm-features-compat keeps every FEAT_SVM bit when svm is off, > including the defaults of the CPU model. QEMU 8.2 drops those through > the dependency on svm, and libvirt checks the QOM features of the > incoming guest against the definition sent by the source. Every AMD > named-model guest of a vz9.0-9.2 machine type without svm (the KVM > default for all named models) is refused when it comes from HCI 7.4: > > guest CPU doesn't match specification: extra features: npt,nrip-save > > so hci-upgrade from 7.4 cannot evacuate a single node. > > The compat is only needed for Vz7 host-model guests, which run with > npt=on,nrip-save=on,svm=off given explicitly. Keep just the FEAT_SVM > bits requested by the user, both against the dependency on svm and > against the host, and let the model defaults and the bits -cpu host > takes from the host go as they do on QEMU 8.2. The guest cannot see > any of them without svm, so its CPUID does not change. > > Fixes: e51cdbf863df ("i386: keep SVM leaf features without svm on vz types up to vz9.2.0 #PSBM-144630") > Signed-off-by: Denis V. Lunev > --- > target/i386/cpu.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index e22fafeaef0..6b68eebc35d 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -8998,15 +8998,15 @@ void x86_cpu_expand_features(X86CPU *cpu, Error **errp) > for (i = 0; i < ARRAY_SIZE(feature_dependencies); i++) { > FeatureDep *d = &feature_dependencies[i]; > > - /* CPUID leaf 0x8000000a stays empty without svm anyway */ > - if (cpu->svm_features_compat && kvm_enabled() && > - d->to.index == FEAT_SVM) { > - continue; > - } > - > if (!(env->features[d->from.index] & d->from.mask)) { > uint64_t unavailable_features = env->features[d->to.index] & d->to.mask; > > + /* CPUID leaf 0x8000000a stays empty without svm anyway */ > + if (cpu->svm_features_compat && kvm_enabled() && > + d->to.index == FEAT_SVM) { > + unavailable_features &= ~env->user_features[FEAT_SVM]; > + } > + > /* Not an error unless the dependent feature was added explicitly. */ > mark_unavailable_features(cpu, d->to.index, > unavailable_features & env->user_features[d->to.index], > @@ -9168,7 +9168,7 @@ static uint64_t x86_cpu_compat_kept_features(X86CPU *cpu, FeatureWord w) > } > if (cpu->svm_features_compat && > !(env->features[FEAT_8000_0001_ECX] & CPUID_EXT3_SVM)) { > - kept = ~0ULL; > + kept |= env->user_features[FEAT_SVM]; > } > break; > default: