All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>,
	khorenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 0/2] dm-qcow2, dm-ploop: do not merge discards with gaps
Date: Tue, 10 Nov 2026 11:03:50 +0100	[thread overview]
Message-ID: <741fac77-e0ed-45ec-9365-5022c8220eab@virtuozzo.com> (raw)
In-Reply-To: <20261109153619.277888-1-andrey.zhadchenko@virtuozzo.com>

LGTM

On 11/9/26 16:36, Andrey Zhadchenko wrote:
> The block layer may merge non-contiguous discard bios into a single
> request when the queue allows more than one discard segment, and the
> stacking default for dm is max_discard_segments = USHRT_MAX.
>
> Both dm-qcow2 and dm-ploop handle a discard request as one contiguous
> range taken from blk_rq_pos() and blk_rq_bytes(). For a request built
> from bios [0, 512) and [1024, 1536) they discard [0, 1024), which hits
> sectors that were never asked to be discarded and misses part of the
> range that was.
>
> Set max_discard_segments to 1 in both targets so each discard request
> always describes a single contiguous range.
>
> https://virtuozzo.atlassian.net/browse/VSTOR-154159
>
> Andrey Zhadchenko (2):
>    dm-qcow2: set max discard segments to one
>    dm-ploop: set max discard segments to one
>
>   drivers/md/dm-ploop-target.c | 1 +
>   drivers/md/dm-qcow2-target.c | 1 +
>   2 files changed, 2 insertions(+)
>
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  parent reply	other threads:[~2026-11-10 10:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 15:36 Andrey Zhadchenko
2026-11-09 15:36 ` [Devel] [PATCH hci-8.1 1/2] dm-qcow2: set max discard segments to one Andrey Zhadchenko
2026-11-09 15:44   ` no-reply
2026-11-10 17:46   ` Konstantin Khorenko
2026-11-09 15:36 ` [Devel] [PATCH hci-8.1 2/2] dm-ploop: " Andrey Zhadchenko
2026-11-09 15:44   ` no-reply
2026-11-10 17:46   ` Konstantin Khorenko
2026-11-10 10:03 ` Alexander Ivanov [this message]
2026-11-10 17:46 ` [Devel] [PATCH hci-8.1 0/2] dm-qcow2, dm-ploop: do not merge discards with gaps Konstantin Khorenko
2026-11-10 17:47 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=741fac77-e0ed-45ec-9365-5022c8220eab@virtuozzo.com \
    --to=alexander.ivanov@virtuozzo.com \
    --cc=andrey.zhadchenko@virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=khorenko@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.