From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020141.outbound.protection.outlook.com [52.101.69.141]) by lore.virtuozzo.com (Postfix) with ESMTPS id C865E80E7E for ; Tue, 3 Nov 2026 21:28:28 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MhDFH0y4obYExt+tLDNtlEcKQlgIDNoCFflJx7Y7dYjCmq6PZtJqxDabSVHfz8howJZm14Qz4sb8o3IuFzYEq8TyXr4aIWpeNieIFKZZ2BTqh1npzf3z86zyqxNTpG35SQDcG/DCVOsr2g8E4m0fVvq247c4OPQN8unvyoLPx4ZCbZwQc+zTKlefa/7055weF9YRJS6FynZRea6RvUiKLyUskUykso5XcC/e8Y0EVuMj1JFvAPm8Vz1yL+/pdwLfhy/8xZnGESg7Lny2hav3cJTjR7GKDNh7ypjwQEnFeVFeVt8kqyAuvX2e6bLkrstAddoeE3WwimQKN+XTguUF0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hxa0dBZD3XH5b1VVNb91C/ZkUt0kWP9hWG3/o1Gg0Ws=; b=JoNsdr75tYw3MHLKf8mAd3wLfahel846hqxry+RNYZgTsvd6MN4FY8uhg6LLiVNHcx7NuHYrUmKQQtpNx+umaqg6Kn7oZK1N+5lKoAvumni/+9ODDnA0uH9x5eOWWwAasvvGtaGq+g4zdAauyxlbV2p9wfgPcYqh8ipFubwW9//JPLVVw3p3lzMQHYlZXWvtxauvRdPSxrKq/FcCsMbO7Kx3D7YL+mi3SOaMWY4DLmFAtoizwqoKsBxq+9uzKEVeCAli3QU8F4WNL8/dtJyC3M+QsfAs0EkUK1k990KKYgA2VthhiLa1jLWRuqjTPTQyrUGivtmSCe8drVXcLH5YaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hxa0dBZD3XH5b1VVNb91C/ZkUt0kWP9hWG3/o1Gg0Ws=; b=aQNznRQcheto5O1UJgV/yiI1/xs5IW6QeK+ZRU5pSeOOvTXcGKQE4Aiw878j7kFQgkoKg7F/qs8Lbt2X3wDCqJaKmfRwdxt8XYJMI/RtGlcewzIlO4l01yxVkcUz2eaDrCb4/vpUrFTduUKaKYBLQh3S6ug68n4Dp1mrvPDNRILC4RWPhGXCnB53hsN5E2k+pgvRyzk+B/u/qchLTZvx2ilsvw7Bl33YY9ZT5O0DrS+cXfLp1s4HtpVOb+JT+WC2guApggG4+290r1atIzPOkjHekXwM8J43eW4J64NU05n0G8f6huRLQbZp9wNtuItQoojSfsm7/41mIr4ZAx4niw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from AM9PR08MB5892.eurprd08.prod.outlook.com (2603:10a6:20b:2dd::16) by AM8PR08MB6498.eurprd08.prod.outlook.com (2603:10a6:20b:364::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.592.9; Tue, 3 Nov 2026 21:28:26 +0000 Received: from AM9PR08MB5892.eurprd08.prod.outlook.com ([fe80::94bb:633f:1f55:4bbd]) by AM9PR08MB5892.eurprd08.prod.outlook.com ([fe80::94bb:633f:1f55:4bbd%5]) with mapi id 15.21.0569.011; Tue, 3 Nov 2026 21:28:26 +0000 Message-ID: <762129ef-da3b-4d15-a1ee-41b3afc9319b@virtuozzo.com> Date: Tue, 3 Nov 2026 22:28:25 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH hci-8.1 1/1] target/i386/kvm: fix latched INIT lost in kvm_put_vcpu_events() #VSTOR-153069 To: "Denis V. Lunev" , andrey.drobyshev@virtuozzo.com Cc: svt-core@virtuozzo.com References: <20261103181817.834166-1-den@openvz.org> Content-Language: en-US From: "Denis V. Lunev" In-Reply-To: <20261103181817.834166-1-den@openvz.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI5PEPF00000986.AUTP296.PROD.OUTLOOK.COM (2603:10a6:808:1::81b) To AM9PR08MB5892.eurprd08.prod.outlook.com (2603:10a6:20b:2dd::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR08MB5892:EE_|AM8PR08MB6498:EE_ X-MS-Office365-Filtering-Correlation-Id: a590eef7-7e05-4cde-74bf-08df39f16590 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|366016|10070799003|376014|261028144727099003|261026140227099003|261102123227099003|261022105027099003|261021123027099003|261021121427099003|56012099006|5113699003|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: Jskbp/ngXBIWBJLLcWXW4njr1TpThkBcHeHdpg4N7oQWr/TChWeNnd91Si5Y5+B5qQxUuqCxAi+xvg5imlMfs7J//g5MgWVtpYViG/74mtADBYEn2sLnKj7NpPiFXgZ8ASd8iXocKptoO2suFXltlBTRC1RftiLaSvdajLII5veJPUaNoJwc4lr9SD60ltfzgicMVtqf1mUSQricpOA3PNFu8uNoArDjV0JH5yujUocJR0+oaNyokmFf21BgWz9/S4PuHv3g9U5NbOqNf1ifri37NaWuvnrkF7Z7uMN0paKo7laHNOd6pFl064cDsgo1W8IKKmkGaiGSHndzh1jSAja+wnTa/V5TwbcTJsM6mA8TVE2go7Lqn6IH8aNi8XJa+qe9SmVO084qy/ILRU+Ey6y7V7KSTixw5DhDSGPtfQl3r/8Uk5IPuDimq7vB/Gip21GZQrinAnKtoyk6cV9lUCMRr87u7ySSTLhzz5wwiyGhV6n+xDkaYFEe7wRWrgG3SqmeOPxoUlRGKPv4HSiLt2NEChE8li6Y5KdegQf2sNyyrabhs1kmjffd7PDb6tZlzCe5KU4/KTNyzzdCCX1WcIHrGrvp67kRV8r271qxKWTfFYh8c13M1SjKmjbIKCn2D5mliL2EFsT9iVSYThqma2CXF/Lyq6EsTF7/+t9CwPA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR08MB5892.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(366016)(10070799003)(376014)(261028144727099003)(261026140227099003)(261102123227099003)(261022105027099003)(261021123027099003)(261021121427099003)(56012099006)(5113699003)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmJ6TlRoZUczSlR4czhSNVdrMHNucDZrT3FmM3lnK3ZlNTNhT0t6MlMreTl2?= =?utf-8?B?TS81NkhReTVZakZEZGZZL0NUS1BZRklsUXhVZXpzaEQvdEpLLzF6WjUwZzMy?= =?utf-8?B?SEtBdVR3N0lyWGRYTTdlNWdjRE5uTUswQ01DMFZTT001bkY0OHJnNmczQjZ1?= =?utf-8?B?N1lrQlRhTXNjcjlPa3piQXRsU2pxdkozL3psZHFYN3NnQzM5aEwxVVhtKzlK?= =?utf-8?B?aWZUaG05b05vMFVrTDFnckpBa2VlSi9nWC8vaVhrOTNmNmQzNkx3V3BUbG9N?= =?utf-8?B?N1BlbGJ4T3VuKzhNVCt3ckNTNUhzSHNuZC9VUi94WFdoMFpJaFJraXArVkE5?= =?utf-8?B?dzNFaWRMeWZSWXU1WURTOUZSaHhJMkJvanNrM1RiWHFZc0Z2THVxQXRZSG9p?= =?utf-8?B?UGFqZ2JRMTdIcEdZYlVtMjZya2o4K1pnbFpvODlWcTc5MTBqUWRYYlErVzFo?= =?utf-8?B?NTBFOUlBcVpSQVV2THVQS3N2Z3ZzQXJ3ZG1EUENmZi8xc2IyYUQ1bHdSTE5W?= =?utf-8?B?T1JDWEhBZXhMS2RVcktGMG9NeTFzVkpBbXVtT2xJendRa2dTVmIzTTVxOGNo?= =?utf-8?B?MVJmZm15MlI5NVdCM21uNkRpSE9FR0JrZ0NSaFJlcU8wNHFhTmlJZXdJNzRr?= =?utf-8?B?My9ZWGN1Q3c5RENUOVJBR2dxT0tFWkZmZlowV1p2ZW8vYlBKWityOEJjZEQr?= =?utf-8?B?c0JHMXZJdDBldUpBN3p1UTN1L3FwRlFQVDE2bkZrVUJXbVJZdWRNcnFxVnVi?= =?utf-8?B?ZmlySEJPMkdkeEVYMEJCVmdOZWxGSnhER0g5RlMwbU5OVnduTWMxQXBMOVRO?= =?utf-8?B?YllPY1lLbms1MTZYUGh5OFVWbGRsd0lJbmUzOUJXTmVZZWtqOUQwaExPK3VI?= =?utf-8?B?dkY0L20xV0lMNWlBQXdXSGRQOW80b1V6TDl3V1N1a2I4bTlPQ0F5L1FqeXp4?= =?utf-8?B?NXo2TkcrNDZnYU9WQ2F5VnZjSjZ2YTR1V0M0aFFySHR0dksxMnZNaUdlU1RP?= =?utf-8?B?QUhCaUhSZ2pvaGFSTGRYVUJPWUhrYkY5YzJhcWNrdThTUFRONmN1SHNMNVQ0?= =?utf-8?B?RVN5aTlrUGNHNUtNb1FyZ0oremJYMmovVkpQRzdsdG9nVHBCZFhVY0Y0WFlr?= =?utf-8?B?aVBnV0FrK2lxTmZRZkdnM2R3dEFWSVYzL0ExMjdQanZFaGkySGFZNzhvSTBa?= =?utf-8?B?dmQ4d0RCcVlEL0xaOXRBMW1kb3Q1L0lHaG1ZbG82ZElPS09rcHlaMXAzV3VZ?= =?utf-8?B?RzhQbEhUT1RYQU1rTW15b1QyRThIaU5aZGdHQU9uTUI2cFNQQkg2SVpXbzE0?= =?utf-8?B?bHA0aHNKTU8zdk9mNVZ4TEFLb20zV2gvTzZKdTJwZkhJMmpMc01NNWg0Tzg1?= =?utf-8?B?NGljRUp4TzVUNi9SYWpJVWg4OC9YeHYveUNQTVpJVlBaVy9PWC9wYzA1eHor?= =?utf-8?B?bU9jN0lDYW5lSjhsUVJBV2EzYkpCSDNraWJoM3BlQm5Qd2x0cGdDZmRnakls?= =?utf-8?B?NkszazlhU3lIWnNJeUhrbUxMZUZXWm51NURRbTMrMlM5RHFEdzhFMGd3THVC?= =?utf-8?B?TGN1OEJxSFQ0dTJ2VjlQVDZQR2FCS0JvcE1PcFkzN05XU2lxeXJTa2pBKzJh?= =?utf-8?B?TWpDeVF4bWY1U2k2RzBXNlBETysyK1Myb2FOa3RMakt0UFNTNkhCR2gxclZv?= =?utf-8?B?YUlzWTVDMTJxSkFIVTRERTZ4S3ZldU51cmZjTkc0UEtMYnJFeGtkc1Q0bm1Y?= =?utf-8?B?RmhreEh4RVBnUStSRXRLbzRDTE1KMFdPK3Y2dWh0R1NteCtBTThFaE5VUFNZ?= =?utf-8?B?blVmQ01SS0V5YUxYTksyZi9ZaEN0V1lkVy9SM3N4emE4V3lkcWRuWlh3TlJs?= =?utf-8?B?M01vWXF6Z0tIaWM0Ujdzak1NTWEvNWZhR2h4OFFSVnhkM1lzOUVTd00rRVdG?= =?utf-8?B?SGFyY3FBdW9QdGxWVzI2SVJXN0JibWROZVAyaHJhRVdlUmlWS20zK1BtT2Nt?= =?utf-8?B?Y2FDWVpLell1dmYvZzkyZ3RQb1hEenQ1TmN2c1dyQ1VHZ01OUWx2eWo2eHBk?= =?utf-8?B?ZklldlFWOU9vcVdSQXZBNDRybERVQThKMkw4ZU91ZllOL0kzcTlpZXlmNmRw?= =?utf-8?B?OG9LUERSRGEyNHRWajNCZjhlOHpUbDcwNHovUmdINTk0NVMyQmNNMHgxN2Nm?= =?utf-8?B?Q2tiVGRqRk9WMjhTbTk2VHlPV0ZaUm42bXJvSGhPZmJva0FVK2w3cXhPN3lP?= =?utf-8?B?eXp0U1RDYmxsdThYSDNpMEJ6a2FhZ1M1eHcxNFRMUE5rUmt4a2ZrMTcrdktS?= =?utf-8?B?SldrakJyd2gwdU8wTXpkM2lpNXZqRVNubElja3d0V0JlYnp0eTJRRjRLZEpz?= =?utf-8?Q?AMq2Qb0sakXtNQuOn1njKd/+kSbtnDtAARfTR1hohrjaF?= X-MS-Exchange-AntiSpam-MessageData-1: C2Y1s9o3zVTRDg== X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: a590eef7-7e05-4cde-74bf-08df39f16590 X-MS-Exchange-CrossTenant-AuthSource: AM9PR08MB5892.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2026 21:28:26.6393 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aH/6JK0V6lysZtFsVVtrv25LLxKB8C/yt4ahrT+VSpJ72iv+FyFZpAANFv3aRtT8K0/bB35HQR/Pwp8l4eYVog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6498 On 11/3/26 19:18, Denis V. Lunev wrote: > From: Denis V. Lunev > > CPU_INTERRUPT_INIT is 0x0400, while kvm_vcpu_events.smi.latched_init > is a __u8. The assignment truncates the masked value to 0, so every > KVM_SET_VCPU_EVENTS tells KVM to clear an INIT it has latched for a > vCPU in SMM. smi.pending survives only because CPU_INTERRUPT_SMI is > 0x0040; normalize both with !! like the neighbouring fields. > > Fixes: fc12d72e1082 ("target-i386: add support for SMBASE MSR and SMIs") > Cc: qemu-stable@nongnu.org > Signed-off-by: Denis V. Lunev > --- > target/i386/kvm/kvm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c > index 8dc0f134990..6efe0e6b308 100644 > --- a/target/i386/kvm/kvm.c > +++ b/target/i386/kvm/kvm.c > @@ -5124,8 +5124,9 @@ static int kvm_put_vcpu_events(X86CPU *cpu, int level) > /* As soon as these are moved to the kernel, remove them > * from cs->interrupt_request. > */ > - events.smi.pending = cs->interrupt_request & CPU_INTERRUPT_SMI; > - events.smi.latched_init = cs->interrupt_request & CPU_INTERRUPT_INIT; > + events.smi.pending = !!(cs->interrupt_request & CPU_INTERRUPT_SMI); > + events.smi.latched_init = > + !!(cs->interrupt_request & CPU_INTERRUPT_INIT); > cs->interrupt_request &= ~(CPU_INTERRUPT_INIT | CPU_INTERRUPT_SMI); > } else { > /* Keep these in cs->interrupt_request. */ queued mainstream by Paolo