From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 638CD802A5 for ; Thu, 8 Oct 2026 09:52:20 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6989owOL022500; Thu, 8 Oct 2026 12:50:59 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6989owOL022500 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="Mm/Hs0FE" Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6989otGO022494 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 8 Oct 2026 12:50:57 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6989otGO022494 Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cc1b8088202so3856850a12.3 for ; Thu, 08 Oct 2026 02:50:57 -0700 (PDT) X-Gm-Message-State: AFuF++kMcnh49pMk45r+NkH3cC9iK1Qtf2iQtCB/qb5R6gX8/C0EmG49 +xN54xlLf0HgAzyfmKlKyiz45ax9fBiQrSA3YzaiWC6b5dAbfI4cjdOecdduvHw9O9smN1UFGbl tehb6Ioifequ5Pm2TrnFX/0Qq4a+DvW74HAPy8qV/4YzP2OmwFu3D6g== X-Gm-Gg: AYBFou35246w/yXIdcPhMEeyg2vrM7rmqCR9SATByIY9jS5gTG1EC7s+6YDvoAq3sJo Xu5qYBWUYGaIh6gc0/3ruk9I5BhztidSMMzceQ3/eetTcUck7NI29EtTBKCM0LqdaQK+MNEksQN 4itpXwxxgJm+7IZMEk5cOCF9kYXxUINOjvp3rRGT9g5pPKUpuIVI6GXiHY4sZKwdPbGqMdgathb FtjVlz/dgxoHlpA6/vrgBDrNldeSRrvA03rmeaE4GgIS8+TcVgoCu6G7Yj5+x4xNg1x2JcdlPkK F2Qtzyxwho84/7BsMCNJ8uyJDE/YW66VBuC8GlhkYc3bSyqy7svXaSE3/P8/77zcVRvOulJyqg6 Uvt9nHN8xlz6ax/n1XyNzb85BdBjtxhkBRKj+SYf3ztLVF3MvYlsRhH/LTU5tC7X0yiIZTzyFgP QONn34Oztt4A7boYqj/Cp2P+s5MODRRiny X-Received: by 2002:a05:6a00:f9a:b0:88d:8074:1a7f with SMTP id d2e1a72fcca58-891b4221657mr4027136b3a.12.1791453055295; Thu, 08 Oct 2026 02:50:55 -0700 (PDT) X-Received: by 2002:a05:6a00:f9a:b0:88d:8074:1a7f with SMTP id d2e1a72fcca58-891b4221657mr4027119b3a.12.1791453054690; Thu, 08 Oct 2026 02:50:54 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1791453054; cv=pass; d=google.com; s=arc-20260327; b=oGIokBVqICDN896mPJUKL1X8HXPX8RxD4i1zwt0ihwhHmxrP+yrTy1+LX+DAhcsop2 71CBHZNUlbQXAd8qk6D87HXHrc++Q+en14AYL+efF2TP2Xch/BPmYHhNGchrpimKWbJL WSt90new5rwWFUE9i40o2JDg6PqetqJ7t9MoTsctzWRT6AZOiWm9qw/YeqihXcmTi0fu Yq8C6+pr47VqYGdWzVTsWOODQiwDpv9hfdnPUCkW4rswrxMAOhbAzKG7RvgyczLljygi mxbmNlv0yHqL9hrfjMSu6KBUNGdqJTcATlRn51DUM0MvKS7Sp8wJD1qe3j8xejqDoKuA O/Vw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:content-language :references:cc:to:from:subject:user-agent:date:message-id :dkim-signature; bh=3CLVHS5VguWNtxHiyyYPDr0vI6S5deKgF3ke1SCf040=; fh=tMEsLKuDQ09qqpmC2pLav8OyMwzw4kazC9GBASug5RM=; b=byQsQz/kzcgfygRmYvDL5iFbQHKsgEQHZv4MaZZFcN7RjRcGCXWTTCL8cgV1hvxzOR vCIBwqpwGy1LlBiOa1iMmawkR36PlEEH42gK0T9msG78dZxNsmXCU3GNMgOSr2ipJAcb d2Htv1i8MkNJ3B4phbtsb7fzls/6ruOLbO6ZCyrP8OOo5Ou1lhmn49ok0GiWuGMR49Rn tgvB2hmbiEaqOlbOrcO754g4h1u8wZMYpM4z0QEs2tlU/i4p4aW+awOdesVgJkU/8sza 5n8vAoPdrt9n9vbw8kb3J/U1chVwVUzhr0ln5upybgeIzvG7FYoFI7HDgTQ6bPzMgE/N KPyw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b="Mm/Hs0FE"; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazlp170110003.outbound.protection.outlook.com. [2a01:111:f403:c200::3]) by mx.google.com with ESMTPS id d2e1a72fcca58-892bb28f2a8si4933999b3a.80.2026.10.08.02.50.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 02:50:54 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) client-ip=2a01:111:f403:c200::3; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b="Mm/Hs0FE"; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DTKVR6wszlfAeBCcgny+CIR6abXNvnIW13aV2cduRJ3EBkcAeRySk6x6/aqcPC02urT4gDXTgaUw10RaL8yMfV6SVmXUisH0W9krmWw1W/8fU9+eUb/dAy1TOzUleVd3jmNGIA/lt7devk2UhGl58U6XZvYolMcWtBVmlIduHDl43YEcBy0Alq5OphnXXt1N9qvU5YmNEehaEKLUXRDoDsVFYzR/QQw4T0h3anpGwgKVIjI2YLVZx0vjJ9PxRrFjYccVbR19iW2366ibOCVSpbPqkAYZj5Ar2j1uWh6OJodK5VMRnyfEcGaRWH/SEfNTFJgErZDMJbyOL1p37z1pCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3CLVHS5VguWNtxHiyyYPDr0vI6S5deKgF3ke1SCf040=; b=pZmoQ+0lKx12TDzisef4+DEARll+ZLhXoAHEBM2o0TYzjpclVaxgifsDu/eWE64b7CYHblTYFS6hhNyzexMUCIKcz97Z0aZHvIbEgxqDhVP80zPsidpYOgq6ZuJp+i30bB/Tq+JgBPAmCEvYT7slk5QumoA86fodPccJNfXeEqgZL50ZnXvVDrS0HPqUstyV82lmHjmiMSjUPKe7uLP3SWVtI6CiX4yvhOWKClY9C+TNaZioEAqDzZlSLOvozYQurhTUxQKts2WyRemEi5gu9f5xxo9OZzW48ekDX6Ahlo1DCbmaKP0iTUmVw2SP+uFq4rdZyHn2Q562idhlDCdbuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3CLVHS5VguWNtxHiyyYPDr0vI6S5deKgF3ke1SCf040=; b=Mm/Hs0FEkHMTU6cRJEcfau4zTT/DAIgtUuIzieFdK1ZDmbqp7lErKtwDRTJvvjIA46ofmRtxeIUKaY4gFsDdmr1W/lBv7X2Ut5dnjLsE3Z5Xn8YN/bHhwWU7i8JZ7bSI/mSo7Lebx+wMZaFi8IiXKxzCW+iamUMfXALXmEmJsbvDYWWLm8EhAGBEyFRmia6imGmwAb5qytppJZno0z+dV8T5C+YnQTmHa9+RKkbMYYPEmf/yq+bi+ITi+jQscJIWyuBqTdDIIvr6PgzbyFhw7J9F0JWqRIkcrt7DQdS9f770S56TrVjfqgVx00VhQv9AHNV8lvnTH6cKCigk8SvMvw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) by AS8PR08MB8016.eurprd08.prod.outlook.com (2603:10a6:20b:549::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.17; Thu, 8 Oct 2026 09:50:51 +0000 Received: from VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a]) by VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a%6]) with mapi id 15.21.0522.002; Thu, 8 Oct 2026 09:50:50 +0000 Message-ID: <84548c3c-b663-4b55-a04b-6c5575330deb@virtuozzo.com> Date: Thu, 8 Oct 2026 11:50:48 +0200 User-Agent: Mozilla Thunderbird From: Alexander Ivanov To: den@openvz.org References: <20261008073837.510678-1-alexander.ivanov@virtuozzo.com> <20261008073837.510678-3-alexander.ivanov@virtuozzo.com> Content-Language: en-US In-Reply-To: <20261008073837.510678-3-alexander.ivanov@virtuozzo.com> X-ClientProxiedBy: FR3P281CA0112.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::15) To VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10743:EE_|AS8PR08MB8016:EE_ X-MS-Office365-Filtering-Correlation-Id: 45e188c2-9b5e-497b-3207-08df2521a262 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|23010399003|376014|56012099006|4143699003|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: Qzd1Gicz36NO9NMV1fdq0cLjAYTymsZMblbIB6/QXujWW8t6BYDLM1iugQwpzbCqhmHv945U1rcNGeLZarTIZHMw3ABJL+yvimVwUATx7LNMwpzAtoDFAgoK60yrq0f8NLLMeozp/Eu0kriMr9piwsUEpIjvvkcdiQ4VKrGe6R4mtPsT1CUc+WoAGyMXjas8Kj20fd6njZbG3bwLWc9V+qaHomr1ev7uOckzvswi6v6WFqRhWYD8GLlCMRQy3K/tB79dQKyMLi4odeEiEY/DG4RQ5TCkHqfDAuuQBVAq4wtJTmZyPNbcUjZm2pxdAODBRf41/cH284XdQ5XuvTpVveRFr9QRGDvC4L6fq4owKMKMX4UiOZPeB5Mbuh55lNenCfdNXMYdg/slAflqdXsjYmVCtobtD1C8atMyKGcI+g6Zz5E7piD5/UIn7Y4y5hWnvgsj5Cjf+ixmrbpc0bcruuKcDRhhW0H4GE2O9FielA1qPOsLV7ClAZKpgnsd/v/xjT3kRzcNFnOorRZaNriw3M15iZfHtn+p26TjiVJ4ywPNv+BE8fXKQZiE4vT+jctaijj34Vnh/KAgLZ75adXwx1x1lHubwO10skvYJJQ5axLX90G+5HjDW67YFgJceukWdoHGqu8GV0p4/FyT0RaaTnYwU9sCYnV3GCzJQzQnsWY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10743.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(23010399003)(376014)(56012099006)(4143699003)(10067099003)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RlowRm13cGpJaVp2aEd4ZkdNUVVvM2ZkNHd5MnNIbi9FVDVPL1lTRDRPd0FD?= =?utf-8?B?VStxWThZQ2plMUMzQkZJeGlDWllmMUFiYnhxSHBDaTlLTnpSQTZHTEVlbUJj?= =?utf-8?B?ODFFT2NScFArOUc0N3hwb2grOGRuYXVobUxGZzAyZCt0aiswK0lSaXVXSHdP?= =?utf-8?B?cE5ITzViTEl6bGQ5ajhxWHFFOTN5TUsveUhrbTRpdGoxazQ5dkl3eDNJaEZH?= =?utf-8?B?bndqd3ZOVTU2dXVuZUhGd1N3VURqMXdPUzkwaUFFSm1iOXRTcklVVzBUZ1N4?= =?utf-8?B?UGpobWRnMm9ZTzMwQk9RbWd0L21MSnYyamk0aFpvMUNxKzJPSHBzcCtwZXNV?= =?utf-8?B?Y3RxcDJPbUdPNXhQMEZSQlNCN0N0QzBuMW9TZDVUU3hnMkJYRWV2U1g2cmZJ?= =?utf-8?B?a1lxRVFYU2xENm9vbzdzOWlzam1WZlp1TmdkMDZWWGN4Z2l0dmU1KzNZOHhr?= =?utf-8?B?NnJIQW1kU01NMHdITjZab3BGcjNRVlo5T0RqVThLZ0FGQVJvN2Q2bTAvWUp5?= =?utf-8?B?S3Q1SDJBUzFMR0lFaGVOSDRlZ3RRNmJnYzkzOUxPVzBRb1N3RVhLOFkvaktT?= =?utf-8?B?QytlNXBlTmlPNjhiNVVXRlB1NWNIUlBvN2RST2ZPMXdnNWYxVUVUczFTNnln?= =?utf-8?B?S0o4MlVEOW9aL0JsNXoycW02MDNsUS9HWHhqRm5NdVBnTC9vbVRMVEN1TEFH?= =?utf-8?B?bDF1M3FJeEdIOUdSTkpQeUhzNGVScUJjUzgvSW9lbUpqTUdKTmxaWEFSTDdP?= =?utf-8?B?K2xROVZrS2dTK1pVVjQvUElaS25qVjB1TDRZS1NnUEprbEtRNGRURTNMN2N2?= =?utf-8?B?bUVNR1lmWXErQmRqbXY1QzV1SjZ2aHRmN0Jaak16OHNzcXdpZVVuTGZpL0d0?= =?utf-8?B?ZFBiRndkU3BCYlZBZmtHTUtZVk9aclFnTldjSEhEdldOT2dxVCtUdkEvZmRH?= =?utf-8?B?Rm52VU1aeVgrMkIxWDN3bTgrZ04zRzdkanBpaGpZVzhUakEvZUMydnNaK3JR?= =?utf-8?B?Vmk0cXB6bmZPaFpXU1ZxYk44VkZsU3FqRFZoZ0pUMEt0TWE3Q0RZcDE1bmFM?= =?utf-8?B?ekhMdWRUeFNleTRNVnQ3SXM3Q3ZWSDBJNFlPeU5rZGY5Mnc5R2c2YnFNMnpP?= =?utf-8?B?V2lwcE82ejh3RW1PY3hwUUFjekppZUtpQ0hrNlBIaUdEUE1Ia3EwSndnaTR6?= =?utf-8?B?d3M0aHJOdHdHVDlnMkN2MkN6c05TeWl0UG5haVkwSDhQV1ptRll3RkQxS0lZ?= =?utf-8?B?S28vYVFtM2RMem1ZeHFkT2NERHQ0NTJ0aENycEEyYmxSK1FaZG5pVGNBSmp0?= =?utf-8?B?ZmQ0cWJ3eFdYSXpIUVlqZG1WUzFzUnFIMFpSR0sxenRhd0dSd2o4bi9WTlMv?= =?utf-8?B?cllrMFIxNjBNdXA0ZlE4ZXNZZGJJSTRZRnBZRmZaSTRTZWVTV3hkZmc4NGNu?= =?utf-8?B?aG1oV3l3MjVOcHVUU0VMOFBLcjdMWDJORlF2cko1NlVrYWpUSS91YzlEQXJE?= =?utf-8?B?L1FoSFdqd252NnlOd3FaZ0lOMTJYajRTMU1QTGkwZWRUK3FrSXdFWi94N1Vo?= =?utf-8?B?cWZ1dVZLcXVkZWlPeVd3dWM0QWMzcE1oWThMbUQwKys3ZkoxNXZZVDE0WmJp?= =?utf-8?B?Q1VNc0VYNXNZTEwyOCsyclYzZ3JsS2k0RHEvdC83U3o1UnlFcmhKUldPTzlN?= =?utf-8?B?QnF0QnlaejJhaEh6OFFHcG5iMitQNjVJRlduSkx1MWlIQnc5TGhuUDFVT1hU?= =?utf-8?B?elZBNGFFQ29hU0VZQ1JSWjZRbHpuTEE5Sk1YWVM4T1N1UmFjcVFObTc0M1Y3?= =?utf-8?B?dVRLMkhScWtva0M2Y3gzRXUrUFVMdVhOS3FmUHRvdXprK004cG9kVkpxODJo?= =?utf-8?B?NGVSd3FGS1p1K0pXNGh0WFlBc3R6RWc0Zlc0dVhhSE45SGtPU1I4UnBmRVJ1?= =?utf-8?B?YmNCOGJlVGFCVDgydCtmOGVHWmJxVXdrbGk5TmFTNmpuTlVJZHlXajBYUjMz?= =?utf-8?B?R20vVzVQaWRueWZ0TzR1cDM5bCtaR1RwMXBWeERUaTA5UWU4aFJPVFdlT1BH?= =?utf-8?B?aTBKQnAwZjY1ckhzbG5EcGFBeU90QUYzR1NRMzBkV05aditLV0R4WHBidi9Q?= =?utf-8?B?NDNvZHhWSWo1bm02cmpOcUJaTkRIZGgxSk9GVFJORGtabnZWV1h1VWF5c2VP?= =?utf-8?B?OUZ3cE1rUW0zejh2RjlFREw4aU4wN213UVh3Y1U0dXltRy9uRkdZYWNONFdm?= =?utf-8?B?dm5NVGRXM2JwNCtiL1YxbDloWjlsZGRlQjVWUnhoRGtqSDYyM201RHMxMVJw?= =?utf-8?B?WmhyTk80M2drVUF1akliUTdvU1d5Y3laNzVERGVRRHQxRnpUNHhvRTErWEdO?= =?utf-8?Q?Gdtzq8MNuag4miDU=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45e188c2-9b5e-497b-3207-08df2521a262 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10743.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2026 09:50:50.0539 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c+EEfOicnhw/99biPlFsMC9EwFW0xegPzYfLD5MV6f3CoP0IN9RORvFJEdHAf+VyOBD+uv3LnMgX+lqtrhxz5nre5gGMRofwY3oo1GIjOFQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8016 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 2/6] dm-qcow2: truncate unused tail of image on suspend X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org > [Severity: Medium] > Can the value returned here exceed qcow2->file_size? > > file_preallocated_area_start is only page aligned after > qcow2_parse_metadata(), not aligned to clu_size. When clu_size is larger > than PAGE_SIZE and the file ends in the middle of a cluster, the first > cluster examined starts below file_preallocated_area_start but extends > past it. > > If that cluster has a non-zero refcount, the function returns > pos + clu_size, which is greater than file_size. Fixed. > [Severity: Medium] > Is the check against file_size sufficient here? > > Only end == qcow2->file_size is tested, so with used_end greater than > file_size the code goes on to call qcow2_truncate_safe(), and ftruncate > extends the file. qcow2->file_size and file_preallocated_area_start are > then set to the larger value, although this patch is meant only to shrink > the image. > > The growth is at most one cluster, but would it make sense to clamp with > min(used_end, qcow2->file_size), or to use end >= qcow2->file_size for the > early return? After the previous fix qcow2_calc_used_end() can't return value greater than file_size. > [Severity: Low] > This isn't a bug, but QC_ERR already adds the "dm-qcow2: " prefix through > QCOW2_FMT, so this message prints the prefix twice: > > dm-qcow2: : dm-qcow2: Can't find used end: -5 > > The raw negative errno is also printed with %lld. Neighbouring messages in > the same function repeat the prefix as well. Fixed in the old and the new code. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel