From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id EA524803F6 for ; Tue, 10 Nov 2026 17:55:32 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHsEjI017770; Tue, 10 Nov 2026 20:54:15 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHsEjI017770 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="M7a+Ix9Q" Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHsCbU017766 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 20:54:13 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHsCbU017766 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-8b847ab3fd3so2997509b3a.2 for ; Tue, 10 Nov 2026 09:54:12 -0800 (PST) X-Gm-Message-State: APuU4Z86Vx2Ip4SvskJCvN2U80xYHEXJFQVldFIJ68+A7mLMya1TApHI 2d1GVqnItiMt3mvHHl1X7MQ5KU8azt0nyfzxRpsKQadgPo9EeJeBJOTw3hmVE6+5JEAfpAGVUNb XkDitK17xzcpuLczSOtIT+WsBPpOQmvCJYgTId99ry/iO8m7sL+m5MQ== X-Gm-Gg: AYBFou1N56a2tFYuPOk30JfgHERYfeDU38zSHyX9KObFKjP59O/FaWjAuim/kz6FXhk j7WX/3Wbzo7uEXhPkhkK8RLbsEznbAEXvgDoEyWDmhrN+/ALWFCSJhGbTF75EnF4+Qy7pCBN0MX lMDmmJOr4Nl3OyW1+5L82auaonwsv7ATj7Q4FAXSpLV8tC+tOyWnkrSviQ1m8FB6XDlMoZObScl a2ZQvGmeDTtk2dumT2EWcrx7N4NkTto8D6uzijqw5xz45SJoBZ1I9dPLxiMiA9ipPkCPPcJfhfq 97/3Ji5T0rfIdMxtZqrayZ1zdlqyihyL/dYAU0arJeFSS6ZMiGPqNWSVEtMSzvaKw9zlp6EmE5y XYxS8Tep+uwxcIXt+CIwPLjSnJJPlxRZ1qqlQK6ctC1LKc6CtC2vdwA4K+RJZ27V6k78QZqtFHQ rbP8XNg6ZPsLJwp9M8ZyLfd7kAnakJQ7eWnA== X-Received: by 2002:a05:6a21:6f10:b0:3eb:a74f:decf with SMTP id adf61e73a8af0-3f18e6cc82emr3160106637.22.1794333251601; Tue, 10 Nov 2026 09:54:11 -0800 (PST) X-Received: by 2002:a05:6a21:6f10:b0:3eb:a74f:decf with SMTP id adf61e73a8af0-3f18e6cc82emr3160081637.22.1794333251033; Tue, 10 Nov 2026 09:54:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1794333251; cv=pass; d=google.com; s=arc-20260327; b=k5MQH0pevMwsxN61KmohyIMg0EsIPmqCXu3QQ/K3P3fr2n3CpE7O2zambXqF3hGjcr qRfoCrwfo2TCDQCP8o54Fz7WwMzUDrf0xL69fVGv+1hFdwGFQXil5qox9gol2e8rliRe eY7pgz2D9jLFwTZDzfGeFxdYGcMSXp2X24dVwkKyf79hqwuT5oy8lIX6lr3C8RZuSfVN 8dgTb7ZbM0NliABWWirR6/Oe3hgFrJn2Ue/gr64Yla0UzbDrjxKA8heZ85bTioW+AK3s 0Cy521aYYOiPe095v2Pkfzls7/9LthoEiquSQaPWng0joS03J0WKmDQcamVI7skjL7pX twoA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=8n0QK/4pD0Fw3AGT+Jb/ur/90cCzhSILLbHj9y4ZcBA=; fh=zbxUNAoqur3lb2tSbRFE+QAWZ0p3WLVJvU4WJImHWU8=; b=R6fOqNWoee++2otBWawRIh4wsK2UTHGBAdYKKxX3TbrZCCR6drKzMj3bVIvfABF7QI CM79OTUWAmeq8xp0zTwK+oEG19dz8l8YUxN6fYfp8W8J0nPowbfaGy1T1ALNGJsJBCrQ iNag3hVeL1piu1jSOk0/PKqxsEpwz5TWRpL+w0UZ1iCoqW03vod7KuPmeTBsfG8nBt9G ObroRi4zanYNqigkawtTLgIWw6kTJkIy3lVwG8FtlUZN7RG7oLjC9+OADbwfmrG4bsea 0zw7T5XmFphel2HT3VVDAb2pJ81l6tQSUCzBiCOCsDjoLFfZGK1/goz7kNwdRSMakYcM tvfA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=M7a+Ix9Q; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c207::3 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazlp170110003.outbound.protection.outlook.com. [2a01:111:f403:c207::3]) by mx.google.com with ESMTPS id 41be03b00d2f7-cdd8d8a50d4si4315074a12.194.2026.11.10.09.54.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 09:54:10 -0800 (PST) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c207::3 as permitted sender) client-ip=2a01:111:f403:c207::3; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=M7a+Ix9Q; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c207::3 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=e84y7UXcKBKu3LDFWULn3lZHDcMbua9Tp/4RrGHIcmdCIsdA979WKNdo6Bc7bDkmXfK6CZRQAkCZ70KEAG/MlSrSULRzRKl0dIaDMJKHsZioTK3iHDckKuVXujrSCmOn47mSPIUAiYZSYD9TS2iaQAaikbdf3+nMRuB5dGqrIbG6NsZGDtj+TBROUfyh/RMoZKOoK8IF7/w93WEj3MaeGaKjOBpx/92B+Rcupe5LitKzxO4h6gftvgD/Px059FZKUwxO5aKXT7A6OQrEcqco7A6Afn1y9iEwpsixPtOj2WPZUWevrr10+YSmWdLWnVi+vUNkowVwDMBqBDasUISpdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8n0QK/4pD0Fw3AGT+Jb/ur/90cCzhSILLbHj9y4ZcBA=; b=smKkA/FZE56C4N4JjhZixqpe4SvC8r/fIJTcAaelRukqA7hnxfEq3Tk2ODum0In9oTmI+Qh4EWznyiXkQXkjI0wywDBAGVDPlRY3JOyQu60YLLl+x+GDv0goYKvOIvVln4oXcuIo1spaPRlX+DMI1mEp8qxI17tkUcAYIWTcEodw+UxuFlKuwCWcXcHlXyOG//DVkITPwMndUQYLvxCg5RaBQTE8OyG1DzdCU4u52fX7ZtrHlMkFTh0xNdLEF84WqbuoGzGN+NvY8/dvDdhzB19Rpv6oiXFr8HACtHz5PmVVkxREwoOzqe/NWk4HpM11UUPtc8MivFa5r+R2lIVf+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8n0QK/4pD0Fw3AGT+Jb/ur/90cCzhSILLbHj9y4ZcBA=; b=M7a+Ix9Qixo7fTpffBtiAgWVjZ/ZfLKRfFprmC+sCttDpByQSXyLRb0VNeDNUhYu7pELus3YKtF3NhNIA9S4UhjOuRtEAhyojVPgOWx0PYSDUJLxtDlZEvqSyjTyHTBjwXGvKzZFd0ZmSXgtySuebeorIziPE+imtbH3GTxF1YaWx8gRVweozzuzSLT5wy7MtUrdAejX4YUgkdrc9Pp4tZkOYsieNdeIs/zFE7cgeEN7TXDS1y3ovZNA7KdXUX3km+OxN/A0eGx+tCmwGhsavXJ9g5LvQA3Bz6JPaaBMjyGyZDc62RuHF6HLYCBWOnmSyBQ2PzKT56c8slsQSSvGCg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) by DB4PR08MB7957.eurprd08.prod.outlook.com (2603:10a6:10:37a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.8; Tue, 10 Nov 2026 17:54:07 +0000 Received: from MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa]) by MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa%3]) with mapi id 15.21.0615.007; Tue, 10 Nov 2026 17:54:07 +0000 Message-ID: <847fa923-f247-462c-a95a-c359cac4636c@virtuozzo.com> Date: Tue, 10 Nov 2026 18:54:06 +0100 User-Agent: Mozilla Thunderbird To: ptikhomirov@virtuozzo.com, vasileios.almpanis@virtuozzo.com, Konstantin Khorenko References: <20261110-ovl-use-orig-ve-v5-0-f3f2bdb29e23@virtuozzo.com> <20261110-ovl-use-orig-ve-v5-5-f3f2bdb29e23@virtuozzo.com> <010701a1c689784e-b24e201c-83d1-4ece-845f-7e659dada2fa-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Vladimir Riabchun In-Reply-To: <010701a1c689784e-b24e201c-83d1-4ece-845f-7e659dada2fa-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: ZRAP278CA0010.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:10::20) To MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI7PR08MB201474:EE_|DB4PR08MB7957:EE_ X-MS-Office365-Filtering-Correlation-Id: f26ad17d-45c9-486e-c78b-08df3f539dba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|376014|366016|1800799024|10067099003|4143699003|56012099006|261022105027099003|261021135927099003|261026121527099003|261026140227099003|261028144727099003|261009220027099003|261009221227099003|261009221727099003|261009223027099003|261009223327099003|18002099003|22082099003|3023799007; X-Microsoft-Antispam-Message-Info: MKYmF1FNkqzjMXO2u1omiYmBd2iF15n5MwW8Wod0lVot8ezhC4SKx+A6s1mZwFRZgBhBw4hOOAud2XB7e4ILqUIsKwYbvnGM3vcFWwC4XNPdoA9xQTr5PCKYqtARhmYCL7bvcNHW5MgT+/o6Obtv0Xx5OAYV9a/qiL2pyVtEFmdtSG64cItYOv7I0BSlkO5VzDVz/98JqMKjJmwjLSSaMrP+tu0x1yJ0Pp0VAh+ZO8NTp4oOU7hK2OrPXGCrIEti0k/0Ns9VwaOr0OdWHu3ATgNpRrzJRx8CGkTUScjG1m1muYLzTM/xHnbYGceH5lqZgnFtRMSZFyZ/ELee8G/p6PPtTmkzNcDa7cadfN31zLxrCR9apPjBjT0y/jJOX4J8JXRBShmKYBtTT6QqtmZ1TChQWjs46R/5wF74HB4XuTYCWTP98DEyc7nRt63Gzx4uq7blLdSNDwi9Gd2oTJMcnHpVr00UFWt/9ihY2FU9hXNRgSKLSy6QJyD88MdqVSFRErzdOunjTRHARw2Afnt/FUJsQKM/oombtz7ogqGaOJ2cx5KUVcPO6Hw9r59QqYpTqUyagrEppNBnBVbNl48OjY2GT0QPHIfD26cJX5WDBcEfBxlqiRdldUfXBURz3hAsXYISwR5RVydHRje1xHdDnuFiHPTespQl6qJRdNrRtDk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MI7PR08MB201474.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(376014)(366016)(1800799024)(10067099003)(4143699003)(56012099006)(261022105027099003)(261021135927099003)(261026121527099003)(261026140227099003)(261028144727099003)(261009220027099003)(261009221227099003)(261009221727099003)(261009223027099003)(261009223327099003)(18002099003)(22082099003)(3023799007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1hQZ2czTUZuSm80RWdnWHRsUGhXamNXR2ZtclRLOUlsbWM4MnhpR2RGUXh4?= =?utf-8?B?VGNWQlV3eHp1S0tVTVY5b1ZPSkV6QTBoZml0NmZFS0dqaHJjSGJnZkZ5RkYv?= =?utf-8?B?NWtOeVNhZUwra0hjbWtzMzR1VXhOck5JRDIySE51Z24wQ0tIWGNCNXdQVjNx?= =?utf-8?B?NXV3bGhER1E0WUJpTVNQdzI2bUdlb2JQS3ZGK3Y2QXBPSi9XaFNQZmNsUm5O?= =?utf-8?B?UFIrZG94RFd1bmMwbG45THE3ZW9TS2F6aTNkcEtRekh4MERaYVZuQVoydXpI?= =?utf-8?B?UHg1TlVqMlA0TmVIRW5xbnhubmI3anpLRlc1RHVOV0FnYzF6a2xRdFdVMnNm?= =?utf-8?B?Yld1UDVTYXNMTDNZVHMxalJIbjJhNDY0UjFRSXY1Ri9XaGw3MllJQnFyblI0?= =?utf-8?B?dzdhUnY5Y0JYUmVnTGlTTXpCeFFDczhQV2lTS0hxa01lT1BDSlBUUDBUSmRF?= =?utf-8?B?TzNrSms2MjcxNGdTL1kvM2pFVHEwTzBHdVJJNjlyUXhhWDZLeW4yZjl0QmpW?= =?utf-8?B?OHlEa083QzZBZlRDUFpPT29mdCtZelFHYXcxWDV6eGkwR3BFZTRCSWwwS09X?= =?utf-8?B?d2Ixd0dLZFg2ZlhuZ2xxMW40VlU5S2xFRkRna3VIM0ZpUGVtN2g1Uy9FLytK?= =?utf-8?B?Ty9sdFpJc3A1UXVnZERJb3hxcUZ1ckVreUdvYnZ3WDVaZmJ2UU1PNk1WTnZ0?= =?utf-8?B?VHJ0WGFuYUhpTll2a3BBNVRGRHR2dXNWWEQ5M1pjTXE4MFRRK2w5MU5KTDlF?= =?utf-8?B?MHlHZGN2elQzTE9IVkZzTkZvR3A3WStHc0hlMEU0VUV6MmJTUzA1eFgvL2pG?= =?utf-8?B?dkl0eUtNbXZJek5JQWpydy9zeTNhVndNamVVUVNKYldLQjk1dHlpOWZmK0JR?= =?utf-8?B?RjdHaXBEaDhVQmtWY2ptMGJLUHRlUEdCUjF6TFNzcTZQRWxjZElvRVNHTDda?= =?utf-8?B?QkhxUmV3NEdlOUNESERRWWQvMHlzRnRocGpBUWpFRkRVYnIzRW02d2Zsb1gz?= =?utf-8?B?MXhXR0RLUit4eGZPL1VFVEpBbVo3TTNXbzZQeHJjQ0lTY2l1UVRlSTBnVFdr?= =?utf-8?B?Tis5cUxMOGduNEpEN043UGJQYjY0dEdaMnBIMjFEcjBLMG5HeCtWR1AyNG9z?= =?utf-8?B?RjJ3UXBNUGREbVVScEhxbTV3VE8rUXkxVERNWjVRQWRxK0pFZkNsZ0kvNnpK?= =?utf-8?B?Z0I1dDBTb2xlbXljY2ZTYkk0MERrdU5BQzkzbmhUOHBaajRieTMyc2sxV3RX?= =?utf-8?B?Qm9abkxraTc3UmtPSktFYXBlV3RndWpFNXo3K3A5czNoTU5xQ29JTWFOc0ZK?= =?utf-8?B?ZlpYd09IajlGM2x4bHloYzhFb0dibEVVSjNROWQ5SXBKL3dLL3VFekIwSXBt?= =?utf-8?B?YU43aDgvNkQxWThoc3MrK1B4cy82YmtISEYyTVh5MW5GT1A4Y0pzYTZ6Tno1?= =?utf-8?B?UEdMTXYvR01xMG9YTk9nUVlhQkNIaW53T0o5T2pOSExHOU02VlVRSWVPS3Zo?= =?utf-8?B?enF0TFlqeXhBVy9NZ1BwbGVMYVp5TjhYbktGaHFySHE5TDJNR25YVkJKbzk5?= =?utf-8?B?YmErN281TEMyRlhUa3pMWlRiSW9XVko0dDVrSHh0R2FWdkh4MjRoOHhxbElJ?= =?utf-8?B?MmQ3YVFTN1ZzL2ExTjM3d2M1OTFTMGZNdytKNTV1SElUVVl0eDJpUlNqeFp0?= =?utf-8?B?VWs0OFFOVklUNWNESW1mWU5pUUFWVEpWRXV4UFdZR0FDZUF1dXRUU0JGTkxk?= =?utf-8?B?VjdNRXhMMTdLTlZjWW9UMXhQbFVhM1lVZE5BNHFISkMzYmZxamNRQUx1Tkps?= =?utf-8?B?UTZHQlhqV1BqNzBaNVYxRkhVdFY2Q0R6RzJDWGdxVFFRYkpUbnV1RTlJUXZl?= =?utf-8?B?b1hZc0FLaEhiZ3U0ejVJaC9kUGdQcUV3S3UrUWtjYmdLem1ad0Z1RlVOWE1I?= =?utf-8?B?cDg4Tk00dDJCdVY2bGNRMGV2ZHNLcmszNm15cmcxTWpuaE0ycHRVSDVSdDdC?= =?utf-8?B?U1pPeWxQeXBuZXNRamk0ZjJwMDZhZFJCQU45MzE4Y2NCNjhWZ0hja3N5SVlO?= =?utf-8?B?UlFXT0M1ZjN1NW9LQXpsdWd6R2pDQ05wT3JmbXJFWXJtMHlqRE9iWEFTVjls?= =?utf-8?B?K0tqNzArYWt0LzNXenk1MjR1RFJUeUFUKy9lQmtEeWtzaTdGTkxlS3RHVXJ0?= =?utf-8?B?OEFETmJpRVRLUGxXTkdWWEJUYzA5b2dTMjdCNlNOc0lSdjhUdU9wdkNoRVJx?= =?utf-8?B?dEhKQXoySFlPYUVLaENJNFN3Z1NzekZLYUNOeVpFRDAyZUs1QmQ0OTFnZ0JS?= =?utf-8?B?NzFjeTNaWS9LMVFNbUJ0TjcvNWNTWE51bnU3bWZTdWF4R1h3KzhzbkFzcktr?= =?utf-8?Q?VLh+/Pe4nB852U1Q=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: f26ad17d-45c9-486e-c78b-08df3f539dba X-MS-Exchange-CrossTenant-AuthSource: MI7PR08MB201474.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2026 17:54:07.1627 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pSI9qbokKpyH8mPK0agenmNCaa1hj3cGbemcyWktPfjWKCe//zb+kLHxd2IcMaJDpL/WrX9b4UmP6+IubWjjLKUafSLob6avDEF+RBapbYQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB7957 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v5 5/5] ve/overlayfs: Override VE together with creds X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 11/10/26 18:37, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: > - [Low] ovl: ovl_lower_positive() returns false when ovl_override_creds() fails > - [Low] ovl: ovl_nlink_end() skips ovl_cleanup_index() on override failure > -- > > commit 8148285e45d307c93a9e362536fb412f0d9a0ee9 > Author: Vladimir Riabchun > > ve/overlayfs: Override VE together with creds > > This patch changes ovl_override_creds() to switch the VE together with the > creds. It returns an error for cross-CT access, and it converts all > callers to the new ovl_creds_desc / ovl_revert_creds() interface. The goal > is to fix a NULL pointer dereference seen in ovl_get_index_name_fh() when a > host task works on an overlayfs created inside a CT. > >> diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c >> --- a/fs/overlayfs/namei.c >> +++ b/fs/overlayfs/namei.c > > [ ... ] > >> @@ -1426,7 +1436,10 @@ bool ovl_lower_positive(struct dentry *dentry) >> if (!ovl_dentry_upper(dentry)) >> return true; >> >> - old_cred = ovl_override_creds(dentry->d_sb); >> + /* Ugh, hard - we can't pass an error from here. */ >> + if (ovl_override_creds(dentry->d_sb, &old_cred)) >> + return false; >> + > > [Severity: Low] > If ovl_override_creds() fails here (for example -EINVAL on a cross-CT > access), ovl_lower_positive() returns false, which means "no lower entry > exists". Is that the safe answer? > > The callers use this value to decide whether a whiteout is needed: > > ovl_do_remove() > bool lower_positive = ovl_lower_positive(dentry); > ... > if (!lower_positive) > err = ovl_remove_upper(dentry, is_dir, &list); > else > err = ovl_remove_and_whiteout(dentry, &list); > > ovl_rename() > if (ovl_lower_positive(old)) { > ... flags |= RENAME_WHITEOUT; ... > > A false result on error selects the plain remove, or skips > RENAME_WHITEOUT. A lower file could then show up again after the unlink. > > The operation probably fails later, because ovl_copy_up_flags() and the > ovl_override_creds() call in ovl_do_remove() fail the same way for the > same VE pair. That makes correctness depend on call ordering. > > The lookup-error path in this same function already assumes "something is > there" and sets positive = true. Would returning true here be more > consistent and not depend on that ordering? The problem is that failing ovl_override_creds means something is very wrong, and we don't have a nice solutions. The users of ovl_lower_positive are doing cred override later anyway, so they will smell the problem. It really shouldn't matter, I think. > >> diff --git a/fs/overlayfs/util.c b/fs/overlayfs/util.c >> --- a/fs/overlayfs/util.c >> +++ b/fs/overlayfs/util.c > > [ ... ] > >> @@ -1216,11 +1243,15 @@ void ovl_nlink_end(struct dentry *dentry) >> ovl_drop_write(dentry); >> >> if (ovl_test_flag(OVL_INDEX, inode) && inode->i_nlink == 0) { >> - const struct cred *old_cred; >> + struct ovl_creds_desc old_cred; >> + int err; >> >> - old_cred = ovl_override_creds(dentry->d_sb); >> - ovl_cleanup_index(dentry); >> - revert_creds(old_cred); >> + err = ovl_override_creds(dentry->d_sb, &old_cred); >> + if (err) >> + pr_err("%s: skipping ovl_cleanup_index.\n", __func__); >> + else >> + ovl_cleanup_index(dentry); >> + ovl_revert_creds(&old_cred); >> } > > [Severity: Low] > ovl_nlink_end() is void and runs after the upper unlink or rename has > already succeeded. If ovl_override_creds() fails here, the orphan index > entry is left behind. The only trace is the pr_err(), and the caller is > never told. > > Is this reachable? ovl_nlink_start() calls ovl_override_creds() earlier in > the same operation and would normally have failed first. If it is not > reachable in practice, would a WARN_ON_ONCE or a comment saying so be > clearer than a silent skip? True, shouldn't be reachable. I'd keep this error check and warning, this is not really important. > -- Best regards, Riabchun Vladimir Linux Kernel Developer, Virtuozzo _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel