All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Vladimir Riabchun <vladimir.riabchun@virtuozzo.com>
To: vasileios.almpanis@virtuozzo.com, ptikhomirov@virtuozzo.com,
	Konstantin Khorenko <khorenko@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v7 1/6] ve: Remove STOPPED state
Date: Mon, 16 Nov 2026 18:35:44 +0100	[thread overview]
Message-ID: <862ebf4c-833e-49f1-a367-956f437aff4f@virtuozzo.com> (raw)
In-Reply-To: <010701a1e5624753-2940e43e-f39d-4302-8708-b236dc8dc38e-000000@eu-central-1.amazonses.com>



On 11/16/26 18:23, no-reply@sashiko.virtuozzo.com wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Low] ve: commit message omits removal of DEAD transition in
>    ve_destroy()
> --
> 
> commit 23cbc0a68783a5b04322e1e051abf52807d3e18c
> Author: Vladimir Riabchun <vladimir.riabchun@virtuozzo.com>
> 
>> ve: Remove STOPPED state
>>
>> We don't need extra STOPPED state. It makes us feel that CT
>> could be started again from it, but it is actually not true.
>>
>> Separate STOPPED state doesn't bring any value. Drop it and
>> transition VE to DEAD state directly on the stop.
>>
>> https://virtuozzo.atlassian.net/browse/VSTOR-142405
>> Reviewed-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
>> Signed-off-by: Vladimir Riabchun <vladimir.riabchun@virtuozzo.com>
> 
> [Severity: Low]
> This isn't a bug, but the changelog leaves out one change the diff makes. The ve_set_state(ve, VE_STATE_DEAD) call in ve_destroy() is deleted, and the message never mentions it.
> 
> The removal looks right. ve_exit_ns() and the ve_start_container() error path now set DEAD, so keeping the call would hit the "already DEAD" warning in ve_set_state(). The old call also stored to the object that kmem_cache_free() frees on the next line.
> 
> One side effect is worth stating. A VE that is destroyed while still in STARTING no longer passes through DEAD. Could the message list this change and explain why it is safe?

Already replied in v6.

> 

-- 
Best regards, Riabchun Vladimir
Linux Kernel Developer, Virtuozzo

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  reply	other threads:[~2026-11-16 17:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 17:18 [Devel] [PATCH hci-8.1 v7 0/6] Fix kernel crash in overlayfs Vladimir Riabchun
2026-11-16 17:18 ` [Devel] [PATCH hci-8.1 v7 1/6] ve: Remove STOPPED state Vladimir Riabchun
2026-11-16 17:23   ` no-reply
2026-11-16 17:35     ` Vladimir Riabchun [this message]
2026-11-16 17:18 ` [Devel] [PATCH hci-8.1 v7 2/6] ve: Introduce override_ve/revert_ve helpers Vladimir Riabchun
2026-11-16 17:25   ` no-reply
2026-11-16 17:18 ` [Devel] [PATCH hci-8.1 v7 3/6] ve: Defer ve creds drop until ve is completely destroyed Vladimir Riabchun
2026-11-16 17:26   ` no-reply
2026-11-16 17:18 ` [Devel] [PATCH hci-8.1 v7 4/6] ovl: Keep creator VE in overlayfs superblock Vladimir Riabchun
2026-11-16 17:27   ` no-reply
2026-11-16 17:18 ` [Devel] [PATCH hci-8.1 v7 5/6] ovl: Fix leaking fd references in ovl_copyfile Vladimir Riabchun
2026-11-16 17:27   ` no-reply
2026-11-16 17:18 ` [Devel] [PATCH hci-8.1 v7 6/6] ve/overlayfs: Override VE together with creds Vladimir Riabchun
2026-11-16 17:32   ` no-reply
2026-11-16 17:45     ` Vladimir Riabchun
2026-11-16 17:43 ` [Devel] [PATCH hci-8.1 v7 0/6] Fix kernel crash in overlayfs Konstantin Khorenko
2026-11-16 20:22   ` Vladimir Riabchun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=862ebf4c-833e-49f1-a367-956f437aff4f@virtuozzo.com \
    --to=vladimir.riabchun@virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=khorenko@virtuozzo.com \
    --cc=ptikhomirov@virtuozzo.com \
    --cc=vasileios.almpanis@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.