From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 8EC2D8017D for ; Thu, 29 Oct 2026 11:05:06 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69TB3h68031714; Thu, 29 Oct 2026 14:03:45 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69TB3h68031714 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="yilk96I0" Received: from mail-yx1-f72.google.com (mail-yx1-f72.google.com [74.125.224.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69TB3fGb031710 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 29 Oct 2026 14:03:42 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69TB3fGb031710 Received: by mail-yx1-f72.google.com with SMTP id 956f58d0204a3-679f81d5d7bso2533323d50.2 for ; Thu, 29 Oct 2026 04:03:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AKwUvBzv7yFUQ2UZy+Nm3UPhrp2anzgZn5OUyngWdz47UdQFDFMb4g5WfVbIXJwsWwDTCQ0TUqYdZw==@openvz.org X-Gm-Message-State: AFq9FYL2g86++ilRNyWUvLz6URFyv/9vhXQIWdi59t053hYQ9Xjuh8gf IHHD6Z1GxWu0DNss3NzO82BgmnE2Ft12xdjcmwOVvZhYaMxzpz9y4dPN/JZszdYxCdLfVhgBIE0 oSukFQ0x5cupAXdTvJOh2Pba5B7WKgFNP5ioX3EkMz/cGKP8gpu2zQA== X-Gm-Gg: AYBFou1BJMXaM4MzJI3rVts3YF90kaKyOSzUNZUWqwkl3un81bizWlPMoFFPKdRtQIp SVhn7LUb4d70qvweNlMACcbIkXbYT60oeKMjvAYJA4JqdNNPRuknLGwMEQLGtWFCsfKBxg3x61E rNl6B0nwymWlr5wc+ckVyaBQA3Kyp2LE3b9+qHCl78q8UXalAfwi17TrJWNa1ITVskj1AQ8SKX6 zzceR6MBFDrgLRWCDpQz2VkNXcnvl2NDb6J4yo2qCJ32b+Go8CElxRIeeu9JL90Z4UjIs655E5K yzypcjjWifB9dtNo0xJH2pDh3JpMnw6OQkrhmAy1BR41sl0/BO62dRpPPX0jva3VtDKNme0w1Us L2NHqD/sBiqH1Joj/wICQ4nzheS/dIocMlCkc1/4lf7XvTqSKfBeCjBU/dmCRx5Sd9hQdAVrxoU MUVzD43FJoMOFBkNLQ746haHW6zaF3IBTJ X-Received: by 2002:a05:690e:b85:b0:67b:98ee:6bf with SMTP id 956f58d0204a3-67b98ee08bcmr548493d50.19.1793271820913; Thu, 29 Oct 2026 04:03:40 -0700 (PDT) X-Received: by 2002:a05:690e:b85:b0:67b:98ee:6bf with SMTP id 956f58d0204a3-67b98ee08bcmr548476d50.19.1793271820302; Thu, 29 Oct 2026 04:03:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1793271820; cv=pass; d=google.com; s=arc-20260327; b=OT4kJP2ydob1v7aA+BBMl81eXLV1EdD80bnDvbCORbMKQpqH3RBLYBXBFOzM3Jgx5N DCzrxAuCp5+yKsiJCQXtWhlyhsZ3DRHvJCZ/iTkyCywev8kNQVgu7WxAU5BQ7lQDDptC keWLNigpkDi805unreLRwKbytNiyUoM78NokxliJvdM6fM4cK4SSvhULaMOhPlODRWds 0O32sAh2ye0nRm7UlBBLr6XGlAy/2PJHGTN67fddxLX1B9AIh18Fol0t3/LNEaDoCXkG Qi2sHB+UQEwmmbAdBtqQ5EYg1BSrwQswyFGhG2bMKyr/1ocunkG0nVwCSyorxnAttzha NmYw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=nuhoscW666Tkw7B1azgdzwtK9hmWuIEx6QLgh2RJm7A=; fh=NQShvAamTRhKeEdBP+VGPvHYs3WDIRdtFLGEhdoHFRg=; b=Xvts6XqaraTU1W/34mQvKnOuZbtcnzIpMFNX2AvcWTaCUIOWu708FrqqbERQXAb3cA VPV6zg4h+cOZ8MNHoHm1dgXnY2OT/ywjlMfu+bT4SUDZ+SfNaNELAC+BGbCLZYY3IbY1 D+Bj/CQmaMJqlQjIncyIQJVA3t+w91hyiBrKi/p1UbEgspCLo6u266ikMvFhPyaKKfxh NjUCDwZHyGVjr6fqXbsHoUKitbryPUIx9BNgHdE+ptKBQyNFfY9/qJU/EeaSP6ssGIBt voXeT65Hmgqyg149tYlRUQB8BFR2EwBj1gXDW84alBBFDiEv5ADHcdDdNwgMq06JBb/N bHjQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=yilk96I0; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazlp170100001.outbound.protection.outlook.com. [2a01:111:f403:c201::1]) by mx.google.com with ESMTPS id 956f58d0204a3-67a7a0ffbf6si4438472d50.195.2026.10.29.04.03.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2026 04:03:40 -0700 (PDT) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) client-ip=2a01:111:f403:c201::1; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=yilk96I0; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zQqLbb3yDCEIMXPSuEBMQIaYxpSGbpxLDPXA7hsvlHiCnZmtsBF/4To4OZS7EfDoRZWJXm2YdTyAerKPgNo0BEk6tdsUmZwvdV+h6fy5DOmVuGUpEBgI41dv3HMfmSoFn5U2Tqysqp+Oxn6Nu2eWvgKZrFwpkdYSBuzw91bK6HfRsOQxfKUBvcdwjKGqLw59UbOtUqv7vVn5+1qZ6bJ/0wcj0r1NafZvixL5l6/2iKKpvWVKn3nGpnn1FbllQEzoOGakjtQ4kMbwONJalxqCPENtUwZzfUbpPqNMNW00iJ+nTEIwfZsGXGmCCIq7yNWAkkTThzJeA2PFopPG9AINmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nuhoscW666Tkw7B1azgdzwtK9hmWuIEx6QLgh2RJm7A=; b=ldxXXTHUkosEJhoowI//PMlvQ5aFqQA7Z/09urifVd5Evf+eJXykfXI/6fP7jpH8HIvOXQ/IphG8Dox3JTpYL4dWp61mlIIkP9DSQ0ImlEEBRnQhwjWT3J2AJOufPwA6H6rFHNZ9TM2xDZwn/vDBlpyVJdGHd9h4ejs5dJUU8oaWwPf61vl8TlVhF7r3cL4BPiIdRwm1IP5luLO7RDsAGJUCjBJiiS21/axezuZVXK5Gsv8Tn1YqTRxRk8klhpj4smxxPmrPu7SZqJi7RgtK4pt2zNfvZvSqTvvZQBZQ9ReFYs9uw8MOK5regflDHqs81AeKCvz9QN+ozfa5H1SZgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nuhoscW666Tkw7B1azgdzwtK9hmWuIEx6QLgh2RJm7A=; b=yilk96I0cbVhyiTBZ8Y+PEu5mMBPXieTOm7HhnflX6lWFMsBIegBNhyKVX6OENA3iG6x6ET0zU3w+XVK/YyrtsNKOwLvJiJM0q3pPSPYJ+HBL53HzWdIC7TUbbJIWnqgCWm9gssdOSV3dv1q78qokJ1gQiHwlJDzqauIEmP1CRcpt49nzE2ux5F6gQ7gDxy62TL17PHS7ZdiBszzIXb48Whg6zQ/sXTgsIDBdke7kIOIlhB0dJC8WibRUNJI7KeynZjJEOIyFSIGTfoLQPdJjD+RCJGaxxTvVac2ZTYm7f4p0nwspgX3AC64VUamQd11GKV2LmCRGHGPi8vg3QWbfw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from PA4PR08MB6061.eurprd08.prod.outlook.com (2603:10a6:102:e9::13) by DU4PR08MB11175.eurprd08.prod.outlook.com (2603:10a6:10:574::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Thu, 29 Oct 2026 11:03:36 +0000 Received: from PA4PR08MB6061.eurprd08.prod.outlook.com ([fe80::c3bf:e107:b1d2:6a00]) by PA4PR08MB6061.eurprd08.prod.outlook.com ([fe80::c3bf:e107:b1d2:6a00%3]) with mapi id 15.21.0569.007; Thu, 29 Oct 2026 11:03:36 +0000 Message-ID: <86fbc89a-f264-46f5-a008-fa096ad56f61@virtuozzo.com> Date: Thu, 29 Oct 2026 12:03:35 +0100 User-Agent: Mozilla Thunderbird To: Alexander Ivanov References: <20261028081459.3050162-1-alexander.ivanov@virtuozzo.com> Content-Language: en-US From: Andrey Zhadchenko In-Reply-To: <20261028081459.3050162-1-alexander.ivanov@virtuozzo.com> X-ClientProxiedBy: GVAP278CA0003.CHEP278.PROD.OUTLOOK.COM (2603:10a6:710:20::13) To PA4PR08MB6061.eurprd08.prod.outlook.com (2603:10a6:102:e9::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR08MB6061:EE_|DU4PR08MB11175:EE_ X-MS-Office365-Filtering-Correlation-Id: fb76100c-c2ff-4e46-d0da-08df35ac47f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|376014|1800799024|366016|10067099003|261021121427099003|261021123027099003|261022105027099003|261009223027099003|56012099006|18002099003|261028144727099003|22082099003|261026140227099003; X-Microsoft-Antispam-Message-Info: Wc+QbaKedCbIwf3L+Jg0cWNhudHx91p+Eh10gQSfv+L1QrtV/CPvQ6PiQfBXwf2jP0Bt53ixtF0eBpD4DUYvBsvOzW0ZAyQhTg4IzerZd7kAATsaU2ylXj7YEdKmLlQZVRnhcvvi94hdeIgRJxEQKD8Ecl/96HziTv7ryqCoM6JqI0AJOKLJRa6HdG/ZhL2GzU8d1hjV+Pmyp7c+4A8dXwxe6+mtvkf+5ujPavDu+mW4e4syC3eciawCwH4IcgXxVQWzJ4dXak/l5d+HGRaI2RkmVJMCLGEUlUXF+Yh55cnli2Uejr84YTnMwF5AVqkzZlW2NEBuGBvuigjYJF1usmV6cTEA+iE1FHFgyYEYlrfCIvXsybJfLonbXc2f19ljfptaX//3qOd1GFeKSxGEyviIgGjor3tBk3KLmG4desjlC/KKe5vuU2ZOKAoTof1LooSRWem0gPxQsguLzUbsroPmqhIuhiPXm2O6j772+LIoIBfaCqeGzheNmw6eoCUkctlfd8nYxUN0sAAL6lIDYvb4D4oG4EHnc4GpL5DmtmXkn6PGwP2dflpoZ/bV6XcD+xvDsiTAppnnu9BXvpkMmrxTg2GoCCsnjoli3sSIgIL8URO4D9oKcMayR+I7gqhQ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6061.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(10067099003)(261021121427099003)(261021123027099003)(261022105027099003)(261009223027099003)(56012099006)(18002099003)(261028144727099003)(22082099003)(261026140227099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Sko0TFZzbnc0Ni92RmpBQnpSczhwU2tUWWtkOE5RaER0NTRqMERnQU80R1pY?= =?utf-8?B?RXl6OVRqWUlIbnd5QVB1cU52RFpLWEl6YURFY1R5UFZKUEFFcXVkNDdZLzNZ?= =?utf-8?B?VVpIdG83R252UmdwUk1rNVRidXpnRUJleUdGOGtxS3I2T01YOVdsZEVqNFAv?= =?utf-8?B?dDE2RlBtYVYyejlEUGp4ZDhzc0FNeDZ3QXdjY2ttV3ZLUWlvaHZHOUN0QWNV?= =?utf-8?B?Y0hZdWxpZXgyaVluUGgwZTRYeDl2UDVMWHo4NU9QWUxFcU9mVVFSdWJHejFs?= =?utf-8?B?MUJCbzJXRVpwZWZuQTg2bDZWL2ZvK3ZNMkttUUZKZ0twaVBZTVlXNkhoT0Uy?= =?utf-8?B?emlwMXhVWEZFM3MrTUE1Q1plZGk5aitGR0ZNUjNIcG9JQm52VlI4cytnQnl4?= =?utf-8?B?UTNtVitJZXJZcHF0dHBOWFg2YWhaSm1Ma0dDSkNLZUdkTEpDbGUzSDZkRzdF?= =?utf-8?B?MmlFdWZpNUpzOEZDZEk1bWlaaG9oRDZWNmlCVytNNThqblJxOTEyYU9aTWhi?= =?utf-8?B?Z0Jyclk0YmIxeGY5eDhnaWNqQy9tcHMyV2ZsL3RKMWZyUjNEdEhPc1dXc0RC?= =?utf-8?B?ajJzcnhPcEU4RzJWUFU3ajZ4aTFPdTNyM3pIWUltU3lNVmlnTWtkUzVQV0RS?= =?utf-8?B?U3NtdW4rUE5XampjZGNMdERFRldGeTM5Q3RoeTRINTBaV3ltRzF4OTJNQjU1?= =?utf-8?B?K3R5MnhRZlB4SXplSlhOekJWVjJEdVErKzZjN3ZvTU5XRlBRbEdDdkRGVVNK?= =?utf-8?B?cDJyVUVPZS80MSt4OTlPWGFETEpGTmN5T2pNQnUxY2FXc3B3WTFkVDNMZVIr?= =?utf-8?B?aFg5VSsyeEFnOHdxUjVnUjBWT1NIenZiMzFlZHpLcE5xTWM2a0RFZmx3YzVk?= =?utf-8?B?UndXa1hKSHR2YlN5dEVza1cwbW81U2V4Zm9jdFZyNWo0ZElsTnpTd21TNGt0?= =?utf-8?B?ODRyWWgzNjJMbXdvZE93RmpHY2g5eE5SeGY3Umpxb0RFd3dmcDZQSCs1RTYw?= =?utf-8?B?M25KYU5PZWpjMVBzUW1KRmdoWnFHYjFSWllCQ3NSU3ZRMGdaVTlmMkkveXpW?= =?utf-8?B?OHJMbTNlZUgrc0ZPOFVQOElyckMzS2tiWlJvWjdEb29VRnpQV1JqaE1lbzNO?= =?utf-8?B?TFhDUmFRUGc1am1vSWdhYlhpUnYyMTc4MzliLzluNmp0WmRhNy9ERkFuT2pO?= =?utf-8?B?V3F6U1cyQXp2bHFUTWEwRGV1cXlVZy9kVS9mVzltVnR1Mm9SOE9XQmlEZVpY?= =?utf-8?B?SVloUVRlOHdXbDMwMEJOMmIyZVA2c1RsOTdvK1A1cEFKNi9qZGMwL0RJN2tl?= =?utf-8?B?emc0dlpobnZGZ1A3eGUrOGxLMjM5anZMMUFPWTQvM0VZWkNicGRBR05NUjc0?= =?utf-8?B?andPSEw5ejJmalBoeXBWaHVPK1NQZnB5a01oNWF2VGI3Uzh0S05KUkRTMHg1?= =?utf-8?B?bTl0NEIzWEFEcFJ0LzN5aXZyaE5SeFhkMnNoTVlmT2MzMUZCVG8yM0pSanJO?= =?utf-8?B?anIwVlNpZHNLNEMrblpidm90WGM4Ty85andyWnMwd0N5eTZvaGJGZU1leVlE?= =?utf-8?B?ckRGNGlZVkJYdS9WSFdEeC84TDRnUTUzU3ZKQjF5MHorODRGOHZoZVprMkFO?= =?utf-8?B?amFFU0VYOURIaEh2MkV0b1RTOGxyYTltWnN3cS9jSXNkL1VjTnZWOE5ORDVG?= =?utf-8?B?VmVZakowdEIyVjgvSit1cnZwcW12d2s0K1VuM09CSWJiK3BBeFNrS1ZxckhC?= =?utf-8?B?Qi9aTVBNUWxvMnBhUnZMZmxQVUxoVE9aWVdPUmNBUGIvdXJaNjZ5ZUp3QjJi?= =?utf-8?B?Qm82dGlZR2Y1N1pzRUZaSzJmdHBPUStQRFZqNXp2S1JJbnUyVEJNSVdaMDFr?= =?utf-8?B?d1FER1V1YlZTS2NWZjRHbmx4VTViZi9UNm8rM0xtWnN3SCt0Wk5jc0NWR3ps?= =?utf-8?B?NXJGdXozYmlQWUlqb096b25IbnExV01IU21iZnU0Q2dPZlc5TDRRWlQzdTFk?= =?utf-8?B?dGprbFV0L1crbEh3SC9TUTN6ZE94OHVGVlA1ai8rRWtjQ0lJdmF2WXA2Nis3?= =?utf-8?B?MjdnMWlSVXA3MmcxMm44SjFmeVgvdXNldkIyckhvdSs4V09GYjh5RHI1a0ZI?= =?utf-8?B?MmNtaEtZQjI0cWo0dGJERzhxWlEwTHFuVndTeG8vSXM1aXUzRlNoMkdHUzVs?= =?utf-8?B?MHg2NVlLZ1RwNlFYYzNGWjNMMHA2aHl2cmkvcmJoemtqK3J6cGZLSVdOQTdC?= =?utf-8?B?R0FCTU1mZ1R4TjlKVkIwd3YxNDVkaDZhWXUwYVIzWkJha1Z1aGVhVllMMjJZ?= =?utf-8?B?ck9XVHdYMHJxTUNLUkZreGlKOEZaMVVWeVhhb04yQVB3a2JNblFCelloOVRZ?= =?utf-8?Q?p0Lnekuy/CuX9rPw=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb76100c-c2ff-4e46-d0da-08df35ac47f0 X-MS-Exchange-CrossTenant-AuthSource: PA4PR08MB6061.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2026 11:03:36.8634 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7IAoO/T4FNTqCmnPl6FKbk21qW0W+j6+gCjLwe0gAZkxHYFehzIqcve/972hXHHrL4eVZDITVwhTfRg6RzpJdUOwfqVCYLwOK2rzujwdCIc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU4PR08MB11175 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1] drivers/vhost/blk: reject a head that is still in flight X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org LGTM Reviewed-by: Andrey Zhadchenko On 10/28/26 09:14, Alexander Ivanov wrote: > vhost_blk_req_handle() takes the request slot by head and overwrites it > without checking that it is free. A guest that puts a head into the > avail ring again while its request is in flight makes the slot get > submitted twice: req_inflight is raised for each submission, but the > completion path sees one slot and calls forget_request() once. > req_inflight never drops to zero, and vhost_blk_flush() on backend drop > leaves QEMU in D state forever with the block device pinned. The second > submission also overwrites bio[], bio_nr and the iovecs of bios that > are still in flight. > > Mark a slot in flight from bio submission until its completion is > handled, both under vq->mutex, and fail the request if the guest posts > an in-flight head. The caller reports the error on the vq error eventfd > and stops processing the ring. Allocate the slots zeroed so the flag > starts clear. > > https://virtuozzo.atlassian.net/browse/VSTOR-152123 > Fixes: d8722ff88c5d ("drivers/vhost: vhost-blk accelerator for virtio-blk guests") > Feature: vhost-blk: in-kernel accelerator for virtio-blk guests > > Signed-off-by: Alexander Ivanov > --- > drivers/vhost/blk.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/vhost/blk.c b/drivers/vhost/blk.c > index b170439a1806..668986449373 100644 > --- a/drivers/vhost/blk.c > +++ b/drivers/vhost/blk.c > @@ -79,6 +79,7 @@ struct vhost_blk_req { > u16 head; > size_t len; > int bio_err; > + bool inflight; > > struct vhost_blk *blk; > struct vhost_blk_vq *blk_vq; > @@ -434,6 +435,7 @@ static int vhost_blk_req_submit(struct vhost_blk_req *req) > if (ret < 0) > goto out; > > + req->inflight = true; > vhost_blk_bio_send(req); > return ret; > > @@ -457,6 +459,9 @@ static int vhost_blk_req_handle(struct vhost_virtqueue *vq, > u8 status; > > req = &blk_vq->req[head]; > + if (unlikely(req->inflight)) > + return -EBUSY; > + > req->blk_vq = blk_vq; > req->head = head; > req->blk = blk; > @@ -628,6 +633,7 @@ static void vhost_blk_handle_host_kick(struct vhost_work *work) > added = true; > } > > + req->inflight = false; > forget_request(req); > } > > @@ -703,8 +709,8 @@ static int vhost_blk_setup_vqs(struct vhost_blk *blk) > if (!vhost_vq_is_setup(vq)) > continue; > > - blk->vqs[i].req = kvmalloc_array(vq->num, sizeof(struct vhost_blk_req), > - GFP_KERNEL); > + blk->vqs[i].req = kvcalloc(vq->num, sizeof(struct vhost_blk_req), > + GFP_KERNEL); > if (!blk->vqs[i].req) > return -ENOMEM; > _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel