All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: "Eva Kurchatova (Virtuozzo)" <eva.kurchatova@virtuozzo.com>
To: no-reply@sashiko.virtuozzo.com, khorenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1] ms/tracefs: fix a leak in eventfs_create_events_dir()
Date: Tue, 17 Nov 2026 08:02:58 +0200	[thread overview]
Message-ID: <97ea4db0-fcc9-48c5-8380-bbb549a76e84@virtuozzo.com> (raw)
In-Reply-To: <010701a1e812c113-b282fd1a-2a58-4655-8b5b-14ef55346c78-000000@eu-central-1.amazonses.com>


On 11/17/26 07:55, no-reply@sashiko.virtuozzo.com wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Low] Fixes trailer lacks parentheses around the quoted subject
> --
>
> commit 19e003c422eeb3e947b70fcf695dd6a60f9073e4
> Author: Al Viro <viro@zeniv.linux.org.uk>
>
> ms/tracefs: fix a leak in eventfs_create_events_dir()
>
> This commit moves the tracefs_start_creating() call in eventfs_create_events_dir() to after the security_locked_down(LOCKDOWN_TRACEFS) check. A lockdown bail-out then no longer leaves the parent directory locked.
>
>> ms/tracefs: fix a leak in eventfs_create_events_dir()
>>
>> [ Upstream commit 798a401660a151633cb171738a72a8f1efb9b0b4 ]
>>
>> If we have LOCKDOWN_TRACEFS, the function bails out - *after*
>> having locked the parent directory and without bothering to
>> undo that.  Just check it before tracefs_start_creating()...
>>
>> Fixes: e24709454c45 "tracefs/eventfs: Add missing lockdown checks"
>> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
>> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>> (cherry picked from commit 3bcb274a192fc89a003a7808a877faf1f9a81ce3)
>>
>> https://virtuozzo.atlassian.net/browse/VSTOR-155413
>> Feature: fix ms/tracefs
>>
>> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
> [Severity: Low]
> This isn't a functional problem, but the Fixes: trailer is malformed. The subject is not enclosed in parentheses, so Fixes-parsing tooling may not recognise it. Should it read:
>
>    Fixes: e24709454c45 ("tracefs/eventfs: Add missing lockdown checks")


This is how both upstream commit 798a401660a1, and the 6.12.y commit 
3bcb274a192f look like. The cherry-pick copied them verbatim.

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  reply	other threads:[~2026-11-17  6:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  5:50 Eva Kurchatova
2026-11-17  5:55 ` no-reply
2026-11-17  6:02   ` Eva Kurchatova (Virtuozzo) [this message]
2026-11-17 15:16 ` Konstantin Khorenko
2026-11-17 15:16 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97ea4db0-fcc9-48c5-8380-bbb549a76e84@virtuozzo.com \
    --to=eva.kurchatova@virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=khorenko@virtuozzo.com \
    --cc=no-reply@sashiko.virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.