From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 5BE7A81377 for ; Mon, 9 Nov 2026 14:40:27 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9EdFnb000479; Mon, 9 Nov 2026 17:39:16 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9EdFnb000479 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="RFCk5yp7" Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A9EdEMg000474 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 9 Nov 2026 17:39:15 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A9EdEMg000474 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-8b60129a46eso1416172b3a.1 for ; Mon, 09 Nov 2026 06:39:14 -0800 (PST) X-Gm-Message-State: APuU4Z/b6yLd8aYHoIjpov7v/ApBvksxu0Ti12pucF46EU6gdlAJX/8S RnP3bRm3NOKVZnLDqMwgthonG4kn7o/fp3U9G3/vGsIoYozuELmbNH4RHaWW8VcUYjXKeRrsaSD SabkNdEcshR70es5zJC4dP2BLEG9GxkiJpE3eXaWKFEYnBwRk3HNBnw== X-Gm-Gg: AYBFou3lcYWb1O0a23tzg2owkacLiH2FUr61C5QnKWkziQB/W68UfxPwf+pQPjQaoB5 k6JVhoHPhqNbN0tdZUmjtRdzk2kIqajgsHKBC+fLtUIW49SNmPqh+t0GBI0zyB9+ZkvRTx/Z1mP 8nOwfNbF3D1tvtFuNv5K2q9xulGrlMGeE0dGbeeXcUyrlD86toXT3JLYp9xXrMcf/bQen9QcVSB C09rCO4Siac6cfjhX1pp7Vds1zrmTXDSd/wG9x4MSphDaXv8huzMAUaj3rJVAfFUeh6I1h7u5Ss HAEerRGnMqcOnRyp8lsECfOrZV7AmuRmeUj9S4yHQ4z800zC/226FAERVs7p5uRHD3IxunhSgCw fVcUEzHkEpFn+BfDiKYE3MN4wu8a4ly9Z6f+3LXu28gALwlLp7qx7F0drqqj3R3fI3wrYqY4mT5 LLFoTX5On3qp2tEp4mvU05xJIN+5U2poo= X-Received: by 2002:a05:6a21:50f:b0:3de:7854:8567 with SMTP id adf61e73a8af0-3eed2615560mr4534008637.12.1794235153672; Mon, 09 Nov 2026 06:39:13 -0800 (PST) X-Received: by 2002:a05:6a21:50f:b0:3de:7854:8567 with SMTP id adf61e73a8af0-3eed2615560mr4533977637.12.1794235153174; Mon, 09 Nov 2026 06:39:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1794235153; cv=pass; d=google.com; s=arc-20260327; b=T2nNFCld0KLxOqmGiClBoRTB1Ur5gNcemtVaHwuPTeZCTIWQ9/DJn33Mv1jPWUsvCg 1Kt1Pg4b5RFnkAVntX9JcxbjW2ezeYdd1ZAdy85a14QfFvfxs6M8znBl1inwIdQ10akA Cdx+BUED2IbjyAA5Z42Vdhy+ti8EpiDWljaomH+843uQWb0nVWXGGmD7pzD+fQp0kFYz wQqzwa9MOgMVECR+ptEauiv/QzgB9J7/l7ZkWGx/dvfhT0XiLp9VeMmmNDBSXJa+CIPG ir5iFIOJ/yLMLiu6i3nsiSX6krn7+9TI6Nxd+TiJHEEpi5t8btKVA1rsadkeOsN1gcxf o/Sg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=A5m+359VC4ZeBVFFxH5y785VzsIbUgETz1r3NGw1s/A=; fh=IlzoM7xapMIT9vjIu8V1YxnmOSGAT8hvLuDm+hjUGIo=; b=GZn30BOSfFEkK0xxpYvQoi9Iuw1iftH3XLXW12CzyDL+xTaQ/LZuuh00vKeueL+D0q H058SRSn+9qmfMDNa+DDsfhN5SUe25CO1jHOMaSzh9yQlrIoTsiFq40Uv4OaF0txD5Tn KzoybnzTAAbh7ddx7pmxo63OyT3AhbjfKVXORFg66ckmfK2Nl51tiZ8PYZeBPvEywGgl lYKZDislj1ULrozsGtmULoRp4L6w/jgE8Df/ngnBTrnS+YLG1kTtBC6sc9s7rCHhWIXW wPyo+pO6Hft0nj1/hYRoVHuegYsfJITShN4j/fMZKnNLk3XCyQ8yAZGAVDRv8o22N6HC Ob8g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=RFCk5yp7; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c20f::7 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazlp170130007.outbound.protection.outlook.com. [2a01:111:f403:c20f::7]) by mx.google.com with ESMTPS id 41be03b00d2f7-cdb9695a1f0si5657102a12.174.2026.11.09.06.39.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2026 06:39:13 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c20f::7 as permitted sender) client-ip=2a01:111:f403:c20f::7; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=RFCk5yp7; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c20f::7 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=v1duCdxQdsLiwbfiiSOM8hQtRrRxM8GXDINEQRD0Nk4J8p2009vcWdJ1E+vDsR/dyjaXOPglquqdTGY127J6xJLbCImwVprkQNVfwZc52uVJ52PTq+V2riPA8WVqdx36hScAHspwfcgbTdotte4+VeNo82S0F7jHQNdEXJLhCTloFj4rVv6it21m7q8oxRrbbjAqd/frwlhxhnRqWoZD09hOaZbmQI/dKknHIQWY/Bnz//+mQFc61z0NMhFcgND5hNFQckqkW5zAutLfNjim7TNxRCXao/s282H9utvYy7q6mmDmxtGZpEZR+7efyyLOI/9w6R6VDAC7Q3McF9YiLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A5m+359VC4ZeBVFFxH5y785VzsIbUgETz1r3NGw1s/A=; b=pU4QrMYt+l8QdFbGXQa8ID9VJAWqQka7p/lGWkiSsjB3UbKj7Y4qL827RFZczShoScqJD6gmlgBslnEdhOj+3fgrsjN8iI6twJKLMnjTALCOUvjcsBUhm7tbxptbzttza/jI84xn1hc8sl0Z0c30rcT6mfZstwFE05VJVXPScBtiBV2qv/+fwQCpmd0n1wMEdVEWR4nXSXD7hJ2Fa9sVw1YlFseA5IS+796kSWQugWsCIwHemjfMNdde7OZoFZoTgvLM0DywoK/uelJAiimzUnTctQUzYzwbelxprAzKgdXCpZk7uOkKnO8uu93ca96H1st9cFufVx0nLHluvYYjMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A5m+359VC4ZeBVFFxH5y785VzsIbUgETz1r3NGw1s/A=; b=RFCk5yp7N4cTPj4VGEu3MnxgppMY8+A6uEMj9jt6Py97Sj5OY+GC+pjBk7Z0IUEloADz/j7XAJYuKT1EN3YyXCrxLyRvAkt0kEcgFw9H67MMcMKgpdzpjKU78dkQRiE+7fU5y4KR8h4igwkts/42bLPwEDFWYR6U/KnoYorQUXaH4xE0PlC7yWGr9rqLy9vk4QUOOU9ccU8HdClXbO09ShxwtzMLYrpRVgXqRjDyCUc8jkBE8VlgvWBHJaAeZ3ksQJuP67Q77ZeIO/OS0CEgyGBq873/RDMTVNojY3iNKZMzck8iFaYKmac17ehLly9TR5rITvqkPWyfnWatkXd3Sw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) by AS2PR08MB10033.eurprd08.prod.outlook.com (2603:10a6:20b:644::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.592.13; Mon, 9 Nov 2026 14:39:09 +0000 Received: from VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a]) by VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a%6]) with mapi id 15.21.0592.009; Mon, 9 Nov 2026 14:39:08 +0000 Message-ID: <9c123860-2491-417b-a08a-1713546a5712@virtuozzo.com> Date: Mon, 9 Nov 2026 15:39:06 +0100 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, andrey.zhadchenko@virtuozzo.com References: <20261109140143.1408038-1-alexander.ivanov@virtuozzo.com> <20261109140143.1408038-10-alexander.ivanov@virtuozzo.com> <010701a1c0ab4520-2783c6ce-b60b-447e-8f9e-453427afd458-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Alexander Ivanov In-Reply-To: <010701a1c0ab4520-2783c6ce-b60b-447e-8f9e-453427afd458-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: ZR0P278CA0049.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1d::18) To VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10743:EE_|AS2PR08MB10033:EE_ X-MS-Office365-Filtering-Correlation-Id: c1298617-9e27-4d9b-f790-08df3e6f360d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|23010399003|376014|22082099003|18002099003|10067099003|4143699003|261028144727099003|261026121527099003|261022105027099003|56012099006|261021123027099003|261026140227099003|261009223027099003; X-Microsoft-Antispam-Message-Info: lTVnoaA6oHM3Uh2jn2a27lQC8PFrBme/hA6ayTQJwsN7tu/MHzB+T3AICu7dXrDRk8bFaXA/GztJDGCx/WGWuefTRe6+pgyt1qh4MuUB9xGIGpeqYgYHWtz5yR2ndGwV/8MMUgNDO9Qwgs8gOg27Rxlx96fU+RL9ZQazvYV6hn9HXHLxoQfcSizNmPjVPJZGmLr1yDFz/8fknM1e0ta4yrFPD4Isupl8WN+m6WQ0F5w+5d3N23YTytB2Xlm9afJAE+RnfTiBXbkCN56a3BKhj6QTEgJkxTFLAg7GsPL9rIouT2fNCChtofVX4T0qzZvlU9y8MSTCKUAGsEmmR9Bi1eA13pg7bl8vv64bAcbfWRrJNBLrSXrhNBrlg18joRyodApTwh2KX3pFYl3itNfR5W/yC64SoEYn9qfoTEHCBz9CTIcLryRqbEoMbynwND3bursXpJD9G+vkXT+AcI/2ZxDqoAOAb4yJUpdF2dFhG2dHyMDccmPbRdx/SRhV2Jf2avpnSrnntFMGUoAQZls855Yj3XxDNcbrG1FY5E261L1JM2fxjmdywZXLP9Wm7N+C1ebVbjwecweFIo+hFoepEu5de3ZgV3GGgKpcm0zQqUDsZACaJfCfGT+GiM6ZvxQoWGE/J35PPiZP/H0sUGpLdlpl9IUiHkFMrZrBFBXQwk4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10743.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(23010399003)(376014)(22082099003)(18002099003)(10067099003)(4143699003)(261028144727099003)(261026121527099003)(261022105027099003)(56012099006)(261021123027099003)(261026140227099003)(261009223027099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVVVNGwwMTM2ZnFRdHljdUFwakZyZVpQY1paZm5XM3NKNllBdFgyY0pHV2hI?= =?utf-8?B?UCtSUlBNUlJvazc4U1pWMVpEVGN6eGQ3bzYveVpMQ2IzSzFLQnZZNjUreGNU?= =?utf-8?B?TXZKZXoxOUNkQ2Z1NFJFWGlsYXA2SFNsTXhzM2dzTUt5ajVrenlramVOL3c5?= =?utf-8?B?VUFmZFl2dGIyZ3BuSisvSnMyNG1NR0x0d3YxTURhVnJyUFRDYkIrM3NFUU1R?= =?utf-8?B?SVRMMytHL0NLbHhWdU1INFltUTRyRXhkZkF2V0pMUWNSTzFOUnNhb1lOL3E0?= =?utf-8?B?eUYxYjFJQnNzWVZKVG41REZXbHpJdGNpQWZiMWlsQ2RBL1NaWnZmbjhzQjk0?= =?utf-8?B?U3RmcFVwOEpYQTRnQkF1RlNOS1lkak1jY2VaaXU4RVBueUFZSnR5THkvbVZY?= =?utf-8?B?WHNlOHcza3BqeFZVWHRVVXJEam9SSC9pQlVObUJkeWRMUWN5WFZJeW5oZ2RL?= =?utf-8?B?Tk9tNi9kTVQvOUtCWDJ3Q2RUMzBiY2RQRzZWTmY2NXFXUHpCR085cVFvTlpG?= =?utf-8?B?ZkgvUW50bU14a1RhUS9RNUdGM0VxMFhrTE1hQkcwZ2hBbjdkS0c3ZDkySEpT?= =?utf-8?B?R3hsN1BYM0pPNFAySyszWHY1NHpPU050bjI0M3Vld2dCQTlkVEx3LzlmU1pC?= =?utf-8?B?TFF0ZWlSSVBVUnBzeVBsbGxmYitVQld2Z29vWUduTGVFWG1RaGwxcWE5OXBQ?= =?utf-8?B?OCsyYWE1dVgwUC9YVmtWRDVZSC9lQkQxT0Y0cnMrRlNIQ2FLNUdlNWhoZ0Nz?= =?utf-8?B?Z3Y0L0pCWE0rbWhFejRuT0tnV2hLd3JzYUt5RGMxZDFLdFJrVklhMEZuV3lY?= =?utf-8?B?TTEvVGUveml4QjQxdVhrWDJVU2dTNTN2amxiQ3FmbzZGQkRjTmwwTTlseXRU?= =?utf-8?B?YzZ3eFFYOWY2RkgxSmVWRTVidVczWlBhMDN2aXhCb1hoOCtKQUtMUmhyN0w3?= =?utf-8?B?dlJJMkI4VVlvcFRsR1g2RzNyMzJJdVZEOFd2OTN4ekExckpiYlhEa0pvYkxJ?= =?utf-8?B?RERLc3ZHWmN1bVNDZW1oeVdVUUR3MW8wai9XaldYb1BSbGVoS1h0YU05RnAr?= =?utf-8?B?U2F4U2JVcTRGU2IyVm5LbkdxeHNaOTZXYjFySG40ZkpDdlNSWEZ2Y3dWeCt6?= =?utf-8?B?OEE0NDM5UW9jQ3ZUNElzRzdENHQ4cjliNEY5MkhWWjR4Mnoxc3lrdkdBQkNW?= =?utf-8?B?clBBSGc0TlNIKzBMdkVDeGFKVWNWc05rWE5mRGNwalowdzJNOEV3M0hmUUJo?= =?utf-8?B?eGZRT3orbWxxTXBNb1ZoYWNtYVk4c1llU08vMVJDZjRMY0M0ZDNhVTE2SWtX?= =?utf-8?B?WEEwVk1zVlhrSEFVRXZDSFFsZ3pTN0dCL0JtVGxwdTUyRlppZlJ5eGNqOGJy?= =?utf-8?B?Y0VRSEZtVHJIMlBZNVE0Q2lHeVBPeUpkcW01NklrbHlGTkZqZnlxanhwMGx2?= =?utf-8?B?VS9pcjg3aVBnMDlLN1RKRXd2SUR0MnE3RVZZQVBiREVJbTVveG1IdFdnNlJ1?= =?utf-8?B?ZFB6TnRXRHBFZzEwM0lpOWxOU1Jna00vY0pEc1JWQ1E5NkhpT3IxalRVanhR?= =?utf-8?B?ZWVGK0tSLy9ud01FQ3ZtOFE1ZkpMQWUzZ09HM2RKdGZBSUd5ZW5WRWRrN1Y4?= =?utf-8?B?TlFlWTYxRkhUSGF5bkxMVTVWbDhwdnF0MnBKZ0VQbElxbkFMNHBoOFJpVzRl?= =?utf-8?B?Ri9OYWlLWU0rQ3JzVUlVbVd2bzJUMjlRaTA3NUY4azZWYUxyVWtlcE5BMmMy?= =?utf-8?B?T0RmRHJhaldMd3VqMm9wclFwSDRtYmZUSjJnOUhYRWxqSzhkb1l1NjBqVHRZ?= =?utf-8?B?TnRwY2t2VitPSHpGWVFiNUQ5KzZ3VmtjQUVYSHNKSFVtc2J4eVBkTXBGV1VQ?= =?utf-8?B?RTRVa2tMT1lMODFRaTN1MlJCdC82WGxQSU1YU2llSmRhbmhqRkVZbzVHUVdt?= =?utf-8?B?dkF6VU1XNjY5WFFZMjFzb2djMU1Jb2F4dUplM2ZVSjlNSHU0OTd6V0s4d3J5?= =?utf-8?B?TXpVVXQ3OFRQdmxsY0R6M3pLdC9HNmthNGl0aHpkaFNpTWNZVTR5ZXhpN2ZX?= =?utf-8?B?VGdjK1dodDRwU1dqN3E4SUJ3TnBWRFdXL1BJaWtncEZFTmdiZVEyRmxjVkIz?= =?utf-8?B?NUR6bVduVjIvazJMQ0pGNmlQUzljSmdmejFFODdobkVFTGZHTytMcjJjanN2?= =?utf-8?B?MEllZ0N1ZUxML2E2K3pteTdmeWFiSXNReGhSUUJ1UnJGY1VBM2VYaE93djBy?= =?utf-8?B?ODJKaHlZUUt1ak80NlRvZlVudEhGUGhDUVhnbTJUanpRanFDaFIvbUJVQTFH?= =?utf-8?B?K2swbDVCamM1bHdyQTZJQkRQVFBJUVAraSswOXVWTDNwUXJBMzhvbitFWjRq?= =?utf-8?Q?aLuFmMJg1DY+exWQ=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1298617-9e27-4d9b-f790-08df3e6f360d X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10743.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2026 14:39:08.2248 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ae+GpxvNRk/L6GCdEztvZL8rIxJLQYrsxYnGUF8O3zNBRIOG3FxaKGTqU0pNNUdzm3WEFtIzMq7eyU+S1VvRc3HYHQVXF3ygLecZtPyWQDU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10033 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v11 09/10] dm-qcow2: retry R1/R2 writeback that failed with ENOSPC X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 11/9/26 15:16, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Low] dm-qcow2: flush gives failed R1/R2 page two retries, not one > -- > > commit 2997fd4391d8fcb3d55f988df71bac728d0346e1 > Author: Alexander Ivanov > > dm-qcow2: retry R1/R2 writeback that failed with ENOSPC > > This patch redirties an R1/R2 metadata page whose writeback failed with > -ENOSPC, so the slow writeback timer retries it. It adds a flag, > md_wb_no_retry, that qcow2_flush_deferred_activity() sets on its second > pass to stop further redirtying. It also passes the errno of a failed > metadata write through complete_metadata_writeback() instead of > converting it to -EIO. > >> diff --git a/drivers/md/dm-qcow2-target.c b/drivers/md/dm-qcow2-target.c >> --- a/drivers/md/dm-qcow2-target.c >> +++ b/drivers/md/dm-qcow2-target.c > [ ... ] > >> @@ -173,7 +173,9 @@ void qcow2_flush_deferred_activity(struct qcow2_target *tgt, struct qcow2 *qcow2 >> struct md_page *md; >> int i; >> >> + /* Retry R1/R2 writeback failed with ENOSPC once, then give up */ >> for (i = 0; i < 2; i++) { >> + WRITE_ONCE(qcow2->md_wb_no_retry, i == 1); >> if (timer_delete_sync_try(&qcow2->slow_wb_timer) != -1) >> qcow2_slow_wb_timer_fn(&qcow2->slow_wb_timer); > [Severity: Low] > This isn't a functional bug, but the comment and the commit message don't > match what the loop does. > > Consider a page that failed with -ENOSPC at runtime and was redirtied onto > slow_wb_batch_list: > > qcow2_flush_deferred_activity() > pass i == 0: md_wb_no_retry is false, the timer is fired and the page > is rewritten > clear_writeback_status() > if (ret == -ENOSPC && !READ_ONCE(qcow2->md_wb_no_retry)) > qcow2_md_make_dirty(qcow2, md, true); > pass i == 1: md_wb_no_retry is true, the timer is fired again and the > page is rewritten a second time > > If the write in pass 0 fails with -ENOSPC again, the page is redirtied. So > a page that had already failed gets two flush-time attempts. Only the > failure in pass 1 is final. > > The code comment says "Retry R1/R2 writeback failed with ENOSPC once, then > give up". The commit message says the flush "gives the page one more try" > and that "A page that still fails then is not redirtied". > > Could the comment and the commit message be reworded to say that the flush > makes up to two attempts, or could the loop be changed so that only one > attempt is made? > Fixed the commit message. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel