From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konstantin Khorenko Date: Mon, 24 Aug 2026 14:28:06 +0200 Subject: Re: [Devel] [PATCH vz10] selftests/prctl: skip anon VMA naming test when unsupported In-Reply-To: <20260821150523.792660-1-eva.kurchatova@virtuozzo.com> References: <20260821150523.792660-1-eva.kurchatova@virtuozzo.com> Message-ID: <9ea77c8d-0d52-4902-b092-033999271d85@virtuozzo.com> List-Id: 1. ack the patch 2. do not forget to remove the kludge in hci-kselftests: # prctl set-anon-vma-name-test test fails because CONFIG_ANON_VMA_NAME # is not enabled 'prctl': ['set-anon-vma-name-test'], 3. There are 2 more bugs nearby, please fix them and send to ms as well: In tools/testing/selftests/prctl/set-anon-vma-name-test.c, FIXTURE_SETUP(vma) checks both mmap() results against NULL, but mmap() fails with MAP_FAILED, so neither ASSERT_NE() can ever fire. ASSERT_NE(self->ptr_anon, NULL); ASSERT_NE(self->ptr_not_anon, NULL); -- Best regards, Konstantin Khorenko, Virtuozzo Linux Kernel Team On 8/21/26 17:05, Eva Kurchatova wrote: > PR_SET_VMA_ANON_NAME returns EINVAL on kernels built without > CONFIG_ANON_VMA_NAME, and every renaming test then fails. > > https://virtuozzo.atlassian.net/browse/VSTOR-142442 > Feature: fix selftests > Signed-off-by: Eva Kurchatova > --- > .../testing/selftests/prctl/set-anon-vma-name-test.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/tools/testing/selftests/prctl/set-anon-vma-name-test.c b/tools/testing/selftests/prctl/set-anon-vma-name-test.c > index 4275cb256dce..815470c47aff 100644 > --- a/tools/testing/selftests/prctl/set-anon-vma-name-test.c > +++ b/tools/testing/selftests/prctl/set-anon-vma-name-test.c > @@ -76,6 +76,18 @@ FIXTURE(vma) { > }; > > FIXTURE_SETUP(vma) { > + void *probe; > + int res; > + > + /* Naming anonymous VMAs needs CONFIG_ANON_VMA_NAME. */ > + probe = mmap(NULL, AREA_SIZE, PROT_READ | PROT_WRITE, > + MAP_PRIVATE | MAP_ANONYMOUS, 0, 0); > + ASSERT_NE(probe, MAP_FAILED); > + res = rename_vma((unsigned long)probe, AREA_SIZE, GOOD_NAME); > + munmap(probe, AREA_SIZE); > + if (res == -EINVAL) > + SKIP(return, "CONFIG_ANON_VMA_NAME is not enabled"); > + > self->ptr_anon = mmap(NULL, AREA_SIZE, PROT_READ | PROT_WRITE, > MAP_PRIVATE | MAP_ANONYMOUS, 0, 0); > ASSERT_NE(self->ptr_anon, NULL);