From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id A65148017D for ; Mon, 26 Oct 2026 15:23:21 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69QFLutk012097; Mon, 26 Oct 2026 18:21:57 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69QFLutk012097 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="FOYC5ZmJ" Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69QFLs9t012093 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 26 Oct 2026 18:21:55 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69QFLs9t012093 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-8ab43f7f5faso54741177b3.2 for ; Mon, 26 Oct 2026 08:21:55 -0700 (PDT) X-Gm-Message-State: AFq9FYLk15AbmM8IYyX9sqdUZ50sjl6A2NRJeRP0pOvDmoV4wD00Tsvn BwN6LWOY318M+R/rjKvUgGb7uEKZpHDTmJnNp+/ylwdn7Xq6JKBY4uxX4ulxeSNPd55UiYxWCXI HBLsTkxUIgLKP/Mn8nYQDn3hoYpxB0BoUJEeGCjSD0BWvfFMVqIrZ7Q== X-Gm-Gg: AYBFou0YQCxKwU8iCx/PNbsxHxswduiNvXp61gsFN1sBLDRWlPqiAPYusnuskI7HTco na/FqKMsktrA6JAJXq0BJ0cYLXDOfHRCGkBpn7ul8bllyxKgB9WXAOfUOYF4Iga8NLU5dJ0QikX EFjJ1NYRuS7dnESqTihMzut2vfvI34KGSfr1qqdBW15atsNExlbToa43sQwfqlTP+t9U0X0Jvef Xzxdbs9csOx+OdbPK1eM//t3bjfiyKt1WBDDUfLb+IGm5xoJabn5pUtdRCUZdT6fRoPwJB7XHh7 CVwQ01ylfi4GrLRUi3nQ9Ohw5YXa3ONQcmO15z81G5l9gZtX13lfU99y6wrDeKNnLdvCzGwBIVV LE1v9Y2MAVm+OCRXMqMMz3r9vhV0aB73aOQqWhVs9FTFe1SPCo6McBq1jNcFTPz0ytb3aZYUWh9 kSHhbqiT12DADjWzhhfQsMdIC3NisNhHN2 X-Received: by 2002:a05:690e:b84:b0:679:ac65:4898 with SMTP id 956f58d0204a3-67a4525baf1mr4202366d50.5.1793028113787; Mon, 26 Oct 2026 08:21:53 -0700 (PDT) X-Received: by 2002:a05:690e:b84:b0:679:ac65:4898 with SMTP id 956f58d0204a3-67a4525baf1mr4202354d50.5.1793028113140; Mon, 26 Oct 2026 08:21:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1793028113; cv=pass; d=google.com; s=arc-20260327; b=nbDTor+RticnUwHsU8FWAPYsQd1C26+TJWZ0dz8LxxArVAhUaEW+u22yehzd2ftYt2 oT+e0HMAI4oY9RKn/fKR33KO6NK3T69KCSIIJMuymfAbW2zujfHxCIwBbh6DZ9AIcm2S lx7nPWQHr05Sq1VPGT6yuOwPgUcmbj4vj7xrpQF8yHl6z1yi8TtzyUXrEhhqVqcvAnLf og+FbFEznK/0+6beJshe7mECVx4FaXGQDF38XsTLKBtfd3ovOnbEECi143VNu0LUk+E1 HUfA7XoM0Fz28WaMkaUfc71CZ6DVFZe8i1k69RJyLixG3FIgH48t/ILRoiPyeTharBWG R4IA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=cNVcTXXYUDHrsvfYwYUgVM3Np/e7AnJQhymXjXboSIs=; fh=NPLL+Nx2SOKuyMzrh59oIWEZfDUDydMx1Ehn/EDiW8U=; b=omKQMRNzrkcMsi28k/rfIlssaxHf0ii1B2ewreqJUSet3WjGV2m58izxyPZjqBIMMx 060hS6wVEtfJJnHu7gT8T1J3ziHBEItcFWIN7hyBW0Hr9qiMEY5EtzkKAAlvD7vYnut6 RDZYEXOFiteLp3bgBrGODl4qeZ6hKBWLoJGPzxepo1pxOPpNjGP40Uo7M30UT++aCqwS FHjAgPMHiD5EKa8e5L9aPJaZj17KKydZ7aIn0yU7J/kgIOGW2lXMEj/x3SU5oT8fqEgJ NEoXVZ13cCd5OS+gq0j0GHkMloq+8FTfdMVKNwXWdzm2z8eilszY1oy19h7U069IAMNg GgAw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=FOYC5ZmJ; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazlp170110003.outbound.protection.outlook.com. [2a01:111:f403:c201::3]) by mx.google.com with ESMTPS id 956f58d0204a3-67a46291f62si5481697d50.296.2026.10.26.08.21.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 08:21:53 -0700 (PDT) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) client-ip=2a01:111:f403:c201::3; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=FOYC5ZmJ; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jugZRfsD8Xv5bjTVM0GaHRTutqlJrTfkXPBl3+PHpFME9oktro/M/PBqH7l0I4KPCvxrxE8b9FA/XmxPoGaBdeA0EE8M+2UA4qzANORtoNiiPJUPTc/8I75FFw7sFQ1ik+vHWKZBFENAk6w/1ZOzx0A60B/KUmOgCNjdNHtUcCL5ANelISIuSqkGB3XD//AX/AlVGCZcKfrY7tx+HwlEBaXO55Zk2CvNnpBDl28pwVky+Ib/mINrwbiV/hlqG6RGsmbDk/hVqArkRCcpKcdNWBMRBL5O5oATtDVgxV7jELuWsSA2wLt+BShkoyuAEc/ZjuR/H6G+j5rlPn7kw3PdGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cNVcTXXYUDHrsvfYwYUgVM3Np/e7AnJQhymXjXboSIs=; b=J978th9GqRgrOe9T2qLg3JU0BGqiBI8RpFI9LLZYnUjLvQ2MdSzfi1Pq5iNSuy41Ittzpex/g4bR0wmE9jQyS5reqObkIc14c6qmz+iAaPNAQXp8IRu2RfEDGYQmcaI0HVuT+EFNYK4BAYf1i0c2lH05NUl1IKwJkyvNqAQOkdCD3zvc3HyWpQ7ueREA+a5wTAsI242hwLA3oX3pBcTazywU/HQvYWcZBWzFBWsG4dENoVBTuHmKsKHgZnqoY3EMZa6Ossoau2bU0+MrIT92PtRRb4FhvOi7+Ce7QKto2EOF9kE3thTuvrMUGrWJx6vKBJMrc8f3oWE2ugkw6dOYaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cNVcTXXYUDHrsvfYwYUgVM3Np/e7AnJQhymXjXboSIs=; b=FOYC5ZmJiXSR6Akxws4n2fpDWWh0IIBstEA5L/6jqeRFnG4GLhT5MQBVfAl0oDJ+mSOtJ4b3iVu8RlRlomQ+RzsBBus+FAD6AnTj52AwwQrK1yjCI7eFD6gJu2dvQQYLvkTWdbNG2slLKNroxzhKBYgzz1TW3M4Rlw5O5ywp/ufYWsd+6/Zk8kZzD48pU9kTb/VMfk0ZvB4A1qGodkPSxK/ltGJlg9vJI1XWGoECK38lXMGsYN77su2zR9uawtjS3tPJ+1nrwb9NVDyPf83pkBa0RGUIgGaD/v5z8CFfp03hU8TEOkL/t276Y05D+K4yTHU70XI+VyJxniCEAD0M6Q== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) by DU0PR08MB9559.eurprd08.prod.outlook.com (2603:10a6:10:44c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Mon, 26 Oct 2026 15:21:48 +0000 Received: from MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa]) by MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa%3]) with mapi id 15.21.0546.021; Mon, 26 Oct 2026 15:21:48 +0000 Message-ID: <9f396ef9-b678-431c-9070-34e13f6a787d@virtuozzo.com> Date: Mon, 26 Oct 2026 16:21:47 +0100 User-Agent: Mozilla Thunderbird To: Konstantin Khorenko , vasileios.almpanis@virtuozzo.com, ptikhomirov@virtuozzo.com References: <20261012-ve-printk-irq-v3-0-efc95fd5c78a@virtuozzo.com> <20261012-ve-printk-irq-v3-2-efc95fd5c78a@virtuozzo.com> <010701a12d311bbc-e0c366e6-3ae3-4211-8782-5d95ff805346-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Vladimir Riabchun In-Reply-To: <010701a12d311bbc-e0c366e6-3ae3-4211-8782-5d95ff805346-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR4P281CA0173.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b7::16) To MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI7PR08MB201474:EE_|DU0PR08MB9559:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a9838cb-b8c3-43f1-2f98-08df3374da9c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|23010399003|1800799024|376014|22082099003|18002099003|6133799003|261026121527099003|10067099003|56012099006|5023799004|4143699003|261021121427099003|261022075727099003|261009223027099003|261022105027099003|261026140227099003; X-Microsoft-Antispam-Message-Info: 2OgN5J6fPrXfn/4fV+1HJTVlSCMupwZ9t6jLnrKKTgSEnnpMabgtu3S9vQtpnj2LVJ2H4M12GXQ3unn9m/PfnQKn2QWy0UTKd4ePsSRiDxxyLz2s58pPVG5Y0f9WFfj/tazYnUR+TdWnYyTDnwrPEnTrIZ5b131buN5s2Nq2Chw2TG2WvegISNZMaTEO5L3eaoS2duXuyVSUOodfPlskSqk1CNpQpqE9wwInHLM/ZLR1h2UqSCvCXnSH1bckhycdJFI58FgOr6OIckGjs7zpy21ctglVbSrplnbNptolIGFgaAp5nLgNeHItLfsNSgg5o6Rc0JL0Adjb0HI1oV8ZRAGbpZwNaWFFxYaGPbItvYkC5Ctx+k2xNuJySqBdcuWhKz114wOuu9m3e8/XI5Mf2uyTJveEtsOB/tTCUbh+ZF6aFowNkveLZMe1xBNCjGHprCKLi7d/6NyU3y3FX9PYICHf6cBOeQ73yn8nPZYHVswJj4DiOtYlOaJfQ6PKUerLIkmu5H5bIJi0K7Kuk2RRsaUlGqbOvDMmOK8/DvP/+/5C75SjHMLeDyG31hRXoPtLR70OQBnYB2XqVUEmf7xXcFc707yGDljNZ8/62itIqA2wRih4zdYEVV29ALjTSWjH X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MI7PR08MB201474.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(23010399003)(1800799024)(376014)(22082099003)(18002099003)(6133799003)(261026121527099003)(10067099003)(56012099006)(5023799004)(4143699003)(261021121427099003)(261022075727099003)(261009223027099003)(261022105027099003)(261026140227099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmF5V1MwVGhnZ0ZUVitMUDdvSWxITUpWNVpWYThCV3FEWGR5dTFVdm4wQjAx?= =?utf-8?B?OWliSGlseUdvbHh6Vk9pRVJ6S1RWZ0lUdkpMWU5DYUtpRWEzVGJwTkdtYlhX?= =?utf-8?B?cEppVHZRNk0rbC9BQ2xnT2JnWHRDc3ppYUxmdWtHc0pSQjhDbG9qOHdXZlZ0?= =?utf-8?B?UjIzYkJGaG52Tnd6T2pxVWg3N0pLUERKcDhVN0tmYjk4eHYyT3dQM2o1dHY2?= =?utf-8?B?YXh3em1RRy9JZUZDVjZ1TUlXUmtaRmlqSjNOaDhlSjlQVzZoYXBVZGFyTVR1?= =?utf-8?B?UXc4bkhmUUZpVWxGOE04YU5nNWprbGN5a2svUmlBSkt2dUJhK0d0WUlPNGY1?= =?utf-8?B?L3ZwbnlOdlBsR3NRSTByN05SWUUrcWhJNGNxb1ZSSDZxZVArcWJxZkkzVmkz?= =?utf-8?B?Yi9rQVh0SzNZUVFnNitOd2lwaU5uSmxkTVYrRW5XY2Yyd1k3cHRoUERHZDFL?= =?utf-8?B?eW8yY05nSzlaU2VXL3czNjEzNEo2Y2dZWUgvUkpYNUtkT2xiUUpweDRKRnJy?= =?utf-8?B?Qk1CcU0wNkZqeTBrZEd2enNTck1NZkxubTlsdWFHcFRvNXdTNWREcm5LVWJk?= =?utf-8?B?eitkWVVYQkZnVGNBa3NiNTd3dWwxaGlUYkVxamxXQnRaT2NOWTBMNDFpTXFk?= =?utf-8?B?eUVEMnpFSS8raU5INFB5RHh1UG9jMUEvM2p2Wldia09PQW13ZzF3NzdFN25G?= =?utf-8?B?VEJNODNCSVJoWXFkOUY3OE5CNnRYZXIrWHhOMWl4MExRZWo4MEp3cjh6YzNp?= =?utf-8?B?dUVNR092RnhmTnVEeE45WXdJS0ZKaXpPTy9XZktNdDlnd1g2djhubkpGYjd1?= =?utf-8?B?REcxTGVPakF2VHJmcDZYQXp1a0JoM1hSMCtVWnhmTG4yK1lJbGpMa29vTHUr?= =?utf-8?B?S2x5MXFtbjFhZHdsRnZoMVpoN1FoT29YNE1ucVJEdUhJbTE3NDA1bVRiOGt4?= =?utf-8?B?b3VPR0pUV1BTTnF6QXRZS25YZ3p4Ti96NlM0OXBkTFpMMU1mdktiakR1bERJ?= =?utf-8?B?K2lFVm4ya24zT3paVUVTOTlhMHlJRXlBOXgyQWJ3M2Q2Q3VONStaK0Q5cEcx?= =?utf-8?B?blVNb1NqbEhGbzBRSFFDdGhyaTdzNHZuZ3U3OGdNOTdqeU9jT2hlWXZNdFpP?= =?utf-8?B?QjRCSjM3bGVtSGU3U1dvZlAyYkVFcm40a3FvSG14Mm9sOTJlYkR4QWhrSUN3?= =?utf-8?B?VXU0UFBWc2liajF2OE5ZanF0UjcwRkh6ZHZwSHU0cG9oUXVTaEZ1YUUrdEFN?= =?utf-8?B?U1NUNDJJcWF4dFcra2FlOEJ0M2M2ejZBbklrVlJHRFd5L2k3NnZHRXE3UUpo?= =?utf-8?B?SlBWRGlrVFV4TmR1T1E4bkpEUTY2d1B6WkZJQzh2azF5bmduN1Bnb3o0VWRw?= =?utf-8?B?UDM4Zlh6RVJOOEpIUS90REkyRUlCenVFbTZpSG5rdVdaTDZjellVMVdjZUZS?= =?utf-8?B?TEs1YktXU1R0NGNNaW1oSXRpYjE0T3J4NTB4RXZjcnZIK1E3MUQvZi9pSEsr?= =?utf-8?B?UENVYXMxMGx4RkVNelo3aGI2aG1DWURDYkVjcCtnWVFsM21ybHZyNFg4SUJv?= =?utf-8?B?VGxVMTROcElaS1VQaElzNFZ3YmtNckRVVU9tUUs1VUlLUlEybnFGc1h2ZEth?= =?utf-8?B?OXk0dmJaTHU0RkZrNUV4SmZsUHVnK2ZVd2x4RmtCQUxCMjBvcVR1WGtUODFZ?= =?utf-8?B?UDUxYUtKVGRDdDlKTVRUVDcvZXcrZHJ4Yy90UlRoTlY2YVRDVmxTSmo0Mitj?= =?utf-8?B?ZHhvNzI1Wkh2NjZuQUxoNE1JaWlGQkQ1T1kxZS9mZ2RRTktrblh4dS93SmxP?= =?utf-8?B?UEk3MFNwZVlQNmRvS2syYll6TWFuSnZsUGFDazFoU2RmcXYyaEhkMGdzN0RQ?= =?utf-8?B?bzRWZGFGUERNRmxHNFZFblljZFdTQkZKbCtSNE14eTdjNEFqVzFrcmFweGFY?= =?utf-8?B?WTJnemRyTlhtVzYxMlplcllRRHpJNVlOYXZzdGJkZExYVytxdThkRzEvaGJs?= =?utf-8?B?b0d2dXZBN2VkZzBwVkZJK0J4L1d6SDZjUzZBZEV1N2QzSHlTWHVzM2hsSHh4?= =?utf-8?B?OHJTMUI1R3FDeVRENnpicEdWZWpNblMrZmN3SjVqbVNEeCtVQXMyWWpkeEdq?= =?utf-8?B?enhDVHlPVUNDeXZjMnFZNEhqNWFpM0EyTkhPdVY2WmUvbzdjOHpwY0MwalIv?= =?utf-8?B?ZndlWkJrNjlweGFtL3JQL2FDVVNpaEFtcUJ5clFYMXYvOGFTOFRIOTVWaWJM?= =?utf-8?B?QVdTK0RvUHUzMmFkOVRjYi9sUDJqYjd3ZkJIVkpYSDVNcnk1a3JBRFJZYjJn?= =?utf-8?B?aTJtRjNXb3AwVEhxTE54RVJNa0hQVHFQSkMwRUhoaWUzZ1hMcnNDSXhocW5v?= =?utf-8?Q?lWTe8snGoYoWJHLE=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a9838cb-b8c3-43f1-2f98-08df3374da9c X-MS-Exchange-CrossTenant-AuthSource: MI7PR08MB201474.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2026 15:21:48.7390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Oa9yjhbe5s8Dz7VxTD8e9sngh5CPuLk/9WXTfQGvenc3q+VSB1BRf/pvDDSCjDoWUW4H6qx4yUSgS17gOvyXPm1VdvlnWa2PngnkZXy4DEw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9559 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 2/6] ve/printk: Report potentially leaking usage of ve_printk functions X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/12/26 00:59, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Low] ve/printk: host-log branch still keyed on get_exec_env() from IRQ/softirq > -- > > commit 8d09395a5f1fa2043bb21991f8eb2152c9a5ad97 > Author: Vladimir Riabchun > > ve/printk: Report potentially leaking usage of ve_printk functions > > This patch adds WARN_ON_ONCE(!in_task()) checks to the VE_LOG branches of > ve_vprintk(), ve_vprintk_deferred() and ve_dev_printk_emit(), and to > ve_log_state(). The goal is to avoid relying on get_exec_env() in > non-task context, so that nothing leaks to a random container. > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-146839 > >> diff --git a/drivers/base/core.c b/drivers/base/core.c >> --- a/drivers/base/core.c >> +++ b/drivers/base/core.c > > [ ... ] > >> @@ -4952,7 +4952,9 @@ int ve_dev_printk_emit(int dst, int level, const struct device *dev, const char >> >> if (ve_is_super(get_exec_env()) || (dst & VE0_LOG)) >> r = dev_vprintk_emit(level, dev, fmt, args); >> - if ((dst & VE_LOG) && !ve_is_super(get_exec_env())) >> + >> + /* Report IRQ usage here - printing to VE requires explicit ve reference */ >> + if ((dst & VE_LOG) && !WARN_ON_ONCE(!in_task()) && !ve_is_super(get_exec_env())) >> r = ve_dev_vprintk_emit(level, dev, fmt, args2); > > [Severity: Low] > Is the host-log branch still keyed on get_exec_env() in softirq or IRQ > context? > > Only the VE_LOG branch is guarded by in_task(). The preceding host > branch is unchanged: > > if (ve_is_super(get_exec_env()) || (dst & VE0_LOG)) > r = dev_vprintk_emit(level, dev, fmt, args); > > With dst == VE_LOG in softirq, the result depends on which task was > interrupted: > > - host task interrupted: the message goes to the host log, and then > the VE branch only produces a WARN, even though that branch would > have been skipped anyway. > - container task interrupted: neither branch runs, so the message is > silently dropped. > > In both cases r stays 0, so the caller cannot tell what happened. > > Nothing leaks to a container, but the outcome is not deterministic. > Would it make sense to check in_task() once before either branch and > apply a single rule for non-task context? > > ve_dev_printk_emit() takes no ve argument, so it always relies on > get_exec_env(). The in-tree caller net/core/dev.c:__ve_netdev_printk() > passes no ve and can run from softirq/NAPI context, so it reaches this > path. > > The later patches in the series ("Specify ve in printks" and "Use > ve_printk with specified ve") only help callers that pass an explicit ve. > This netdev path and ve_dev_printk_emit() are not covered by them. > >> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c >> --- a/kernel/printk/printk.c >> +++ b/kernel/printk/printk.c > > [ ... ] > >> @@ -2540,7 +2541,9 @@ static asmlinkage int ve_vprintk(int dst, const char *fmt, va_list args) >> va_copy(args2, args); >> if (ve_is_super(get_exec_env()) || (dst & VE0_LOG)) >> r = vprintk(fmt, args); >> - if ((dst & VE_LOG) && !ve_is_super(get_exec_env())) >> + >> + /* Report IRQ usage here - printing to VE requires explicit ve reference */ >> + if ((dst & VE_LOG) && !WARN_ON_ONCE(!in_task()) && !ve_is_super(get_exec_env())) >> r = ve_vprintk_emit(0, LOGLEVEL_DEFAULT, NULL, fmt, args2); > > [Severity: Low] > Does ve_vprintk() have the same problem? > > The host-log decision still uses ve_is_super(get_exec_env()) without an > in_task() check. In the series-final state it reads: > > if (!ve) > ve = get_exec_env(); > > va_copy(args2, args); > if (ve_is_super(ve) || (dst & VE0_LOG)) > r = vprintk(fmt, args); > > if ((dst & VE_LOG)) { > if (!ve_provided && WARN_ON_ONCE(!in_task())) > goto done; > > So a VE_LOG-only message from softirq with ve == NULL is either printed > to the host log or dropped, depending on the interrupted task. The WARN > can also fire when a host task was interrupted, although the VE branch > would have been skipped anyway. > > Could the host-branch decision be made deterministic for non-task > context with no explicit ve? > >> @@ -2574,7 +2577,9 @@ static asmlinkage int ve_vprintk_deferred(int dst, const char *fmt, va_list args >> va_copy(args2, args); >> if (ve_is_super(get_exec_env()) || (dst & VE0_LOG)) >> r = vprintk_emit(0, LOGLEVEL_SCHED, NULL, fmt, args); >> - if ((dst & VE_LOG) && !ve_is_super(get_exec_env())) >> + >> + /* Report IRQ usage here - printing to VE requires explicit ve reference */ >> + if ((dst & VE_LOG) && !WARN_ON_ONCE(!in_task()) && !ve_is_super(get_exec_env())) >> r = ve_vprintk_emit(0, LOGLEVEL_SCHED, NULL, fmt, args2); > > [Severity: Low] > The same pattern appears in ve_vprintk_deferred(). The host branch > ve_is_super(get_exec_env()) || (dst & VE0_LOG) is unguarded, and the > final-state code only guards the VE_LOG branch with > "if (!ve_provided && WARN_ON_ONCE(!in_task())) goto done;". > > Can the same non-deterministic host-log versus drop outcome occur here > when this is called from IRQ or softirq with ve == NULL? Same questions as in v2: http://lore.virtuozzo.com/kernel/960265f5-da39-4346-9297-709da41d6932@virtuozzo.com/. It is fine to print something into host. > -- Best regards, Riabchun Vladimir Linux Kernel Developer, Virtuozzo _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel