From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 7C0DC802A7 for ; Mon, 5 Oct 2026 09:58:23 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6959v4As007178; Mon, 5 Oct 2026 12:57:05 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6959v4As007178 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="cD012Xxz" Received: from mail-yx1-f72.google.com (mail-yx1-f72.google.com [74.125.224.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6959v2Du007173 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 5 Oct 2026 12:57:02 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6959v2Du007173 Received: by mail-yx1-f72.google.com with SMTP id 956f58d0204a3-6768601940bso3564315d50.1 for ; Mon, 05 Oct 2026 02:57:02 -0700 (PDT) X-Gm-Message-State: AFq9FYLkCceOqgeedJIiF/bRvEscPSdHQHQm1PcmoJ0Clblq9oWcsh8q eN320ujl6s8izQERAAGK8+71d577I/fAG6gixKqgEFYoi5EYoGWONjdglWYAX5hWI/S3YSELSCW Zi/fAGBLBm54GphsV1mOWmPy/WokvXIe45Gr9Actebxmmi60zLuL7CQ== X-Gm-Gg: AYBFou1+aZrDTrBcEtkHGx/BiXVNsD4OmAyjhkY7v7z4Z+wqc9LmDWxKwW+ayAlhHFH BJ7WGGMOT5C2dctksQMIdnO8YGHPbzKgzwJACvX/4xFRvMRSt06j61TZPeyhzbfcUDejgS1KcNd DJe8UQ4hybJzu9EZWlIMG6JLOGhWfkJ9QuBWZWBTap7knBjaCzQfks6+fldUlwl4fkhDKnV1kM8 4G6wxrkeJ6UkwT7mh2MSBKzq5FxKRi1z9d8beiawdn3912lAejpUiH/y77r3SfQSj0zDr+d+sSD yiU1FNxrJ82sAEGAee2S/2551vnbmq26VsYXrXX4jIQKPCwWnqMZY3mgkC0iMwTRsDWDP8YHEq6 PYflZ8Y2kAdVVvRXo47PreS+2myTIITscD0LNsr6S470P4k+ynABDB7BWr3LjGnIEkOifq9Gbf5 f0MXKRP/RbP+ytnOAgvBBvQzThPemgooU23A== X-Received: by 2002:a05:690e:14c7:b0:66f:c1bc:4045 with SMTP id 956f58d0204a3-677ac1fd2e0mr3526257d50.38.1791194221555; Mon, 05 Oct 2026 02:57:01 -0700 (PDT) X-Received: by 2002:a05:690e:14c7:b0:66f:c1bc:4045 with SMTP id 956f58d0204a3-677ac1fd2e0mr3526250d50.38.1791194220880; Mon, 05 Oct 2026 02:57:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1791194220; cv=pass; d=google.com; s=arc-20260327; b=BQltzYhT2Lg+NzWZeUaK2D9jynM6JFpSigVVP9XCj3jBI2cOcFytjlGoWmL3dTqGuV unquvUXqi/cd+S2BB1fUFPEHG554GZCFo6owHSWonTSsey1EVMUK3JOvKtvjnMIkCHJ4 yK7ToZKywvY4zLg/fgk27RBiBiSnGc4KuHQ5KhE8GXGsDGRLAciAu9XG7cUwhx/2nwIC 4bKlwngmYt/Wsi5A1pECoQd1vl2WCoaPScp/zqtcNhI5X5RugUgD2qh2U1//SBIgNK1A yISFvdSYV4iQuM9ikr3bNa0YZVwVCPUTmGPPybkbFuAIZjEefw7V/QSBmHjkUcUPf+CP Xzbg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=c6xYcC7JLJ7fE376N2j5gEZlO2pDr/LumN4HE8DD5CY=; fh=x+sEwlPrYjdnvyPJZgDx54RG2HGIpQh28bviCAKous0=; b=FOYQPB8prxvNBZD+3bBFNtdn7jNdWaYNbI8+XcK/MKsmvy5VkZkGYHABgrkFBDRXHj uGCSBL1v4LGz4hXY9uIi5PTYpZREzmjB8LYZX3i8qJiDkCBXoIO7ewvF9hXwCkbtgVh7 /41NAAO1E652ME3bdpaajHxelYX70Q7F6cHu4vwc4uayNJyW2lGa22pEj4CG+KMqXePg D4IQe62Z6MNhkNnKUGH2qvklYOXlt7BOKCsllPSO0xoOW/p2bCf6bwhEZwefA1EZJ4OX cbuIsqTxnsZHWP0/rPCMkrZVRYqTr3UGt3h2pOjDboLwW0X/6troSrr9bcXarM8sSRCg 4/oQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=cD012Xxz; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c207::3 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazlp170110003.outbound.protection.outlook.com. [2a01:111:f403:c207::3]) by mx.google.com with ESMTPS id 956f58d0204a3-677c1b68946si2717091d50.84.2026.10.05.02.57.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2026 02:57:00 -0700 (PDT) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c207::3 as permitted sender) client-ip=2a01:111:f403:c207::3; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=cD012Xxz; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c207::3 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=U+9x4pSn2Li2IB6LfJOFwD2h5GmfQ4zXCsPhixGdZnvJAacPPdxcZXXW/hDGI1H1+LTISeKDewvRo5unzvrbbaGo7AI5JSVCtHuJfcQHW+WWDVi2oWxY6BvEHvQIH9cdGDEJCIYcGFa2maSy3aVxtwIeNQQjJb+QFIUtoHeSS6TLGk7VoYF4aCOA634BGCPG6jjrCHwHEB7sAJnXxkCS9nQGzr1zts4n8zfx6G3INaszCVzaGRNq2AnGljrJsHFUWOtBW2Mzv/UKi68jTCNgG0Z1open7nZpEol8an89FMMEbv1FkEwQ3bQLsrMQFV8kRa5OSuALQhIdsXW1fmEILA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c6xYcC7JLJ7fE376N2j5gEZlO2pDr/LumN4HE8DD5CY=; b=lwKWCAM2+ODb6aCo+sppptd1x5kPp0KlZnfiPXq3hegtFm6uVJ8qQvM+qxdS3WDzvTpeVRpHZExZwRJGv7FMsI2eSgvyPXNCKL4ISSllwfk7QJ5cHWXUrl9z6T1kEP7uT/sSKgLiefHAfl4KFUJY+NKolLwdUTy26Z/AbQWCvYhxni3XGA/Tw3cIvE3BQAZpShAneoI1s92vJ0weVvB4IjI3z5UUBnf5TAKOLgPD0Z9gWdF0PzRzwVULe6CcnN4w+FjgFEBZjeP8h2W6E3zcxU4jXq9RNzai8fIByqdRtt2A2AqAn96h/T2DdBYLdOfJYpnQNYKRAGuoZrB1lkQW0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c6xYcC7JLJ7fE376N2j5gEZlO2pDr/LumN4HE8DD5CY=; b=cD012Xxz/zyV3iuJYpBd7iCb3SDdRctX1oEr6HvBVhd6Go4cPJlyXzmpd/BkpUgTprsh++PD/tmUojKN0a+NXZZuUBTVKee0NIZoUv+oDJYiqv6mcQ8sMGGes3kaVFHkVFomBCEFmZBg0teJ4Zw9Q6sZqu6wGHodIc3vlrn5pXF0pPIkvfZHqba30rK/u2FI3eUrMYmZdmJdzdHgIlP/Aj5gTC3zYfqqChIhQulnFgd5IcZxdU2opXZAQ5WgNd/OJgtz1go36qC/5BLm20xXgQm29Jm2+Cxlj8unmPSbEgtBRr3I9mwEr2rEhcRLD9YAJEQE0KB9M0zOZSm3t2ke7g== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from DB3PR08MB8962.eurprd08.prod.outlook.com (2603:10a6:10:43f::15) by MI9PR08MB122640.eurprd08.prod.outlook.com (2603:10a6:290:bd::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.14; Mon, 5 Oct 2026 09:56:58 +0000 Received: from DB3PR08MB8962.eurprd08.prod.outlook.com ([fe80::da44:b0e3:f6ad:8f8c]) by DB3PR08MB8962.eurprd08.prod.outlook.com ([fe80::da44:b0e3:f6ad:8f8c%4]) with mapi id 15.21.0496.010; Mon, 5 Oct 2026 09:56:57 +0000 Message-ID: Date: Mon, 5 Oct 2026 11:56:56 +0200 User-Agent: Mozilla Thunderbird To: Konstantin Khorenko , vasileios.almpanis@virtuozzo.com References: <20261002-ve-printk-irq-v1-0-cb55896d455c@virtuozzo.com> <20261002-ve-printk-irq-v1-5-cb55896d455c@virtuozzo.com> <010701a0fe8db21e-1c8b6d84-2c03-4dcb-9f65-a60bf2b23825-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Vladimir Riabchun In-Reply-To: <010701a0fe8db21e-1c8b6d84-2c03-4dcb-9f65-a60bf2b23825-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: ZR0P278CA0038.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1d::7) To DB3PR08MB8962.eurprd08.prod.outlook.com (2603:10a6:10:43f::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB3PR08MB8962:EE_|MI9PR08MB122640:EE_ X-MS-Office365-Filtering-Correlation-Id: 563154fe-6e75-4849-4373-08df22c6fe55 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|366016|23010399003|18002099003|22082099003|4143699003|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: 9AftydZB5ZLCoXnB2oN5lH59W+pDnXqKmsQZw6NCDQnbubvm+zBDOgXlY5H4Xrp2NRj+6lYEnFcyjiA65H91W2QUNTExbhGSbG2z5rcVGKe8uMJFPEIp/5aUrmEVtL/PdaJk11ffeTwkoFNv3sx+p9JfxnlK3WnJlb7/AA6JNyzzw8QYkvQQvgnFWpZwjSZY5owdUaX60Yd7DjtwQN9UUKVa/Vr5NbRUvM0Bw70yoz7AsYD3Ig17nBQpnk21a0jriK95oMbUfNbLWXeQ40PfZkRCYQIrCykUqr55t97V8LfCNzSbBXT3Mk+zwdmqXpKMrtJKXbyIIKi+GzNlRhAEY1zinXaMUgTYqxyZ5I2pTFMYYFhebuK854by15uMpeiZAwKzRs0P24v9OI2J+9JCzoUo59yfX9NVKSgGZKJhvYprZZv8SPJGaF598xAP1i3yph6X/k+/DbXFHIjQcW0PbD6V4Fz2S2Jru5jgUD/DvzZzGfBFUa3DoVu5+FJqgz4qrd/evB7wfoGCar3xG/RC5Ai2e3t/UG04y2k3VKGwN6kcmeECoVfegwr2V8buAhCn/r9eK+n4xCoCyPDY/X7eLpm3DL3BNuq67cJhiQE/kmX997xkzMuLu5ECeolubN9RY0CdZwgMDmJg00tpP5dKq5YvPFqOuyjzwFPrUjwVVAk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB3PR08MB8962.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(23010399003)(18002099003)(22082099003)(4143699003)(56012099006)(10067099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmExYW4rZlhzMEtseUNvRm1pMDI2QWxpckowTFBsT285QUs2MnZPaDl6b2p2?= =?utf-8?B?QW1IRkRJS3NxTFVSMm1WWkI2Z3JzOTFaOU1qZ2QxekNaY2ZmMGMyNmpabmwy?= =?utf-8?B?N2xoc2UzNGV3azN0ajYybXdRTFZiaXFadm80TWhoZlZwVTVMaTZhcFB1VGtK?= =?utf-8?B?K3ZEczNZbjViTjJ2S2FNR1d3SGNsK0tKN3dZbmU1c3BTc25icW9kc3dVVHFM?= =?utf-8?B?YVpOU0xZWU8zQ2hDWW9SVVlBdVNpNE5HaVVRYVdLOEduY3FUYXZYL1JjVEJ4?= =?utf-8?B?R1VMYWNWcnZmbkNNYlRQVENCRmNHVVVSUFRmT3NtTE1QWmI2NXZuU0hUZjdQ?= =?utf-8?B?VmVMWWxEU0dYWmxMaXlUZVViNTZvTnNMZlNMM3V5anVycmdadkpweUJIclAz?= =?utf-8?B?Mk54TW5aTjNsTC9DZTlRaWREcjhGVTlyVCt4WG92MnVaTzFYeWZkNWZydnJ5?= =?utf-8?B?bW5yazFzcTNQVVNRTlJwZ2RTb0JkRVJPc3EvVEdqd2paQ2tyL2VpZCtjMGhQ?= =?utf-8?B?YXdqZHpxWHJHc1o2dVZ5Y05CRHZsaG5ZRHR6YWVJbDBWMVRZMjZOcnVDZmQ1?= =?utf-8?B?UDJkU0hLRzd3WWdoTWNSOU9ZM3haMks1bmdmNGFSNEw5YUFSMFU1Q212L2ZZ?= =?utf-8?B?OVBBUkovUjBuQlhxMnBKallhU0FOYXhnaWNhbkpFY2VtcEd3aEVzeEFvRytp?= =?utf-8?B?aVMva2ljRHcvRVhodkFDM1dQSFR5aldsSVg2dWpZR0E1VElNVE1sS3JzdDVR?= =?utf-8?B?V0pCWTJXNE5vYUttaDNSbmZjNmJjUThsVWZ1b2MxTEpNRXh1SEdJMG8xdE9D?= =?utf-8?B?elRSaVd4SlZFUlpTaUZUMTZ6SHliUlRYYTJiVklQYTBwQjNuTEpUZnZySk53?= =?utf-8?B?c2QrakFsck9meldkSk5rY0xrZlhZd0k1N1dvWXZSWU1XZzc4dUpZSi85MEVi?= =?utf-8?B?d05hRDFtT2hjMEMwaVI5Q2dSdEt4RVM0bGJpQ3V4Q2pNSCt4Z1QwWWc4dFBX?= =?utf-8?B?SWVzQjNMS1ZzbDRta2RjcXM0WWVkekJoQ3I0ZkduSXUvV09QUHhlQklyRjd2?= =?utf-8?B?RmtNY1cwWHlGNkU3MUo4R1BQc3pzcnV2Zi9MNWx5MmtmY293L0dyYmJ3dHQ0?= =?utf-8?B?cTBkS1U1WmNyK1MwR011TVBYZ0Y3cm03MWhLZDFmZENCQWU3YTVSc0o3cTJ4?= =?utf-8?B?VkpTU0lSaVlpMVRYT3YzVVN1V3ZiQUFiTE15QnhIblRVMmlnWThyQXRSa3dy?= =?utf-8?B?MzU1KzdzbnkzUk5zdmhvUm1oTEQ5MVRCTmVyY0xFemVCd3BXbHJ1NzlFVStK?= =?utf-8?B?TDhtNnFNS1Z4aVFWWE82SU5vcDZWMHBiQS92emxUNENoY1F0T2dPN0kyOExV?= =?utf-8?B?RVczZzJyMnhHOGZjNW1CZHZ1bVNJNmdZbGhDeC9Tc0FaVjN5QWdTL0tzZFh5?= =?utf-8?B?cXRTWXF5bmNKUjM4SmZVakZRLzJDRU5rOUwvamNmNE1HMk5Ra0l6VmswNzFr?= =?utf-8?B?VzZWOGYxVk4ydkhRVzltNEVtNmNBbUYrN3Fza2VyaDM3RTlnbG9JWFZ5dG9P?= =?utf-8?B?OG9NUjEramVMczNqZGY5NWVRTytPcG0vNVlmeS90eVQ2QlY1ekt6b3JWUmVE?= =?utf-8?B?eDEvQWErc081dG56R0J2eHQ3dkpVKy9ob3E5TDNMVkUvZEIrWE50ZFVVazhx?= =?utf-8?B?LzQra1BtL0RkaHFUdmNWWmlzNmhjejFyNkJSS1BHRGtaeVdYUXh5SXdhS3hu?= =?utf-8?B?ekxySDVoZFowWVEyWVVWRGd2Q2hEbXJwZTRYcThmb0NmY0hTZzBpN3BZZUdG?= =?utf-8?B?WHV6UEZtNElUQ0ZORUE2TVNEWVlvSU8xVU9zZUZGYTJSeHFXZ1VFQTQ3dnNz?= =?utf-8?B?QnJoa2k2Z0xCUWpXUVI2OHVBTFhaY3lQOE9tTXVzbzQ3T3Z0aWhYc1ZIeElD?= =?utf-8?B?Ly9va2x6OW45VzFTeFh4eVFrWUNYK0VoN2pROXFQNDk5NGI2WXdDdlBQR2E2?= =?utf-8?B?MlFnbnlTc3NkTXBYT1hmVmhnZjJpdWt4N0dHRGZVUmhZdmlFdldtV0xvUjZN?= =?utf-8?B?cXE4K0pmNVUzVjdYUVBKdWRtd28vbDVPY3VhMFBXYmJYcmErc2dvNmVJN2xD?= =?utf-8?B?OFdvV2xzU09kblpmdVpHR0d1R0VUNlE0eStMVysxVEpnZVAvVmdSNHBjTDlH?= =?utf-8?B?dllZR04yeUtkNnhIeDBiZmlTdmx1Z1pUZmRxSnhsMEphNmRjSS83cVF6a004?= =?utf-8?B?MjFXQW5uUHljSmFIalY5MTVGTDBTRHl3YTZFVjNWZFdkbWdtMUZQMTBaaGRQ?= =?utf-8?B?THFhdEdHUktlQ1JERUZsL09IZ3h0MUl6NGtFakxhWjZKN2w4bzlGV25kdEVm?= =?utf-8?Q?67ixni22VWbRjshM=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 563154fe-6e75-4849-4373-08df22c6fe55 X-MS-Exchange-CrossTenant-AuthSource: DB3PR08MB8962.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2026 09:56:57.8024 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2UAdfBfJvAlBB0+5Jv5ZVRrf+NiX2P6r/PL38iZDYTbcxgR/SfDdAI5yeHjWbON9uLVkLwWwP3lVYdKYXy8MvJj0DwCygXzXyI4NW9j1sYA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MI9PR08MB122640 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 5/6] ve/failcount: Use ve_printk with specified ve X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/2/26 23:38, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Low] printk: !CONFIG_PRINTK __ve_printk_ratelimited() stub lacks the ve parameter > -- > > commit 446bb8b8f19e9083361fc5d794bba0859020d3a4 > Author: Vladimir Riabchun > > ve/failcount: Use ve_printk with specified ve > > This patch adds __ve_printk_ratelimited() and __ve_pr_warn_ratelimited() > helpers that take an explicit ve argument. ve_failcount_inc() now uses them > so the message goes to the right VE when called from IRQ context. > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-146839 > >> diff --git a/include/linux/printk.h b/include/linux/printk.h >> --- a/include/linux/printk.h >> +++ b/include/linux/printk.h > > [ ... ] > >> #else >> #define printk_ratelimited(fmt, ...) \ >> no_printk(fmt, ##__VA_ARGS__) >> #define ve_printk_ratelimited(dst, fmt, ...) \ >> no_printk(fmt, ##__VA_ARGS__) >> +#define __ve_printk_ratelimited(dst, fmt, ...) \ >> + no_printk(fmt, ##__VA_ARGS__) >> #endif > > [Severity: Low] > Is the parameter list of this !CONFIG_PRINTK stub correct? The > CONFIG_PRINTK version of __ve_printk_ratelimited() takes > (dst, ve, fmt, ...), but this stub takes only (dst, fmt, ...). No, it is not. Will fix in v2. > > [ ... ] > >> +#define __ve_pr_warn_ratelimited(dst, ve, fmt, ...) \ >> + __ve_printk_ratelimited(dst, ve, KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__) > > This macro is defined outside the #ifdef and always passes ve as the second > argument. With CONFIG_VE=y and CONFIG_PRINTK=n, it expands into the > mismatched stub, so ve is bound to fmt. > >> diff --git a/include/linux/ve.h b/include/linux/ve.h >> --- a/include/linux/ve.h >> +++ b/include/linux/ve.h > > [ ... ] > >> + __ve_pr_warn_ratelimited(VE_LOG_BOTH, __ve, "CT%s: hits the " #name \ >> + " limit, see the '" #name "' counter in ve.failcount " \ >> + "of the container's ve cgroup\n", ve_name(__ve)); \ > > With CONFIG_PRINTK=n, ve_failcount_inc() expands like this: > > ve_failcount_inc() > __ve_pr_warn_ratelimited(VE_LOG_BOTH, __ve, "CT%s: ...", ve_name(__ve)) > __ve_printk_ratelimited(dst, ve, KERN_WARNING pr_fmt(fmt), ...) > no_printk(, , ve_name(__ve)) > > no_printk() then receives a struct ve_struct pointer as its const char * > format argument. The real format string and ve_name(__ve) end up in the > varargs. > > Can this produce an incompatible-pointer diagnostic, which is an error with > -Werror or newer compilers? The format string also stops being checked. > > Should the stub be changed to take (dst, ve, fmt, ...)? As written, this > can break the build when CONFIG_VE=y and CONFIG_PRINTK=n. > -- Best regards, Riabchun Vladimir Linux Kernel Developer, Virtuozzo _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel