From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020131.outbound.protection.outlook.com [52.101.84.131]) by lore.virtuozzo.com (Postfix) with ESMTPS id A037D8045D for ; Thu, 29 Oct 2026 10:04:19 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GxvKEXI8IioNP+/d7iUrV47BBKpth9rACwx2Ng3Ae7BcT+dnlz2DqTJxMp5Wv1qz9LebOkonW9ja75NkscWPjVTQUn3AdePwsJBlutOKfFVaJi03Goa9e+StAxBPE4YfaZh63gNPuFnT2ejo20GZ4vi/5SWvzOmS2BtJkClDxwihmGO+C9tpYmR0ZMJNu6roli4dLRiSb601pPEG31CMgBtYuok+Uc65m2nAmTMc2bOMAOHXCcLIX94dKxevHl/wLNAWPNI8lpz9CgTw7lHCGyFfWJa+kHAwkaQ49TI2OQxfqHt6e7vDg9YGDzFo23JnlwsttFdr+LltRwdrPrVoJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SH74MaNovc2p5l0NftUWkYbAufrV1nWs0KSsImxRLcs=; b=w42UnlqbRIuzOCZiJBJZ1jLPucOZGTV8HhBXQw9erbjIY3A287c1AXkTBIsRX5TMHHJTTlgqOe12plbSiPofQmBus8tFunml9SnQrPeukWycY6iy6woOnqfp6ka+eDsad8MqWrkXkl6nFcLUC2Bd3UZw/G5uiYyOFFRjmsZpNxa3ZxORZ6v01HpPDTCNItTTg20yUuthRQqbMx/K700yuoC53Ibzex4GXY2pBC8c7AQqCLskQ33lpPMTXYAnWEPmFo/Hc5d7VBpWLWlRocehuc3tsKa1QbtUqEcZccgEw1p/C/Xe6swHjd98TZj6X0th+3M7TUZeacLQzg9RwlGnkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SH74MaNovc2p5l0NftUWkYbAufrV1nWs0KSsImxRLcs=; b=wmWpdPlpZBJsQVjKUt3ERQ38T7Hb57geJ2yvBC3mGIWSMwx5U6rga3rZYx5yaFH7o4eHIaP9ltVtoSbhcmARWwwtVBWKIAVLV3jNQD374OTVwJt+U+Aqu5Vnint3lrREq3/Disd3bS1j2qWSgpc3BlXDns9JEfQ7MDwfKVfhz42vbHMHXgXbCypSaxIK7bxjpkxhUhMcJLjfx340Mb1Sc+opZAjY1Sm7Nu6BllmUr2lOE0DCdltcg9xuM2Jpc66QyyOn1c2SBwEIx/7hfYgpH9EIOcfwQ4y/p2YOMm/tGxzwu32axELEo+dZHpUFury+/Xz7/Du88PYUzZi0ZH6Tjg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) by DB5PR08MB10235.eurprd08.prod.outlook.com (2603:10a6:10:4a9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Thu, 29 Oct 2026 10:04:15 +0000 Received: from VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a]) by VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a%6]) with mapi id 15.21.0546.017; Thu, 29 Oct 2026 10:04:15 +0000 Message-ID: Date: Thu, 29 Oct 2026 11:04:14 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH hci-8.1 v4 3/5] vhost-blk: use a local vhost_dev pointer in start and stop To: no-reply@sashiko.virtuozzo.com, andrey.zhadchenko@virtuozzo.com Cc: svt-core@virtuozzo.com, andrey.drobyshev@virtuozzo.com References: <20261029092301.3286535-1-alexander.ivanov@virtuozzo.com> <20261029092301.3286535-4-alexander.ivanov@virtuozzo.com> <010701a186fa185c-0055b5f5-c6e0-4cb3-bc54-2a6214472c27-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Alexander Ivanov In-Reply-To: <010701a186fa185c-0055b5f5-c6e0-4cb3-bc54-2a6214472c27-000000@eu-central-1.amazonses.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0216.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ac::20) To VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10743:EE_|DB5PR08MB10235:EE_ X-MS-Office365-Filtering-Correlation-Id: f7a30c91-c895-45bf-0b56-08df35a3fcf8 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|23010399003|376014|261026140227099003|56012099006|5023799004|261022105027099003|261021121427099003|4143699003|261028144727099003|10067099003|22082099003|18002099003|5113699003; X-Microsoft-Antispam-Message-Info: XPlxHND5lETQdYb/IOr8pvxsHVNCdWw3KKAJpOZjNlafF1frN5DlZtwWxnJurRgCCMMZsElEjD+HZxBGMSHhpiRuJmqdNpkm4raa7AzEXH9g06Ue4CA84F1b6cdxI3LdVv51yDpMSU9/cgF/RvsiXBJxCNbwEPIKUZgFLHGtVtQsHtLxx7NQWfznTZq6P0aFxRvFjITsswDd08Sr5tihIzH7maGQd0FhlaBU/n9Pq87qoSNkHY67Nq8MJ3sMM1nwMh5o8Wdda/bYjVszHwIJDz+1J62KCZgjTntAipWuwpl2Ytr1DfWjb/HOosYCO27JZmw4ENzw0JsnrpDoj4w/qJFuANY9ghP53FJWDt0Etg9t22xasob+OqVVpGmiW5ZRpBYrVZx86JfEdX6I6uS2nvPicN+eVLMdTIL+v3UB6raVqX0I325ukMR96jzcyXd6xIa/bdn7B5/ljHkyMwsVxZ9MsNW8xvEKQIAyTBiDmOUnb0Tzb0rY3udckqyhQLNGb74Ez4a+2UgLLyo9440ABdezkWppP/ByOAvhSru9LnLrPZNHkFdPB7v7dGDpA+ZTqN7tvnqNBohn4w1VdV6nP3GQtobZ8fqibFhLP1a7cA+bsZUaBByeOGFN+nfzJBazh8vYx1dEbayNjSK2WXGTOCipdRCIIRDj5Iy1dFHE7Rs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10743.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(23010399003)(376014)(261026140227099003)(56012099006)(5023799004)(261022105027099003)(261021121427099003)(4143699003)(261028144727099003)(10067099003)(22082099003)(18002099003)(5113699003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MTU1dXRPK0pEU2pTcU5ZWWRQa3BPM1pEU1RhY25ZZUlCb2FWRDZtYVJPT0Z6?= =?utf-8?B?UlBkWnE5M2UwOGhQUG9aeXNSVEhSYkVlZWE4cmkvNjBWclhHQ0tYUTNla1hO?= =?utf-8?B?ZUFPbVZsQ1JXazdST0NxdWdyYnQ1VXhpaUxPVUpEN21yOTk3RmVXZERZT1Vz?= =?utf-8?B?NlhlckNycS8yYmdQeUQvOVducnlFWEpaWjJySUFZSnR6cXRiMGdoL284NlJ0?= =?utf-8?B?d3JZVGNNM3FWc0x1KzAvWFk2U2JoRnlDOWJkTGE1bGd6by9NZ1B0eVVFM3VU?= =?utf-8?B?V2srYmFUaHpwUmVrWU9CUG9lbk9kR1YwSi91MzNVbnhBWVpjMlBwNUs3QzBH?= =?utf-8?B?MERsaUlldFF1elR1NXBSRzFjcGFqekgvanFQMmRTdmdOMUJuMEhyanpHZ0du?= =?utf-8?B?bm5XVGVpK0VNZ2lpc3NPY01rY0pjZGt3cGVuL29KbUV0Z0ZDVnExbmtvdkw0?= =?utf-8?B?T2Joa2hwcHQ5eDJaSmE3UHdZY1FKeVNDZGtyZVJvcEVUUGZLem5MUWpjSHQ4?= =?utf-8?B?SW8yTnNzdEUyNHVZd3cxMGhLSkxKY2Y4TEUrUVlKcm0vNnRZb3ptWlJOcWNW?= =?utf-8?B?ZmN0ZE0xaGpDekJMZFlYTG1DVlh5aXpWaVdCV1dzM2tWTGwrV25ndFpiTUs0?= =?utf-8?B?V1Y1S1VlMnFVYzdENVEweVZHMjM0Umo4cEFvVldhSEc4Ukg1bnlyOWVwVHNz?= =?utf-8?B?Vmd1WXN1UVV0T0M4dlEvTXNEQkJkVEpwMHBTUkh6Yi9sdXRDZmpBOVdRbGFJ?= =?utf-8?B?MURGZllHNVFmN3VTcnFCZkNIdTNkOG5PRmkrK002Z1ZIalRjYlFXTVo0Q0lI?= =?utf-8?B?NHFUWTg1SHA4RmtXajZYakRVd2tsNkZnSnhtRjh1MFY2TGxRc2J3OTR6R0ZU?= =?utf-8?B?V2FZck0xSzdXNkdleG8yVy81YlFnbjJyaExoekxmQmFuNERZbjFkSEhDdVFT?= =?utf-8?B?T2NxSXJSZWttYm1yVy9NeitLR3BOa3VmemgzRmcwL1g3ZTVXVGFONUx3c2xF?= =?utf-8?B?aFVvZjNheEtqNnZ6L0g0TVlWSURZM3Z3bk43WStjZ2E5bEJadnhwSndtY2F1?= =?utf-8?B?dkprTURFYU5rNlVmNXM2Skx6bXE2alFEWlNveEZEWHJ5OEozN21MbG0yenFS?= =?utf-8?B?aXB3cFBLaHBRa28wRi9Zb3NjTjNFWU8zN3UydFdMdzdyNFpIaHpBV1I2dkdz?= =?utf-8?B?d3lma2FkRlNFVjRXWHZrKzZuWU5KeXRlWTFLWE95ampYTTMvMm40bDg2QUJU?= =?utf-8?B?K3A5YWhwbEY3aGZDa0lWbnNqNzArd29PNkk2Tkt3dUt4aWJlK0ZDTWp5Mm8x?= =?utf-8?B?M1ZYMFhjcG90RVEvdmdlbW53RDRPdHJrWUhOTjdtWFNWb3k0YmFKMFVSNita?= =?utf-8?B?dFIwVFBQYUVzVWovUEdNRHpZdlZFS1h2MFZ2bmk4OHpLRnVMTHUrRzR4Z3dC?= =?utf-8?B?ckhxK0s3V21yczhJeHdteVNIWXFzYUhPS05QR2hjaWJvV3ovTkJnYXY0OWNM?= =?utf-8?B?SzhzT3R0bFNZRC9XblAvZFhoSlZ0L3dyZEp3OXBNNG5od3hnVzhrYnBPQ2ox?= =?utf-8?B?YTBMN3pRUTlWckV1ckFoSUpkWmp4ZWJtT1FBQXZUejZvQ3NhWTBRbTRjVVJP?= =?utf-8?B?Y010ZTN0Y2VTY3IrMWVRZkRHKzQrNjVDL0txMmJIU0ZOdnFjTlVMdU1teVpm?= =?utf-8?B?alM2MkFmUTQrU0g1MDRhb3Vvek5LS3RpLzZKQkp0b3NTMzNQcG94WVRkaXhZ?= =?utf-8?B?b2czU2FITEdFM3NUQ1VXWG9lV0hQZW4yNFlpdkoxQmt6Qi9JSkY3Q3JyV3Ax?= =?utf-8?B?eEppUHpVMWhJZzdmdms1UVQvU2c2cTJkbEFXV1pQb2NBRFBldVgvM1pkblJa?= =?utf-8?B?NmJGdlpUSngraHBFOGk2T09FaVJyRWh1RDFIKzhyN0cvWWxvOXRpcWZleWVl?= =?utf-8?B?a0RhZldnZ0NISnd5WTBLYm1PY09QWlZBdDRFeHF6LzlPdVV6eDd1b3RpZDBn?= =?utf-8?B?RUc4d0tObEpFcGxoR01GemlMTVVyVXZiYmhvQmJvR3hsbzB6V2gvT0hERVd4?= =?utf-8?B?c3JldUlrTWhWZmFUTy91UzQ5SXp6bmZuQ0gzNGpVbHNiTkp4MmVTSkpsSGFV?= =?utf-8?B?L044bWtNdnl5QlFqQ1NBdU5xVG9rMkpKdThnVEQ2ZVFmVVJGbll1UVptRDdx?= =?utf-8?B?WkkxN011M0d1RDUrb21Hbld2SGNKUmJNY2xPaDZWbmplTDdzc0RIeElQekhq?= =?utf-8?B?S2JrNWNpajdWemdSSEw5alNnRGgyZUN5enFmaXhSblFPa2dpbWs5MU5mWGty?= =?utf-8?B?b2w2RUlBOERnUXo2NUZQSWgzam8zZ0JNZllHQzhLNnR1Z0dJTXhvdDVackY2?= =?utf-8?Q?j4e3wPMI+8cgdvQE=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7a30c91-c895-45bf-0b56-08df35a3fcf8 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10743.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2026 10:04:15.1158 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fWaoVE/fr/+QQTXTLzWEF1XvzW/I1uWknKSFvOz1Cc3UbjWdRa2uDxl2vzfQrXDvW6pyNRC88pleELWllgAusqwC8KXmpie5vLkBObBEJBs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB10235 > [Severity: Low] > The message says "No functional change", yet it carries a Fixes: tag > pointing at 0ff3cb5ff28f ("block: add vhost-blk backend"). > > The only edits are the new local alias in vhost_blk_start() and > vhost_blk_stop(): > > struct vhost_dev *hdev = &s->dev; > > and the replacement of &s->dev with hdev at each use. Nothing in the diff > fixes a bug. > > Could the Fixes: tag be dropped? Stable-backport tooling may otherwise pick > up this cosmetic cleanup. > > If a real bug is being fixed, could the commit message describe it? The Fixes: tag is intentional: the maintainer asked for this cleanup to be split out with a Fixes: tag so it can be squashed into 0ff3cb5ff28f on the next rebase.