From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 2168A802A5 for ; Tue, 29 Sep 2026 11:22:56 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68TBLe42025361; Tue, 29 Sep 2026 14:21:41 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68TBLe42025361 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="K9s8n0d5" Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68TBLb7b025357 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 29 Sep 2026 14:21:38 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68TBLb7b025357 Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cc1ca15334cso4589477a12.1 for ; Tue, 29 Sep 2026 04:21:38 -0700 (PDT) X-Forwarded-Encrypted: i=3; AKwUvBxU/wCn9ZxFDgcfsPX2GH/GVW1zsBpCbXfbtqjtgkb/sY4/M2/lYjhnKwM00hFLu78yrsV8ug==@openvz.org X-Gm-Message-State: AFuF++lTgYqbf4jYWfp0HK3jkfjN8cDGGHnTno8ARdbnVWOfG0sey3Ls FIcYlaRrHvVnZHBu8AjNY6pu4/kBIHXnWk5j1DwPdvMn8RnRX6OMEzGJTuk2BYusfieMCzEwHV4 zTWaFnwE4xFZmwIPVhXqUESHCNftAd/lK479kJLTew6u2cW83rHa/+w== X-Gm-Gg: AYBFou38RlqhS07F6Wvf5hsWOmkupPdnx6ctP5bDa5hlmGRoULFYjdKTpZhHIp0DARd +UfxqweV0j5WCEkUQOmBfY4Qwu35xf2w19WpAKn6RpPq7gdxRIsHbyBKybzIqHEivBjJjnfimzI 6Yn7RAF9Zb8dKC99vevNUFTik8z2kE3uB/Efq1VavpfeNFuhC8EdiVmbnN2yl7zdi9z7FKaYuDG E/4+qXjAUHq+sQ1p7t9BNKS+Vs6hIhrEts+8aZ5IDwftkXXNPliUedf55l6nTsQuGAMHBZ+Pe8k GhZRaVT7Q83Ob/iERhOm/BlK6W4/V/OqndTmWdG+iCxdesDqcoiLbUxvpSXi8EvyASB01J61yR4 KBH8t948fFIC5Sp5mSLgmUeG//qFcmui6Pw1nj4TDjgPuGAZQddspbmVijeiR3eXdBwSn8zJ3/A +sr6dnPpmc5SxmsvZPeW7CJgdy5h6X0b2xwDKN X-Received: by 2002:a05:6a20:9e4c:b0:3dd:a007:cb2a with SMTP id adf61e73a8af0-3de26db5242mr11025644637.38.1790680897146; Tue, 29 Sep 2026 04:21:37 -0700 (PDT) X-Received: by 2002:a05:6a20:9e4c:b0:3dd:a007:cb2a with SMTP id adf61e73a8af0-3de26db5242mr11025608637.38.1790680896471; Tue, 29 Sep 2026 04:21:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1790680896; cv=pass; d=google.com; s=arc-20260327; b=meZHsGXy1Eaz72GPhhx8WTlxzWhiDBXkoG1MEAPfl66nUa/GteQys7zL+CN/MhQEx9 nRjzTj4X2rskOQwxItnp3H1ZN8c6l4VWi2qPHd/YUkvw2h9P6O57eNrcpmPEZSTB9qsb pHUvF9j4gJZVGXKA4dWYRyHAvOd1uxlxRUMZTT5vLf2UHLVUQ3Snolnc/x1ERBAgluiK XMm3lnE3roYBGMHDPfVXTYnZh6WOqS/QtCeRbozOhEL+SqSwMoKC6CykMc0UKyMaQ0xL /RwC/nIfY+HemdLXKPFe9Z/9foc3ANulAbqJ7cdC/ZJ2Omlv5/0U+xq09Np+c+gLzFW5 SJtA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=dU3eLvZuzLJO1Bn6qEbbozXX5wMMuOdNOZM3nenK0YI=; fh=iW+EeVBgw6gMfBKTMQNjVEaljb3qEpbHxtkEro0NxH8=; b=MXSPDEirmBh4EsU9Zr8jTN1DyZiA8CU1lWlUnNM9GfGYCGh+0qsttcoqgFWOSsPWpQ e83zUFMk7ECTVFdbQy/myXOMuwLKVjhCYPcnLP0x3WFNElLdc5y82kCE1GzFWy8bchQO q47VcsC//Eoj1QNIXO2+ekWOeutYt+oeSUWWDsMtvei9wD5FFS+8C33+HGJFAO5NNa+I T5uzegDvtRTUBp4drRGBXm/FUs2+kgaB0G0rfguZ5ZD25UkJ1lZrtfb0vP06j/kfyPii GbA88KTzEsy2fGK1nKTHc3TNvkrNav70v8TkGjPBypQr6N2mxXvOduhJ3YCMGlL5qKFa 8ZYQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=K9s8n0d5; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of mirian.shilakadze@virtuozzo.com designates 2a01:111:f403:c200::1 as permitted sender) smtp.mailfrom=mirian.shilakadze@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazlp170100001.outbound.protection.outlook.com. [2a01:111:f403:c200::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-cc7b4a2b1bfsi7813578a12.355.2026.09.29.04.21.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2026 04:21:36 -0700 (PDT) Received-SPF: pass (google.com: domain of mirian.shilakadze@virtuozzo.com designates 2a01:111:f403:c200::1 as permitted sender) client-ip=2a01:111:f403:c200::1; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=K9s8n0d5; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of mirian.shilakadze@virtuozzo.com designates 2a01:111:f403:c200::1 as permitted sender) smtp.mailfrom=mirian.shilakadze@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=K5/oNJCIOoMWRHv21uRmvtPzSaAOAlssu4GIm19hWb29w130U4ysRQukLX5QLSu0DWqHNl3e8j2YkbNDkmNhrTTXms88R+hMmd0E2yzESKShWoAVkLVlFoJoLBd1Zr83Gmt6sP7ZoIm+yrMeHTRhuD/6htacyS5fqrpDwpJbL0wyMmV7MNcJdOzSV6Eku2Ly+55zDGigBevBLGah7pFMRxtsJLqJnEh5gateHHuV509lGikv537kP5DoaynVwF0h28WCnQw3m6mCgsRZQbMP4VtZSY9rfQMhAqpQUNDLaAGGnk6woVjuIsxfDWujhKdpEA1OORcUeKe2y4eiun1TaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dU3eLvZuzLJO1Bn6qEbbozXX5wMMuOdNOZM3nenK0YI=; b=rhP3m4DXGPzLBdl045AXP8NNFNuNIroATlpXqz6WI+3QQ0+A24T/ciEPv4uA6d7xXK/CxLdhTeI4nffYWtk9ktoUFxxywtojd3HbELXBPazVSo++7a1/X6vb+kcTJcSMEJWhcPh2S1nS/btv1WOchGqfLcfq20Z2BxgR/nk8LwHfTlxg64s1XblJRzlVo5lQ+IP+6ANDWOCcMvn72bQ5RZMi5rNQve9xNV6JZMm0DTBhL5DM7eF7OcxqUOR4WmM0HVSVsdpj1xVyIKSQOM5WSHCX5JM7SIl25gHYk0u4HOnnIpLSoj2aw3sPc83gEX6qs8C/Abmw0usNT9kA94BF4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dU3eLvZuzLJO1Bn6qEbbozXX5wMMuOdNOZM3nenK0YI=; b=K9s8n0d5HgoHsvL/aguA7bM2U05y4Mb1vVul6fkKZ0edm7s+/Gx0gJdLiciNSydtdU2+ccsA6+h0nn1NP+poRuJtMuvPgiyzaQ1xcqFa03JUu6NehXsJR5yJz7NFij/KSFC0vezMEG3H/ltDnR0zdz19NamfTzB4V8cGtRNASmQv7Q8II+SoX4gD8I+SI9BxmKOpr6pygL6I40DTeceJZqaEnCLl0tbLMhliWKqswtYP0AA7NZMV9l2dUDQgswuzL7fojsOFVQTxw2sThvTToskP9H13moJwuyG4BKqS2krYSUKoFnxePFqIq4mibGqtsTMRqGsKElaJHNz6cwBPPA== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from PA4PR08MB7596.eurprd08.prod.outlook.com (2603:10a6:102:272::16) by DB9PR08MB7493.eurprd08.prod.outlook.com (2603:10a6:10:36e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.19; Tue, 29 Sep 2026 11:21:33 +0000 Received: from PA4PR08MB7596.eurprd08.prod.outlook.com ([fe80::883a:7428:9702:919c]) by PA4PR08MB7596.eurprd08.prod.outlook.com ([fe80::883a:7428:9702:919c%3]) with mapi id 15.21.0451.014; Tue, 29 Sep 2026 11:21:33 +0000 Message-ID: Date: Tue, 29 Sep 2026 15:21:30 +0400 User-Agent: Mozilla Thunderbird To: Konstantin Khorenko References: <20260928-prep-kh-vstor-142552-kernfs-pin-ve-v1-1-7297e159e813@virtuozzo.com> Content-Language: en-US From: Mirian Shilakadze In-Reply-To: <20260928-prep-kh-vstor-142552-kernfs-pin-ve-v1-1-7297e159e813@virtuozzo.com> X-ClientProxiedBy: ZR2P278CA0005.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:50::10) To PA4PR08MB7596.eurprd08.prod.outlook.com (2603:10a6:102:272::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR08MB7596:EE_|DB9PR08MB7493:EE_ X-MS-Office365-Filtering-Correlation-Id: f2add250-3c0f-43e4-3894-08df1e1bd0d0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|366016|376014|1800799024|5023799004|6133799003|10067099003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: SfUoKKQsQczADF3MjVnkQTemV15enZORdl7StgV77Uu1ErT5S+r1YKir1X6/Nbb+LJTbZzv1Wxlp0BgDXjguq6ztzJKCTqjthOPy2SCQsU4YkZxI+gSmgNJPysnz/m7g1nJoB231s+7lbQalImK9zqud1aV0ulEn100COl5modlMCc/75zWVrEkORHjNIxHkus6M7T7oDhNMZzqv75QIbf2dvf8lrgWx76Mm0fTnWm3biGvgnIDN/LmmBCSNYv6inVQzUYRcCBBw5GkEfQFap4Uml6OcQN/txCR4uCZclm7akC+O8c0LbYV+OGmCOFu/2pM2+zUNZiYm73pBGLCSuPaBaY+ijMpLE+vFU0fdV79Y8sBUeZScQHiiO+nlC9y4MkRRp4jb9lWz2mEC+rK/yQ268yEefl273Irsqd1R4GgBk26EaaGe7o9n5aPCp8+hT0MdgpwMdNcoYk/anDWu1qjC+ThrOv4MCbRKgxniLmUpbQWx/MEXNUAxpxevDgNsJiQDPYHv35zE9UrVpYpUjAeaw9AU/p+lwPGhPxCcOTSZJX/0Kk4icCbgmcCNDOrzcT0Sx+q0K4UAC0F07eodpI0iyT3li+B114mg6AHdF++xG9w/wITK/qO8aoT4BGOEOn2rZSQzDYjhMtuOUuukVKCGgD/WzvKT1nPgtSesPRE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB7596.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(366016)(376014)(1800799024)(5023799004)(6133799003)(10067099003)(56012099006)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWE0NmE0QVROWHY0OHN1Z2ppV1MxamFCSnlpYmE5UzIxd3ZFUmt4YVVwWVdZ?= =?utf-8?B?bEhvV2dnWU1MT1cxQUdnYXcxcjdLWk9yUGIvQTRpTmptK3hINllKYVVBWXZp?= =?utf-8?B?dHN5L1Z6bzhTbFBncWZmWDNzRkJXeEZNMjhtWDFuMVc2YjUyMGNxWUNuSGUv?= =?utf-8?B?U2ZxQjhuOWtpT0JKU0l3VW9scTZxazgvbE84dDFrUm1Bb0ZpQlhidHZyM3R5?= =?utf-8?B?ZTBCRFo5L1NXaXRhclNzNE5nVjdKRXQxTktwUk9ieWQ0a2VKeDlCRmZGY0xn?= =?utf-8?B?THFORlluM0FBOU1pT2YwMEZXbUhwQVJ3S09JSUh0cGxKTmpob0dqSXlBZzZn?= =?utf-8?B?NXI2c0FFbHlNdTVSazBsdTdDcDRyRjlkdi94a0xoaWhuTkptckJQY1NYbkxB?= =?utf-8?B?WU5IMHlSbmx4YUo2UVhVVDZhTkhVQ0w1RDV3WmpINE9GeUNHMVY2RmRxRTJX?= =?utf-8?B?VkllMlRjMG55TEs2TDdlNXNOSjk3M0lENUJVZVoyLy80R0c5Tkoxb0dISnNx?= =?utf-8?B?Z2lEUDVSR0tNaC9hbk5aQ0xETGE3VExZa3U5cWNXbWlKalA4bXRSMWJrb2Nz?= =?utf-8?B?QUJIeDBWSVRkVFJDcm01M0NWVitWRDV1Z1JFbHFDVFhZTldwRHZTYjBDb3d2?= =?utf-8?B?VC9uZVBiSEliM0dUV2xjZDdScWRibThCYkdBNVB0UTIyQXBra1VLc3pxQkpk?= =?utf-8?B?djliSVFJRnpOL3RqYVNGd2VVNTRyek5XOVY1YW1WeWdDRWhCWXM2bFpSVjVK?= =?utf-8?B?QkxCZldqRUZsMjJRWG4zc25OdWtJZzRhenRPbTg4Z1RvVGZubVQ4a2xrRWxK?= =?utf-8?B?akU4ZTI3dFBjampBUkZSSmhtWVVvOXgyamJNNTQ4aHFHNjBFWkxPWHpLK24z?= =?utf-8?B?N0VRVmEzSkRveFBjOGM2anE0c3RVV28yQ2JVN2xYQlQ3TnIwdkdReUF6S1lX?= =?utf-8?B?eG1BWkFPTnJOZjgwZ05JeXR1VEs4eHJPL3hmOCtyLzJ2YUF2eElHVVdDNTlX?= =?utf-8?B?QzlpS3dXdlM2U09ESDh6S2M5MmJISUt0aUJYQ29vUnFUOTlHR1diTC9LVDdq?= =?utf-8?B?a2lwTWtzL1RxcmRISDdTeGkvV3diU25NZGk5NFVFWTFIUE12MG1pNlFTUVpN?= =?utf-8?B?blM4Qm03SnBNOGJoekJ3Zm9TK3BYRFZTN1l5VVNVV015L1d4eGljR01PZXN2?= =?utf-8?B?QVlXOFg1cFZrSTZWK3VkcFAxbjQ3VkcxOHFhaWtjWW1paHk5dVh1UDg1bUNH?= =?utf-8?B?bFdWWGtnVWtTRnp4NGFleW92L3o4V2lpM044RC84VHlNUkpOdnM3Mlp3N212?= =?utf-8?B?NGQ1WEdQNHdFa1FHOGxHbGxkcVgyUUtkUDR2WWEvMUpyclRZMjB4N3N4MFF2?= =?utf-8?B?SXRaWDRaT3M4bE1mL1AydWE0UndJZDNkSmxvOHRiNlFFUXZMdDVLVHIrSm1I?= =?utf-8?B?WlVZb3ZrNE45RVpmY05lSGFPUks0UHhMVTA1SUR3MXU3aW1oSEVGN3ZJU0JW?= =?utf-8?B?K2FBemJDb3VTN3JyZmtZVzZZZ3Q4YTRkWkZkT0tuNk1XMnFwK3FBQ1JlbC83?= =?utf-8?B?Tk1PVEQzNm9NTFFNUlNRbEdnMW9kTVNzeGNYMGtudlRvWHhGOERoNEo0YU84?= =?utf-8?B?dmhuUHFrenFhTHVIc2pGazN3MDY2THZtSzNsQ0IwajFwTUswVWUzSlo4SGVE?= =?utf-8?B?RWhoeHVCb0ZvMFFKYXJnckRRaWNZdFdjSmc4UHpUY2Nabm1TeXlPbTZpVCt6?= =?utf-8?B?TkhJeFpDM3hNSENQZjdlVjBOZUs1SFVyMXQ3YTlQM0pOS0pvM0k5YytrdWtB?= =?utf-8?B?ejRtMkFMWW9wYjMraEs3ZHVJd0E4eEFZUEUxcTErc1E0K3NmS3RacE9OQ3pJ?= =?utf-8?B?OEY4QWNPUGU1Z2ZXbGJxdVZJOE5QckEvc0pWUDYxWXhHMUgwNjdCR2ZLYlVW?= =?utf-8?B?L1FWSXRFUENLbjk4TTBtKzdMOTQwK0tMQ1RnQ2NEMVNqdVYwY3BKTWhJY2Q3?= =?utf-8?B?czRvVG5ibVgzTDlNQlNMQlVtemZrd012WUxSMjlVSTNqRzh3UmlucVoyWHBz?= =?utf-8?B?WE9zdGpSbzhOcHhhZ1dIc0YwZldrUmduYitsV0Nzck9WQy9OWXJWSnlVOENo?= =?utf-8?B?ZGN1cE1vUkcxZzhkb3M0a1NIdzEyMVg5aytDNlNOdzRNUGF6cG5zL005Tmk4?= =?utf-8?B?ZG1sdTV6QzB2ZWxRbFR3a3N0OSsxRU1zYkQ2a3N3SGpvc204UXR3SUQ2aVJV?= =?utf-8?B?d0FzeFZtR3RFU0VqMkNxUDgvbVY5S3ljcnRHcitZbFVQcWdIVWVudkxNOG1E?= =?utf-8?B?TlBZT3d0Z1NDd0Q5bytRUnRPN0ExdXpONGpla2dQQWp0bFdDb0o0V2FZVExp?= =?utf-8?Q?SG8IzYGRldfeoumU=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2add250-3c0f-43e4-3894-08df1e1bd0d0 X-MS-Exchange-CrossTenant-AuthSource: PA4PR08MB7596.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2026 11:21:32.8945 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h9LCUU+Qy27iTzrdprcFynTwNYKAwiPb0HmAFq6sQfe6cQMTrnnAuJUfzPexX9KOKJtZFHetsgnw2DWyHNS98L0ko4eCWd4Cl0+pjn3SmpQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7493 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH vz10] fs/kernfs, ve: pin the VE that mounted a kernfs instance X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 9/28/26 8:41 PM, Konstantin Khorenko wrote: > kernfs_get_tree() stores a bare get_exec_env() pointer in > kernfs_super_info, and since commit 8d1abf587552 ("fs/kernfs, ve: > hide entries from a VE without invalidating the dentry") > kernfs_dop_revalidate() compares it against the caller's VE to decide > between dropping the dentry and answering -ENOENT. Nothing backs that > pointer with a reference: if the mount is pinned from outside - the > host bind-mounted a Container's sysfs, or holds an fd inside it - the > superblock outlives the Container, info->ve dangles, and a later > Container whose ve_struct is allocated at the same address is mistaken > for the creator of the instance. Its lookups then take the > d_invalidate() path on the dead instance and detach the mounts placed > on top of it. > > Take a css reference on the VE for the lifetime of the superblock, so > the comparison always names the VE that really created the instance. > > The assignment in kernfs_set_ve_perms() is dropped instead of > converted: it runs right after kernfs_get_tree() in the same mount > context, so it always rewrites the field with the same value. > > Fixes: 8d1abf587552 ("fs/kernfs, ve: hide entries from a VE without invalidating the dentry") > https://virtuozzo.atlassian.net/browse/VSTOR-142552 > > Feature: kernfs: per-CT entries visibility and permissions configuration > Signed-off-by: Konstantin Khorenko > --- > kernfs_get_tree() stores a bare get_exec_env() pointer in > kernfs_super_info, and since commit 8d1abf587552 ("fs/kernfs, ve: > hide entries from a VE without invalidating the dentry") > kernfs_dop_revalidate() compares it against the caller's VE to decide > between dropping the dentry and answering -ENOENT. Nothing backs that > pointer with a reference: if the mount is pinned from outside - the > host bind-mounted a Container's sysfs, or holds an fd inside it - the > superblock outlives the Container, info->ve dangles, and a later > Container whose ve_struct is allocated at the same address is mistaken > for the creator of the instance. Its lookups then take the > d_invalidate() path on the dead instance and detach the mounts placed > on top of it. > > Take a css reference on the VE for the lifetime of the superblock, so > the comparison always names the VE that really created the instance. Nit: in the subject, "mounted" would better as "created". A later mount of an existing instance reuses the superblock, so only the creator's VE is pinned. FWIW, the comparison was never needed for the fix. v1 returned -ENOENT for every hidden entry and fixed the container start on its own. The comparison came in v2, after Pavel suggested in review keeping the old invalidate inside the CT. He later wrote on the v1 cover letter that invalidating isn't really needed. It's the only reader of info->ve, so dropping it would also close this. Reviewed-by: Mirian Shilakadze -- Best regards, Mirian Shilakadze Linux C Virtualization Developer, Virtuozzo. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel