From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023097.outbound.protection.outlook.com [52.101.72.97]) by lore.virtuozzo.com (Postfix) with ESMTPS id 04E1981B5C for ; Tue, 17 Nov 2026 18:12:24 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wFJMkiD/Y6/kM2m4PgC9xn5FV8WIfAqB3i4Kl4EIptFInQsiF+kXfMrKaHeaovkVrmdZ7fXXb+DAv/zsaMTz+isvM2ttW7S61SkeI7UmU7xeznCZF7cLV1+DP1WL5REmB0vNeN0Hce/zTAvtft6VOxSyHLmaWVAtKHdnsYG0YvIL7ogmYWzyqb2BYyjivpYKs3Gmlv0FIXXLjAdbZUUZN1tbQ3S8wbD4ybBoAEiIMA9yiKei3CIUZF5NsX93Q1xEhO5DxsHZjVCILWdRd1nRStd/PDJekatKkzeeKgmwS41sKbr7f1mub52xE87DDDbVpNOjyk35NJ7MjBscHMoV/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ewdQUCWdtaKvPqM+Z4quzKN2mCOt0MNv4tVRlhu0aCI=; b=TQYIzzsvhRY2ZNLjCGrHmgK6tUNKCKShY5VStG6lvFqgRqSHnncOectds5KY6HoX79PsRcN5BJ6vO8GkO2l0a+ACWXKkHTIngeT1y25gLpjNXHVN/x4X64mN963Pm1pctCvLnG4XqoaAFEM4e3JmfSJADyoWMMY9D5aJ0d19gWv1VpLdYCzPzUEaYrhP5S6j9boPDdAKxsl5/uY3kGnjZFlyZzq/0a60XxnZRGzy5EGwYBGGMMutStNyd7a6o4WHdar+MEOTpdmiAdHaDomXmme3NRBP8cWeLAm9QdI08u8KdSww++yHeMFsmIw2fa2VaAdHbZHZ3uQWLVJzo8cpFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ewdQUCWdtaKvPqM+Z4quzKN2mCOt0MNv4tVRlhu0aCI=; b=lRvzEsl4G/u8H2zCD63SqXr482xB6QTL1znJO8f+XDMnFmxhZKH4Sbx2OjvQtBOJzP7ButCN0xmOKWSaR9vZqi4Z3J4kCTu9jQxcJY2ZJqSjcAgnNH5oh4KVwJhJFA0srbXqsSNMQMNovl1O0N+4MYCrAE540NGJMviT6PylkCg7yO01k3DhkO+7u/PoDnWFC08x6R4RSanDeZgb0q79+oWHzW+1UhdeSUud39nR7Q92+In5ODXxKJRRGFX9ArcMA795NE/yIwx3mSGtX3i7Ry/DOFG0R/lnEg8bCiCH/Mm4sfDHsJSKgnf/cEMkPzVCg8SU7V2KtZqaqEIkm4BIEw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by GVXPR08MB11323.eurprd08.prod.outlook.com (2603:10a6:150:2c2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.14; Tue, 17 Nov 2026 18:12:19 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%4]) with mapi id 15.21.0615.013; Tue, 17 Nov 2026 18:12:18 +0000 Message-ID: Date: Tue, 17 Nov 2026 20:12:17 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH hci-8.1 1/2] vhost-blk: add the werror and rerror properties #VSTOR-152175 To: Alexander Ivanov , andrey.zhadchenko@virtuozzo.com Cc: svt-core@virtuozzo.com References: <20261117105003.3082044-1-alexander.ivanov@virtuozzo.com> <20261117105003.3082044-2-alexander.ivanov@virtuozzo.com> Content-Language: en-US From: Andrey Drobyshev In-Reply-To: <20261117105003.3082044-2-alexander.ivanov@virtuozzo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0377.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f7::13) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|GVXPR08MB11323:EE_ X-MS-Office365-Filtering-Correlation-Id: b0a4a219-8127-48cf-49be-08df44d65135 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|1800799024|376014|10067099003|56012099006|4143699003|261026140227099003|261028144727099003|261021121427099003|261022105027099003|261102123227099003|261009223027099003|18002099003|5113699003|22082099003; X-Microsoft-Antispam-Message-Info: 9Ib6HAgEFoHOnPMtHIdDYq53KsWcuJUG7ft1LvhKnOHkmzZCLgLzvNRY2huxjNFqkA+w5ZpO5uBHUeEeOYmU66wDwbOOzQjDoqh4FUdZO25CVghq31b2Hmur88oUXzlCAh1C3Om3g6B0U0R8w9nI0oh6erVlYA7kVrC+soQuwnxpUgfy3F5Hmrxj3SMXh22rStYVEhc3tD9ojgTUaYk8OZnQxOMOnEaHJcg8RW3JnWPgAv7coUBnqAcQdvx3MaNSepCqwK6n3fqt9RqfWsVjQ/5LRedkkrRvvTD3wF1wuPTxHGDIn8BKj7K0VqPCBlmQLjziB9719TLmiqQA86wqkANAmZV6pExPH2HL0F+Dz1g8I8B7NIhsoHIwk41eU3HJTcNxsqkGRsIDy2jLRJJJAfX3V9qXB/FS3Got+AmSsCBp7G6rLVmX5XeSkQJ9DEGhdohErw07vDv8XyjTHYI50fXoMkw4rPTvBHDqKg+8ffj/UnUw489BzijKAXpcZgKfFcCd9KxbQuhE5Qtmc99pSmumd5UTXr77vjZo/k0KYJEdSnOmyF/8te+l2R5GrQnzgHzB9FIBlQF0xabhGuiQ8o9nuekbLxuMKRWM9TWdBE3QavICITFk3R9RkUmUjtnP X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(1800799024)(376014)(10067099003)(56012099006)(4143699003)(261026140227099003)(261028144727099003)(261021121427099003)(261022105027099003)(261102123227099003)(261009223027099003)(18002099003)(5113699003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?elRjeERNdXFMMW82SFBsWUVxRFk4K21pL3MzbVpObUJSSU9Zb0x1WjZCRVJo?= =?utf-8?B?UnNiNmRVckluQjFjOW1OTTZIYkRpMXlZdS9DZHpkcFV3SkZicUtKaTJ4cmp4?= =?utf-8?B?cHZ3bnZ2dnZZTUk1Q05FbzlqUVRCOTlhYjFYN1kvTGd4M3JodytaOVhPQ1Fw?= =?utf-8?B?N1dvOGVYTXBTSUkwemNZYk1CSkhqaEpuL0NvOXJzc3p0cnBaamFZTzFuekQ0?= =?utf-8?B?QmFzTjFMOE5ZQmcxb2I4cmhWSnVEcGxMSlFxVHRqdUZ6U211Y0NlSis2OUNx?= =?utf-8?B?ZlBKWHFtNlpyQzlQRE5hd1hoYU15L2Y5TFk3RDFTbWFEd0R4SEdqcXU2bms2?= =?utf-8?B?Nzl4NEZaRHhYdFlXQk5xSlhBL1hEOThVSThNVXpWOGFhV3laS0x6akdwWlFa?= =?utf-8?B?YmxBZzUzYXRud3VqVlJGODhTSWg0RURaZ0h0MVBkQmg3bUpEbDJRYUEwZFVu?= =?utf-8?B?VU0yeW9XOFg4MFhpQ2tiOTJjL1JVaGhTOVBEMTdWdlJOZDhlNjgwaC9MZzNr?= =?utf-8?B?L01WTERja0xwMEx5SGhIQXZxc2pmRkFJMlJNTnEvSXFJR2ZEV0g2LzRvTkZt?= =?utf-8?B?L0NYUnJOcUZFSExnckNlejZaQTJreGR2TlErSmY0WmJZVm1Tejd3d1VlRTZ4?= =?utf-8?B?cDJPZWRkYnk4NUhUTzRGeW9xYlVSelBrUDJBNFRTdmtzc004OXdhcEN6ajdo?= =?utf-8?B?aXMvUm0xcmovc0l1V1BwQVZSVWNzdS9JMjJXZ3F1T2dZWnR2eUNFL1RYRjFU?= =?utf-8?B?MVcyTDF0YzdPSHdtN3ZxSVRSY1QwbzQzNFU4SVI3bWQyWm5ma0VyOGtCcmdt?= =?utf-8?B?NVROZm1rQ1k0eDgzeURsd0lWWGVkVG1WMGFFZFN1UllTZ2wrc2JoZzdrT2lp?= =?utf-8?B?ZjRNVHNzR1R6dGVDSnQ2bFpxbEpqeXEzUVpOTkYxaTQvSUtsMGdmcFBQcmVu?= =?utf-8?B?bTBQSjJYSWFoMDZJeTVReDJmWUZPNEVjVTQxamExekpRTFR1ZjV3bUVnSTJF?= =?utf-8?B?STc5bEE2ZEowZjNTNGxMZGp1V3BkTVhwSjlRSkV3UXNYb1FqMFVOOGxsTEQv?= =?utf-8?B?UFN1TGNCSC9Kd1dwUDEzVWhPRG9HN1U1aTFDRk5oMnh6ZE4yWGkvMTRmSlUw?= =?utf-8?B?WDdDZHdBOEVlVWx6U2p4SGJJc1dnR2FkMk9oMUVzdWl4aHFOTWRkNlNrMnBz?= =?utf-8?B?cVFhMjkwcW14K0liOWoxOW1BMTI0b0RqZ2Q5ay9OaitNZXBiM0l1c2hnQkts?= =?utf-8?B?OWhaOWFBNEh2Z1IxNXZWSHJIdDRoK0FDUGFwUUlQWVh4S0RPcEtlUEVCNTdh?= =?utf-8?B?Y1JUQjQyUTN3S3kweUhtcmlIZU1XUUFSRkZSbm1EVlZ6alB6Nmd5MDB1emxm?= =?utf-8?B?UGkrSzJFV25ENzE3K0VJWUJXWjM5VHJFMHU0ZHNjV2xwdUk4MExCbzE1cllT?= =?utf-8?B?bHI4eitDb09pK3hlbk5jRklBaGo0eDhEOVFsOVEyV3NSVk1rRnAwcDMrUUY5?= =?utf-8?B?NkZDU3FBdWc0dksvQWpDdlUzb2lBL3FSU1FpRjJ5bnlCSFFwR0Zickk3V0lR?= =?utf-8?B?Z0xMaWVlcjVsWnlVdi9wTjByZlJlNS9uSDd3ZlNIenl2SUdnWTBQK0RON09F?= =?utf-8?B?VWVTaDBOWi9sS3RaUnhldm5yazBrNE5sSHhzWHFwUGdTQUV6OVJkSksvT3Rz?= =?utf-8?B?dk5sVEhIdFFjUHZEVVlkK0xrT2xmSlZYcjFRS01VS0h5QTVaRXd0WGNqTnow?= =?utf-8?B?VWtzcGJHMzZxWk5Lam5tRktVNTlGcVh0dVhJT3h2YmZ6MCtDU3BObWtaZ21M?= =?utf-8?B?Zy9GeU9nZFUwZi8xazcyM1IzWWZsWSt6bnBXUHJBVm5NMUZ1ZGlkWllGd2E3?= =?utf-8?B?dHdzaDhnQmk5dlM2T1J3RXBPNU9YSWlIdzYrcWJMNlR0amVrN1A0c1lnZ2F3?= =?utf-8?B?eE9TUFVaN2lRZ0J6eUhqWHEzQUoxT3JwSkdkOHJUMnI1V1daS3JDQUdTc0Qr?= =?utf-8?B?Smc1T2E3OXVBU0xDaVVTbVBYMmJIanNjL1I0d1UxVU8zd0hUc2ZNNDJSVS82?= =?utf-8?B?VDRzcUMzcmI4WTE5TkVrV0k0VndVV1k1U3pDVjcwU0JpVTNpWVZPQVBBMnNV?= =?utf-8?B?a1Y0b2hjT2NDUUZiTGpieFExU1lRQ2RUbTg0cmJiSU1EUDNldG5TUHRVbVJ1?= =?utf-8?B?NWphekk0Y2JJVU0xWG8zdEprenRwZ0lCbDZFdWFwLzYxbzRFMm83UXFRR3d2?= =?utf-8?B?bWtlcUlkNDN3NzFwRFZEZWZNUkJOZUJHOUpqSG05MEdKQ1UxWEtDQVlRb2Vk?= =?utf-8?B?MExKQndka3ZQUU9GWDRNNmxBbVVSbm0vOEQzSjB0Vmt1cE1uRUpHSGpFa3dr?= =?utf-8?Q?3Gb6LYuX5S49i7EM=3D?= X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0a4a219-8127-48cf-49be-08df44d65135 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2026 18:12:18.7106 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0bvUhY04VNQPMXaBK9OMDbKAA/ngLE5iuJuhvDDS6xCuWMi7IHQeONSobushyfV7nqPLOwY6aTviwQLb02SDroqjFvEL/wufAfJ3+0KzFC4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB11323 On 11/17/26 12:50 PM, Alexander Ivanov wrote: > libvirt passes werror and rerror to the device when the disk has > error_policy or rerror_policy set, and QEMU refuses to start such a VM > with vhost-blk. > > Accept them with the defaults of other block devices: enospc for > writes and report for reads. dm-qcow2 holds the failed requests under > the same policy, which libvirt loads into its table. It has no ignore > policy, and enospc makes no sense for reads, so reject both. > > https://virtuozzo.atlassian.net/browse/VSTOR-152175 > > Signed-off-by: Alexander Ivanov > --- > hw/block/vhost-blk.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/hw/block/vhost-blk.c b/hw/block/vhost-blk.c > index abddff02c6d..354111a1b41 100644 > --- a/hw/block/vhost-blk.c > +++ b/hw/block/vhost-blk.c > @@ -617,6 +617,24 @@ static void vhost_blk_device_realize(DeviceState *dev, Error **errp) > return; > } > > + if (conf->conf.werror == BLOCKDEV_ON_ERROR_AUTO) { > + conf->conf.werror = BLOCKDEV_ON_ERROR_ENOSPC; > + } > + if (conf->conf.rerror == BLOCKDEV_ON_ERROR_AUTO) { > + conf->conf.rerror = BLOCKDEV_ON_ERROR_REPORT; > + } > + > + if (conf->conf.werror == BLOCKDEV_ON_ERROR_IGNORE || > + conf->conf.rerror == BLOCKDEV_ON_ERROR_IGNORE) { > + error_setg(errp, "vhost-blk: 'ignore' error policy is not supported"); > + return; > + } > + > + if (conf->conf.rerror == BLOCKDEV_ON_ERROR_ENOSPC) { > + error_setg(errp, "vhost-blk: 'enospc' is not supported as rerror"); > + return; > + } AFAICT this last if condition is dead code since XML parser in libvirt currently refuses rerror_policy='enospace'. Correct me if I'm wrong. Otherwise LGTM. Reviewed-by: Andrey Drobyshev