From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11021085.outbound.protection.outlook.com [52.101.65.85]) by lore.virtuozzo.com (Postfix) with ESMTPS id CFE1F80024 for ; Thu, 27 Aug 2026 13:00:44 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RNf2Go3HqXfXDI+Hnyc2HQyq+yDMwNqFQyEMg1dL7QEyPN3R7zWRtL48ahWnPMgffddBuMqcWNroRAvaStNRYzjjjmiDyPneWu8lE1UKfF3DrAYFb7qX85KfWUjxagX4OgZwtXWyx4ZSjdYehDxhBjPp8+6Q2Yo4edO4PtFdhaxI8vSEGKkq2bxEeqKhcD1IKLer1OvwoFX+W1PjAXffca5yuN1IGlbxyskg2dffa0fdv2k7GemR3SNs1lT/oQoDrTdms5G4yUNMCmK0eoOr8sMcvohCh/JI3eK1cIGiMO3v3rVBaIUKUXX5zvjZ/yXs5rw0vltFEFelygKkT6aXgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CU0GTvsSKo8bhcSmuYmxWHLz0MJLza6DMF4QI3y3Es8=; b=Zv0QCN2nzq5UOlJusJfYxnhSS4HVqbNLcG5C8Sy7vuMto++yMwEwAn2K0YEjmkRCZD3reqO5rjsE7J35f5mHmkRsJb/E/F3/3sysoExAo6HL3LGYBCnGV18bbGu9yGt1JZ0Vq5pJ4atTvNx1dyO85dnKeVKnqdjYwZyb/1E1VdnzC6wV+C6U3dOsx3s/DsUBPlf82xwdv2UDncf/f2/gH8j1UVPLgkDZZ/jiEcTlztjDkPuCU58kp1mI/RwmVqfTzxoYMI3qE5SYafH8IKifqZdnwrLBSSZjMU7xTwrOklMUPLwipfK0xK+ZSws9wX7wcnRZma5nen+Jw5cYbhqIlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CU0GTvsSKo8bhcSmuYmxWHLz0MJLza6DMF4QI3y3Es8=; b=QbRHX7q/ZE3+AuzqprIlXXufBD2lx4S5b6ca1xetVqFF2aXBUAKfFaW/C5Hlk3qvdi+PK99YIhj3kN0PlBK5hqemNSwthowkx0klfey0YRIQ+QfPmR9UxsWlUJgsV3CXzj0/NErRG/udH0Cs8kyLId5j4lcd2xa/5SEk5ksgERMknl3UAaencVjp9BM4pPwgauEy0BNIBjXX5G1qdvhEURqGb0UW379ocefSVWI4H8VHxRIK40VEEeY5GYnvyUUj0dA7Ljr8n7+PbDNeu1I6a2DYtzKbxz3D6UOOabDjdmwYDERzfGAXnKOX2uvO0HCTVy6qZkxayIjhb0O7pL6u+g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by VI1PR08MB10218.eurprd08.prod.outlook.com (2603:10a6:800:1be::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.12; Thu, 27 Aug 2026 13:00:39 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0382.005; Thu, 27 Aug 2026 13:00:39 +0000 Message-ID: Date: Thu, 27 Aug 2026 16:00:38 +0300 User-Agent: Mozilla Thunderbird Subject: Re: [QEMU HCI-8.0 PATCH v3 0/4] vhost-blk: improve feature negotiation To: Andrey Zhadchenko , den@openvz.org Cc: svt-core@virtuozzo.com References: <20260825172736.269590-1-andrey.zhadchenko@virtuozzo.com> Content-Language: en-US From: Andrey Drobyshev In-Reply-To: <20260825172736.269590-1-andrey.zhadchenko@virtuozzo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0126.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b9::7) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|VI1PR08MB10218:EE_ X-MS-Office365-Filtering-Correlation-Id: 95e4b66e-1cd7-4369-ea49-08df043b31c6 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|1800799024|366016|10067099003|56012099006|5113699003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: M79ZydPUyaRTEC55DL2eIX0EgCDYLBGqoCyWY0Fj4+hM0Wf3IkjaXyMWdb9A1GxxMpGE3EqQvqRAWPuHoJEBO9eIa5lUaC/9a39rreKB7H0Buh3b3qnYVBVb/2qSgJ/nWWFE0aQwNZrQ3W0VM1gZons5bhSfyy0BOUmPSHB7+hDQL6x1TJ26ZXiZhtenivVxZ3VVlXMY2/MyZmcnaVlR/YmLRHYG2CbpmG+660xYNwUDcZFKMrC0MRT2U51CIxbpWpLbk6FTKcWml3y9MvmBe7ZvIfaSo6KQbX9Z4hEdSb/CIB4Ug0PkCAL/3wDJ7QrZbtTMnBH2btEqrESiXpoMIO+lhhDeI8N36brh6g1HrLGCpX9vJoUFtdMEtbApZ8iW9tewbohN3wqMyfsxrqFD5pYxQAhTlh4iBWpiLKXDGYMSbm9BnJRfT46sylTMRqn236M4E7AIlhBW+F6T2o3Br5wsvDt8DT4ZXT5beyQA9n7MRJwWjcpxVm2MYDwE7QxaAt8Ul/xIOlkfV/EC8VOQYyzTPsIyki4bRrCDW5QTLUEK4yus8T7Au0SnrQL/zxqsh5DPf3mUI2KzvI8ty/QgavgUKpDtzaTLLGRaBnTSHNODzXdFhf0MC2BYrt0nr9ZsklYKBa0qM8cPkc++JLaVHiHDl0waOgBSzUfZwcfpzJA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(10067099003)(56012099006)(5113699003)(18002099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGlFMmFGYmI2aWJsc2FVVU03ZHJrckswcEZmL0U4TUsxRS9kbTkzSnA0N3hE?= =?utf-8?B?OFg2VXU0NG9lR1FGRUV2UHdUbUtTaldkODV0cHVFa0F6QmEvbllRQldFRzkw?= =?utf-8?B?U0dDcHJWVkxjZ1lJb1NRRThnN0RqU0JicVdMRVZ5SGlRWE41ZThWWUJGUXM4?= =?utf-8?B?TGJ3V2YxNUtTRlM1VFByUnRDNlY4MHpwK0NRZ213elJIK0t0MU1vdGxMNVhm?= =?utf-8?B?dXM2bjRIK0Z0YXVsZUhpTlJRZUNJUkg5b2J1TzJ4WSs5b3pBdDVzVFExRFpv?= =?utf-8?B?VFNWdFhFdXRPOFV5RGYwRTJmdGtacHdidnZyWkg4ZmVYN0hwZ2hROVliWTFr?= =?utf-8?B?UmJyZUs2UnE1YXFwVzR2QXhjMEFJelROcUVCamU3MEZwbU9lVTR3byt4dkdQ?= =?utf-8?B?dWJDWHpDREtKbTVZMnlBTTlYdHJuay9HcGVwWXk2cHdLakliWkVPSW1kc2dl?= =?utf-8?B?Zk4zUTZjT3Z3Y0ZWZncwRWd5MFZYcktsS05mRWJzQnRObGhxUmdRczQ0R2Ro?= =?utf-8?B?RlJvZk1yNFdocUJQbElMdUZPc0tvTFlLREFGWlJzUVVxd2JpSVVPdk9FUmJz?= =?utf-8?B?NnlSRUNOWGd4M1o0RFVqbSthRlcrNkplRE54R1VLeXhIbTY3ODBxd3I1MGZ1?= =?utf-8?B?THVySzdWS3JHUTdGdUNGOHZNN25qMjdWTTV6Yis2SlljNjNlV29VMTVkKzVx?= =?utf-8?B?QjZVU1QxRElJZVFTblBsZVZZVWRNcnB0T0FSOVJNWm5PZHFmOTB0a3R4K1Zw?= =?utf-8?B?ZGVLUTdtd1R5WDFDWmlMQXByTmMrTTJoK0pjL1pEcVdyeDBRakVLRHQxSW1t?= =?utf-8?B?ZWduWWMzTFlwdGZsdkM2MzV2eUVpTG52NGpJMkRZNU1RZXcvTkc3ZmJVS1RB?= =?utf-8?B?eTFnYWJ3VTdNdEgrUWxIaU50ZktTc3gvanFPbjhGRkVrT3d6ejFwbmpUM3RB?= =?utf-8?B?akl3V3dIbzhPRDl6R1BUT3E1MmR0emZCZG1rSktGQU0rbWZDWE9VSEZZTTYz?= =?utf-8?B?VVUxSVJlTWZiMHlsYVhkdjU0MHJmNDFwb2IzaVQyMWdjMTZFTHZZZ1B5UEVG?= =?utf-8?B?WkY4Sk1nSnZRN0dSaFYyeHVWZWttWllhVHk0bWlYMnBIZ1FoTkxDK3drZWNv?= =?utf-8?B?aEltQlpmZmQvdGpuSEhweFJvbU9NK1o1NllTS1RTWnJPYVpQdnY2U1dvWjFP?= =?utf-8?B?YXYwVnRGVG4yL0tJZ0ZPZWphekRKMXRNK08wdkt3RU9sL0hKN0xTdk5pTk1P?= =?utf-8?B?WWY3cEJBR092akEwcmowYVJYRXQ3enZGWnQxZEZ2bCtxbzZLdkswYklLSzNy?= =?utf-8?B?ampNSEV1QVJnVWNUMTN6Q093K05ESEUzNWRMYTRrb1JHbzBPNGcvYTI2SkUz?= =?utf-8?B?dFVRdkw2YnduSnRuYTM3OTdlbWVndkVpYnAzTEhxaUVOdk90Qkd4ekhDaUU4?= =?utf-8?B?Z0NqVGR2T1N5L2l0Z1FuZjVHTWNwdE5yTW9kRytNblJuQmMrSElGWXR1bG9D?= =?utf-8?B?eGtseDlIcnA1TGYyZk5uMmNwZTc0a2NVT1FWMGhSQVdmUmpwMzBOdmpmZzFP?= =?utf-8?B?WjlNa3VGYU9aSDNrVzQyWW9OTlNoZG9IQW91dFRnRnBpL3hPOEE5L0JiYmVV?= =?utf-8?B?NmUzRjZ3VnpTN3BFbmc2MVVGSmVBQWkzTmhtUm9LZk1SRmFxanI3aDBONUwy?= =?utf-8?B?OE1wTkdhWk5MRm5rSE9HODlja1psU1JzOVJXM3ZsZnp0VlhYV3dCZFE0Q2Q2?= =?utf-8?B?V0RhdXh3QWlPdGVmWG5tWG9NMXMxM0tMallUSU1rR0pKWjF2V3ZlaEVZZGNO?= =?utf-8?B?SGpGSEFtSEdYTWkwekdJb09BNXFHRlhYdHplK1RPbGM3S3JiR0VzZGpla3dT?= =?utf-8?B?MkJUR0hPWkhFUFluYnhibm8vSnNlVHNPeGhNdlF3ZDE4N3NNNVhldFMzR1F0?= =?utf-8?B?aHdiRDlKRnRlUFRZN3FDakhhNGlTVFc0NFFtZFFXbFRFaW13MTJYSVJGU1Ba?= =?utf-8?B?TG1nUUNxZ2ZwbCsyamc5Sk9VcjJQWjVtSUFCTFpSNjFEVkE3cGRIbkpCZ3Fh?= =?utf-8?B?WHZ2V015TzA0dFlVdDRIdFVHdkpnL0orTFI0M0lGMjRXSEU4eU5OeDFuelRh?= =?utf-8?B?ZVpHS2IyaEd6MU5HV3JnK3ZOMWRXaWVrOU5Ca3dzT3Bob3VoRzUwVWhwQjg1?= =?utf-8?B?OVJhckZnU1dXNHRkMk4wM1NaOXJ3Yk1qTzJqQW5qZHlnSVk4clZSVDhCUzl1?= =?utf-8?B?Z1FDb0pQNm9JN3FpamJZL0NlWHZjTFBSYU1kaUx5d2JXaEl6TjRRdldVYWIw?= =?utf-8?B?cVg3TXRNa1hPOHVaRTcrdWNaYWNDOHo3TmFxZXp0OS85Q1BSMVJjRU5PMDJU?= =?utf-8?Q?D2NN1eIFWWLmvCS4=3D?= X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95e4b66e-1cd7-4369-ea49-08df043b31c6 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2026 13:00:39.6355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DrYWQ7PW0kd7geHBa/VcR6MfDmZ57SFHPkA/wu8qpBFXB5w0dRoQ/cUQX1b6xnQipH08viIUsSU1BFoOrazETa7kQneIE+1PUvykmt3cKDY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB10218 On 8/25/26 8:27 PM, Andrey Zhadchenko wrote: > Feature negotiation in vhost-blk is a bit of a mess: > - offering VIRTIO_BLK_F_SIZE_MAX along with size_max == 0 is a > bug which causes win2012 crashes > - kernel not allowed to reject some actually unimplmented > feature bits > - flush is not offered to the guests despite kernel support > - duplicate ioctls > > Fix everything above. > > v3: > - separated patches per reviewer requests > - add new patch dropping extra VHOST_GET_FEATURES ioctl > > Andrey Zhadchenko (4): > vhost-blk: never offer VIRTIO_BLK_F_SIZE_MAX > vhost-blk: expand list of the features kernel can refuse > vhost-blk: offer VIRTIO_BLK_F_FLUSH > vhost-blk: drop vhost_dev.backend_features use > > hw/block/vhost-blk.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > Fixed my own comment to patch 3 myself. With that: Reviewed-by: Andrey Drobyshev Applied to hci-8.0