From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 8B4F48045D for ; Thu, 29 Oct 2026 07:20:16 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69T7Irma029089; Thu, 29 Oct 2026 10:18:54 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69T7Irma029089 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="kXzVK118" Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69T7IoPB029085 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 29 Oct 2026 10:18:51 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69T7IoPB029085 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ea785a4decso6411535ad.1 for ; Thu, 29 Oct 2026 00:18:51 -0700 (PDT) X-Gm-Message-State: AFq9FYKgH8hCWIUaUMVaqjBmILVkqKQWUN+UytHOM8sLO0kOsANnuAi7 JHJwF70/W37XuOYKYjqQI7SkbfF+aqX0XiPG8iq4/+CqhNIb4C45YIRs1+1h9jKENCEZ7n1Yfe/ lHj3UY6ZK1KXtaq+XJaQjMymx1ZfjidDrc1r5qqvlJdTFEreOapupCw== X-Gm-Gg: AYBFou2990XL5zN5lBm7Q/8UQSFDLDziPaY24bHpfWlH+RKhsC+6QXO72sEnTSXS5Mh hAb4X6aUqV9CI7LfKkul7lz3O0oac0ZMsNhBgmPGUpeBCaV1Q1OqSnr25gu2NAcm9NKjxCEszeF PpMKykmyt6LJxK2GbwHkLN8sl7IqHXcM8kprg92yXKVlYcZbDTMe5Dw2yy8LGBuX+B09kaY6bS3 mzxl8B3b4f59hNL05ePaDYHxG5s5KxG+EU0teKwdQBnAoeSfCZRTsmf3oBMtfF4DLBBpRoQRHIQ 7M14Q/3GwYZUmSZwZHOfcTDTKgCW1P4l/MfCiZduQECK3MnmuvT2Qcv0AUENbrzTx3ZhYaFv1mF m9uuEBN+F5bvH0DmhQYsgM/Hlu35v2IY3OqH71ysYjNVA69deIdgEmqUu7ux13u+xwUP6c+eS4Z z4KdDM0Y3KjpAml2srWoWQXXfRqRGEwWU= X-Received: by 2002:a17:902:d481:b0:2ea:dee6:d672 with SMTP id d9443c01a7336-2eb1ac04eddmr11650815ad.19.1793258330279; Thu, 29 Oct 2026 00:18:50 -0700 (PDT) X-Received: by 2002:a17:902:d481:b0:2ea:dee6:d672 with SMTP id d9443c01a7336-2eb1ac04eddmr11650715ad.19.1793258329760; Thu, 29 Oct 2026 00:18:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1793258329; cv=pass; d=google.com; s=arc-20260327; b=JUMC24+JOI+ufkQFIortV8UI0QYR5a3CmM1duKvX8B35UFUPJ4uQjP/30I7pPiQpla SqDCiFo4VWVl5vMK6qjOTJU7obdcYCAz2oBtp496Go6k4qkBs7EZieoUjrJvn1Nm3dIU UQe2coW/G8ILKdzekcrIEq+57NbID+roSSkPTFIxiy7oesAiAGqfU0GYIYqAGZyV+sq8 XQFVnlBMrmqUMAm8C6Xb+xWeuuN/YwYzugAApO9C15x1i9PyqgGw4np2dZfwc1snhtfZ EJGZGunrtfSaUfCAGT56c2ixPG15LEH5tYoTLazyvA5JfMutFpKS1GqWI10Ac32srOTV WH4A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=dfkMm1pIFp78CR4vACLx8BX/N2oZLUV1JZvmL8dBbp0=; fh=IlzoM7xapMIT9vjIu8V1YxnmOSGAT8hvLuDm+hjUGIo=; b=orZrhhhOV0EQiUgnNeawqCL6RVSnVIjlbWsAJDvL/wi3K5BHhhmBRMuMXghLB2Z2sz F34hAbPpcy3BVoAsDr06e8R5VCRe9PI6vfwo4xaM1QW+BBnlBu/482pXRNczE+2QwCuJ wHJ+kUnSRutJqmSZCO8mxrV+06onHZDmG9/1KZ/tVvB3ZXaul5mzvGWY2bkPh3fPaubh a9jjt2sDVEqCg+zJwivKx1Ll4OKG1ws5FReddXaZ0OaUJGzag3ZxOsJxwuulodGFvL9a zT0IGuboz0jyCUkgfitBFueBIGXp3PfXXut2Uk0MxoQUpsMAw6WRynMguVX2ZiF5xBpn XJmA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=kXzVK118; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazlp170110003.outbound.protection.outlook.com. [2a01:111:f403:c201::3]) by mx.google.com with ESMTPS id d9443c01a7336-2eae6ca695fsi141026685ad.192.2026.10.29.00.18.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2026 00:18:49 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) client-ip=2a01:111:f403:c201::3; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=kXzVK118; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FVHn4q4PMw9QoGbSPdMAZD8ALu3lZB/9LOMlX9qyd3dT7G8dtsTqjcXrrUIYSxSbUOeSAuF+/hn6K6NRmZW6oKIaSEg8xSAPO+/5nyD2hQd3FsRiO8JwozIA+RxuexF+9EWtEHnE7GUODo4Is0M6E5+F3Yl+FjYALMBKP1A5wp2SroWXWp1W5+NNK3ZGJeSE567KXXlj3ygghI9viYJzzzKXDlchQksZeBbjFHIcHl/vod/wvKOVBODswQPqhdLjycn45I6/RO0+QiSJjSc0U9cCONVKSOxGcGHj6ob5X7bmEHh9gbxpvzjUsy7qigmIXEPZFCJf/l6nvQhcti/4+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dfkMm1pIFp78CR4vACLx8BX/N2oZLUV1JZvmL8dBbp0=; b=nq0cmcRqD5NYHW6lC/Pz8T+/QppT5ahZAyjCO2DB6TUxe61L6HZjzWvdb4y/AfZAF6MS+bT2rpBw1rA+H4jBs7pj5hg09MiEzgMxyITHa3RdUoZVw6WgW0KOF4VWw0skvz6dYTtHC4OavalmvU29hM4UIJ9BDALzOGwINPncoT899+w0K2C1HLxHGG/F0Jh4utTyiCb90P1RASoxO4nKDryeVOKTIw2mcHlzbxfm4vaA/X8IGcN71LwvYZ3fSEQflN83LuL8UEZWeuwhGAcBNZDp+R/pbTVwquLKPNRUY+dd6BjpAWJdre0cPZG704DUByi0fLXOkTomIX1dSqU+Ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dfkMm1pIFp78CR4vACLx8BX/N2oZLUV1JZvmL8dBbp0=; b=kXzVK118MjyOErEl8kOB6SVQRES0weKZOxP/iSIsd4dfYpbPGO4TSnX/jpNlyBCtQwO20WNEqVtnFrn0j9oVvXM+N3MR3zVvyUZGywSi76ZnYpupQLnk/7TLb26aiGsgP5UW/E/UZnv8tz1mvZOWFHE3bzmAoi5Qa9h5SQOVGUW/Y9XheZZXRT3yWqoqSeMYaXjbsuDcyqTz8n8Agd1+1RFsQSoKu3G03DTLF5/mqG1erxEIkFjrBTXFgyzLmN8+n1Pe4iqWdZYh0anbhqBuGtTOxY4PVTJBWGC3z0l9NqoLt9e6wJRT6JrdDLpWdx/sc14Y/XYJOx3VBX1noxk8tw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) by MI9PR08MB781463.eurprd08.prod.outlook.com (2603:10a6:290:87::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.9; Thu, 29 Oct 2026 07:18:45 +0000 Received: from VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a]) by VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a%6]) with mapi id 15.21.0546.017; Thu, 29 Oct 2026 07:18:45 +0000 Message-ID: Date: Thu, 29 Oct 2026 08:18:44 +0100 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, andrey.zhadchenko@virtuozzo.com References: <20261028150645.3222391-1-alexander.ivanov@virtuozzo.com> <20261028150645.3222391-9-alexander.ivanov@virtuozzo.com> <010701a1831688c4-55012a05-7c58-4142-aa54-dcd2e7ec4734-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Alexander Ivanov In-Reply-To: <010701a1831688c4-55012a05-7c58-4142-aa54-dcd2e7ec4734-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR0P281CA0222.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ac::18) To VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10743:EE_|MI9PR08MB781463:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c546e1d-7655-455c-0034-08df358cde72 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|376014|1800799024|366016|4143699003|56012099006|261026140227099003|261026121527099003|261028144727099003|10067099003|261022115727099003|261022105027099003|261022075727099003|261021121427099003|22082099003|18002099003|6133799003|3023799007; X-Microsoft-Antispam-Message-Info: E3YBeTmtUQsl9pxDGFeWk/r3kKs52yzDQLLRJBuRI1wFQM9HW+uCbcKSBdGBQUfxEWjTtBA4VnHreqR9nhQ14NT6V6GlOX90lh2ltkIwHzVdrGoGBwnF8XLKo0VGOgsG5tpZnc19iPYX7QRIIrvCUSp0wEMSi2tibzLqjaHGpq6VVjDk43riN6D2TgsNRMHbRY6l5JtpcqLX8iq+v1exevnkHxr4SmhVqIFOSaeTKckjyKGk6MbbOIoNvtsdVVyL/pqtgydGQ58QyUepJ0hj9RXPpdwMCPdza+yqVz/9rUSXnbd/pdAKSVYtvVCvpOpP6VTLkPWISa4nTImnF3JruwHO/Htc62JBs/ZLWdp5C3aQ0EjrI/v9UJvm8I2yKZhpU2AfUGbNIq4FjPeRoIarpKQRw2pmmn59TIAxwlHnQXBSdw9GBkewte20BFxQofxUhnLkyT0509oDDOk+XwP+1r3Du+RTWXhusPyTxY3jEHSfTdOjS9tjsG6JySX3HdCY7CA6wwdtHcfaq1W6c/NtQv9pndhzP39mvFGA953Gr0nLGjJ7soCTA0khSmvdxglMmp2sMOZ9qTmfdWVhajA9YeH1Rxykxlc2KnQeTb3V+Qw6V5JefJt6sC1SjdM1E5CbcmlNJ8+qQmTUKU904qaTJWDDlLnZVsVjVAgdjlLM27U= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10743.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(4143699003)(56012099006)(261026140227099003)(261026121527099003)(261028144727099003)(10067099003)(261022115727099003)(261022105027099003)(261022075727099003)(261021121427099003)(22082099003)(18002099003)(6133799003)(3023799007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1ZaRUZacnE5UUJHUXB5VDdBd1VxUHNsa1dYNzNwSEdUU3FhbnV3OFIzNWtF?= =?utf-8?B?cXloc1RORWFFNm8zRElZUnlyaUNSdDkwKzlzd29GMnMwR1Y4cVc4TVMxNHMr?= =?utf-8?B?VGdGWWFTNTIraHc4MWcxei8xU1lBMWZtRWVzWFRoOEhhWW1SUnJoN1RJTWtV?= =?utf-8?B?TGZuTnFkTzJOMEc1NWVCVWFaSXZOOEp3aUsvMXhaQ3hnTzhxZVFJVENsZEdm?= =?utf-8?B?alcreWRpRzYrRDFoUStYazRETHZKN1NGa2ptbXZKMU5LYmZBZk5BNUp6TzdL?= =?utf-8?B?NUZNMDhUK0VSdmVyZ2tEQ2E4UG9TNEthVm54T3hEaytFTWE5UVZPUnlCcVpJ?= =?utf-8?B?TXJuN1lTallzcXo4OXB1U0lBQVI0OWlaY2o1UDVMc0xhK1dYVTgxdzhaWGF2?= =?utf-8?B?MStyTHpiZHFaS3JYNWhjMDZKRytaU2lTVFFjbXRXTG5TMHFKU3BjMXlaNEVJ?= =?utf-8?B?UjNmRkplNmcycllUVmFXeGJyeTFjaGdiYjJmeHFTZGVMdDJCWHBQVnZhSDJS?= =?utf-8?B?a0toeWZMdGVocjdsbVdwakhmWi9nQnhmays2Tk9lVXg1REtheHdrNG1tRmsr?= =?utf-8?B?VzVpQ0xtWXJyV2V6N1k5SGlyeEhxZCtrRFo1NUNWbWZKRjB3eXNOYmk5RjNz?= =?utf-8?B?YUI2OWcrdUNnNmZjcG9xY3dyMnQ4T1RwOElvRDNxWlp6NEZGYmM0dDhmaDBK?= =?utf-8?B?ODVqc044RlAxc2JnMEE5ZWZ4Q081aERSODJCbUFZYXZQNXk3TzZLZVNOZ0lq?= =?utf-8?B?ZzBqM3Y0ekJsTHZXdkd2aEdMNTJTUlZ3Yk1vWTFSbU14bXcwTXMvY2ZTM01L?= =?utf-8?B?VVg2eGZGMHFBM3ZnbUlDQkxHNXJYZTdXNlMwZU9NZFlYQkxmMDJxdHgvK2Nj?= =?utf-8?B?d2N2dWtlazlaM1YyT2xpZlJIZHdoQkdWMVF3OStNc2NwTEZuUGo2bUo5cUlz?= =?utf-8?B?Zlh6WnQwL0JlbncwaHdlOSswZ1Z3ZzRSMUFNKytuUnYyWHp6QzJUM0FYM2pl?= =?utf-8?B?R2NXL2dhWENCRktpYzE3Wnl6YTVYQ21YUDVvWDRtaUVkYjJRcHpGMGdnS2FG?= =?utf-8?B?aDQ5Mmc5My9XVUIvYnFsSlhyaTBSczdPR0Q3Z2lQcDl6UjVVeXhmZGRrS25w?= =?utf-8?B?RmpaQytLN25xcllkUXlIYWUydnUrQkdkaVNhRytiYytSeXZVQzZOR2NqbGNy?= =?utf-8?B?RDNKT2xydFRoSU9SZWhYcjY3U1NDTjBxeWJlMi9ESTBKd1Z5WnF2Rzhjc2ky?= =?utf-8?B?ckdPS0sxdlRGMmxsaGp2RjlORFNVOU54cFhuMWgwcFdqdzFHVzVlbStadnlw?= =?utf-8?B?MzJxOTFBcXNzQ3ZwVWZvd0RSSEkyQXg1K01hTWZ2Q3pwWFE3bVBxdW5HMFlO?= =?utf-8?B?TzJIYzNzWm9lejc1Y1k0dzR6WVJhL1oyNlQ3VlVYSzJYb0xKaWUyWGFvN1ov?= =?utf-8?B?SkJSZWh3Uk90VStHcnNSakI1dkhWeEthUkVlTGxGOEdJdTBQdHZ6ZEIxZDBP?= =?utf-8?B?Uk1qcTJrbW5wWWx1dFFqUE1jQW1lbTFDajNtM3FzRzkwV2FZOFpHUC90bVpo?= =?utf-8?B?QTJna2QyUlZkcGxWUzgwZ2hWbWJ1V3oxTXlmbGtHb1owM2tOalYwUHVLSFo1?= =?utf-8?B?cjNveFVMZ3lYVngxRXhCRnZQM3J5dkdNL0N0b2Q0Z1BYN0lDK1lFaGpmTjBT?= =?utf-8?B?eVhpSjV4aU5Sc05Hc2RUV2hmYkg1TU1XN3dycXJSSGhpNEkwNHpHQ0dFQU9z?= =?utf-8?B?bW82am5yOTN5bW00MkVYZTNQZ2d6bC9vTnBCTFdoVmlHZlJnZGdUNkdDd1gy?= =?utf-8?B?aUNBS1JoMnhEVWQxd2Z1c3NweVJOWmpncXFxSEVEWWxneStkK3oyTmhzancv?= =?utf-8?B?Um55QUROcE1Da3FtY2ZtcmZ2UlVaRVhPdXB1NjBNNGIrMG9HWjU1L2grOE5m?= =?utf-8?B?K2MvQnF4L3FORy9NaGpwWU90UklNOHFzZjZ0NFdBYzUxZzVidTdOUDl0RVBm?= =?utf-8?B?bXBPaHpKZG1ENmQ1aFNKdy84UkovdFJKY0ZyTy9HZ3l4STNPK0x4cFpwOFlH?= =?utf-8?B?Nzk2RzFRQzlFSklTMGxoRHQ3blVtRXdCaENtVFFlVlhyRkU0Z1IxOWs4K1h5?= =?utf-8?B?R0swWGlYT3Rzd2hEQnRCcUtoeXdLcHlDSEJ1citLc3JZZjZSZ3lxbmpaRXRl?= =?utf-8?B?VHU0K3JHdnpVc0Q2S25kZUFFaGVEdlVGYjFzMTlWOUFBa3FXVFR6K0J3N1JH?= =?utf-8?B?bHVFVWFWZFJPdmQxT0hRRWs3TGJEdGx6WWZZaGdSZlA4WnZrVzRzS2paWDNY?= =?utf-8?B?TnhxVjk3ZFhLYXlSci9yM0Yvb1lTazlrRFNyV3hEMmd5WEVCNi9hM1Nyd3lC?= =?utf-8?Q?i6iWAM9AoqsR5YEU=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c546e1d-7655-455c-0034-08df358cde72 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10743.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2026 07:18:45.6094 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LgXMN0iAlaLPRs5qmg+Uh4fTYwRM6B4RLmSBxM+w8RsUDCbFRXpTmYIcMNXRlxNvHd7i6r6q0XmLC/nQn+4dgXVM7BVvfJQ3k4otTsOivNA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MI9PR08MB781463 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v9 08/10] dm-qcow2: flag the image for check if reftable relocation fails late X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org >> @@ -2351,6 +2351,8 @@ static int relocate_refcount_table(struct qcow2 *qcow2, struct qio **qio) >> if (ret) { >> /* Restore old R1 */ >> set_reftable_in_raw_hdr(md0->page, old_pos, old_clus); >> + QC_ERR(qcow2->tgt->ti, "failed to relocate refcount table"); >> + qcow2->tgt->md_writeback_error = true; >> goto err_free_r2_pages; >> } > [Severity: Low] > This isn't a bug, but the message logged here after a failed > qcow2_rw_page_sync() of the header is identical to the one logged at > err_hdr_written. > > Can an administrator tell these two failures apart from the log? > > In the header write failure case the cached header is restored and a clean > failure is possible, while at err_hdr_written the header has already been > written and the in-memory state is partly converted. Would distinct > messages make the two cases distinguishable? > > Setting md_writeback_error here is conservative, since a short write may > still have reached disk, so that choice looks acceptable. The two cases are not really different: a failed header write may still have reached disk, so both need the same check, and every late failure is already preceded by a WARN splat that tells them apart in the log. >> @@ -2405,12 +2407,16 @@ static int relocate_refcount_table(struct qcow2 *qcow2, struct qio **qio) >> for (i = old_pos; i < old_end; i += clu_size) { >> ret = qcow2_handle_r1r2_maps(qcow2, i, NULL, &r1, &r2, false); >> if (WARN_ON_ONCE(ret <= 0)) >> - return -EIO; >> + goto err_hdr_written; >> mark_cluster_unused(qcow2, r2.md, r2.index_in_page, i); >> } >> >> return 1; >> >> +err_hdr_written: >> + QC_ERR(qcow2->tgt->ti, "failed to relocate refcount table"); >> + qcow2->tgt->md_writeback_error = true; >> + return -EIO; >> err_free_r2_pages: > [Severity: Medium] > Does the target stay live on half-converted metadata after this path > returns -EIO? > > By the time err_hdr_written is reached, hdr.refcount_table_offset and > hdr.refcount_table_clusters already point at the new reftable. Only some of > the R1 pages may have been renumbered, the new R2 may be only partly > connected, and the used/unused marking may be incomplete. > > The only containment here is the md_writeback_error flag, and it is > consulted only in a few places: > > dm-qcow2-target.c:qcow2_preresume() > if (qcow2_wants_check(tgt)) { > QC_ERR(ti, "image check and target reload are required"); > return -EIO; > > Besides preresume, the flag is read only in the status dump, the > dirty-bit decision and the suspend-time truncate logic. dm-qcow2-map.c > only sets it and never reads it. > > The allocation path does not check it either: > > allocate_cluster() > if (unlikely(pos == -ENOENT)) { > ret = relocate_refcount_table(qcow2, &qio); > if (ret <= 0) > return ret; > goto again; > } > > Can a later allocation that finds no free cluster re-enter > relocate_refcount_table() against the already modified hdr and cached > parameters? Can the target keep servicing writes and cause further > refcount inconsistency until suspend? > > Would it make sense to make the target read-only, or to have > allocate_cluster() and the relocation entry check md_writeback_error? The > /* TODO: switch to RO */ comment is still present in the err_free_r2_pages > path of this function. This patch only adds reporting to error paths that already returned -EIO and left the target running, so it is not a regression; containing the target after such a failure, by making it read-only or blocking further relocation, is a separate change. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel