From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 80FAA8017D for ; Tue, 10 Nov 2026 08:32:44 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AA8VSbT012498; Tue, 10 Nov 2026 11:31:29 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AA8VSbT012498 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="XhfR1hNR" Received: from mail-yx1-f71.google.com (mail-yx1-f71.google.com [74.125.224.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AA8VPWq012494 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 11:31:26 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AA8VPWq012494 Received: by mail-yx1-f71.google.com with SMTP id 956f58d0204a3-67bfdfb2641so2760180d50.2 for ; Tue, 10 Nov 2026 00:31:26 -0800 (PST) X-Gm-Message-State: APuU4Z/CEwr17ZFK8XTJKISapmkw3vd2o0y7iL3mKiwmdpvbqbXagf/n BBewghu+X2oO/+HotVp8TBAo4h2oIuRsTQ2qkNh5SrSKQDzCqG1OaBsbozHCVXlakeR0GIGSqI1 9u87HQ4SCdjc6CdivUOZj+CkuzbCoi3eUFfM0KejC4ZdWWCV9ZfbM+g== X-Gm-Gg: AYBFou2pYyE8fuinUi5KRuUJlIqSAColNYMFb4AnUSwuv61FHytRsWPnkm2mZqthq/O gEvW4Dfpfhgm8l2z9oaQ0r+4sFcSpYltBsZMuhETFKK8riej4RhC478DDN2OCo9aVvsOnx2p5gw F9SziiX3hJygZtmRkI020F1ACL612dvMq/UYFud7fvvEj2nYGOl7udqe0b/WBqBY94PpmiDCG1Z Ym7/cXn4IoMthwg03/d9oA+s62gqJwYXdjufRlhUXf5cKVW46KyjBNpCAJpdDcob5f4y+q0UXxj 35oxzWsLN0eIq6cW2EO+IOOpynPxQVuEbtRZD+RVEJI1tjG2WaM9+Nbq8t13tHAQ0e4R4E+/3QU CL8aIRGQvroZWxp30b9WGFJqGAF1/UM2jgbrtX+8V3ooyQshbmhoaQHlQdf/2BBWqU25Lvknorz RFkEVpSF6YQ8k2z/YrRtHAl7jNLYuBYfzR X-Received: by 2002:a05:690e:1c07:b0:67b:ff2b:8e9a with SMTP id 956f58d0204a3-67c5684330bmr1125204d50.88.1794299485448; Tue, 10 Nov 2026 00:31:25 -0800 (PST) X-Received: by 2002:a05:690e:1c07:b0:67b:ff2b:8e9a with SMTP id 956f58d0204a3-67c5684330bmr1125188d50.88.1794299484818; Tue, 10 Nov 2026 00:31:24 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1794299484; cv=pass; d=google.com; s=arc-20260327; b=LL6CRfQVdl1N7UMufxPPSDN1o4gdB4qDcgc9lMbvWMYqlCruSWugBC/PrkbV6ZnPrA XILwPCyul+ZHn7Flb5j0jMcHin+gjQjvfdZFdMbaXacpgNEodNW5j1+k1cdVtViATmqb WoPO5pywuEfhJ8ekOAmiVMYzQ8q18tst+q+mvwe5DGCI/8Q2tx0dcaPTPBWp0SboZ5NE tGqMyPrRJCiaGv4v795QoNDewFXi7kZZ+ukcdAXToJl2p7iXZYBaqCaggC3AupCiS0B1 vA7hTWLCLpxjWg3xeR/2pntsIWcxwS63bjHKZc8fJC2m64KXui/7l5+T7HVOBJ3HgiXW Ju9A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=Tew9zJlkwrFuIysxyfybtf7WEMEI4j+hEeJsbcCtsXw=; fh=IlzoM7xapMIT9vjIu8V1YxnmOSGAT8hvLuDm+hjUGIo=; b=IssEuc2IRnH/gwmi42JxUUuaQCaVdvz/VItX8OOculuBlnK78zRSdlrXcXRRYbj9lX Teeq2RJMFQ4pwAQQnNvegDvsvC/4HSq5/x2z1JCY2gI3m2/eLsEPkD11vUIm4VYGzW2e 20P7Af83LJqZ5PvrGjaL49KYmaDdgkML7/91MJheCjOLAFJ0KG4eE9eGwwslSiS/V/Yh t4CosFv7D7rNrMBX8LbqN/mHxee+8SE5yHc7S6k2IuVah58YKVbtF1qsPkeYIH8zn93J d04d4RXTm9C7fOFWm59kPyoHI9V0Mjd1ffHJWJ7QxDKHbJ3wLw3xedAPM16Xk/LzAcWM J0lA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=XhfR1hNR; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c200::5 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazlp170120005.outbound.protection.outlook.com. [2a01:111:f403:c200::5]) by mx.google.com with ESMTPS id 956f58d0204a3-67c589c0706si1262934d50.87.2026.11.10.00.31.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 00:31:24 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c200::5 as permitted sender) client-ip=2a01:111:f403:c200::5; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=XhfR1hNR; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c200::5 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yJ7CMTFjkjI7XKwJgwfeMGiHzO0/ubUDlg9zGW2ntYun0MS2VlkaZU/+vffLCQsKhZFFyqV09Eja2ByKM4QqakKHCv9icUAgfhPQsd2LHA04bcD9GvM6EbdvnkdfA+GBrI+5JfX9EJ2iMTqwl40Uh9Reqy/MvjUcBwkq65y9fpx42XLEg/HvXOtNlEhAERUsVtDnDJqxJ0erMFeCDZNrv3RJgYh/V4QrFhZPgRAtFFASFDopQqwx5HSZWEJXlFsif+dz4GM3Qn263ldC4fGg/nF0y4jzKNFBwXiyYPH+xl/ibGkodCtVcl931BHGiSKWI1XFPyob3GPrU2cD+HiwgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tew9zJlkwrFuIysxyfybtf7WEMEI4j+hEeJsbcCtsXw=; b=XNRwYB0WyJD2k75y0gcWTmg4osaB6g2YqO+lx7bm058J0ghogZWpoVRciqlCWafjP7KUJWuBk72hhfZa55QPYUzRnYN49dvuGSBtU6GwUnDxgLJ6X8HKyx3KnSyEFtoqD3xepMuvsCrfLkZxm/H3a+EhNKwqSPPi4ulz40Mt0Ku9FodInlDkwUOfrEVYN4aGB3aqjZes0b9WhbZMDhT3PVg4X5k3pJuZIhPtVYN0ZNyHlpJq2n5Nfr0rrYtEv5tY5B0hFAnyPrirXPErZneoqPRgbmRsUed838pYydfjKI/JjEZ5bxhfjXdlk9euNKW09SCwzCDZGeUhX48NP6OXKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tew9zJlkwrFuIysxyfybtf7WEMEI4j+hEeJsbcCtsXw=; b=XhfR1hNRbWDw5e43odMhDq49JmtYW5d+9arYPmT7wcKBziGV+X1ap0xGClzzjcLhHGWyHhGKycLqA0Z4heGqZ8K1iV5dtz2mogHGpmu65CiE7+yuOUaPd2uubpSdQH9+2RiMIvQlx4VmNlblJB165GXd9EVH1Tdf1rcI2pnvzIX8v2FgG7S/VAaGYCyvyLnjVWEfsoFZQvdhtEm47Jh2kXAALOgv67/cqn3onji7/Qk7OqwANZi1tLHvbfWvHnryrrajhEZFlTgHc8S9hhIKLOWpNMH7jt97AHHVnhubgKJ1O5VpJPQLg+5kmywsd/PhCzV38NvhAe6JLdv8qKulrg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) by GVXPR08MB11448.eurprd08.prod.outlook.com (2603:10a6:150:2c3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.10; Tue, 10 Nov 2026 08:31:17 +0000 Received: from VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a]) by VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a%6]) with mapi id 15.21.0592.009; Tue, 10 Nov 2026 08:31:17 +0000 Message-ID: Date: Tue, 10 Nov 2026 09:31:15 +0100 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, andrey.zhadchenko@virtuozzo.com References: <20261110075140.1475607-1-alexander.ivanov@virtuozzo.com> <20261110075140.1475607-11-alexander.ivanov@virtuozzo.com> <010701a1c47e2aee-6f86a867-6158-4994-9845-2e83ccfdfdee-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Alexander Ivanov In-Reply-To: <010701a1c47e2aee-6f86a867-6158-4994-9845-2e83ccfdfdee-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR3P281CA0179.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::16) To VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10743:EE_|GVXPR08MB11448:EE_ X-MS-Office365-Filtering-Correlation-Id: 1569b40c-63b4-4319-a811-08df3f04fd23 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|23010399003|366016|376014|261102123227099003|4143699003|261022113327099003|261022075727099003|261022115727099003|261028144727099003|261026140227099003|261021121427099003|10067099003|261009223027099003|56012099006|261026121527099003|261021123027099003|261022105027099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: QOyLxzQXui2DTQctytHOlR0H/JAXUw3VAUGcLJ3qr8Mj9G9gEYnNllbsfO1r4jvc2uBhixGdqeZXl+19HVvISO/WRn7zOccPKyH/A1PjpzHYebHoQ3pslGU94XrPjHSpSYVGY8asPDO+yaavvOyQW7qcQun5PUK1K2qTXoQvORN1+7oSX/HWv+GFKdXcFiskOt3V8hhq6W54fbhDKm0/ZLOCB5B+J1rmXhA+Gfkw5JphPzk7KCzfPb1zdQoMkUWelxannxnWAvVEqlf4/XWsFBkP9Th1NafK0U2nMq6qeOzBVqpQtZ+u4mEOdBn4v/QvEwVujtl6RUkjnV7F/YE+HQGFu+NsS2INvpXr162fugcc7MqsRljAeyc4jJDPdXqlvZ6TeOvZ1qXaMUSnhg2ZlGSp/OFP6xGjxXCwkgFNOE+iEutBgTY8TQoYKhFkl+OZ1Urm9SdD82gIBn8rfYakGLLp9kElXKlFWyMv7MfFx1UScVISgImQCZ5ddlUNnD34RlmFCWkrx6+V+8sqCM1KYnx7+GMPg/+JMzjA0fCZvhgPv/sDQZ/TJV5THu1yKg0fIVVAgtgP3kaKPXuLbiol3BXxShmo1bd4sqeLArF5FUYiiYFW5I7NKIJpdiieeqVNQkNdK/l/69rLpY/UEiz0duvu6QAHrxRUJe62Ruo0GsE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10743.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(23010399003)(366016)(376014)(261102123227099003)(4143699003)(261022113327099003)(261022075727099003)(261022115727099003)(261028144727099003)(261026140227099003)(261021121427099003)(10067099003)(261009223027099003)(56012099006)(261026121527099003)(261021123027099003)(261022105027099003)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0kzbWxCT0xPbTh2aFl1WTlLMWFyeVhuTVZCTmlsbUJvSVRWMnY3VDdJV1ov?= =?utf-8?B?b3BzRUZydkhCYVQ1dWpSNGw2OVhJL2hlRWFxK2c0ekR4WlFPb2xVb29KR2ZP?= =?utf-8?B?Yk1XOVhQQTMyeWozcnFYYnlhL2tlWk4xM0xORkRJMmpqMjg0ektPRFJLek1i?= =?utf-8?B?NUdNN3JLbmpFMk9xcG5QbXdRb0plOWZvK3l5czFkdG11b0wxK2swQ1g5Y3dJ?= =?utf-8?B?a20vOTkxSG1RcGRtbVplbnJnNGpydlRhMWlLaWtBaWt0b2JYbnJWZ0pLVnRG?= =?utf-8?B?cHFHMk9OSExnQS9zMjBBQnZqcWVNNWpKbFF6eTZnYWFoblJ3R3l2bC9heEpR?= =?utf-8?B?TnFCSGNRNkhnZnk2YXVFMlEySjFyemNjbHdQdHk5K294MVVVZTRXVXIwUnRn?= =?utf-8?B?SmxxVy9pRWF1Wi9OTlJUcnMwcW4vR3ZqWFJ3bFhLVWhiZTZKMXB4c1kxWlk3?= =?utf-8?B?ZnpJczdkci9RRHdacDcrTjlURlpITjU5aXJwVlFXSTlVUFdabmZOa3RYVC9S?= =?utf-8?B?VzhrZU9wZlBLbXF4RzFYcnpBNi9MYmVQZnJqeVI3TjA3WFhkRlA4VDdtNlZo?= =?utf-8?B?THVFa3oramk4aTdTUHZ1TVMvRFBxdkFaQTJBNStNQ29nRTlVTlhYbzY5alBH?= =?utf-8?B?V0lrK2NZV1EraTRsakxwYW1nUUhxclFKenRubFhUNlVGa29aNWVJMFhXMmw0?= =?utf-8?B?RURwQ0VnUXRuNTdkWGFxQ0N5SHhYMGdnSHR4ZGh2eWZwZytSbWdWZlU4cVZ6?= =?utf-8?B?SnJPNkJxZC8yRWFlR3lUMmtzYUVHN3QzRlZMM2l3bzlrVEFuVmdEWnBWVTRz?= =?utf-8?B?enY3TVkrNHVKck9MSmZ0aW1yeVlGc3lsanNseXVqek1kbzRMZlpPWU04STNI?= =?utf-8?B?cUNUVThuUWhkYnlZcVo0b1g0b3BQZU1FTE94cG9xaGJqdmRUQ3U5d2lFRlZq?= =?utf-8?B?L3h2ZU1SUkZIT3c4clc3MThiUjh4WGx3K1BnTTAyZ3lXcGo1RHhkbXUybFRO?= =?utf-8?B?WjlzN3p0OFJjenVmNzQxRkZIR3BTSklWVFFaUUJ2cGFLU3ZXc1ROczNEYkh4?= =?utf-8?B?Q0ZNNzFQdk1iNmc0ditXTlVOUmFGQ1YwelNBMnN3bnhwS2pmYXpvLzB5bzVa?= =?utf-8?B?Z1YvVkN3czdaZFViVStXKzdrYmpWRVBXOHYyLzhwZWFZRmdUVnZwMWtZeVhM?= =?utf-8?B?ZHJYTi9oUDFPWnVKc0ozaG0rM3R5OHllV25WR1JGc1dEUWVBQ3hScDJaUGZE?= =?utf-8?B?THI0ZlhRSjRuK2pvNll2bDhtSmlNMS9NcHFSYXphVUdMZWRZSEJua2pTOFFG?= =?utf-8?B?RHRnQjFqRUptd093c3N3WWg4UDlhMEJiSGxoenR2WXd5enRrenl2NzZ6aitp?= =?utf-8?B?cjhuaXhKQ09tMUxEejVEQjBhS2xhNFA5eFAzRFFLZE04RDdRZk9TY3NUeTlK?= =?utf-8?B?czdKY1NzbWp6Yi9BVTdBaEovSzlkVzk1RlJ3dXExMldFU1JRWjNKem5hZ1F1?= =?utf-8?B?Y1VncEZ0c0pvM3hYM2Ird2dXa1o5NWVNOUhpMmgxejJ3NitsL0RZNXU3VVI5?= =?utf-8?B?cHp3cVNjWmFPSnRWZXJnVzE2TWhQeDdXNWl6c0wzRm42eExGdW9iSk5BRGlz?= =?utf-8?B?ODhtSFhmWE1uOEoxTFFQcyszdnZ5QnJYYmtuaDdWTDlseW5tUW9SWjlKakFw?= =?utf-8?B?ZTdrL3FiTGNjYWVMSWF2eGZjUHMveGpEbGFWNWZtYkxVN2tzYmxrcmZXdnhD?= =?utf-8?B?aG52TnNaNDJuejJSSW1NOHZ0ZWlqSlZ1dktBVmVkR0pXRStDYU9FSXRuNUVN?= =?utf-8?B?TDQ3YkdKaG94TThoY2xZeVFWbzdsVWxjSzJOQUxHZ0RuNENBNzA2NTRpUklU?= =?utf-8?B?OGJFMU9VdWRTb1g0RzBhZWRpN29NZUlLSHpvdXpEOTJWWkVzVVhWekVnc2tw?= =?utf-8?B?WHJOK3VuSnNmdUFFWHpUZ1l0c2RVb0FCdkNmUUl4Slp1WWNpb1BqSnFuOTNO?= =?utf-8?B?U1REQUxla2oxblh2SC9wT0tHdml2SEdZSWtRRXVraWp5YVYvNThGNURNUkFm?= =?utf-8?B?c1ZEMmUxZnlpVWNTcks0ODE4WW0rR042c0VwaHRkbnd3K1R6Rk81OTQyRVdV?= =?utf-8?B?NVM3QnJIbHVPTE9tL3hYRXY2NkhsNDdYTXV0YUlmbTZxaUNnaFozdkJveFBq?= =?utf-8?B?KzVyYmhYTzFzQWZiZ3hyd21aczFOeU1sZUlxeUI5bWVXRGM1YnRzeGljU0NM?= =?utf-8?B?cC9ZRklTczlSTXlLa2RBaGdZQ3Jwd0tpQ2YrYWxhNENMYlV2bHhyeXZpYkJD?= =?utf-8?B?R25tTnNGRzV2eUZNNjFHbG9ORmh6SmhSNVdaWjE2aW00ZE5NSFZSMGJsUkcz?= =?utf-8?Q?fLQoo/hHup2DbOxc=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1569b40c-63b4-4319-a811-08df3f04fd23 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10743.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2026 08:31:17.0600 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JY59UeK73AnbjKiIqhwqggzgP239md/Ke+1wgMffi8gsBwZe/TB3qyRUcsDOxVZ8V1LW/IqpqLjNwZmF10RbQ6XBgXGp7HlwbMeDwT7DyWc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB11448 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v12 10/12] dm-qcow2: retry R1/R2 writeback that failed with ENOSPC X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org >> @@ -3869,9 +3871,9 @@ static int complete_metadata_writeback(struct qcow2 *qcow2) >> md = qio->ext->md; >> qvec = qio->data; >> ret = qio->ret; >> - if (unlikely(ret != PAGE_SIZE)) >> + if (unlikely(ret >= 0 && ret != PAGE_SIZE)) >> ret = -EIO; >> - else >> + else if (ret == PAGE_SIZE) >> ret = fsync_ret; >> >> do_md_page_write_complete(ret, qcow2, md); > [Severity: Medium] > Can this change make the cluster leak repeat? With the errno now passed > through, a failed L2 write ends up as -ENOSPC instead of -EIO: > > complete_metadata_writeback() > do_md_page_write_complete(-ENOSPC, ...) > wbd->ret = ret > complete_wbd() > list_for_each_entry(qio, &end_list, link) { > if (qio->ext) > qio->ext->cleanup_mask &= ~FREE_ALLOCATED_CLU; > } > end_qios(&end_list, errno_to_blk_status(ret)) > qrq_endio() > if (unlikely(bi_status == BLK_STS_NOSPC)) { > if (qcow2_try_delay_enospc(tgt, qrq, qio)) > return; > } > > complete_wbd() deliberately does not free the newly allocated data cluster > when an L1/L2 writeback fails. Before this patch the request ended once with > -EIO and was not retried, so this leak happened at most once per request. > > Now qrq_endio() delays the request and resubmits it. Each resubmission > allocates a new cluster. If the L2 write fails with -ENOSPC again, that > cluster is leaked as well, and this repeats for as long as ENOSPC persists. > The leaked clusters stay counted in the refcounts, and the image file keeps > growing on an underlying filesystem that is already full. > > The commit message acknowledges this ("a request whose L2 write keeps failing > with ENOSPC leaks one data cluster on every resubmission, until the space is > back"), but the patch does not bound or fix it. Could the cluster be freed > (or the leak otherwise limited) before the request is resubmitted on > BLK_STS_NOSPC? The leak only happens in a narrow window: the data write to the new cluster succeeds, but the overwrite of the already allocated L2 page then fails with ENOSPC. Once the filesystem is really full, the data write fails first and its cluster is freed through FREE_ALLOCATED_CLU, so the leak stops by itself. Freeing the cluster before the request is resubmitted is unsafe, because the failed L2 write may have partially reached the disk, and two guest offsets could then share the cluster. A leaked cluster leaves the image consistent and check reclaims it. Leaking a few clusters is better than failing the guest write with EIO, which is what happened before this patch. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel