From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id F1991803BB for ; Tue, 10 Nov 2026 08:27:28 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AA8Q5kX012478; Tue, 10 Nov 2026 11:26:06 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AA8Q5kX012478 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="0B306KiK" Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AA8Q2ie012474 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 11:26:03 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AA8Q2ie012474 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-8b320a98b7eso32294047b3.3 for ; Tue, 10 Nov 2026 00:26:03 -0800 (PST) X-Gm-Message-State: APuU4Z8kkpo0qnlVafi8DkJB/sCm91qlYnkvJ5gtLfvemqXRpMPiFZri 3hPnhNN43g2EESbNj6dOVpDg+AkPYvh7w9e65w3gFVWVxXexufAT6SQnGywsAo07GV2aHph/HYK EDxrlmmQKasaPPrRRz7YNGDZ58Og1bkS05ay7B0mAa1phlPirlcJWxQ== X-Gm-Gg: AYBFou3cbQMu740G1LqwmhBammZY6rkBA3i16Mzk3AraXmkJ5PYyaapgI++ZmJ0kbG8 VCVS1qgktNuVnUU2PCSOqYe9EFJ4R50VSRq/485QqEL33yN/NI4xBXINzq6yOBcyP3OJEyR1XB5 r7XRTNk38cltgaSDplMUzGnHU8MYWbPBDAgP3nJYNCaGQXLBwwedj/lq3+VBEz6DZDTudhSZEdi L3tAg/ngSGMlfTvOQeoSk1+qqf6DESGs9QKIrDMaIKO9LqTtQcq5rMHDe3z/Mn7i+Ul3KXWcWmP WsNnYN+vgmWFhNtb51w+nBCtcOGmfvsqMtTWOAA6ibeheMQUTYQtxS9a3GPfkH6PtDNUt8OzyEu XP4aW96efvDaUeNkM76QecbQdvkM3Lb/wdmACJ8tnh6x3OPaeEc5Yhk4uP+tWUqzi4s2/FJvl2W L3nfX/qBj4rLBATO1LgM/AlgZLoxjp+r4= X-Received: by 2002:a05:690c:ec3:b0:8a8:6a39:37e0 with SMTP id 00721157ae682-8b392b72346mr15211687b3.42.1794299161751; Tue, 10 Nov 2026 00:26:01 -0800 (PST) X-Received: by 2002:a05:690c:ec3:b0:8a8:6a39:37e0 with SMTP id 00721157ae682-8b392b72346mr15211607b3.42.1794299161290; Tue, 10 Nov 2026 00:26:01 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1794299161; cv=pass; d=google.com; s=arc-20260327; b=qjuv/f9cc2kJ0YO1C2k8V179UCW2PINaETYfDCTqdWJfQqB5OiGK0xcJB7NQcn9wIk Dle8+khPIJ6SLpj3rPPwIrK7LrwUstvoBocDEAcktbQff9YE2PaZ0Rp/1gxXp7mkNTqF Uz/Dp6sRBeFaAGttNTS8BsgoznzVw5lmXoZ6Sbl8OuHExj6zEXBR4Phi30A1+e0qXzEh ZKayN1GKygAHseb5Js97AtDs//H1hrvJDBxTZlrj3iLyMfJvIzcMvfFYOMe7pIvjS7n4 CrbUGxnQX6DwvPTFO40N8olWDfxM/AGXzDRv2xBtL9txOgCIJoTIQoaVVpaWRgjz98Fe TBqg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=pfrpgL3KKao0C6ecptm4me1kZuUS3lIDshGyWD+pDBw=; fh=IlzoM7xapMIT9vjIu8V1YxnmOSGAT8hvLuDm+hjUGIo=; b=Emj9VNb7OnGFjNU5MzbZCO6OmwJzZlLuTx5KlBXKMwmW6xkEQEKBEkG539rFTjg/hb xYdk9oGJmdXkBdQiBZL/cnzeOmShzgxpe61ns3rqY8hfDdOGuDUeaPx89gyNMta53UPu cZhxLkAFxhnLmPpMsOXm6e1k5pIn9fLpra5nsBjf40785SgEjrnivnFtrEytvaBiJnGt ljVeoB6riWZ3ZtUWnzPuXe8f9wxqSWi+tRd8ETv5jPHUDhXTFIjcRJ7Kt08ANpIlg7O1 zX71PS1igc+y8BBX2TNlEY4w45qL5JxOHt5oQeTkOwbJSx8Fl3ubkTrWEVeNPeAgNvHY s4Mw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=0B306KiK; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c200::5 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazlp170120005.outbound.protection.outlook.com. [2a01:111:f403:c200::5]) by mx.google.com with ESMTPS id 00721157ae682-8b3932acab6si11086027b3.1.2026.11.10.00.26.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 00:26:00 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c200::5 as permitted sender) client-ip=2a01:111:f403:c200::5; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=0B306KiK; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c200::5 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GM93qix5ubYsBvBtdvU6rMNiE3Xg2cjUtt0fN6ejWD5/9QuGpdkrRZ7/k7z1/6LDx2C9qBUWvekUnNEirxhPhwJBWo9C5RGF5doFeVG4L8ZQX1KJL9bfhpoC80u/sjDB5ar/aZ4fw3ZtYR6AXIfpY9aZDUdhSUpzwuUS5Fyh9dy6pmXW17OxNGEKdJRRM8koGF6mG8YbverdWRdiA2YpBx6bUYK9qvXuZyLhjHowWGZtMskbxFvjrGfQB9pViY2kNzNhUcGAlRcEWAwuCAs2YU/nGhpbxzvqaq8FbmhmBXNUMWI/1DXlvqF+5yPh8jBJhcijpU4/yDrxw2AVjQbJWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pfrpgL3KKao0C6ecptm4me1kZuUS3lIDshGyWD+pDBw=; b=wAGTuEHu6RQziqaazNT5zRpA9tOBzKKp8hJp1mqiAYZBtptBIOPTb8jshJNDFGsJjp/970hNP+l7DhaK2VmNZys1UkloVqeKw4ondbiusMdhza1vZgZqdkIEbsYdVQ6vB17D2wWGkACRfz75bex+JqB/iX9ghrATBbvs3y5aLy5GQsBsDSPt2j0nLFWyKUA+0yJZFp5+Ts2+Q1hhkyYPgMFiX9FmqQlpYjX198r6eZehGkYI26XOOy/avW02/j4VFJbmcHB8509Teibvss5Cylo8EicvSMxn+zaV7dGKpdSk/38frIMQMsoRkpvZYRtWaWXOYqJT5pfq4TVVA1qAlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pfrpgL3KKao0C6ecptm4me1kZuUS3lIDshGyWD+pDBw=; b=0B306KiKdZiZYVMzU+HGUdetA6vN68bSrbsil1pfRtlNkeK61s743H2MjYdZDbtY/RbfbRM5tgVOSJcH1pAsAuzDBwszVitO3V+erNEQywKA6afNC6wYJkP7GT24K4qxQsE85n2PduYqCnp8FANASbzFA/2c9mINPevgrLJ1evdRY6RIo2CnSVPUM8fzh+LlhNBtW9jOIge2+i1y9mde2FsidGwsXeSALpzXrsp42DFxiq7DYSIA/QNaUCcDLweJN+/PLdOVJLH9Exo5dtEbdKv3r0yEYjtfvRriA3G1wJuRguNznamQr1a5k11lYSX2Itl2lki1m1IFpmdSqRdEXg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) by AS8PR08MB9361.eurprd08.prod.outlook.com (2603:10a6:20b:5a8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.14; Tue, 10 Nov 2026 08:25:57 +0000 Received: from VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a]) by VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a%6]) with mapi id 15.21.0592.009; Tue, 10 Nov 2026 08:25:57 +0000 Message-ID: Date: Tue, 10 Nov 2026 09:25:36 +0100 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, andrey.zhadchenko@virtuozzo.com References: <20261110075140.1475607-1-alexander.ivanov@virtuozzo.com> <20261110075140.1475607-10-alexander.ivanov@virtuozzo.com> <010701a1c47c8dca-09b0fc20-e2e2-4379-83d0-009e1c0d80d2-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Alexander Ivanov In-Reply-To: <010701a1c47c8dca-09b0fc20-e2e2-4379-83d0-009e1c0d80d2-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR3P281CA0171.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::7) To VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10743:EE_|AS8PR08MB9361:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f39e97b-f5e3-4402-9317-08df3f0432fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|376014|23010399003|261026121527099003|261022075727099003|261009223027099003|56012099006|261021123027099003|5023799004|261102123227099003|4143699003|261022105027099003|18002099003|22082099003|261026140227099003|261021121427099003|10067099003|3023799007|261028144727099003|261022115727099003; X-Microsoft-Antispam-Message-Info: 6559/ENsOhN8p4pVdY+nmgDavi5HtQCxtvAZrsTI86oj30eSbsSPfC4bXuK5SSizo4Jpf4VGozHUKf0qjiaNt1n3mvbf4NoBIiYrfjXlHLqUp8vySs6eO21A0TKrE81CpARZp9KXnyQtuRNgExEwa+imvVaVvbU3r0977DmOla1nZ5K+kdVAyx8tTJJ8CuG3dhZhRuBvgd5sjYeMj7Uiz+J8p9BkNTwDJjPSGpa3Ys3PZImtH/Gc5AWbFF6Plk/BUZ5zhl87GJQfEWoJ7uaUCxQ6bUnNR+K9oY/M9c97sK8I/6YvKWJfIHNEUUAiYccFLCVSFwKAjLD5CngqGaT/xADALd/0UoJa7MCOHwqzT7higzT+zZvaRUNTUSPzSS8JCuonigyHNd5utTCRCTCVRaAwtNeGnHM73yxhx8/nG4NJX1CbVzQgYof7pSqwEx0K610aDduI4jTItjtNx/Sh42G7+fzwzjMHirvMZxtzG/tgg5ntR1L5axuQJl3ZyUvF5ieIiZtHq+kijISEAeGzRE63mkU9CbIxrMDyY8/KW1OKBiinEyoDNK1HN7JMowqMYaDD/HIk2LNkIgU5ZW9Y1FBysgxu+4wHN4aAg1TmUakj31fXQ/QBEsa8mSdiiv+TQbBV93rzk7NQFoRLRwflBZ1uQmEgiWYpcWbDOZ/jHxE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10743.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(23010399003)(261026121527099003)(261022075727099003)(261009223027099003)(56012099006)(261021123027099003)(5023799004)(261102123227099003)(4143699003)(261022105027099003)(18002099003)(22082099003)(261026140227099003)(261021121427099003)(10067099003)(3023799007)(261028144727099003)(261022115727099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXlRcDdHUGM3d0xsMytlVDdMT0N4aE5kVjZsOTk4TE91bUpiL3NHSXo5dVl6?= =?utf-8?B?Q1I4WGpvNGFTYXIwRkxaby81Q2gyejBkWDVYMkoreHhWMHFTRHVIWG8zK29I?= =?utf-8?B?RjY4Y2ZPaWxuMVFvNzR3OXZLenNFYVpHZHc5bmJhaUxXVW5RRFVLNjJPaUtH?= =?utf-8?B?N2ZQTGZtU2NKTFFUQVpmNjRtdXJjT2E3OW5jajFTMERuQWF4U2VBZWtCSGl1?= =?utf-8?B?ODZmU1o5L09YMGZYSHhWMHVNSE1JZHdjZUVIVFprS0ZOUEV2a2pJdFhobzZt?= =?utf-8?B?N2VpYXEyUGlKL0J0ZWFwRURyMmd1bCttWnc3KzRQRDZBRjczcmI3Q294eEQr?= =?utf-8?B?aCtxQWZiWXFxb1JmRkovTG9BMHNtb2FmaDRkdlZUQWJMQzFySVFLRXZqYmhw?= =?utf-8?B?OGd4OXBQSzREVWhIanZBYXBGU2p0VStGcFZJNTNYOEhzVTlGTXVJbzRCVytv?= =?utf-8?B?SWlnTlBDeVVvamNTTlRMQWp5OUdIOWdVOXJNa1ErbERtVURZSVA5VVpQbGg4?= =?utf-8?B?TEFGZmI2aTNXNG9RNmNCemw0Y1pnRjlEYkNqZWRyblZDQmVuVE9KSmU4bjkr?= =?utf-8?B?U3FOSUZiM2RDNW5ZWXN4eFBzV1p4YVF4a0VRZndQcVNqeEN0Q0d2MS9WL2dM?= =?utf-8?B?djAzTmYwNUNvOWk5VS9OQUxCQnRzdDVKcU5La0VVZlFYYjhTUldzVTRDNk13?= =?utf-8?B?bmc2dnJDaVlmQ1I4T1czazZUYVc4V01henkwcytxRHpFWmF0dDR1YmJpYTlq?= =?utf-8?B?SUc4QTcrZ0JvcFU3anpnTW0vT1RtMzZISkdzQlB5MGNCcnRsNFNNdkFKVi9X?= =?utf-8?B?MXRuSjNSTDRsSjRVQW1uREJ4UDBiTm1JNGYrVERBdHE0QnBSVlo4R0tBSkpC?= =?utf-8?B?WjVrdmdTZHRUMWlQZUowZlc3K01UaEVzK3BXNVBYMzd4TkJSMVFrRHRRZ0I2?= =?utf-8?B?aXMxZzc4aUoxLzBxOGVrNGM2dzRYbjVmdlNndkR0cDlXeW8zZWYrSVpiMTUw?= =?utf-8?B?aHp1ajZENlRFRmRJamtUTlZXNGNOdDltYnNYcmRBbEJ5RFVmY2dRUDdvRjUz?= =?utf-8?B?QVdhTDFQVWNKZWlGNmRZekt1MEpwU0g3S3ppUWVUVzdua3N2SWhDVUpVM3hp?= =?utf-8?B?eS80WVdLSTRUdi83cEZWSU1HNm13YUZqa1J4ckdlNlM5SzROdmlDcGZiWWZN?= =?utf-8?B?RXZTQ3hFRUpha0dQNk5rRG1oUTZlVHdSbEk1M1NaNTRoNnZqNVNKdmluV2h5?= =?utf-8?B?UjVTd1lEejVQbTIzK0NIVlFPYmJDVEp1Q2hMR3JKVXZMU3VKSEo2OXhFOXA3?= =?utf-8?B?TEhyWU85d0RPUVIzUVVEd1huV2o0NWVtSWlZejRBQkxBN2hITldNMjVKSGE1?= =?utf-8?B?TklGU0R1dzhjRGxHVXBOdmRYelhLTGJpRzI5enpiQzZ0Q0hXVFlNL1JzM0RC?= =?utf-8?B?VDE1S0NFWVVoZ2w5L0phdzBrTUFhb3dReC9XWHpjeVZJSERXbDBDdWpzUGJU?= =?utf-8?B?TXlvYUt0RDkwTjZRWnh6N2w3MmhmOXVxb2tFTXpLWnZZSFdKM2lqaEd1dG9w?= =?utf-8?B?aDlXMVIvc1ljMHNXUnQ0UytHSnJWcEpiUStNbXp3bGRDMG1DamUrZzluRURF?= =?utf-8?B?TlhRcWQvejFNR29SS2F2WWhFMytqRjJwY1MzU3kyUU9jeVk1OUYvamJMYlVD?= =?utf-8?B?N2RlcS9rOElYZVZGaFMvbXl2dDdEM0FiQWYvVVlNSy84Nm1HZjNJcU9Td3Ft?= =?utf-8?B?elUzWFowWllGVU1GSmpGSThkbmoyYVpXZjhSb0Nvc3pwOFhjeGNzaWlTSVI5?= =?utf-8?B?VDZmMVpoS0Z1aXFGRTR3ZjErZGp4NVd4OVlTYnFBMkJjOXRmNXZCR0MxUHJG?= =?utf-8?B?N2JtT3RCalZXaUNBOHJmUzNXa0plZzVScHMwK1UyK0xTOG1wcnRZcS92SVFQ?= =?utf-8?B?VkFEdXRKeTBwaEpaNUNqM1k0RVhEZXNNMmFLa3dHeExjQUd5NTdncVFKZ29r?= =?utf-8?B?dGN5K3c4WTdPQzJoL2JVTDk3MGFGelZuNWE0MWJLU05nWi83NkFabVY0VUwr?= =?utf-8?B?TW9hM0pNa3BNcnVKSVVwZkxXR2Y0WDl2TEgxTzVOczBFK2lLVldEZU9QQzhB?= =?utf-8?B?TnM3RGpVd3F1d1VpMXVOcm9iaVVGQmJ0MWUweWg2NXQvaEJNaks2T1JwVFV6?= =?utf-8?B?RkdYMDc2MmVYRVVVU3gwMTJkWTkzazFlQ3pWTFgvR2YzMVRiZUlBOFZaRHYw?= =?utf-8?B?N0FOcXRqVVlIVGdPNmdxNlRqbC9sbzZkOGRqcUlNeEQwdmpmUFlONTVHQUF0?= =?utf-8?B?UjRpWVFkZnZXYmZqWHBTdXBkeVB0ZkRUUUMrMnA1eUVzV1oyWXdvU1JyOHZS?= =?utf-8?Q?Dw9wXAzbbcTSlhCU=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f39e97b-f5e3-4402-9317-08df3f0432fc X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10743.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2026 08:25:57.1820 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EmDS0gIWzhoNf3f4gleNQMybMpx5THbGFCY/gQmcIWODsN8LLCbt3vyi8eOVxmkSbvgWnuMkJdEfqfSIHqJ6xmmrRC1hP8cUetxa9Ltk2UQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9361 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v12 09/12] dm-qcow2: leak clusters allocated for a failed L1/L2 writeback X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org >> + list_for_each_entry(qio, &end_list, link) { >> + if (qio->ext) >> + qio->ext->cleanup_mask &= ~FREE_ALLOCATED_CLU; >> + } >> qcow2_dispatch_qios(qcow2, NULL, &wait_list); >> end_qios(&end_list, errno_to_blk_status(wbd->ret)); > [Severity: Medium] > The commit message says "Check frees them, so the image needs no check and > resume needs no refusal." Is that accurate? > > Once revert_l_entries_update() no longer calls mark_cluster_unused(), the > L2-table cluster (for an L1 write) or the data cluster (for an L2 write) > allocated in prepare_l_entry_update() keeps its refcount. The same applies > to COW clusters, because complete_wbd() clears FREE_ALLOCATED_CLU, which > bypasses handle_cleanup_mask()->mark_cluster_unused(). > > Nothing seems to report this leak. clear_writeback_status() sets > MD_WRITEBACK_ERROR only when !md->wbd, which is not the case on this path. > There is also no QC_ERR message and no counter, so wants_check and the > status output do not tell the operator that a check is needed to reclaim > the space. > > With persistent write failures and guest retries, each failed request > leaks one more cluster. Leaked clusters also stay counted as used, so the > used-end tail truncation added later in the series cannot shrink past > them. > > Would it make sense to log the leak, or to flag the image so that a check > is requested, and to reword the commit message accordingly? A leaked cluster does not corrupt the image: nothing on disk points to a free cluster, and no two offsets share a cluster. It is the same harmless leak that qemu-img check reclaims during any check. Setting wants_check would bring back the resume refusal that this commit removes. The message already says that each failed request leaks one cluster. A separate log message adds nothing, since the guest already gets the write error. >> diff --git a/drivers/md/dm-qcow2-target.c b/drivers/md/dm-qcow2-target.c >> --- a/drivers/md/dm-qcow2-target.c >> +++ b/drivers/md/dm-qcow2-target.c >> @@ -173,10 +173,6 @@ void qcow2_flush_deferred_activity(struct qcow2_target *tgt, struct qcow2 *qcow2 >> struct md_page *md; >> int i; >> >> - /* >> - * We need second iteration, since revert_l_entries_update() may start timer again after failed wb. >> - */ >> for (i = 0; i < 2; i++) { > [Severity: Low] > This isn't a bug, but the comment explaining why the loop runs twice is > deleted while the loop itself stays. > > mark_cluster_unused() is still reached from handle_cleanup_mask() with > FREE_ALLOCATED_CLU, and process_indexes_end() still dirties R2 pages. Both > can re-arm slow_wb_timer after the first pass. > > Could the comment be rewritten to state the remaining reason for the second > iteration, rather than removed? The loop itself explains why it runs twice. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel