Re: [Devel] [PATCH hci-8.1] configs: build with WERROR and KVM_WERROR, as RHEL does

[Konstantin Khorenko <khorenko@virtuozzo.com>]

On 10/27/26 14:54, no-reply@sashiko.virtuozzo.com wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] configs: commit message cites a nonexistent UML config exemption for WERROR
> --
> 
> commit e34168fc988cd9c5d2c187255bd4bad60ab0fb1d
> Author: Konstantin Khorenko <khorenko@virtuozzo.com>
> 
> configs: build with WERROR and KVM_WERROR, as RHEL does
> 
> This commit adds CONFIG_WERROR=y and CONFIG_KVM_WERROR=y to
> redhat/configs/custom-overrides/generic so that the vz kernel builds with
> -Werror, as RHEL does. The commit message says the UML config
> kernel-um-rhel.config is kept with CONFIG_WERROR unset.
> 
> Link: https://virtuozzo.atlassian.net/browse/VSTOR-151903
> 
>> diff --git a/redhat/configs/custom-overrides/generic/CONFIG_KVM_WERROR b/redhat/configs/custom-overrides/generic/CONFIG_KVM_WERROR
>> new file mode 100644
>> index 0000000000000..af20cbee74354
>> --- /dev/null
>> +++ b/redhat/configs/custom-overrides/generic/CONFIG_KVM_WERROR
>> @@ -0,0 +1 @@
>> +CONFIG_KVM_WERROR=y
> 
> [ ... ]
> 
>> diff --git a/redhat/configs/custom-overrides/generic/CONFIG_WERROR b/redhat/configs/custom-overrides/generic/CONFIG_WERROR
>> new file mode 100644
>> index 0000000000000..f54ff6cdaab85
>> --- /dev/null
>> +++ b/redhat/configs/custom-overrides/generic/CONFIG_WERROR
>> @@ -0,0 +1 @@
>> +CONFIG_WERROR=y
> 
> [Severity: Low]
> The commit message says "UML kernel build produces warnings, so we keep
> kernel-um-rhel.config with CONFIG_WERROR unset."  Is this exemption
> actually implemented anywhere in this tree?
> 
> A search for kernel-um-rhel.config, kernel-um and um-rhel finds no matches.
> The only UML-related files are tools/testing/kunit/configs/arch_uml.config,
> coverage_uml.config and the wireguard selftest um.config, and none of them
> come from the redhat/configs layers.
> 
> redhat/configs/priority.rhel sets:
> 
>     ORDER=common rhel pending-rhel custom-overrides
> 
> so custom-overrides is merged last into every listed flavor, and the new
> custom-overrides/generic/CONFIG_WERROR (=y) overrides
> common/generic/CONFIG_WERROR (# CONFIG_WERROR is not set) in every generated
> config.  priority.rhel lists only x86_64, ppc64le, s390x (including
> zfcpdump), aarch64 and riscv64 flavors, so there is no UML flavor that could
> be exempted.
> 
> If kernel-um-rhel.config is a standalone file in a separate vz build
> repository, the build is unaffected and only the commit message cannot be
> verified from this tree.  If it is derived from these layers, would
> CONFIG_WERROR=y reach it and break the UML build on its known warnings?
> 
> Could the commit message say where kernel-um-rhel.config lives, or could the
> exemption be made explicit in this tree?
> 
> Also, since both overrides sit in custom-overrides/generic, they apply to
> every flavor, including debug, rt, automotive and zfcpdump, and not only the
> main ones.  Is that intended?

  The tree you checked lacks the User Mode Linux series. The base of this
  patch, 39277db2080be (rh10-6.12.0-211.52.1.22.10.vz10), has the um
  variant and its layer:

    priority.rhel:                    um=generic:generic-x86:generic-um
    custom-overrides/generic/um/CONFIG_WERROR: # CONFIG_WERROR is not set

  The um layer is merged after custom-overrides/generic, so the um config
  keeps WERROR off. kernel-um-rhel.config itself is generated and ignored
  by redhat/configs/.gitignore, which is why the search found nothing; v2
  names the layer file instead.

  WERROR reaching every flavor, debug and zfcpdump included, is intended:
  with ENABLE_WERROR, RHEL's build_configs.sh turns it on in every config
  as well.


_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel