From: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>
To: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 0/3] drivers/vhost/blk: fix virtio-blk request header and payload parsing
Date: Sun, 25 Oct 2026 22:54:25 +0100 [thread overview]
Message-ID: <d9f00cb5-6a2a-43e4-8496-ec4ef9f49134@virtuozzo.com> (raw)
In-Reply-To: <20261021084610.1476738-1-alexander.ivanov@virtuozzo.com>
Reviewed-by: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>
On 10/21/26 10:46, Alexander Ivanov wrote:
> vhost-blk parsed guest requests from the whole descriptor chain without
> telling the device-readable part from the device-writable one, and used
> the header fields without byte order conversion.
>
> Patch 1 converts hdr->type and hdr->sector to CPU byte order.
>
> Patch 2 takes the request header only from the readable part and drops
> requests whose readable part is shorter than the header.
>
> Patch 3 takes the write payload from the readable part and the payload
> of other requests from the writable part, reads the status byte from
> the end of the writable part, and fails reads and writes with an empty,
> oversized or misaligned payload with VIRTIO_BLK_S_IOERR instead of
> leaving them hanging.
>
> https://virtuozzo.atlassian.net/browse/VSTOR-142755
>
> Alexander Ivanov (3):
> drivers/vhost/blk: convert virtio_blk_outhdr fields to CPU byte order
> drivers/vhost/blk: take virtio_blk_outhdr only from the readable part
> drivers/vhost/blk: take req->len from one side of the descriptor chain
>
> drivers/vhost/blk.c | 56 ++++++++++++++++++++++++++++++++-------------
> 1 file changed, 40 insertions(+), 16 deletions(-)
>
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-10-25 21:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 8:46 Alexander Ivanov
2026-10-21 8:46 ` [Devel] [PATCH hci-8.1 1/3] drivers/vhost/blk: convert virtio_blk_outhdr fields to CPU byte order Alexander Ivanov
2026-10-21 8:49 ` no-reply
2026-10-21 8:46 ` [Devel] [PATCH hci-8.1 2/3] drivers/vhost/blk: take virtio_blk_outhdr only from the readable part Alexander Ivanov
2026-10-21 8:49 ` no-reply
2026-10-21 8:46 ` [Devel] [PATCH hci-8.1 3/3] drivers/vhost/blk: take req->len from one side of the descriptor chain Alexander Ivanov
2026-10-21 8:50 ` no-reply
2026-10-25 21:54 ` Andrey Zhadchenko [this message]
2026-10-29 11:26 ` [Devel] [PATCH hci-8.1 0/3] drivers/vhost/blk: fix virtio-blk request header and payload parsing Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9f00cb5-6a2a-43e4-8496-ec4ef9f49134@virtuozzo.com \
--to=andrey.zhadchenko@virtuozzo.com \
--cc=alexander.ivanov@virtuozzo.com \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.