From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 0261C803F6 for ; Sun, 15 Nov 2026 11:41:34 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AFBdCM4011899; Sun, 15 Nov 2026 14:39:13 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AFBdCM4011899 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="jZu9w+xU" Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AFBd9ox011895 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Sun, 15 Nov 2026 14:39:10 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AFBd9ox011895 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8a06da65d92so1816696b3a.0 for ; Sun, 15 Nov 2026 03:39:10 -0800 (PST) X-Gm-Message-State: APuU4Z8JiRjWQlrEK9rDYrzKW0zdfq+3/meW6NeQXUR2YkN0MYlbY4WX PKwNCLGJzHV6kGdQzjXIhwA7yqB+kZxJWZgXT5fma8Cqie4u4dv6+79OAR5ycs1heNSW4IHvlR/ MtsM5HJS4Tv5yqjG1ScItOOJPyO17ws77eIc+nA1lYpFl2n1ExkXADA== X-Gm-Gg: AYBFou3NfBBTAH2ZQTQaFsiA7BVSh9S+ts0Q4oOz6npaC6pwjYRDz1sehG3LkWFp01U mucJ0d1jVnsCMpe+crMXjMjIyQl0fhzX8ryGGdjYpZNxM5zJNXu/u39lSSMyWP9pwCvMOI9K5EB pRKuL8vQ99J9BZV1cl2hiCQZ63kw5SjqlAhf7eZdHSsFZ1N75NI480SeGOQAgZy58R6GwKNmZI4 bmNHqLNv9o75YfkO5T82uRX82VLKEFA/7PVgVb/zr8W+qYdWFcNOnm4j4Bn3TyIkKzOUqwxtUoS Yg1xct142WsSKSdHOjUHzE5kBELMf+7VIs7+buM0IZUu8JiqWUUX+vzlMmFgQFnv6ofhOsjsh4c U0UR0FA4ebCFbL3DcTcHyHxIZJQBoTrwtIbJxvECxHfeGqzrA1tK18K5kaJCvKX2t642UPrDI3E Lljnh0jBCzmoFcASlrnnGEhMD2ibGi18gF X-Received: by 2002:a05:6a20:9c87:b0:3fa:17db:6e65 with SMTP id adf61e73a8af0-3fa17db76fdmr1769634637.39.1794742749165; Sun, 15 Nov 2026 03:39:09 -0800 (PST) X-Received: by 2002:a05:6a20:9c87:b0:3fa:17db:6e65 with SMTP id adf61e73a8af0-3fa17db76fdmr1769623637.39.1794742748620; Sun, 15 Nov 2026 03:39:08 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1794742748; cv=pass; d=google.com; s=arc-20260327; b=gdVdC3YY9wsNHU1PEmGwDPdFv/sCxKF4xzyLWLOQPSXG4WfgDRbGm7R2SOaM54D3Xm giW0dkDpCMgLUsULn2JZPO0OtKc1a3YFfYCyB7l+lW2QHdy877/DAlaFbW9NVlLbD2Yb jKswACW7r7HqtR69D3Bit4bWVBHVfePf60/0gZ0LGyhx3UwUpyUM5dmZPnGlpTBIfRnW dv6DsFWPA64JLDZOt2Ru7/eTkSKrB9PWh0RQkfCfM/1Kp94JRVZmc1aesMiywJqi1d+b R1arM+ddglG4zsSAFkeWgapk55u05kwizFDIlBe0ejTFpHpEdKWB182kfif98gRkRkF9 rBNw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=eQQM+36D8o6XOBYkQRT2OTPh1155gMO8H34uUZuWwl4=; fh=IlzoM7xapMIT9vjIu8V1YxnmOSGAT8hvLuDm+hjUGIo=; b=n6JcV/NjcsN1b4uxeNGZZ7c3/AnD3PIpGe9p7d/qSHCB8+QbmdtqncIdk5OZT8/eGN ze1devQpy8iq8QSZkRXNqzIPtofTkIR7S7bLSMwgDCuWHL1+rIkgQrHCNtixp9ZbGERZ sKG0hVDRVh6MF98FLCtEC9SXNoOZOnKYIu4OcCbYImPyw/JNtIrqm7smF+cCwGuDur71 7qr9mofcFjIwoxdBN/i3ING6mLcYPvImpLPbFu63M482HXhkdC0cvDeT84U2MsEVRIgI PDv9SraD2a46DER9/Vmtsn4L0m0wMADrRYe2Tsc7tPdAQuDqDev3PJaJq9fO4DpMcR3j gN/Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=jZu9w+xU; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c207::3 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazlp170110003.outbound.protection.outlook.com. [2a01:111:f403:c207::3]) by mx.google.com with ESMTPS id d2e1a72fcca58-8bed3bb8a2asi14833614b3a.107.2026.11.15.03.39.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Nov 2026 03:39:08 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c207::3 as permitted sender) client-ip=2a01:111:f403:c207::3; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=jZu9w+xU; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c207::3 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Dcn3gf92J7WJx6WiKDqf0ZgxSgYfs1rmf/Y1a2h0fIE8QBVgKkf2tu/vC4TpcOXE+vmW2BpiE8z+27AKW2jrVxJ1QOdytN9aclJhOtsmtoS9NtU7pTDHnr4T0gDxK17BeZpcVfFmOrfh+4gv7EOwGSKsCxOdQHpJ7re3mAZbEoxhprKPm/ZuoW6+Oy6bm0InTRAu73uy36BEJ9zpiFNh4h83X6LPMOqz8mIhAWXCBmRbWvKpPzStWdEqjvz2WBTzXO74hKmbS4WgwVeWJXssBNSxBUAM6vkAdeZuBGVBc0J/nDpABv+MB7ObhTwnq0r1jN5PAqbcpnWHB8hcL12AZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eQQM+36D8o6XOBYkQRT2OTPh1155gMO8H34uUZuWwl4=; b=slXix2XTcbAlvaIqDtCsMXJCvwfUbCq8CcVOYWwHUOj1q/DRKLLFwiXJ2LkEcFjdNM8LyV+hAvub77eXy57d2vq14pXqxXIMVWF75TAtubR90kQ/F3YOLoTNDolDWHk4TwomIswdEOc0479EA9uT845WL68hbjPtO5lPB8Q7ObTK04VSfemALcuAPjeFM17VrfF7m+Cg6IjhUTDXBmDzBC3HFN7q+r9mthYNZxuWjf1+U5PVrvh0GE2FsEv/1Q+f19Au+YH0CZw2d1nYh2PtX7sQ3tRHDUSA6Wn8tfrAorf3zWrwo+dkLXlLcS3jYxVH5xW0quuWc69JUpR+V2ZS7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eQQM+36D8o6XOBYkQRT2OTPh1155gMO8H34uUZuWwl4=; b=jZu9w+xULL7q0iSgPHrbCGNARZLK1XOF4KvqH0nmAf8t/QoCFUCMqIrx8zcLvCUITYsYbD38TE6zK43wFrH53dwlPnb9EB9+cupL4gOlsPgqbLI3hUT9yA4FMIYkuaTSf9RcRtQ05lq+I6hvbegZXZ96dxchIz9TA8KSI+eYZwpXYG7EZT0iP5PN2zOP99AVgnfA9RD5nIcJR2O1URSq7+FonHHpUXLFKMiovm32PhoXsHT8LfcEL3e5alkWOqbL0C9tp0vhi/QAzlzblqntu/ePB8ZXWfoKDkXpmasd6fTeDzxBrefoaJJtYkFCEdWosR0y0FkNRICvFG+so/IDaQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) by GVXPR08MB11786.eurprd08.prod.outlook.com (2603:10a6:150:312::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.13; Sun, 15 Nov 2026 11:39:03 +0000 Received: from VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a]) by VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a%6]) with mapi id 15.21.0592.009; Sun, 15 Nov 2026 11:39:03 +0000 Message-ID: Date: Sun, 15 Nov 2026 12:39:01 +0100 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, andrey.zhadchenko@virtuozzo.com References: <20261115102811.2745757-1-alexander.ivanov@virtuozzo.com> <20261115102811.2745757-2-alexander.ivanov@virtuozzo.com> <010701a1dec69ac9-bf9daa4a-6cb1-4816-b5e7-cea3599a4584-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Alexander Ivanov In-Reply-To: <010701a1dec69ac9-bf9daa4a-6cb1-4816-b5e7-cea3599a4584-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: ZR1PEPF000077CC.CHEP278.PROD.OUTLOOK.COM (2603:10a6:918::473) To VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10743:EE_|GVXPR08MB11786:EE_ X-MS-Office365-Filtering-Correlation-Id: ae2c4ee3-ae84-4e58-11aa-08df430d0c79 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|366016|23010399003|10067099003|4143699003|56012099006|261009223027099003|261026121527099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: dfnZAV056zgf4u5359c3cmMgEYkoDA6eHznGj3fB12PKuY+7ehOQ8lKSdBJ8n+JR/QAwrpWdz6Prtls2aUlxURMfBWjxlB4U624j/0zxGY8KdDHDKfuw+y37bYPN5gMEvZJNV2DYjg4+3SrJXImdilkd05eTgosL+H7cEmtUK4tga3zYGK47ldrlT2W7zLPUQ7ZzGzvaQVu2sZlziPnMTkO1aFpgArWEXI3TzvZrBvoqRpL6pi2aWu9BqmqEtv5OiHV1A9ewJ7L8K4tz/VqWSO+wNgA5oqbaFl2NMkLqgBY1MLYK2V/yB+6tcOpznoasyKqEW3+nwIwesAANGBxc3nYT5hTM3VhoBOuDzlzYbSuPy7A88jrIfzHiRK6/eXPNy1Lm9a4CPvn68iAWxRlZAhOYRezuWDzCk7liUPJwQyEHdzbBqLvFIRXSnrRZBL0Sl/9mHEq4pxskc2zM+A+B1pRJN0nlzdHOdFe6Gkyn07phGWsxZfSRVS2Pl1FKqBSFbeSFF+2o80OiWGDh8IqgRWPOviQFRe3GunaNcZOBW8YmiLL3+IoRxQWVsHH9P1s7HUH9Sp1j8fgK/bB8r5osQJVpfxtvowhV4FPIKESjzwrMKeK0c80YL+mbvaQmoSsXed6lR1E/LOLldaU0oTCRfXjYYzNyFKU0Nf9UPBkBdoQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10743.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(23010399003)(10067099003)(4143699003)(56012099006)(261009223027099003)(261026121527099003)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGRjcmxkRERCVmF3SzFIekFGcVZ0L3dveFFyVWdTTEpGMzNpTGZXbnE1amFR?= =?utf-8?B?SDJhL09IUk1HZVJxb2ZVK1Z5WE5TRDRPUXVxSmFDQkFjS0FwbjB6U3lETDZD?= =?utf-8?B?aUN0a3hTNnpYOS9CMzZuSERxZHBzRFhJYkJuVCtnVnRMOU00d201SzBneGdV?= =?utf-8?B?UU5zbGdrQ2lZSy9FL0RGQjk2c1VRSnVqWWNqbjRDVW0yOW84ZUw4Q3VFZ0ZL?= =?utf-8?B?elFJaHMwdS9qNXpyNzZzakZhMVJRblhRTGRucmw5YnJscm0wRHZVN3JBQzVm?= =?utf-8?B?WWtFbHhXSXJabHoyTTkxQ2hQbklXcjJVRG84YlI2akZrZE1tQU1XdStoM0lv?= =?utf-8?B?VDRVSHYyNGlXZFpBTGk0Y1pjN0Y0OWRuMk1UYURDbDRObXF3VUZJeXZPWldt?= =?utf-8?B?V0pHSm5MeVZRZVJ1dnJhRGIxQlI1bGg1cEpJanl0d054cVZrWjYwOGZ2OElE?= =?utf-8?B?UVVuVGdCUWZ4VEExTSt2QlVxVDg3UEErZDB4Q21adHFTcVpubGp5b1hVOGlL?= =?utf-8?B?TU1IdlltN3JoQ1FleUE4aXRlc25nOWFiVVU5d3AwR0d2b0dmaXlYaVNIZG5Y?= =?utf-8?B?Qkk3bE1DMnBudnpBY25NTWZtMGFJRG02a2g5azlvNjVMOG5odHZZNmYvZjVI?= =?utf-8?B?SEhzMUhkb05mdkJnNHVXVjBFVG1lRWNhZExHeDlBWGxHZTM1Nlg0OG5Mdmd5?= =?utf-8?B?eWkwK1IvdnhLWGtuSU1NeWhGdm1WL1k1dlVvS1hhRjRBZTExY3ZJa0hZdFRL?= =?utf-8?B?bDE1endkUytCeXF3WFlvV1c3VFNIWHErNzY0UEtuRFZVQTFISGNzTDkvM0E2?= =?utf-8?B?TXVNTHJydHFYTjdLWDlxM1R3Uk9GV0h3elFJVkZWZ0xaWFgyajhqOXFQbTQy?= =?utf-8?B?SFI1dnpHYXNQSUNzRDZ5c0IycXdnUWNjNjRidUpMNkwwdjZBNG1DeUx4MnVV?= =?utf-8?B?Y0RUMkFOUExnZDdwQWZyQWdFdWs2M2ZTL3lGTVNPYWdOcnlmSXYzc20zUEJ6?= =?utf-8?B?b2kxUitTeDVWWjBrUkZQdmVNWkpJeWhuSlhZYnhPZjAwSCtpS3hsbVE4YUhh?= =?utf-8?B?VmJtT29QdkpFb3luMUlXS0ljZXRGTkg4aFFjeE13UnRKWEpqTXRJSmNEbjds?= =?utf-8?B?SmNxOXMxRmxLWHNDNkMzQlRKOU9ZcVNSUkNOM3dIbnYwWjFKMWRlVVAxa2wy?= =?utf-8?B?L0Rqa3ByWUdmUks0bmNRQ1RsRkt3WVZ4ZW5KMXlWck5oMHV0S3RCZE1NMStG?= =?utf-8?B?ZzJCMnNlUG5tckgrZDJockNiSmR4bGY5QkIzUVc5eEl4ZHR2Ung1VDlqY2J3?= =?utf-8?B?UUk4TkFYbTJ2MVJmRTQrcVhqdk5FRVlCc0dTckZ1K013R0FKS3V5RG15bXpD?= =?utf-8?B?aTlSbkNrMGgreG1mUE5odUs4SjRPTG1tNEZCZkFEd2dRamx6U3NnKzlXQitR?= =?utf-8?B?RnU5b2pwM0xMYlVSdndsMEorT0w0OXBodlhYc3FYeWJwaUlLOGlPYkpmMDN2?= =?utf-8?B?VmlzcS9KY2Zpa0h2ZlVocXBhRXlCREZFeEJZWHkzelVkUHdVUkhnczhqekJY?= =?utf-8?B?ZFpDQWVZeWw4T3FqSFRvWHVVN1l2eldaN0ZoMU1XN1ZidW95cTRFM2hpaTJQ?= =?utf-8?B?VXdDeFpEWER3WUo2Z2RJSUdiVTBsYnltSHVOaUg0TDB6bEg5b0dZNEl1SGxw?= =?utf-8?B?K2x6T1dXY1Z6NitmUFhJMk9CblNvY1g1VlA2SUVxNjcxanQrdFdBcXlpZmk0?= =?utf-8?B?ckhLQUpSRGZISWpIcDQ4UGlpY3VrRVR4cUpLL2ZlcE5BL3UwQXFsTU1UVkx6?= =?utf-8?B?bXc0UjRKK0NkOHUxaCt3UWovUlpKalN4TnpBN3hpb2RFR0g0UEN5TzhCTE9R?= =?utf-8?B?SjIwTU1BTnl5WFBtbUw5azdINXNwaFY0dFU3ZHRrWUo2S2FORHZtQ2FQZnh1?= =?utf-8?B?Y2ExN3RDdWFlM1NTRlFOU2NFU1F0YVRkcnhsdzNLUnhEQzB4ZkwyRlB1TjZB?= =?utf-8?B?eHhVWWl6c3plWkJKZnhOQ09WekFOejczeVBocDB3R3Y5YTFLVjFOai9GUUth?= =?utf-8?B?MmFHZnV5UXlFdnFBSDRndjFreEdxeFc0Q2lmN1k4TzBKQUYyWEwzZVVKelE5?= =?utf-8?B?cS9hMjdrdFQvdDFKNTdkSUNKSzZwS1pscXZCWlpsNWtvckxjeEtiTnBBeGUv?= =?utf-8?B?a0lhdjl2UHAvSzI3ZERnZkdPNHI5YlNOZ1VkcHNhMWh4amk5alN5L0JsOXFl?= =?utf-8?B?SnAvdnRKQzdPQWtEaGdTTkoweFR5cm1OYkJXQmliYlA3b2xFSDQra3VqV1Bz?= =?utf-8?B?TW5UUDYrNXBiM3QrUi9CQlQzNTFOUWQ5VFNBWmx0R3lNRFYrZU9ZcFhWK2dp?= =?utf-8?Q?k9ZNSdaE2cHo/XL8=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae2c4ee3-ae84-4e58-11aa-08df430d0c79 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10743.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2026 11:39:03.3932 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZjIBC7+i3HGzrpFGpABaJV6XmBbjKOxq+uJr3pnUrrlhKEwGicHd9ql6Sw1/SLAzpSf1YhOw7ns+IxfvkolWope9x19jD6stosbrZlSOQPU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB11786 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 1/2] drivers/vhost: fix a use-after-free of VHOST_SET_NWORKERS workers X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org >> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c >> index 1057ba7e3fc7..5092eed75b8f 100644 >> --- a/drivers/vhost/vhost.c >> +++ b/drivers/vhost/vhost.c >> @@ -1094,7 +1094,11 @@ static void vhost_propagate_workers(struct vhost_dev *dev, int nworkers) >> int i, j = 0; >> >> for (i = nworkers; i < dev->nvqs; i++) { >> - dev->vqs[i]->worker = dev->vqs[j]->worker; >> + struct vhost_worker *worker; >> + >> + worker = rcu_dereference_check(dev->vqs[j]->worker, >> + lockdep_is_held(&dev->mutex)); >> + __vhost_vq_attach_worker(dev->vqs[i], worker); > [Severity: Medium] > Can worker be NULL here? __vhost_vq_attach_worker() starts with mutex_lock(&worker->mutex), so a NULL argument is a NULL pointer dereference. > > vhost-vdpa calls vhost_dev_init() with use_worker=false, so no default worker is ever attached and every vq->worker stays NULL. VHOST_SET_NWORKERS has no use_worker check, and vhost_set_workers() only attaches new workers to vqs[1..n-1]. vhost_propagate_workers() then reads NULL from vqs[0] and passes it on. Before this patch the NULL was only copied, which was harmless. > > A narrower case exists on use_worker devices. A killed worker leaves vq->worker NULL, so a source vq can be NULL at propagate time. > > Would returning -EINVAL from vhost_set_workers() when !dev->use_worker, and skipping a NULL source worker here, cover both cases? Fixed. > > [ ... ] > >> - dev->vqs[i]->worker = worker; >> + __vhost_vq_attach_worker(dev->vqs[i], worker); > [Severity: Low] > This is a bug fix, but the commit message has no Fixes: tag. Should it include: > > Fixes: 705a4b3eefde ("drivers/vhost: add ioctl to increase the number of workers") Don't have such hash in the kernel tree. Added - Fixes: 1491588e71da ("drivers/vhost: add ioctl to increase the number of workers") _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel