From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id F03EC80E7E for ; Thu, 29 Oct 2026 10:49:36 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69TAmHrl031566; Thu, 29 Oct 2026 13:48:17 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69TAmHrl031566 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="DuoZwHgE" Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69TAmEn4031562 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 29 Oct 2026 13:48:15 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69TAmEn4031562 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-89f71ac2e2fso1755276b3a.3 for ; Thu, 29 Oct 2026 03:48:15 -0700 (PDT) X-Gm-Message-State: AFq9FYJHGd3KWUwlpvqT2Ukbh7HgOzkF/D2rp4v3DrvwH+sglKPJMz6U aiAFRY4/602zafryedZYDrTmcojuUsAMp8lN4shvg6Ofo3bJkv3/6BaGAD03Kus2u6EQlknKk8I Rhy+UYnoldPnoYf0BWqIQ+Zq42ySEH+KffmQFRiQnBnVPXdXNdI+Tcg== X-Gm-Gg: AYBFou0bga22jPG5o9PyTx7r2VUCDgn5ouVAVY3G7T2HhWcWygl9i2pK1H76PUJ6CLn BP9qdbNzgRvl4n0qBHQoGpHzLAyWjmw8YsD+f9KL7t0BwQz5ELmPRo/idprOE0+hSUylhBzYPvC +fEA/zZw29nna68O0dXaMZPXi0olL2NTUbCuA4Cveo34pyEq9cPUMSIRHqX1lK4FdX7jY2iFylB n+s+tyLUCSRWpEBCY4fWImQrHYsHWfsqfC85LfIM8LASOPvqw1Ov5Dov7nGvWe3t7LeLSlf75wv FsAPwx2jAHg2wFo9W7s1zCLb+4H9nqOH89XcwI0DxeE9RJPfmgy/M5UupMie+L67+Ity+2eR14h YSXAaBogy5EkEW2V5WpgBTSgmfLvJv13f6RE23n0RB4sz/i2erIvfVCYSpwzD4NuSeGGojcAwFw 73yRsjucFuHkqQ6WaL6I+D9V8LDupQaBFT X-Received: by 2002:a05:6a00:3489:b0:878:3538:8f7d with SMTP id d2e1a72fcca58-8a6e7ccc0efmr4164359b3a.43.1793270893975; Thu, 29 Oct 2026 03:48:13 -0700 (PDT) X-Received: by 2002:a05:6a00:3489:b0:878:3538:8f7d with SMTP id d2e1a72fcca58-8a6e7ccc0efmr4164331b3a.43.1793270893382; Thu, 29 Oct 2026 03:48:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1793270893; cv=pass; d=google.com; s=arc-20260327; b=HZbiGR183iPKOQre61X0G5PbLTp87orEuO4r6+c+7PbXXzevRtP5pa9HwZQ3a/2QxL KTtDQO+zsT0ymBRDNhILWMg3pQo5JyMKFtenXeXI8d45NwHn6hGzGR9WzKX39zGyeEvl gKQTyiFnrV2QO9wlUfeQpXI005vBbhH1uUsJGrNOAxGs1e13iwQtZTY7DH+Yf8DVfLTa S6wF4omKhUlvyJ8UZcHx4ULRQmHfE7Q5+Haxw7cq2ty2N2xi3diDCc1oMiW5PqHQWMm9 B6rxUthZVfODquFKSvFOAEL/BfGqVYqx3eggP5JqBD8tEv6CsDyi1BAK16n+m8zZoZ1S JthA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=EjQT2CEOEhOstNX0S0ekUEXkBQf7PUaar6jtCuAWx9g=; fh=zb8v94HIydbT+fODnrL16oDT0rhznlRsQrQclEqomio=; b=IT1m9lwvFVWPw3Vf1FYugBRjN9PAqqua+Ryao6prkMYoHXF3aorEU47aRmpwEyI6te gzEY/BDL9rFbdDwRf7mNZZEwYVEy9ZObaobu9A6Q3HMi12LPnYevzmIupWB8NxTESgqM 87lB8Kuc8IpFlYnawBboK2r0EJnQcZHynAUSYOk2JzY8rH9svBiHIaCDjSf/nOT9Zyz+ DplOczROIT9uGyla7mDkgkm+P/zCBg0+pj7Z/uZK+VCPaRprA5/KYvg8MFP+L0fyzhtc IkDFPgPr38AO1I1zDJNaSqOoCUaYO+npSaCg5vtPgqelcPBiKmA/xqjcERhjBjUb8R1y eOJQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=DuoZwHgE; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::6 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazlp170130006.outbound.protection.outlook.com. [2a01:111:f403:c201::6]) by mx.google.com with ESMTPS id d2e1a72fcca58-8a6a5a8e1cbsi10125780b3a.258.2026.10.29.03.48.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2026 03:48:13 -0700 (PDT) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::6 as permitted sender) client-ip=2a01:111:f403:c201::6; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=DuoZwHgE; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::6 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hUZE9+BzykHK2KPeHxbALLyQjvns9SiLzOu7/cy+uuN++ATljr4XoAI5S3wMiWL5y4/f5/2dOjEE51rjedVEhV1wZIuvvTa9ZGAPAHtxDCAQltkkgYmVQUyATi1nULBNmH0lQKF82QRp4uh1IdMoeylsfXK3WA52DRSZbpCnQ6k72ba7X7Gxe4u0sQ0jhcQ95m+XU/UMbvj6kz3X9YyzVPhIxN64qK7s8TSdyRNizRMv9sVjB3oqqKJeLwTf1TfC9RVq7TbHC6NGWwZ6NwMEhIdAdjmVgZyW3jczH0BXsn0LyAzOf9LNE51xPFbKhAn3cYyS/VkW1jMtCdCvumRdJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EjQT2CEOEhOstNX0S0ekUEXkBQf7PUaar6jtCuAWx9g=; b=VjpbOR22UDpOjP28Du2Obh/tKMrj0T5zygY1LHK8uoLhEgfm/fxlIg/gTxl8nR9bBviYKuo7TcDqcjcKUvEeZ04VszRH/9J64PX2uJh898agOiuAJ+D3z3VtTy5BkFIRor34+zdOcSDOmsO0oh/nNuj14AwvuaKou1c+CTIkhHPEe/DHZ+YXa1454vK1LOJep9vg6FClWox0X0bQht6bNTQcs42zeHHRoRiBWdM1mzFxkT9uwGqtk4CUJYRM0UL/PkzN6wXfO2EcOCZDWIF+42fcGNQtCMg/K4aP6+kZVWCGwfwJzTt29rbKJSLwiruNyErLmJOYXLZZdGVduWrCDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EjQT2CEOEhOstNX0S0ekUEXkBQf7PUaar6jtCuAWx9g=; b=DuoZwHgErG5Q0ptDCBpdoyStDZ6RmwajnavUcp4pmDFs9LteXxaGrPyGjnMgmWtrIchGveAH5nx5DNq+uSuHz99hUnkigOaTBrEYX6QXg/xwM5ShDXBS6U9l0HXpAeWMeAxQ7hqhVeeyYr85Z4ag4IRKESssI/1ZG1n/qsMG412/fy6UYcZDs8q0X4kjmjbTjRCbPgt2mknvVTcobcohQQ0HgGGKP6Owk68rAvApS8SF8hB0Ywh4uDwpDaNax/B4Nu1Q/LD9Ps85YaK0ew09yI0nyRmOFjdRQYFmO6ryRmeulsnYlM5RtJHTGuh4GPHvBtCL4jfVEsU/JHQ7QuUIaA== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) by ZR6PR08MB117518.eurprd08.prod.outlook.com (2603:10a6:910:e2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Thu, 29 Oct 2026 10:48:10 +0000 Received: from MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa]) by MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa%3]) with mapi id 15.21.0569.008; Thu, 29 Oct 2026 10:48:10 +0000 Message-ID: Date: Thu, 29 Oct 2026 11:48:08 +0100 User-Agent: Mozilla Thunderbird To: ptikhomirov@virtuozzo.com, Konstantin Khorenko References: <20261029-ct-invalid-nrpoc-v3-0-89d4b0b7d520@virtuozzo.com> <20261029-ct-invalid-nrpoc-v3-1-89d4b0b7d520@virtuozzo.com> <010701a1872ddaaa-dd6519d6-222d-402a-9d5b-a32a002b7ba2-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Vladimir Riabchun In-Reply-To: <010701a1872ddaaa-dd6519d6-222d-402a-9d5b-a32a002b7ba2-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR3P281CA0153.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::11) To MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI7PR08MB201474:EE_|ZR6PR08MB117518:EE_ X-MS-Office365-Filtering-Correlation-Id: 42a9dd1e-d368-48ac-8297-08df35aa1f7b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|366016|376014|1800799024|22082099003|18002099003|6133799003|261026121527099003|56012099006|261009223027099003|261022075727099003|261028144727099003|4143699003|10067099003|261021121427099003|261022105027099003|261026140227099003; X-Microsoft-Antispam-Message-Info: fD/Bfn8psJeGWs9tZyNxqTEooH/BHcALmvWREjsGOOwcSAbEs3BNaEX9l1Vp17xFNEZG33CgZr+rnOvHT8fxHlA8GXMuS+vN7amDdAch28A6wM1XFP8lqdCZgMUrWMfJvru+GteiZ9dQEs/k3HeKxFkjqtGAK7oShMHkFUjyDja/qu5QlLY599FkPfVAor9RFeaF5brjMIw227NKqoar8QaKnL9FbRQOduXFxeMjI1kGHZ7CPaQkbg/D+mf4ZT4t2ERhMgbmPPB+DIgf79xAItUv3wPk0i/u+FHOoEtnC3CWJLt6/MmLn/L7K1/15xSev4OHas83RP5Mt9+O+smi+MXW7zBGNv2UqGxuApUG8G2nRaVLEAG/j3mr2yPuWThSxh9tvZpyNXwsZgj8c5dF2f5sg5yaEltxPGPGTPwxLyW9zK0LY6ILSfhi/q34W9YxJHowDeJL6bqsFMm0Xl954ACdrpJHzgok1S/0ozOduKDDJHd6vWuKZ1jQqbUOYeJ3OA1oFaJysxhY7OLTW6ciLD6+kGgNxy2Pe2Qphp64HMqU4SgDJTsSnZ4NdsOumc5KRV26UiOXiBUP+H668iGu3dNc9EpHGRZS9ue0Z+uILZHPJipQ89hvte5EUqJjbkw/ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MI7PR08MB201474.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(366016)(376014)(1800799024)(22082099003)(18002099003)(6133799003)(261026121527099003)(56012099006)(261009223027099003)(261022075727099003)(261028144727099003)(4143699003)(10067099003)(261021121427099003)(261022105027099003)(261026140227099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eG5UbXE2N0VKYi91UGdJU0R6cXp1RHB5blBLSU8yWFV4K3ZkSEtDWTdYNFdo?= =?utf-8?B?bnpxL0xkVkpwRFRHWnp6M3JaamU5cm5lbjJRcHJNY2VQSDBSdGRKbHErMjU4?= =?utf-8?B?b0o0QjVaa1FEbmVmbEJrSHlLVVVnUlBSZWkxNXF3a2wwYW9UWUxvZ2wrLy9t?= =?utf-8?B?NXl4Mk91T21SM3BWODZneW1MdWdqZWdhKzBnbEQxNFBiWGQvb0FWY3J3clh2?= =?utf-8?B?cDlsSExubnVOa2U3YjV0YmlmNHlPSll3bGs3UDF0WFhxTm1OL2ZXYlJJQmxT?= =?utf-8?B?WmM4Y0doWE5idE1ldmVlQjRDRmwrd1B3UERYL3pCdFYwYlZPQmd5cEc4UWN1?= =?utf-8?B?djFyNzE3MjhpOGpkSkJvZEx3aDRvL2ZzVXJ1VWd0dnZXQXIvVk1hOUZsemla?= =?utf-8?B?RDVKamloNC9HaUJCb1RLSk01R1ZaZmlFa08rL3pITFFidkNFQlNxc2lBZ2Q1?= =?utf-8?B?d1MwK3VlOFdQSk5KVHdCL09oQnVkNmhPUEFzOVg3aW42TUNDVUhEQXI1UDha?= =?utf-8?B?YTRyaUFvSnBrMVJiZFZ6SFUxc0JvOS9Yek1TVnNKS1pMamEwWFovb2hTNTRt?= =?utf-8?B?bithcmpxbkhKV1VHTzM1dkdFMnBnSFBIUDVrSDlTaG10bi8vT1pVRko5RjNj?= =?utf-8?B?Z1JydFh4VnlHNERaQzZTd2ZyQjB1NDREbHlQU2ZDNmNibjkzSjZXbFY0TzZZ?= =?utf-8?B?RStkWnlIcGdSS2V2Q3NCdVFmQzdHVjBHTFlEM3FkWFBiL2F5eUVETTRRRENr?= =?utf-8?B?bmhXNUlvTnQxc0hnYjlxcnlnaG50MU15b3Fua3REeTBTdzFja0JMQjVCT1A2?= =?utf-8?B?Q0syajQ3WTZLTGRXTElycThSSVJEVXlFeXVHWmFWdk8zMlRUS2M0eWR0SWJt?= =?utf-8?B?c09UclJ2dkM5RU04QUlwOWUwTFU3cUk4NWJGbjRPNHkzcnVxL2M5Z01NbGtr?= =?utf-8?B?WGZLU2lTUm9jbWVnUWFNN3JUcG9vT2FRVHRiQm8wZktSZnJOVks0cC9maDlY?= =?utf-8?B?QkpZbE0zQ2hDVXl3bmtFYk9CMGtBWU1SNStUNXRhcWZiMGlXSXVQWi8zR0JB?= =?utf-8?B?NW1TQ2dMY21HRDBWbktxWllvSEV6NDM1ZHN4SUJ0bC9Ic2t1TjlRQkxXRlI5?= =?utf-8?B?Tm43RDJZbU84dXYxTzBIMEJJUnZDaHNnU0Vpa1NMZHpCS3F5aDZ4MVVsTzEx?= =?utf-8?B?bHdPeWxtb3g5WXdiUDRKVGMwQWNyVTJXMS9ETXMrK2pzWjY3aStxWm9TRHNG?= =?utf-8?B?VEUvQ3hJUU1aSmh3ZkRSUWh2bnhodmZrTzA2R3d0eVByazFKeWFhMExmYW1V?= =?utf-8?B?dlo1TGNNcU8zMVZZV3NvdXluRW1CZ3pGQXNweTZEY0NTUW1uN2x4cFhDb0RC?= =?utf-8?B?VFBhSk1COEY2ME04MldOdGJDeG5VZGRLcVk4azlockxRNXZxeXAvaGtzNUx0?= =?utf-8?B?VmxOZFFrLys2NFc5eGVSTFJOMk54RGxlWGlkZmwralhHL1c4WWJ3RWd5NkN0?= =?utf-8?B?dndLMVExZkdlTEdldnhuTG03a3E5b292d1VwTjJ1STBiRkN1cWlqTENmRVBZ?= =?utf-8?B?R3hvRDZrdXlnOFJUL00xUXA4VWZlR3Z6Q2FSMlh6d01JYlBYV3dPMkpYTDg2?= =?utf-8?B?ZWQ5Ti9BRDJ6WXFNRUhEdDl0THl1QlZ2Sy9YbFlUS09uS0RKa3J2bTBuL1Bt?= =?utf-8?B?MFgwNTdTWXVhQlVVY3JrSG1WZHlQQkVXR2NxMFg5Rk81KzBkUUJ5NnRUZnJr?= =?utf-8?B?SEV0QlEySkdFeVk2bG9LWnIyRTZsb0xlY2tnT2FJRkZoY09GSkV5STB6SU00?= =?utf-8?B?RnRxYWRiemE1cHJNNFQyc211VVZXV1haM2dINXo0NFB5RFIrZWlIQXNIU3Iy?= =?utf-8?B?Mk5qbXlvb3UxZ1hSREQ3RnlKcDBBMHNCM0YyQXUwTjdwQzB5cHRLb1NZaW9D?= =?utf-8?B?L3JkUTlHSklleFBNb21DV1pWSXgxSnZlMklTcm9xRENCMHFZVjBLTUp5cDNY?= =?utf-8?B?T003d1lWUitOOC9OVElaRWd5K08rOTdtaXRKQ0ZmekN6S2pMTUt3R3BTQW1m?= =?utf-8?B?SFJVZnkwR1RXZFliYUFMTWJQTldXSUQ5WGo2c3hvcE5TVW9qOC9XQjcva01q?= =?utf-8?B?MFRFVmZnRHNHdS9ubnFlVlBKUzdxdkpvd2ZDeVpxS1VuWk16ZmJJanBOYW12?= =?utf-8?B?TXZaWkJzblBZTlBXQzI2SHRPZVJOaktCVFBnYVpZUEFMWWFmWnlBd1d6RzdW?= =?utf-8?B?ZkVaZTVNQTFmUThCZEVpaXBaTzRka2crTUw1L0pNd0hucDRLSmxWTXVwMGR1?= =?utf-8?B?VElhQjRyaUx2Vk4vSStzNTc1TVh6SmxveUpFNUwxeWE4dHhDNWgzM2lOTjgr?= =?utf-8?Q?RZdiTpquNCg8miuw=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42a9dd1e-d368-48ac-8297-08df35aa1f7b X-MS-Exchange-CrossTenant-AuthSource: MI7PR08MB201474.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2026 10:48:09.9489 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8wobiC8wJ+6G7FhjhRaAJEgpKG1OHnnC6cax01SkGpzEYsf7gySt8aNGtwT86XNkxWJCtefvdbE/33/r2u1s39hZWCJmRAYHz403ueiGHDY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZR6PR08MB117518 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 1/2] sched: Fix sched_getaffinity syscall X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/29/26 11:21, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: > - [Low] sched: sched_getaffinity() takes vCPU limit from target task, not caller > - [Low] sched: sched_getaffinity() in CT can return an empty mask with no floor of 1 > -- > > commit 89d21190c29ff2e196f8d22db77072e4bd2c2544 > Author: Vladimir Riabchun > > sched: Fix sched_getaffinity syscall > > This patch changes sched_getaffinity() so that, inside a container, the > reported mask is a prefix of set bits. The number of bits is the smaller of > the task's vCPU limit and the weight of cpus_mask & cpu_active_mask. Host > behavior is unchanged. > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-141682 > >> diff --git a/kernel/sched/syscalls.c b/kernel/sched/syscalls.c >> --- a/kernel/sched/syscalls.c >> +++ b/kernel/sched/syscalls.c > > [ ... ] > >> @@ -1316,15 +1316,23 @@ long sched_getaffinity(pid_t pid, struct cpumask *mask) >> if (retval) >> return retval; >> >> + scoped_guard (raw_spinlock_irqsave, &p->pi_lock) { >> + cpumask_and(mask, &p->cpus_mask, cpu_active_mask); >> + } >> + >> if (!ve_is_super(get_exec_env())) { >> + /* >> + * setaffinity is not available inside CT, so these bits >> + * can only be used for counting. >> + * We can't have more than vcpus and we can't run on CPUs >> + * outside the mask. Reporting smallest will provide true >> + * information about CT resources. >> + */ >> + unsigned int vcpus_avail = min(task_nr_cpus(p), cpumask_weight(mask)); > > [Severity: Low] > Previously the vCPU limit came from num_online_vcpus(), which is > task_nr_cpus(current), so it was based on the caller. Now it comes from > task_nr_cpus(p), the target task, while the VE check still uses the > caller's exec env. > > Can a task in a CT that calls sched_getaffinity(pid) for another task > in a different task group now get a different CPU count than it gets for > itself? > > For example, a task in a child cpu cgroup has nr_cpus of 0, which is > clamped to num_online_cpus(). The CT root group may have a lower limit. > > Callers that query themselves, such as nproc, see no change. The other > users of num_online_vcpus() (/proc/cpuinfo, sysfs, net-procfs) still use > the caller's limit. > > Is this change intentional? The commit message only mentions that the VE > check is done against the current exec env, and does not mention that the > vCPU limit is now taken from the target task. Yes, it is intentional. I think the current approach is correct. > >> cpumask_clear(mask); >> + bitmap_set(cpumask_bits(mask), 0, vcpus_avail); > > [Severity: Low] > Can this return an empty mask inside a CT? Already replied in v2. It is fine. > > vcpus_avail depends on cpumask_weight(mask), which is the weight of > p->cpus_mask & cpu_active_mask. If that intersection is empty, vcpus_avail > is 0 and bitmap_set(..., 0, 0) leaves the mask all zero. > > One way this can happen is during a CPU hotplug window. The task's > cpus_mask may only hold CPUs that are already cleared from > cpu_active_mask. select_fallback_rq() does not repair the mask until the > task next wakes. > > The old CT path used num_online_vcpus(), which is task_nr_cpus(current). > That function is clamped to at least num_online_cpus(), so it never > returned an empty mask. In this case nproc and similar tools would report > 0. > > Would a floor of 1 be appropriate here? > >> } >> >> - guard(raw_spinlock_irqsave)(&p->pi_lock); >> - cpumask_and(mask, &p->cpus_mask, cpu_active_mask); >> - >> return 0; >> } > -- Best regards, Riabchun Vladimir Linux Kernel Developer, Virtuozzo _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel