From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 5A2EE8017D for ; Mon, 16 Nov 2026 11:21:08 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGBJjTt023353; Mon, 16 Nov 2026 14:19:46 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGBJjTt023353 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="z3YS2HBv" Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGBJgbe023349 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 14:19:42 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGBJgbe023349 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-c5095dd1514so303132666b.0 for ; Mon, 16 Nov 2026 03:19:42 -0800 (PST) X-Forwarded-Encrypted: i=3; AL+hErEK3NVbDJVzc6/gaLpmL1SK+PvBeMkZch6PW9/6AWul+fLEAq9jI3T0FUjUwN0iBmLRdaOrRQ==@openvz.org X-Gm-Message-State: APuU4Z+PcHokvLY8acfi6w9wUK4mUUOm2XyXasSBtlJKuaYcbTQSi4S3 DJo/GoTZJAoBtdrCB+11MVoQ0gS9oyVGzMDgNi9jPMQzqTx9lOOvOUoroWeVQkEpAG4Gyjbc4I8 k3iZ3Hqollcc/R5Jo8WeSjiJm3n7yJ8asSwZAYRXRTT9BNeLk8N+f8w== X-Gm-Gg: AYBFou0hMZme1SAF5gUugU6zhhSGLno2g1RaU00QR+X3rnOVWPylymDV5AewZly1aZM 3hI/j970KbUCFgCtruGWI6TPoQ+zSshuMS2UT5X/gSJ/w6RI52nuftlstc1E2l808s1XaNkfbrb JunCACqfu+0XCpGk6f332ydNmjSzdqP3T1W3BtFfIUZ1NrkF/k1PVlquqg08rX5xeWOg3ZrS+Us JMdFnTxvRdYHq90jKbq0AeTR3EiUE7aTrV+RjHzyKcjHSw5hB829LgvZAUrke2BpgcLbv/4tMc5 pTj4kbWo4YcVsfJ2/kPAmwefAu0RGXMg0SxwrbaguXWGQN7s5rxuG14U+LhaozvCgfsM3mFrSvM BCJJpIqODy23UzrNdPj6DsCgWI5I94duNFYNxB2Ih7dKXZfUymw9pIyibSti7kBAH3TG5QG8bXP o04Wzgc61TL6UpgQ== X-Received: by 2002:a17:907:6d06:b0:c3e:e677:5608 with SMTP id a640c23a62f3a-c50963dc7a1mr782911066b.12.1794827982174; Mon, 16 Nov 2026 03:19:42 -0800 (PST) X-Received: by 2002:a17:907:6d06:b0:c3e:e677:5608 with SMTP id a640c23a62f3a-c50963dc7a1mr782908466b.12.1794827981593; Mon, 16 Nov 2026 03:19:41 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1794827981; cv=pass; d=google.com; s=arc-20260327; b=FqKe9homDY5+D8Fc7tOSSyVnHdF96JFzbnFPzfX6lIi6gyiya1vkBP9ds4FVJMuJ68 hUfsz/NihO2h3p9Pr3HTIbkWFoiVEdv3jGV1uKFMAVj6MdCa40I/tQ08SIFY4rBV14DR XMezg62d69nfnfjbFvjCNJsSK3Y0Gmsroaixyc457A8+ND8R/Z3XnBajNan3naVZxVO7 U0o24m4XqbedQhdllVQM7r/xI4e13VtUg7n5ufil8BOeCwfXIyCh+lMQzOKHEJ7dU08D 5f33+nWG/axzaChyR+NYDZAwxG/gZbIp0vHekMWIhpk1GphU7i2r0pxmsesw7Ztg+the MgwQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=I9uZRR9jlH7ZOpLsi9mLvrNVNvgyyLQ5q73kSt1I+3s=; fh=vu5F6GX3xx4Py54TLqEUYuQg119V4P9usRk76tnCuQ4=; b=Ke4SiaHK0p7vjWKr/Fe1fjZMOVD0aXEm/9cTM4Xm48kOMWExxQNYZihaGqKLPIbFRi wovDsAAoCyj+SFMS4vdp51WiA+0RBGZDGnAFs28Ca2BRXJ7qEd555hIgekTJ3m9HUE97 3P5IEeQEeLLaekOL0QCRv+r4edM+UWjdw8tf7CL8jRlQMbUpnRNdLEzi+uPsiBfy18Wt RwOca9JahBVM8tFsLci0pBQaWYnch7b/XqFSQ01djuv39H5s8rN6/IZrzCMyTNEQzz17 6L5f3bYHFcyjmbOCrEdNNWTxC6cM+EN4KLzRwvYLmA44ETr+l2tOOq3ha48opqr/h4+9 7x/Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=z3YS2HBv; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of den@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) smtp.mailfrom=den@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazlp170110003.outbound.protection.outlook.com. [2a01:111:f403:c200::3]) by mx.google.com with ESMTPS id a640c23a62f3a-c5095c06150si747845566b.220.2026.11.16.03.19.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 03:19:41 -0800 (PST) Received-SPF: pass (google.com: domain of den@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) client-ip=2a01:111:f403:c200::3; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=z3YS2HBv; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of den@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) smtp.mailfrom=den@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LwUVFmDlP8OScd6ZyPoO6GHmAx1SSmIKRIiAI93Byv22hU1XM6h1VgvdvUdjdbfzLigxKw3QSmxd+OXszUnVnfyc2MOSVZ937eHIVfnjfifUHxWojJ4VWNHlR3f6Lq6UG2hEWUAwdZSik5gta9oGwCvCAJOfZKPBTZMZ/mE7p6Fg1LzzzTvZ5PwMcPCpXFSIqzHlbphAxLd8806Vbza11Zll84LbAAMGlD44Ulaoeo2JuDUZYC51FeaxOd0wrEfgcEB6LAdop/l1Xg9eTACEfcV6IAbsXj55laAgPTgRnoWIJcbzuzWTWebMA6zC3DoQ2V+wJZ6v/boQ6vwri93vPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I9uZRR9jlH7ZOpLsi9mLvrNVNvgyyLQ5q73kSt1I+3s=; b=H/FMOIQY11NvBQV/xP3+fkvvrNotq5DQ/tsobnrbui+VnjY7PkECf8J/6XkH3+KWElkW/DHl5uUaP89zUIutCQkOJkq64Hjia+zDEnjfQYezLoXzrl9k2JqDI7s1GQakAqLTQ48CrK6M1A/TM52dvDnIru0q4oDXrSKoqNwC8GHtn4SR4iOsQYPncXlooEmPE5rsd0XLg3JUG8e6XDtTJAQPCVngFpzou4ZfrpKysGhLS1fQyBJ17B1ULHk42jOk+ztxM6wa9s/9rr7ZQ6DI+BhCxDtuTZ2LdubjDZn+nqL8cTZSXSNsYmJOA7EgRcG02IhKCybpkXpdb6AtZQ3OIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I9uZRR9jlH7ZOpLsi9mLvrNVNvgyyLQ5q73kSt1I+3s=; b=z3YS2HBvZGt/iKshHGbkU1hjGo89x1YKkY3P0mzLRLRJTrc99LXKG4wbMwDSXTnWgO5892hcxpopIWEr4y3IkeGVftIQxWiIp7u4rg40f0+6GUQPy7xR9jujBC27icPmzhodT7cxMoo9kbblNs2yrUol634RndHjCJaVMs2kUHUaj6wWp/+Wzt/Hv5nNtlrg/4bjcrRq/zvkMMhvTJCU20yCz9mboU6rHiNfnyMile/r171j9s33yN6wH4LNq0TqdEhzqdY8hWtAUc2HDY3iYs87uxqJrV/Fr6F0+CUvAmzPUbGlRc6AuauuTz0yaSgtxBb02WMbq6Gd1eDMb31j/w== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from AM9PR08MB5892.eurprd08.prod.outlook.com (2603:10a6:20b:2dd::16) by PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.10; Mon, 16 Nov 2026 11:19:35 +0000 Received: from AM9PR08MB5892.eurprd08.prod.outlook.com ([fe80::94bb:633f:1f55:4bbd]) by AM9PR08MB5892.eurprd08.prod.outlook.com ([fe80::94bb:633f:1f55:4bbd%5]) with mapi id 15.21.0615.013; Mon, 16 Nov 2026 11:19:35 +0000 Message-ID: Date: Mon, 16 Nov 2026 12:19:33 +0100 User-Agent: Mozilla Thunderbird To: Vasileios Almpanis , "Denis V. Lunev" References: <20261116101516.154737-1-den@openvz.org> <179482709634.766664.14347639737025619145.b4-review@b4> Content-Language: en-US From: "Denis V. Lunev" In-Reply-To: <179482709634.766664.14347639737025619145.b4-review@b4> X-ClientProxiedBy: VI4PEPF00000130.AUTP296.PROD.OUTLOOK.COM (2603:10a6:808:1::8b1) To AM9PR08MB5892.eurprd08.prod.outlook.com (2603:10a6:20b:2dd::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR08MB5892:EE_|PAWPR08MB8982:EE_ X-MS-Office365-Filtering-Correlation-Id: 9267c3a0-d00c-4fd1-db1f-08df43d37e8f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|376014|23010399003|10070799003|22082099003|18002099003|261009223027099003|4143699003|56012099006|261026140227099003|261022105027099003|261022075727099003|261028144727099003|261021135927099003|261026121527099003|261021123027099003|10067099003; X-Microsoft-Antispam-Message-Info: FayNqMUMLGdhpL6yTmhcx627lLf40K0szIfG28OhqJLmiTQdszOK9dj07YSKNiI/LhCiQU+yt/BjJc3pItu2DPxHdTlpvdMOjfsVvgIVH/idKOJZ5qj4g3OX5oHsgablyDOFMG8cgjNDQ0pvtQgpNebC/Gw47uBtNsnlGFUqC+gGd1OHXRRuP+cpD/bvYZ6b4Q4x9fp9vSB3SboFPSRok5WmbIzcbdYBNexhQvVdWSC6gBKQHcOWiS7G5w6w0r1sta/5upNBNIijKXswSljkgn5+u/sZDwYh2BLYWN27RVCkKVIACN5/k02hMEehosHshbdi1Qwm+J1B1gBc9+C0dVgDnOoyQPY+uWk71kK/cB/rl7Meju7p2tZ1F/wP2aJ14mX0micn0in5psFKNF0doLK5r8OPMCOZ587WALvs4MFWC5N/mr889zTFuW2kEjrRhRHTHy7+d8qdLtiJpdXXaksxLRW2/FKU44IwdbB4btM+LliBAT62s3B37Xg6ga9hzXSmVn+Vq8oZCg8H/imh4+JDOJyKyZYbHT8LQJp2MpYbG7ry8xOvKsooLLxVkoX6Fl2AxjH4QL0oOCt4oCZvOCyCdRK+IMNIcIisV74oRVo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM9PR08MB5892.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(23010399003)(10070799003)(22082099003)(18002099003)(261009223027099003)(4143699003)(56012099006)(261026140227099003)(261022105027099003)(261022075727099003)(261028144727099003)(261021135927099003)(261026121527099003)(261021123027099003)(10067099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0Y2UG0zeDFJVUhkU1VkaklRbHIycEdZV2dUZU9HRU83ZXR2WHRld3NvMEdl?= =?utf-8?B?MXc1K3VpVVlJZjEvRE0xT2xCcjJHbVpOUHV1TWt5SDZyb1RGWnJFM0J4QzRy?= =?utf-8?B?emg2N0dZSElORk9UQnRQV0s4aWxhOXI3c0s3S3pBV1k4aEpaaWJ1Y2ZCR01s?= =?utf-8?B?dlZPNWlRMUNldlVCV2YyellDdVZMdXdQejZOeDJZWnJjOFVSRkcxSHUvbDZy?= =?utf-8?B?WU1hN3lFRWkyVzdYNXRSaWxhT3QyNXl4OWFLbmkzNE93cU1BZTltTm9wTFlM?= =?utf-8?B?VHJmclVkaUhyelVodnJDQ1NnUUFURXppYS96K3VuWXcySnBoRnVoSDM0NW5p?= =?utf-8?B?cTMrTkxnaGdDV3dkY1JGdGdNUTZxS1VSSWs3U212YTF0UncwenliZldrMUFZ?= =?utf-8?B?ZHVhZG9zUDJzYllEMGhJZHpJakRsTWlGTFhaS0VrOEZZMUNnQ0dtM1hVNWFF?= =?utf-8?B?ZWppNjBINWh2TVZOR0w1N1RGMkp2TWJmZGxNK1FqdzlKcnk3OHRrL1ZFdE9I?= =?utf-8?B?dFQrYnJhTm1MeGw2WURDOFhReFZUdDUyeFk2ak5uR3Q1ZmR5MGV5QXlNVUdW?= =?utf-8?B?dkZXVUJ1eUlNSXpqUTVra0FyU3p0RTQ0WlBIUEF1LzhGcy8wL0daM2VMcThu?= =?utf-8?B?S3pSb1JaajllRWttaDNkckQ4ZUdTKzhPVVZod1NjY1ZuenFXQkdSRlh6M085?= =?utf-8?B?eFRsWldtVVptUnd4Q3VxbWtzQVkweU1jUmxLd2pZZVIzdHBnSTdHT2FjVmtS?= =?utf-8?B?bTUxa3pFUDhDcDMzbWRpUkxVR3cvcTMzVmhRdFIvS3pvNFk1Yy9hVEgrY09Z?= =?utf-8?B?QWpTTmtEQWJ2blFIOHFBQlZuay82VWROcmVKSVhYWnhFYmR6N0E3Nm5JMXp5?= =?utf-8?B?RzhodWdNbE4rUGczS1JuRVdQNzdHREJlcmpHN3ZlaWlpOTVSaUwxZmhMWG1S?= =?utf-8?B?bUFMQnBUcVZadjR2MWc4Q2JXTCswa29OWUtONmtjZTYvNXFvcVlOWjRMYmVt?= =?utf-8?B?Q0hwcGxXMUpUYy9Bam5wUEpuYWE4REV6Nk5tZVQyNmRjOXc3L3Nub3lEZGtT?= =?utf-8?B?WVltdERxaDBWSlBnSm5CQlR0TjBxN1FUT3l4UFdTWEI0RmxjeXdvNThjQ0lz?= =?utf-8?B?MlJvcHdpNllYdEVHSnYrY1dVQVVqTGNiSEJqY3Y5OStSZDJVSU1hZXlGcVBS?= =?utf-8?B?TE5jbW1aVjcvSmhSalpadUlheWhVKzVkWGdHeVA4UjBWMjFUd2tEVFBqcnRn?= =?utf-8?B?cUlNdTlKK0V4Nk9FOCtwRk1KRjFTazQvOHBzUEJCa1NwbXVKcTBTOEdnRkZs?= =?utf-8?B?ZUc5Y1hLcXVlSG5lVjhqZHRYeVpVSnBMUHloU1ViWXZ6L0VSTTMrN1hwZTQr?= =?utf-8?B?YVByVVhmSmNMOGRyT0RyeExiWGtCVVBmTlNBWVpJN1kwbWRWN094VXVqS05Y?= =?utf-8?B?STFRWCtuT1ZGUXo5S1grNG5Dckxkc2FnL2Z6c2FWK2JIbXZWRFVORWNVWnFU?= =?utf-8?B?L0p4Lyt6SlhBOTJVbjNrTXYxVDY2WXBLOFdLUmU1NzkrUDVPVFRjZU9aaXQ5?= =?utf-8?B?Q002ZUoxbm5PMXFhc1prOVdRbmRobjlxNVJoWlpxM0ttM1Q5NTA3aXRjUU5H?= =?utf-8?B?TnYyeFlPbHBOSjFWd3RienV4Ty9Cbkx6RkdEMXl0UXVpVkV1ZWQ0ZWVCckg3?= =?utf-8?B?RWdVaENPd1dZT3V0L2JhK0V6MVJ1QXgvUzd5R21ZZTVmNnpPQmZ0SzJiS25L?= =?utf-8?B?TnVOaWF6VGs0WmQ0cWZXRXZKc3pNdkpqRi9nTDgzY0RUNEZMbHFMV3N6d0t5?= =?utf-8?B?N1RiL25JMWZUbkxybEtnWFJUcTZrVHEzS1NlQVl5VEtTT0o3bVdGT0oxanYy?= =?utf-8?B?dzJKQ3VGMzNaR3dPRDR6cjZCVE43dDhaWEJkVFJ6L0s5RXhadGtoZitRYWMz?= =?utf-8?B?MTdxSXE1V2hWTFJFQmNqK0szNHNUc0NIaDROME13R2pBU0YyMk9DWWp5bHpi?= =?utf-8?B?dStCZGprYmU0OWNhNDNUY3Uvcjc1YUh5OGF1VnVCYnUwVTRxNjlmclU5anRP?= =?utf-8?B?MFBJYk8xZnYzUTN2RWprV3dkUGRuUTRVRkVuRWdMV250TmdxNnp4aUJDRzhl?= =?utf-8?B?YzlNa0N6NzhiZWRwbnVpRmprUUpWM2VMTzZaSEZFb01HREJROXVjQVBORDY4?= =?utf-8?B?cDVwZU9Tcm9nSUJkcy8xWTczZksrTHhscVNoa05RdlRXeVV0THREVnZQVGRw?= =?utf-8?B?R3Byei9hNlcwejdxK213aDVhU0RpWGJxRU5BTHRCNGVRQktveWQ1N0duNXZR?= =?utf-8?B?T2oyNkptbGlBSklIMHNiMkQyQmZCRmdaZ1c4OWNpa3lueCtqS2FwQm9kT0lq?= =?utf-8?Q?cYOYLUa4dGk5yD2X9/TvwaaxgbVN0PBSUvpN5?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9267c3a0-d00c-4fd1-db1f-08df43d37e8f X-MS-Exchange-CrossTenant-AuthSource: AM9PR08MB5892.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2026 11:19:35.2508 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ttIQXieylLz40SUByZBD94hY1xGM24YkTs5EtBB5FTfJerRjPFhMQ2x2nzVX+GP6djMI0cv42qU2FTY7EMDbhA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB8982 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1] sched/stats: fix a hard lockup on task_lock in update_sched_lat() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 11/16/26 12:04, Vasileios Almpanis wrote: >> Commit ead7be4fd3ca ("ve: Switch from ->task_ve to *task_ve() helpers") >> made update_sched_lat() look the ve up with get_task_ve(), which takes >> task_lock. update_sched_lat() runs from __update_stats_wait_end() under >> rq->__lock with interrupts off whenever kernel.sched_schedstats is on, >> while task_lock is taken elsewhere with interrupts on. Any lock taken >> in an interrupt and held across a wakeup then closes a cycle. wbt does >> it on an I/O completion: >> >> CPU A: /proc reader CPU B: NVMe irq CPU C: scheduler >> ------------------- --------------- ---------------- >> getdents64(/proc/X/fd) >> task_lock(X) >> nvme_irq() >> wbt_done() >> lock wq >> __schedule() >> rq_lock(C) >> pick X >> nvme_irq() >> wbt_done() >> lock wq -> spins >> wake W, slept on C: >> rq_lock(C) -> spins >> set_next_entity(X) >> update_sched_lat(X) >> get_task_ve(X) >> task_lock(X) >> -> spins >> >> wq is the wbt wait queue of the device and W a writer throttled on it. >> W slept in iowait on C, so try_to_wake_up() locks C's rq to move the >> iowait count off it before migrating W. Every other CPU completing I/O >> on that device then spins on wq too, and the hard lockup detector >> panics the node. >> >> The put_ve() under rq->__lock is unsafe as well: dropping the last >> reference queues the css release work, and that wakeup may need the rq >> lock already held. >> >> Read the pointer with task_ve() and take no reference, as the code did >> before that commit. Whoever switches the ve of the task, the old one is >> freed from css_free after an RCU grace period, and rq->__lock with >> interrupts off is an RCU read-side critical section. >> >> Fixes: ead7be4fd3ca ("ve: Switch from ->task_ve to *task_ve() helpers") >> >> https://virtuozzo.atlassian.net/browse/VSTOR-155276 >> >> Feature: ve: ve generic structures >> Signed-off-by: Denis V. Lunev >> >> diff --git a/kernel/sched/stats.c b/kernel/sched/stats.c >> index 08ed7c8a9c4a..ede339b768cf 100644 >> --- a/kernel/sched/stats.c >> +++ b/kernel/sched/stats.c >> @@ -23,10 +23,8 @@ void __update_stats_wait_start(struct rq *rq, struct task_struct *p, >> static inline void update_sched_lat(struct task_struct *t, u64 delta, u64 now) >> { >> #ifdef CONFIG_VE >> - struct ve_struct *ve __free(put_ve) = get_task_ve(t); >> - >> KSTAT_LAT_PCPU_ADD(&kstat_glob.sched_lat, delta); >> - KSTAT_LAT_PCPU_ADD(&ve->sched_lat_ve, delta); >> + KSTAT_LAT_PCPU_ADD(&task_ve(t)->sched_lat_ve, delta); > LGTM but what about sched_show_task? It looks like it has the same > issue. Lets fix it too while we are at it? We could protect it with > RCU critical section. > will come up with v2. Thanks! _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel