From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 0EC5480024 for ; Wed, 26 Aug 2026 16:50:56 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 67QGnhtU011178; Wed, 26 Aug 2026 19:49:44 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 67QGnhtU011178 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="ZttY6WQK" Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 67QGnfNj011174 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 26 Aug 2026 19:49:42 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 67QGnfNj011174 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cfca8558d2so16954295ad.2 for ; Wed, 26 Aug 2026 09:49:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AHgh+RqUrQkCH75gy2o5XhOYwMFSL+sIkLVX52DJpFcXQG9yoNde4yUOvEEp+Hs19QGmPrLtcoequw==@openvz.org X-Gm-Message-State: AFuF++l1UfGfLFP78nZYZA2RTcKcypi5PDmNuJVEYwKHGZn4LGokOPzb FIep1jnikRl6B2XYFVp/9OstlJeEcwVaPPDFfGV8F2kqzHEPfW8OSIUrjnaV7qdMAmmqfUZ0oX0 wcjIyYyfSV0j4f0yWMnbzozB4aZvI9lTAVJdZHw7v9woOR5kJJaxRcA== X-Gm-Gg: AR+sD12Fi+mRo5jNQvCbP+iXomhgHpOwAKJSCG2MDhw0vn0N7EAZEf+HJHDBLZvTTCT pIftuJ3tEHOi3SWZd72TR5X8Q8Bg3eo4oazHtTmkiLHAdZ6iOgLi5kig2anHy66mLujzrK10tia O7gvrwuomjhAzwxIk/RzNiZduLm0wqMOqeXGGDOMvOyTI7U4ngjNmwKk8LizLrHSo3BnxRb/Rx1 bdJkgGvB/lnHq4w94XppXnYyEx5Vs7L2IljOD35ExntwS2FiXLgI+Se0TAYO1yS0Ik2bEnU+C5p b041ZZsf0KOURQWufMq4OWNg20qeBctb8XFeMNviv2d+YVgdSJ5BEi+2S8F7wsH1hGW+GXaIqLS AbAQH1OGh03RYFx+oWIjfEnDdR1KJ6322U0bfSFCmgXGP3TlC9nK4iQx+ZbyV+qanvDbxekB9O8 92L2tA0eM5+XFd7Z83tho/pw== X-Received: by 2002:a05:6a21:3086:b0:3c0:eeb7:28b with SMTP id adf61e73a8af0-3cf762865f1mr15288006637.8.1787762981084; Wed, 26 Aug 2026 09:49:41 -0700 (PDT) X-Received: by 2002:a05:6a21:3086:b0:3c0:eeb7:28b with SMTP id adf61e73a8af0-3cf762865f1mr15287925637.8.1787762980531; Wed, 26 Aug 2026 09:49:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1787762980; cv=pass; d=google.com; s=arc-20260327; b=p2QGsa4+7l7Nkeax/Gp0sPIfHmnBIOUGCV8d2Ur2aiqQOzlw/75DZR2KajYs8gxmXF 33tOQftUjq7phRcDKaeujvnpTe1/rHTTFRZGkDGsFBkDzPjdgXt62fo3WKmik42O91UM vyO1l4TbWP+Vab81cz0YOF2mxILOIDRvR4v2vxXF4Ir4voBIkv3gYJLtJiCpYULhyrLJ LMWT5cHaeQ9KYuicKn1BBCy+4l11K+NMBExcNQU1g7Nsz8wYtnM904RwNu+lHkd0VEB1 XNGm+qBvDIJ3w6JsJabFdJisBDnWqRs0433/gV6clYUjN+MW3mRxoiNP4QwSnBpxUR8m XYEw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:to:subject:user-agent:date:message-id :dkim-signature; bh=UQHrf57zZezteEZB+AFqkjVpEt06L0F75hSdStqXCWA=; fh=tx7LOEUDcY0m5PC4BMlh6nxdMY6wg7lNR6PqnyYCbZk=; b=P825vjMc96rRsB/xBfsGdvnUXiNsFfYEToETdgN7WRpSjXBw/5XhvJU+QHQP7OQQSH rdAXiF3uDxcdHDejEHXAfAi6zyh1JYQGT9NU4+DXGY/tuWtjrEwuTnFz4SmXEMpCS0B3 O1P19XCWf/7m8z1mwkCXEsgwXgJco3DLNgq1sBDxJUNTwGW9jsGbqganklbuiw4Qw8yF cuwc2N/mYW+8oyQwZU0t2L4Uhtalso4i5mUx2w0Qlj0E1Qx1h1NbwQlqcZtqbPjPS8Ux KkCECYcL1gEOAlQMMavDz5hj8ysPjyIWUync66m4toHi4f8SApIzHKg3BlPgEFuS+5Jd n4tA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=ZttY6WQK; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of khorenko@virtuozzo.com designates 2a01:111:f403:c207::3 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazlp170110003.outbound.protection.outlook.com. [2a01:111:f403:c207::3]) by mx.google.com with ESMTPS id 41be03b00d2f7-cc1bef89a1fsi6781086a12.256.2026.08.26.09.49.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2026 09:49:40 -0700 (PDT) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 2a01:111:f403:c207::3 as permitted sender) client-ip=2a01:111:f403:c207::3; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=ZttY6WQK; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of khorenko@virtuozzo.com designates 2a01:111:f403:c207::3 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ax4z2TT6n5KfGKAcs62/oHtNIwzN/jhEIfOE+ZW8Y03KgZwUuO8C3XL9AIIFMdxwwJF+EG5C9blmOqhnuuy0eX+gaAEvqQvKIXMgPBoPzwZSQnu8vARTWCQV+gyLdbYpnipe+vu48F8HgeisW3ILrWsBdqwsgqdHFkXN6GDzudAprleA35PyuVNzW1rjBuXCL5dpPaS3nyCB8Tk+CtLKJO9AhzWp0nh4vXEyua3NM4acGp9cuEEqFpafdloMiEwZFAVzgu2syt9akShp6yJoY0sGWrdZlzO/2+CPCfHs9I0A5JjU9fuQ8WtQbowKNL0Tef9cEFheXPkj5YOUih4lVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UQHrf57zZezteEZB+AFqkjVpEt06L0F75hSdStqXCWA=; b=LCRjFjeMwJ2u6o07nrn4IueiyWDqZYXEdYtEHymgEvxxv+CbE5TyHuGZCoFGrHY1brCdnLb5bb5sES5XxS03Lxkzpphy9caA1cvaniAahxTosa1PY+3j6AXkNdnvFzTz1LPwTART2Jwc+n0qwzWb9fUAgl1PIRJgxJV0u3fFRoE4LvJmuoy+0NvTQY/mzchGcp/pgmy6ts4I47sUZTvEBOlzBn1v6deFeEg1y4hlPJPT0bUH4u8yukwe4UiCl40XxAAt75q7+xEIKQO8XVx3Gw3/74PkxGxMpjQ4mTOjIDatb0lyIf4gnen24n2M4j/hyYSQK+lZVPjbRbauhzfAcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UQHrf57zZezteEZB+AFqkjVpEt06L0F75hSdStqXCWA=; b=ZttY6WQK83o7e7azzECv+aUBm/l9QABj+x7f3Ee6hgzj4KGNM6NGNdGbEyu1eTk/m2fX7dstw74ndb48O/RuKz1LHws9Wzdi9CkdvKBl/Yz5kmNVkYDcw4GsG9UxnLC4H8kcoYm93tN58FscoLjW+YpgxL0kcDdYqk3XsnkA1nZ+kg/Oxc/keU898vpN2j/murIJfR/N8OfwbTsZWZs1Fe3XPZGDwQt2xRWpkLpPMXI3Hk65X1vYKs49H8FNxoy4MSarwjK/7UzwpidDazBG5xIXaaxg3fCHS+YqqNIq6cFZZsElCnafHCRbY7FXAg32T4fO5RixqHuIJHZcDLc54A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from PA6PR08MB10708.eurprd08.prod.outlook.com (2603:10a6:102:3c7::20) by DUYPR08MB12015.eurprd08.prod.outlook.com (2603:10a6:10:65d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.8; Wed, 26 Aug 2026 16:49:38 +0000 Received: from PA6PR08MB10708.eurprd08.prod.outlook.com ([fe80::1999:c6db:dc55:494a]) by PA6PR08MB10708.eurprd08.prod.outlook.com ([fe80::1999:c6db:dc55:494a%4]) with mapi id 15.21.0382.004; Wed, 26 Aug 2026 16:49:38 +0000 Message-ID: Date: Wed, 26 Aug 2026 18:49:36 +0200 User-Agent: Mozilla Thunderbird To: Vasileios Almpanis , Eva Kurchatova , OpenVZ devel list References: <20260821150402.792278-1-eva.kurchatova@virtuozzo.com> <20260824130922.444331-1-khorenko@virtuozzo.com> Content-Language: en-US, ru, sr From: Konstantin Khorenko In-Reply-To: <20260824130922.444331-1-khorenko@virtuozzo.com> X-ClientProxiedBy: AS4PR09CA0008.eurprd09.prod.outlook.com (2603:10a6:20b:5e0::18) To PA6PR08MB10708.eurprd08.prod.outlook.com (2603:10a6:102:3c7::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA6PR08MB10708:EE_|DUYPR08MB12015:EE_ X-MS-Office365-Filtering-Correlation-Id: e4846b6b-153c-441e-663c-08df03920430 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|23010399003|1800799024|366016|6133799003|56012099006|10067099003|4143699003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 89j7v6RLxfiGMdxh2u6kxUulViSm7gd5CDfUTA92sM/XvdvJNNMRHWb5bjejsgdbED0Mg/JzyXq7hzelLIVek2MRE4OVVYWsQOHdKzLom1hcehA2JEiQzwDLwcrEb0jCGk65kcYvSQzotDmv1i7r1on7JSwfESThDJvUdsexDEHlaP3zTTuxoBRI0iFr/kMCvxYE1cWRNtLzsNJVbbJL2FW9B3HKpCa7gwlR/RL9NLXwy2LQeG6gV2Jm7ROBVGDEepYr0VXIrEq9jedJKbwWAJTLvIuUWqkO10weK9ZyoGb4nw8QK2GDgavvMdjyKhv+X6xAJES/VtaIQVdhSjFA6QdNx0KXAiP//rAz2lpAKY64MbLmILMK5YdciBX26+mn4foVwaTY/56Zpah1owPG1uXEC393poMs/DRwWln6RiQ7YmGt/HCsA884N4oIAf2d5ki1NY3D1UXzSAFJhPCNTS0TNGRbqJx3kI0DCdufIo8rV23gMBhh0Nw2FK0KAzr4JJo/i/G4MbIGui1BA2vLmEsCwYlNuFXqAsV0Wk9m4l6/q2PT6zruOUn1zQzFOtVER8jo5F3AUly8L11Io++Vz8grKDUK/nHPzFLy50mPZtclC+2LIrfNLXXWGPgIgY/gl+jWNj5kxEcw+C8w6HTMOXlfjtkSTGDlrytKS1nImvw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA6PR08MB10708.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(23010399003)(1800799024)(366016)(6133799003)(56012099006)(10067099003)(4143699003)(22082099003)(18002099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGdNMHJ0MFBRUktJYVI2YUF5Z1dvVlZ3U21XTFFXY3Y4N3VIZVU3emt5SDVL?= =?utf-8?B?VG9ERkt6cXVaMjY4OEVVc2dNcDNrZ1Q4SkE4RWNrbDFqOThFZ0x2aGRwWG1M?= =?utf-8?B?WkwwU3R4Vm5ESFduTktvWUF1SjJlK3BLUHZ2QlBBUnIrenZWeDJERkZlcmVH?= =?utf-8?B?eTR2WUM2MWNtcW41WEVFR1Z0SmIzSnJUVE9YTjljY3hDcExralZiQWViUVg1?= =?utf-8?B?bC8zV1o0WCtySUZhYjljbmJxK212cDJkNWliYzlCb0NxNFV2Nk96NEJNdlM1?= =?utf-8?B?aTBkcC9QOFEwUFNBTU9GQktLY3RDOWlhbnIzaWVBd0JzSG9uNEtRRGlCZHlw?= =?utf-8?B?UzVkSmxIbUJOTzIvWEN3aDV6NHNZS1BjMks2UmkxNlJlODc3bUcyRm9Uc01Z?= =?utf-8?B?SlJ1eDZsejRmWTlvN2hxVXhRUm9qV2dOcWZSVE1SUWtabnNOQmZVWThSamor?= =?utf-8?B?bFl2c3BYeHdaQ1lmS3J6VmpIODRCSFdpTHdKWXArakxIOTJ3ZlZzM1NaSDM1?= =?utf-8?B?alRTV1ZTQzhkNEQyWmVTUFNBWmRMK0s1eXhTWXhyUG8wOXlxbzJXVlRXNGkr?= =?utf-8?B?TWpsWTZQODZIR2ZrM2VvdmRVM1RLSHo5WXp1Q0V1YUJLSHZ6QnBPQWxzT3hm?= =?utf-8?B?N0pHdXkySlRGL21Rcml5YmpMRytMR0V1YUE4RmNxbzhaWS9KSjRSRzhLbTha?= =?utf-8?B?OEc3TzUzMHVCTFRZMmIrNVFZUE1tM0lSNzd4STBRcmpZa04wV3dCcG9xTk5w?= =?utf-8?B?MG80WlJSaEZjMTY5azBvRmlpdEVwRGdaR2xkT0JIenZpeWJOUnZZREVGYUUz?= =?utf-8?B?aFZSU2lnbm96MDBWS0hXaklUTmFUdHRjUTFlVDBWWmNlVWd5UTNmaUtMa1Ft?= =?utf-8?B?TkxLOU52czJ4Z2RHWldmUWZYZ0NFU1ltNDl3dGRyME9nWWFiM3J6NzhKSlBp?= =?utf-8?B?KzhibEV2MlU4dXhJZzVFWkRVRkg0ZUIyMTV4MFg3V0t6Sm53Uk5IYXRNZEcr?= =?utf-8?B?MG94cU1qZzJvcjBFMjU2LzUwY1EwWGdrRkdLL2FhZjkrdnViQXMrWVRLeEZY?= =?utf-8?B?NmoyaFY0emFYVGgxcUtWd2R2bDdWYjlOTE5Dckh1amNmWXZ6U29RZmJ0SWpE?= =?utf-8?B?Rkc3ZkFaM2xTbGcvUjNIM2tCWC9GWWJYR1RxOFR4QXcwVGFHN0MzSHlNU3Jt?= =?utf-8?B?eHhLa25NK3o2NHN0WkR6NlVSQTBTaExHcndpcU53SzNRZ0doZzQzWkJoN0Mv?= =?utf-8?B?d2RSbVBacmZ0ZzQycjFVNG5CeXZMOWtZdUhUZjZlaXlBSnM4djJLaTh0ejRI?= =?utf-8?B?MUVPK28rZjlsNWVNUlpMMXFSMUZ2QVB4WVczMU5pV3NmaExDOGd5R243NUJO?= =?utf-8?B?MzZCVEdJRXdDS0RrNWpnanBTN0JGNUdxWmtBWFEvWTZONFFYWlk3ZVNJc250?= =?utf-8?B?TFdESk5mU3hPck1qWkFYTUFQMmN5QkFRbmhkSVREOUVINkVzWGx2ei9EZWt6?= =?utf-8?B?OEJYV2NLVWxTbWp5Ym1ncHhMMzJldjYyNHFrajJaWjE3MSt6MzlsMktBZ083?= =?utf-8?B?cHRrVmlkNU1ReFVVSGlMSDF4emxLeUFTL2V3cFRlcVAyU2IzeEVMT1NFd0Fq?= =?utf-8?B?NENOU2JyU0pXbGo0QzFqZnp3ZlBKajV4MkRocFBNeWJtQmFWTnFPTjdHMG9w?= =?utf-8?B?U1Q1VnlCb0tBM3NlMnNYekpZaWdMditKTXUreXl4VHhJY0RraldpRi9oeVEw?= =?utf-8?B?WjhWSU8xdjc4VTdVRnpSK0xTaHhxYi9GL20reFlPL0tkaTVvSGZUaVhRcjhw?= =?utf-8?B?cU02RzVUMXlaRVlaeW1zanc0TE9UUGIxV0ZhREU3VytIZmV2TXFHUW4xUEkw?= =?utf-8?B?OXhoUGpTTUliS3FZMkI5WGE3WkRTZjhTZFFscnoxQ0xBMk5SRFFKL2NoZytp?= =?utf-8?B?ZDNWemhxU3BpcWdZRVZpeHltUU5lc0VKZ0dJcDg2eitaS21TV0tKbzBmUXFC?= =?utf-8?B?TWpBWENhdytFeFc0M0NtZTBTQjhGUmFtNHU2YWdNWG4yNmNjM2lET3RxZ1NT?= =?utf-8?B?SHJQdWhrR3lqbk54clAzdVlHTENNc1o0Ky9ZWFNERm56aHBZakdackpSZ2Ux?= =?utf-8?B?ajR1TnFqOENHRFp1RXlSSUgwbnMxQUFzSFFhcUNHUjA4WEY2VU96YlppS0Z0?= =?utf-8?B?aFdJc2NITzBNalN4Y3l5Q016ZGZWb2hhdlkwdlEwanZ5RVMyRG1DaXhOTWMy?= =?utf-8?B?VGdleUhvc05HOWtHVXhpTnREZUh2LzhpbFVLUHJsNXNSemh6UnA0bFFIZzg3?= =?utf-8?B?Mmk3eS9HS1J0TnJEMlFUWHpqMTg5aEFRTnZNTmNwWXFNa3orNEVZdz09?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4846b6b-153c-441e-663c-08df03920430 X-MS-Exchange-CrossTenant-AuthSource: PA6PR08MB10708.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2026 16:49:38.2388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NuqetvH9KR117W6uuMYPylBO/EQSUjxJLBp0Y6BeIw3EqsfYmMPHBVoiJ6FcqRDVXYvHhHw2sHXatXCWbBAEag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUYPR08MB12015 X-OZ-Fwd: true Subject: Re: [Devel] [PATCH vz10 v2] selftests/uevent: do not fail on a netlink receive buffer overrun X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org a kind ping -- Best regards, Konstantin Khorenko, Virtuozzo Linux Kernel Team On 8/24/26 15:09, Konstantin Khorenko wrote: > SO_RCVBUF is set to __UEVENT_BUFFER_SIZE, 4KB, which a busy machine > overruns while the test is listening: > > No buffer space available - Failed to receive uevent > > Two things are wrong here. > > The socket queue is sized after a single message, while do_test() > deliberately triggers ten uevents "to account for the case where the > kernel might drop some", so the queue has to hold more than one. > > Give it its own size and leave the message buffer alone: the kernel caps > a single uevent at UEVENT_BUFFER_SIZE, 2048 bytes, so 4KB per message is > already generous. > > The receive loop then treats every error as fatal, ENOBUFS included, > which defeats those ten uevents. Netlink clears the error after > reporting it once, so the copies still queued, or still on their way, > are perfectly receivable. Retry instead. > > do_test() bounds the listener with a two second sigtimedwait(), so a > retry cannot hang the test. > > https://virtuozzo.atlassian.net/browse/VSTOR-139674 > Feature: fix selftests > Reported-by: Eva Kurchatova > Signed-off-by: Konstantin Khorenko > --- > Changes in v2: > - keep __UEVENT_BUFFER_SIZE at 4KB and give SO_RCVBUF its own > __UEVENT_RCVBUF_SIZE. v1 raised the shared macro, which sized the > socket queue correctly but also turned the per message buffer into a > 128KB zero initialized array on the stack, while the kernel caps a > single uevent at UEVENT_BUFFER_SIZE, 2048 bytes. > - retry recvmsg() on ENOBUFS instead of failing. v1 only made the > overrun less likely; the test still died on the first one, even > though do_test() triggers ten uevents precisely so that drops are > tolerated. > - subject and commit message updated accordingly. > > tools/testing/selftests/uevent/uevent_filtering.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/uevent/uevent_filtering.c b/tools/testing/selftests/uevent/uevent_filtering.c > index 8062804ff759..735eb8138c44 100644 > --- a/tools/testing/selftests/uevent/uevent_filtering.c > +++ b/tools/testing/selftests/uevent/uevent_filtering.c > @@ -23,6 +23,11 @@ > > #define __DEV_FULL "/sys/devices/virtual/mem/full/uevent" > #define __UEVENT_BUFFER_SIZE (2048 * 2) > +/* > + * The socket queue has to hold more than a single message: the test > + * triggers ten uevents and a busy machine overruns a small buffer. > + */ > +#define __UEVENT_RCVBUF_SIZE (2048 * 64) > #define __UEVENT_HEADER "add@/devices/virtual/mem/full" > #define __UEVENT_HEADER_LEN sizeof("add@/devices/virtual/mem/full") > #define __UEVENT_LISTEN_ALL -1 > @@ -78,7 +83,7 @@ static int uevent_listener(unsigned long post_flags, bool expect_uevent, > { > int sk_fd, ret; > socklen_t sk_addr_len; > - int rcv_buf_sz = __UEVENT_BUFFER_SIZE; > + int rcv_buf_sz = __UEVENT_RCVBUF_SIZE; > uint64_t sync_add = 1; > struct sockaddr_nl sk_addr = { 0 }, rcv_addr = { 0 }; > char buf[__UEVENT_BUFFER_SIZE] = { 0 }; > @@ -158,6 +163,12 @@ static int uevent_listener(unsigned long post_flags, bool expect_uevent, > ssize_t r; > > r = recvmsg(sk_fd, &hdr, 0); > + /* > + * The queue overran. The kernel clears the error after > + * reporting it once and more uevents are on their way. > + */ > + if (r < 0 && errno == ENOBUFS) > + continue; > if (r <= 0) { > fprintf(stderr, "%s - Failed to receive uevent\n", strerror(errno)); > ret = -1; _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel