From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id ACB3D80726 for ; Tue, 13 Oct 2026 12:54:37 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69DCrKub014392; Tue, 13 Oct 2026 15:53:21 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69DCrKub014392 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="J2kE1GID" Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69DCrHO5014388 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 13 Oct 2026 15:53:18 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69DCrHO5014388 Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cc4fc935a11so1936007a12.0 for ; Tue, 13 Oct 2026 05:53:18 -0700 (PDT) X-Gm-Message-State: AFq9FYKyApXDrafAATuBmOa5CNamxCenRSiKIA8oBnfvNgo2N6EUSjBG JcfEJGJdJcerf7KEZe3MVUcO7JOrIAihsaH4qL3s9TcR1ZGpEXHn6HT6HNvB1SV9/9bFYNdtK83 1P5EG55aX/XDyYRyuah4pIRu5MnnJYgq/jC8PheOfWwW/ZqGlaqEtZQ== X-Gm-Gg: AYBFou0DgrCjMWEJ++TINYEzuv4JnCxvTNFi9/Rsn+a/ighd+gaIH+wLa+zEmpj/OEp iiuPUg5Qn457W6QYUGehlgBP0vzYgHmIpqKyuLGzOZgeBuoJq7zrGafbHINgs3p4lsK/X8RuRW0 RTaCrFPd89Wdo2prMKT8J6mOfoUoO4OzS9Jlndxvgq0ZRPiphrLrw/VXrp9+01d6Z3u+HZv8D4j /Hhfvg3CI1LVgozyJvSiMC+eXBWtWP30fYnqbUtePqi6u+Jf4KpoISFMN4XNa/4QeMjZfyKNuJH 8JgFftdFd47xlycau2n1PY4NSmFdce1Fj09dL85I4z0B0Mf/nL/Z6q8+JNNHV7jz83z/rhIUxlT TZhd10YZ3C2S+hy4mtqbt+t6RdJ1YqlmBS0w21Uoulo/c134yRcoA81dFYwtktjpFjqED3M6+jt n/Zr2G3e5nowRf0juZFzW/VCaZDPp3cA/Jug== X-Received: by 2002:a05:6a21:d82:b0:3e1:1627:7b83 with SMTP id adf61e73a8af0-3e16bb71252mr11377282637.1.1791895997140; Tue, 13 Oct 2026 05:53:17 -0700 (PDT) X-Received: by 2002:a05:6a21:d82:b0:3e1:1627:7b83 with SMTP id adf61e73a8af0-3e16bb71252mr11377234637.1.1791895996194; Tue, 13 Oct 2026 05:53:16 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1791895996; cv=pass; d=google.com; s=arc-20260327; b=XorFR0biyh/0jGkCVPTvhnm4OVi7lk8tRxFa0jqy6k8hDmoLQ8x7sjap51HubwsK/n 25reAA2kqKt1Va5wgu8XYLrHyq//Q00XIYBQUOc5LkaqIbY/6XyZjaMHRXc4B5AnZq6E 2kO56/P3LIYS3axffOUIFYsQKtdUS22g3aa3wivdzDW4C+1x0+KzmjBsaUJ3mFIB8Hfw Rhu//g6s2zxm6c/B/TD9FtCO5omckMQvp9W7iWdxUohJHxD7g1/eLpkk1BnDH325jJjk uDJUhWbZSQgqwka2YTbvIuO1KG3dww9rLlvbX+yPkDNEspO5xfWD7wL/qDeP1kM/81hP tf5A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=Nya4nMcgCL6zb+iWwUP4J07cZ3dH9PJrCwqQU1wXruA=; fh=a7O+alUt1cWQrLe5ChyqsVBdToUocbAn8sZxqBezD24=; b=nE9pji5jmnTD2Ikkg/GHevfNLYr3hzRzOuiFZy8gnDNdO115e2Wpu9/YjEMda+k2Wl Vvve039OcXu+kcnISmLPgvp33kjrMG8RTB1z7At/polHl89iMAjyQoS068w0KC3cx8W1 ECzz59hyz4rDmkK7I2OmBJfiLitGbWbgrvyRXecMIG5AdPtWWKhE58KiXM2pj2H6P9NN jvqMu/TFwb8w+bhqpJilTXqeNXyfLnQcO13QOyU/7YPj0a6/FWyogsUfeKQdmjBOnrzl GV66/Vuh4JqlBrtWQpyuI7es3mEE0qMYse1vmwtJQu29iOVFYs8nvxIMvsv+hx8ruuzJ fy+Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=J2kE1GID; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c20a::7 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazlp170130007.outbound.protection.outlook.com. [2a01:111:f403:c20a::7]) by mx.google.com with ESMTPS id 41be03b00d2f7-cd3da054796si19317653a12.147.2026.10.13.05.53.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 05:53:16 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c20a::7 as permitted sender) client-ip=2a01:111:f403:c20a::7; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=J2kE1GID; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c20a::7 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gxyuEVHz6E8ZReD1PcPaSIHfrYMUnbtbmyLKUIGpkkS1rmRUF8c8M0S9QwYsQc6GqIr5CY+hHkxXqRA1UujvCXqits13JSQOBOdSm5AKp3H7gwgFsZfjbKqix+D18h0h2vaVyAXiNA19oBFXTKUJQbcp7ECm3muQYxlZA1ushV3faeG7LYeiI1Va6uTyZ8WHg+G7p00TiQ7tLP2h5i0XnUhgnaMaNJkcUelO6huU0LBtxwMXBWEeu/33iYkfIyoRqNPaanLf8/txq/wxC6kj8AV485HvQ/ANv87hcK2ieGwnRF0errK4qkAB/it/pOs7jyvtt+M/R6/8YRO03OunaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nya4nMcgCL6zb+iWwUP4J07cZ3dH9PJrCwqQU1wXruA=; b=EG2Grl3Rpwv0TyOaHLWlNUZ4XcumeJ98oE/INOXnw6e/+wopslH+eR4hRo819v++fL/WPC6/9xb9D4XH78qfFgjULHp+sis1hL/3toHpPDlp9a58wu7nlg1GajnDbaNKQ1tvFbnyCSMyn7JSII54tWwNOsKlkbBbG3QMXER9vvfxNw/8Bm+lPd/wqBlqbbz+rBXLhZqxemz1yPqbLG5tfu6RZOHN2kh3N+ZluVxExQPRQlXmY+WXs36afGpWlmqRrlumwjO3QXnsztf6BL+EglJqAkSsWCOTbplLrroLqgEjJB5n1EozYkmz3iJPgrzfgysC4Tfs/hov76I2TZH5jQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nya4nMcgCL6zb+iWwUP4J07cZ3dH9PJrCwqQU1wXruA=; b=J2kE1GIDeK7p5IGKMZKRZA+4J0nNOy7WX1MRU4e6xmu9gUV5/hAMv7h4aMjoNingkjPcMUiepHp8TOkap4V3YWg3DqK3SQto7ZTa3F9SmlF3qtKdd1qm2c0ZGVjLfBkCtXTJ1Xom63fNA3gtXDObtWOZJIstSXfYfZW7MqZgHT4VjS72HUXB6nDn3oRRcpXOB5u9gcy4evPw+RgN7N/WdtILlXKoFKTzoKBoSay5R6TpWrWlIWCHrU2eOAQRBNcpDwvrYQkFdrhrltXyeIFYACzRsGQLFfKdt5rSnRwymhXNGM6T16jFohLv7XtV3BeG5jN7em2H5t6xIvDJplFqtw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) by PR3PR08MB5835.eurprd08.prod.outlook.com (2603:10a6:102:8e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.12; Tue, 13 Oct 2026 12:53:12 +0000 Received: from VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a]) by VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a%6]) with mapi id 15.21.0522.011; Tue, 13 Oct 2026 12:53:12 +0000 Message-ID: Date: Tue, 13 Oct 2026 14:53:11 +0200 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, den@openvz.org References: <20261013111604.142989-1-alexander.ivanov@virtuozzo.com> <20261013111604.142989-13-alexander.ivanov@virtuozzo.com> <010701a1350e61fe-081a10ef-015a-4b2f-a854-028f6374f46d-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Alexander Ivanov In-Reply-To: <010701a1350e61fe-081a10ef-015a-4b2f-a854-028f6374f46d-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR2P281CA0026.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::13) To VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10743:EE_|PR3PR08MB5835:EE_ X-MS-Office365-Filtering-Correlation-Id: fa07bbf5-2ecc-441a-7d9d-08df2928f0c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|376014|23010399003|18002099003|10067099003|22082099003|4143699003|261009223027099003|5023799004|56012099006; X-Microsoft-Antispam-Message-Info: tYivnFozX2CF8Yyi0pHRJ07kHxClbVDwTdPva2W98fXKcZssD1diUT3CyNMWrfwr0Tjg4KnNJGZy6h96b/WfVwYSscIUHU/zTJ4gmZAtUALj8ylVuHVS5qDsfReN44/+PrjA+Z/ujKJmNF9Fwe8y/HC7e/p+MKnR4TfV4GOVoCttE7CRpBSQhqcm2pWeOoL6rR0L0jLtNXnu27RGgzC1YecG6/OhOS43JH1zOiVjKuOcmujLdMeOKiVGON59OFLxfE9UYF7d19upsb+sqhQAhkAxuowhoIabx+pax/DEQT4nF3JL3zDtSLGwk4pxWwZE2jrnORD6cZ7nZiDGX90BgW7wZ7RS+Vv9m7ZDLGEZNiIf+vVDVuYbrMc6kLRi65i5YEv76P0oJZUOBjcjMkVrfZ3A7xiHlSWYyNSZsLSURJ06qeTA9nW8k1eEXCl7ry/hM9IuBdUTNAC8I882F73r1QWEH7eEydbUaRrORmET5ozHhu5bk+cuSvDJK5msVI5AK7NMSSYrrCvF7ccwmVRQALiA3rzuRp+ehmKi+Qz+WsHmvdpK6JzeMoa2QqzO58EZijO+DYOV02H7ABgH8caIuHq3M1U8kuF1TAUnDSTlnM+dGfQgg7NpNW1jNTuNBChP8ATHQPXJnZqaovyFiQj5sEo/0tkYmd4EAijZ93UFohI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10743.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(23010399003)(18002099003)(10067099003)(22082099003)(4143699003)(261009223027099003)(5023799004)(56012099006); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enJtYzFjQ2paUkdFMXZtR0lpMTU3NUhTeUh4VW8xWUM3cCtuZElBYk9qK004?= =?utf-8?B?TDI4WmJIcy9uRWt4V2F0VkNuS2wxRTN4VDJLblgrdnhxSFRPbDg5WGhxZk5J?= =?utf-8?B?VzZxdFQ4a2pCcXZxU0N0cFYySmE0emNoTTVHNktEMWxDRlVxNGExYTNYT0Fw?= =?utf-8?B?TGp5cFJKTllxVjl0ZTlrWjdNN1RXVU0rdUlvcENCSm5oaERNUXRxbFEzdHNW?= =?utf-8?B?Y0picEF3VVVVL0RqT2UwZnozSGZhRWUvVkRGYzV0WFUxMFpBVWlTek9ZWHY3?= =?utf-8?B?dkN3OUQrSDFNSWZuK2o5MkJTTDZWMWgyK1lLUzBMUUVnTmlOOEVXRU1YV0tL?= =?utf-8?B?YmFIZkJOLzdOTFA5Yk9zQ1VKQjliTXlxZmlsRndHK21ZU1Zpa2hXbHVWQjlI?= =?utf-8?B?bFhGQ0xvQ0sxajFnelFYU1RuclliRFY2VGRwZjRlKys2MzVHZmg1WUs0Y1ha?= =?utf-8?B?WUZqZ00rWG1JeGZKamllVGg0Z21zenlIb21MMVhMaExDZW0rQ1JIWVM2WGVN?= =?utf-8?B?SFJ3Zk9kWWFwODZrdWVBbC9yc3Q5OHR2TXVZN2lvd3hPbWl0NkVGREtyQjMy?= =?utf-8?B?aDg2NE03emdUUGpFZ25qb3gwWlBOeU1peDNOZXIxT2F1MVpHVWFPYUdMS3JZ?= =?utf-8?B?L2U1ekJVQ0JFOWpwMU9wK2lrcEpWWExYNk4yTXVpcE1NNTlxWi9OTzMvQno3?= =?utf-8?B?amZ2a3dRNW9kdXpwYkkwUFNBM1BrLzZ2SEd6K2U1MlZmS0diT1dCMXRWZ0JT?= =?utf-8?B?a1lXVDVsUUpzOGZ5WnlVcmd5Wm1yUUlPVGJxNmtJZXZMdUoyWDBzaUs0RElE?= =?utf-8?B?VG1ZTjdoZDBML1pVelV3bXFkU0dlOTZyWFlkS01YTHlFZksyTm9lSHUxS2ds?= =?utf-8?B?ZVhXTGwxcGptN281OVh2QWthYWU4N0hvVjBZWmg0QS9aKyt5K3Q2WGp1eUVw?= =?utf-8?B?b1o4WjBOdkd3L044dThzMkp6NkduWXZmWmxRNW1DcERrbnMxOUpuR1hmQkV2?= =?utf-8?B?WmtWMWhZQ1U0VDdSU2lacVliVy9xMWVockhuYSthaHRhQ3FtUEU3a2oyNHo0?= =?utf-8?B?cEFvMldZemw5OEx1Z1JIKy9QR2hrQWpjQlZ5aWNrU3RFbktwVGxFay9ZVVlX?= =?utf-8?B?Z3FRYlU0V0c5Z3BtU0d5WVlLZ0FwWkVZQVZvYllzN0ZTaytWMnN0Zkt3Z3VF?= =?utf-8?B?M0ZyVy9JODQ5RGJ0WDdDT0Z4ZmFJTGhBZ3JXVFcyYzZqUVFXaWFISUdONEk3?= =?utf-8?B?RTh4T255YnN4NkhnalVteW41S0JsVzRIcEFEU1RvUHB0ODRsN215anlvQkZl?= =?utf-8?B?MnoyNlRlVU12d0dVTmFsQkcrdjZNRmlDUm5CUjV5eFBpWDF4dHI2R1ZDR21p?= =?utf-8?B?d1pUZy9XdEhRZmVvYTMxSHRnUFlFeXV1ZW4ySktQbVZ3aEs1bnBncWNGc0k0?= =?utf-8?B?eE5QcUJKRkFaOXpzYmxIRnBndHlGUlNIM3pyZzhZRGFKS3prM3N4R1RSV3Ar?= =?utf-8?B?WHZuRDl6TlIzbUN3NmlEK3cwU2x1WHU4dTFoOC9JV1JzNFR4V21IYks2NzZi?= =?utf-8?B?ZUhleUxtY0JLb2szNjQ2V05JR1BaT09JZFg4ZmVsRlRDancrb0FDa3F4aTNh?= =?utf-8?B?RFJuZGtJWU9hUWlUeFJZeVlvbHpNTE5yOFlqaTZTMHJRSVJNMExmams2U3pr?= =?utf-8?B?VHFvenJzZ1hoOVl6R0Q5QXBxdnZBMDhPYTZCWmFvRnRmL0txWUZUcUpZVUdJ?= =?utf-8?B?MXgrY0MwZFF0Vm5rL21ObTkvc3VGb0ZNZlZBNDc4K2dmQmxnbUlpUGk1Vkx3?= =?utf-8?B?bjRMUGRpcWl1UGtHWXRKWTFDc09teVRRbERVQ01YZm03OXprV2RuSkJFU0pD?= =?utf-8?B?V1Q4LzZqbU1qVDBEVzRoUUpxWnFidFN5YnBibXhjQTFIOWczYWwrNmgwd1hz?= =?utf-8?B?eHp6OTNtZHZzbGZnbGhvZXRvd2VtNWhOWm5SODYzVjd5VTlFUnRVcWpPcTJN?= =?utf-8?B?Y0Q0amhMRFR0aUdPeHNMRmcwdS81U1Y2ejU0anhoNFpVUFJ3R29GMzRJVmg1?= =?utf-8?B?czBjTlV3K3pIUGNtZGQvakYxNHhNODB0REsxL2pCQTBoaXpTOEVxMVpLeHRR?= =?utf-8?B?MG5lT1BKT1JOeVdxWHpXK2h4OS9ndzhqT2ZDMEUydkJoQ3JhT0l6QXZZREJB?= =?utf-8?B?UHdqN3E2Q1YwV3paTnlFb3FwNGd4S2RPeUU2dmwrVFo4ZkhzSGVqQjN4LzlM?= =?utf-8?B?enZHdWdHWS9VK3R2V2c1cHVpZVZxWXc5OVR1cTFlKyszTEJTWjB6N2xMOXlw?= =?utf-8?B?NU1JOVlycnRXeW5sY3ZkQjhKWWkyWWZkR2lNTDVBOHpxSmNnUVZCVnRvKzJr?= =?utf-8?Q?9u7k6ylOYJGBSQ7M=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa07bbf5-2ecc-441a-7d9d-08df2928f0c3 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10743.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2026 12:53:12.6067 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SOOlLGYBaD0I0ocvUn59laghxK3H3L7OYAYSeTjMhkPKXtDj2Ymkq+aR2Cqxjb3qPHialMPEB+JhmgM/zjWcbCzbSk3S3zcXX14JPxs3XVs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5835 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v6 12/12] dm-ploop: truncate unused tail of top delta on suspend X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/13/26 13:38, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Low] dm-ploop: ploop_postsuspend() holds ctl_rwsem across unbounded waits and fs I/O > -- > > commit 1aa3a8ea27bee4e747c238df1ff3b02cb36cb3fd > Author: Alexander Ivanov > > dm-ploop: truncate unused tail of top delta on suspend > > This patch adds ploop_calc_used_end() and ploop_truncate_unused_tail(). > ploop_postsuspend() now truncates the unused tail of the top delta. It > does this under ctl_rwsem, so that ploop messages don't change the image > in parallel. > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-148171 > >> diff --git a/drivers/md/dm-ploop-target.c b/drivers/md/dm-ploop-target.c >> --- a/drivers/md/dm-ploop-target.c >> +++ b/drivers/md/dm-ploop-target.c > [ ... ] > >> static void ploop_postsuspend(struct dm_target *ti) >> { >> struct ploop *ploop = ti->private; >> + unsigned int noio_flags; >> >> + down_write(&ploop->ctl_rwsem); >> /* >> * Let the next resumed ploop (maybe of reloaded table) >> * see final size of the top delta. Don't wait in standby > [ ... ] > >> wait_event(ploop->inflight_md_wq, !atomic_read(&ploop->inflight_md)); >> - ploop_set_suspended(ti, true); >> + /* The device is suspended, see ploop_preresume() */ >> + noio_flags = memalloc_noio_save(); >> + ploop_truncate_unused_tail(ploop); >> + memalloc_noio_restore(noio_flags); >> + ploop->suspended = true; >> + up_write(&ploop->ctl_rwsem); >> } > [Severity: Low] > Is it necessary to take ctl_rwsem for write before the waits in > ploop_postsuspend()? > > The write lock is now taken before the killable ploop_wait_prealloc() and > the uninterruptible wait_event(ploop->inflight_md_wq, ...), and it stays > held through ploop_truncate_unused_tail(), which calls vfs_iter_read() > (via ploop_calc_used_end()), vfs_fsync() and do_ftruncate(). > > Before this patch the lock was only taken briefly in ploop_set_suspended(), > after both waits. Those waits could already block for a long time. In > standby, or with a dead or stuck backing file, inflight_md may never reach > zero. Now other ctl_rwsem users block behind them as well: > > ploop_status() > down_read(&ploop->ctl_rwsem); /* STATUSTYPE_TABLE */ > > ploop_message() > if (read) > down_read(&ploop->ctl_rwsem); > else > down_write(&ploop->ctl_rwsem); > > Every message handler except get_event would hang while postsuspend is > stalled. The same stall can come from a slow vfs_fsync() or do_ftruncate() > on a stuck filesystem. > > I don't see a deadlock. Nothing on the inflight_md completion path or in > the allocator takes ctl_rwsem. dm_suspend() also already hangs in that > state with md->suspend_lock held, so the practical impact looks small. > > The two waits don't appear to need the lock. Only > ploop_truncate_unused_tail() and the store to ploop->suspended do. Would > it make sense to take the lock after the waits? That would avoid > extending the blocking to status and message handlers while the wait > phase is stuck. The extra blocking only happens when postsuspend is already stuck: dm_suspend() hangs with md->suspend_lock held and the device can't be recovered either way. Holding the lock across the waits keeps messages (e.g. resize) from slipping in between the waits and the truncation and leaving new preallocation behind, which would make us skip the truncation. So I'd keep it as is. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel