From: no-reply@sashiko.virtuozzo.com
To: Alexey Kuznetsov <kuznet@virtuozzo.com>,
Konstantin Khorenko <khorenko@virtuozzo.com>,
Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
Liu Kui <kui.liu@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH vz10 v3] fuse: reject FUSE_NOTIFY_INVAL_FILES for non-regular inodes
Date: Tue, 29 Sep 2026 12:26:48 +0000 [thread overview]
Message-ID: <010701a0ed21c717-7b81b898-328a-4812-9b85-8f0b28638d83-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20260928-b4-prep-kh-vstor-147641-fuse_notify_inval_files-v3-1-43a1c1d0ebee@virtuozzo.com>
> FUSE_NOTIFY_INVAL_FILES invalidates the read/write io state of an inode,
> which only regular files have. The notification carries a bare nodeid,
> and the actual work is deferred to a workqueue:
>
> fuse_dev_do_write()
> fuse_notify()
> fuse_notify_inval_files()
> fuse_invalidate_files() inode = fuse_ilookup(fc, nodeid)
> queue_delayed_work(fuse_inval_files_wq, &fc->inval_files_work)
> ...
> fuse_inval_files_work() worker context
> wake_up(&fi->page_waitq) regular file state
>
> What the bytes behind fi->page_waitq are depends on the inode type, see
> fuse_init_inode():
> [ ... ]
> https://virtuozzo.atlassian.net/browse/VSTOR-147641
>
> Fixes: 19dd5fa442ea ("fuse: skip waiting for fuse writeback")
> Feature: vStorage
> Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260928-b4-prep-kh-vstor-147641-fuse_notify_inval_files-v3-1-43a1c1d0ebee@virtuozzo.com?part=1
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
prev parent reply other threads:[~2026-09-29 12:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 12:31 Konstantin Khorenko
2026-09-29 12:26 ` no-reply [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a0ed21c717-7b81b898-328a-4812-9b85-8f0b28638d83-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
--cc=kui.liu@virtuozzo.com \
--cc=kuznet@virtuozzo.com \
--cc=ptikhomirov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox