Re: [Devel] [PATCH hci-8.1 1/4] ms/vdso: Drop Kconfig GENERIC_VDSO_TIME_NS

[no-reply@sashiko.virtuozzo.com]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] config: stale CONFIG_GENERIC_VDSO_TIME_NS=y left in shipped Virtuozzo configs
--

commit 6f298fef5110add3238fa534d536cbb04d9561a1
Author: Eva Kurchatova <eva.kurchatova@virtuozzo.com>

ms/vdso: Drop Kconfig GENERIC_VDSO_TIME_NS

This is a backport of the upstream change that removes the
GENERIC_VDSO_TIME_NS Kconfig symbol. TIME_NS now depends on
GENERIC_GETTIMEOFDAY instead, and the per-architecture selects and the
selftests config entry are dropped.

Link: https://lore.kernel.org/all/20250826-vdso-cleanups-v1-10-d9b65750e49f@linutronix.de

> diff --git a/lib/vdso/Kconfig b/lib/vdso/Kconfig
> index 45df764b49ad6..a1cc90133cb9e 100644
> --- a/lib/vdso/Kconfig
> +++ b/lib/vdso/Kconfig
> @@ -24,12 +24,6 @@ config GENERIC_COMPAT_VDSO
>  	help
>  	  This config option enables the compat VDSO layer.
>  
> -config GENERIC_VDSO_TIME_NS
> -	bool
> -	help
> -	  Selected by architectures which support time namespaces in the
> -	  VDSO
> -

[Severity: Low]
This removes the Kconfig symbol, but the shipped Virtuozzo config files
still set it:

config.vz10.minimal:
CONFIG_GENERIC_VDSO_TIME_NS=y

configs/kernel-6.12.0-x86_64.config:
CONFIG_GENERIC_VDSO_TIME_NS=y

configs/kernel-6.12.0-x86_64-debug.config:
CONFIG_GENERIC_VDSO_TIME_NS=y

Should these three lines be dropped in this patch as well?

As it stands, make oldconfig or olddefconfig will silently discard the
unknown symbol. The next config regeneration would then produce a spurious
diff, and any check comparing the shipped configs against regenerated
output would report a mismatch.

The effective x86 configuration should not change, since TIME_NS now
depends on GENERIC_GETTIMEOFDAY, which x86 selects unconditionally. The
upstream commit has no equivalent files, so this gap appears specific to
the downstream backport.

The later patches in the series do not appear to remove these references
either.

[ ... ]

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261009135929.3274885-1-eva.kurchatova@virtuozzo.com?part=1

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel