From: no-reply@sashiko.virtuozzo.com
To: devel@openvz.org, Konstantin Khorenko <khorenko@virtuozzo.com>
Subject: Re: [Devel] [PATCH hci-8.1] ms/ipv4: validate checksum_start before completing checksum
Date: Fri, 16 Oct 2026 21:13:34 +0000 [thread overview]
Message-ID: <010701a1469027a1-244406cd-ca50-45b0-8d27-65796f49e219-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261016-cve-v1-1-d244f4c79d4c@virtuozzo.com>
> From: "Michael S. Tsirkin" <mst@redhat.com>
>
> commit 6785011f8b16abf40b1e9d8b2e332232b3e68822 upstream.
>
> If a packet with bad checksum metadata gets into the ipv4 stack,
> skb_checksum_help can corrupt the network header and cause a bunch of
> mischief.
>
> This was discovered and reported by Paulos, and has been reporoduced
> by others independently since.
>
> We really shouldn't allow such packets in, but as a defence
> in depth measure, let's also check before we complete the checksum.
>
> A more complete validation at input is forthcoming, but needs more work.
> [ ... ]
> https://virtuozzo.atlassian.net/browse/VSTOR-150637
>
> Feature: fix ms/net
> Assisted-by: LLM
> Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261016-cve-v1-1-d244f4c79d4c@virtuozzo.com?part=1
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-10-16 21:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 21:08 Konstantin Khorenko
2026-10-16 21:13 ` no-reply [this message]
2026-10-16 21:20 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1469027a1-244406cd-ca50-45b0-8d27-65796f49e219-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox