From: no-reply@sashiko.virtuozzo.com
To: den@openvz.org, Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1] dm: don't inherit bio-based table type for targets without ->map
Date: Sat, 17 Oct 2026 09:38:31 +0000 [thread overview]
Message-ID: <010701a1493a2ca0-a35b7003-63ef-4ee6-875d-a1f270b45ab9-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261017093503.771224-1-alexander.ivanov@virtuozzo.com>
> A table whose single target has no devices inherits the live table's
> type in dm_table_determine_type(). dm-qcow2 and dm-ploop open their
> images by fd and never call dm_get_device(), so loading them over a
> bio-based live table makes the table bio-based although these targets
> have no ->map. The first bio then calls a NULL ->map from __map_bio():
>
> BUG: kernel NULL pointer dereference, address: 0000000000000000
> RIP: 0010:0x0
> __map_bio+0x197/0x1c0 [dm_mod]
> dm_split_and_process_bio+0x1ad/0x740 [dm_mod]
>
> Inherit the live table's type only if the target has ->map, so it can
> run bio-based. Otherwise keep the request-based type, so table_load()
> rejects the mismatch with "can't change device type".
>
> https://virtuozzo.atlassian.net/browse/VSTOR-150573
> Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261017093503.771224-1-alexander.ivanov@virtuozzo.com?part=1
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
prev parent reply other threads:[~2026-10-17 9:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 9:35 Alexander Ivanov
2026-10-17 9:38 ` no-reply [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1493a2ca0-a35b7003-63ef-4ee6-875d-a1f270b45ab9-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=alexander.ivanov@virtuozzo.com \
--cc=den@openvz.org \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox