From: no-reply@sashiko.virtuozzo.com
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>, khorenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1] selftests/zram: use the device ids that hot_add returns
Date: Tue, 3 Nov 2026 11:07:04 +0000 [thread overview]
Message-ID: <010701a1a1175ab8-c586f742-ae3c-4c9b-a2ce-2fa50eccbdfb-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261103110354.2525675-1-eva.kurchatova@virtuozzo.com>
> zram_load() numbers the devices it creates by counting the nodes in
> /dev and discards the ids hot_add returns. hot_add takes the lowest
> free id, so once the ids have a gap the test works on a device it did
> not create: with zram0 and zram2 present it creates zram1, then
> configures, formats and mounts zram2, and finally resets and removes
> zram2 and leaves zram1 behind.
>
> Keep the ids hot_add returns and use them in every step and in the
> cleanup. A hot_add that fails now fails the test.
>
> Fixes: 01dabed20573 ("selftests/zram: Adapt the situation that /dev/zram0 is being used")
> https://virtuozzo.atlassian.net/browse/VSTOR-152656
> Feature: fix selftests
>
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261103110354.2525675-1-eva.kurchatova@virtuozzo.com?part=1
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-03 11:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 11:03 Eva Kurchatova
2026-11-03 11:07 ` no-reply [this message]
2026-11-03 17:40 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1a1175ab8-c586f742-ae3c-4c9b-a2ce-2fa50eccbdfb-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=devel@openvz.org \
--cc=eva.kurchatova@virtuozzo.com \
--cc=khorenko@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox