From: no-reply@sashiko.virtuozzo.com
To: khorenko@virtuozzo.com, Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1] ms/selftests/xsk: properly handle batch ending in the middle of a packet
Date: Fri, 6 Nov 2026 14:57:46 +0000 [thread overview]
Message-ID: <010701a1b15da36b-38516499-5e31-4d4b-bede-2b37d7b0209b-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261106145505.132348-1-eva.kurchatova@virtuozzo.com>
> From: Larysa Zaremba <larysa.zaremba@intel.com>
>
> Referenced commit reduced the scope of the variable pkt, so now it has to
> be reinitialized via pkt_stream_get_next_rx_pkt(), which also increments
> some counters. When the packet is interrupted by the batch ending, pkt
> stream therefore proceeds to the next packet, while xsk ring still contains
> the previous one, this results in a pkt_nb mismatch.
>
> Decrement the affected counters when packet is interrupted.
>
> Fixes: 8913e653e9b8 ("selftests/xsk: Iterate over all the sockets in the receive pkts function")
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
> Link: https://lore.kernel.org/r/20260203155103.2305816-2-larysa.zaremba@intel.com
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
> (cherry picked from commit 42e41b2a0afa04ca49ee2725aadf90ccb058ed28)
>
> Rebase note: applied to xskxceiver.c, which mainline split into
> prog_tests/test_xsk.c in commit 3ab77f35a75e ("selftests/bpf:
> test_xsk: Split xskxceiver"), missing here. The code is the same.
>
> https://virtuozzo.atlassian.net/browse/VSTOR-153754
> Feature: fix selftests
>
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261106145505.132348-1-eva.kurchatova@virtuozzo.com?part=1
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
prev parent reply other threads:[~2026-11-06 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 14:54 Eva Kurchatova
2026-11-06 14:57 ` no-reply [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1b15da36b-38516499-5e31-4d4b-bede-2b37d7b0209b-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=devel@openvz.org \
--cc=eva.kurchatova@virtuozzo.com \
--cc=khorenko@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox