Re: [Devel] [PATCH hci-8.1 1/1] ms/drm/amdgpu: Fix init ordering in amdgpu_vram_mgr_init()

[no-reply@sashiko.virtuozzo.com]

> From: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> 
> drmm_cgroup_register_region() is called before INIT_LIST_HEAD() and
> gpu_buddy_init() in amdgpu_vram_mgr_init(). If it fails, the function
> returns early and bypasses those initializations.
> 
> Since adev->mman.initialized is set to true before amdgpu_vram_mgr_init()
> is called, a failure triggers amdgpu_ttm_fini(), which calls
> amdgpu_vram_mgr_fini(), which then:
> 
>  - Calls list_for_each_entry_safe() on reservations_pending and
>    reserved_pages, whose list_head::next pointers are zero-initialized
>    (NULL). The loop does not recognize them as empty and dereferences NULL.
> 
>  - Calls gpu_buddy_fini(), which iterates free_trees[] unconditionally
> [ ... ]
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-153702
> Feature: fix ms/drm
> 
> Signed-off-by: Mirian Shilakadze <mirian.shilakadze@virtuozzo.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261106145524.96305-1-mirian.shilakadze@virtuozzo.com?part=1


_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel