From: no-reply@sashiko.virtuozzo.com
To: khorenko@virtuozzo.com, "Denis V. Lunev" <den@openvz.org>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1] net/ip_gre: fix a host panic on a received ERSPAN packet
Date: Tue, 10 Nov 2026 16:35:10 +0000 [thread overview]
Message-ID: <010701a1c65040d8-a8559b09-5aae-447f-b170-1818c4573676-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261110163110.2776207-1-den@openvz.org>
> From: Denis V. Lunev <den@openvz.org>
>
> Commit a1049e020cdf ("ve/net/gre: Disable ERSPAN support in ip_gre
> module") compiled erspan_net_ops out under CONFIG_VE but left the ERSPAN
> receive and ICMP error paths in place. erspan_net_id is then never
> assigned and stays 0, and net_generic(net, 0) does not return NULL: it
> returns the length word of struct net_generic, which ptr[0] overlays.
> ip_tunnel_lookup() passes its NULL check and reads itn->tunnels[] in
> the first page. Once ip_gre is loaded, any GRE packet with protocol
> ETH_P_ERSPAN or ETH_P_ERSPAN2 delivered to the node panics it in
> softirq, and so does an ICMP error quoting such a header. The packet
> can come from the network or from container root with a raw socket.
>
> Return a NULL itn for ERSPAN under CONFIG_VE, so both paths miss the
> lookup and handle the packet as one for a tunnel that does not exist.
>
> Fixes: a1049e020cdf ("ve/net/gre: Disable ERSPAN support in ip_gre module")
>
> https://virtuozzo.atlassian.net/browse/VSTOR-154362
> Feature: net: disable ERSPAN support in ip_gre module
> Signed-off-by: Denis V. Lunev <den@openvz.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261110163110.2776207-1-den@openvz.org?part=1
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-10 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 16:31 Denis V. Lunev
2026-11-10 16:35 ` no-reply [this message]
2026-11-12 13:07 ` Konstantin Khorenko
2026-11-12 13:08 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1c65040d8-a8559b09-5aae-447f-b170-1818c4573676-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=den@openvz.org \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox