From: no-reply@sashiko.virtuozzo.com
To: "Denis V. Lunev" <den@openvz.org>, khorenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v2 1/3] xfs: release the balloon inode when xfs_balloon_get() refuses it
Date: Tue, 10 Nov 2026 22:31:38 +0000 [thread overview]
Message-ID: <010701a1c7969acc-8cfce846-1e77-4e3b-9a0b-9d59bab3548e-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261110222756.3236854-2-den@openvz.org>
> From: Denis V. Lunev <den@openvz.org>
>
> xfs_balloon_get() looks the balloon inode up with xfs_iget() and returns
> -EINVAL when it is not a regular file or is immutable, without
> releasing the reference it took. Every statfs and every open of the
> balloon then leaks a reference on such an inode, which the VFS reports
> as a busy inode at unmount.
>
> Release the inode before returning -EINVAL.
>
> https://virtuozzo.atlassian.net/browse/VSTOR-153590
>
> Feature: fs/xfs: fast online shrink support
> Signed-off-by: Denis V. Lunev <den@openvz.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261110222756.3236854-2-den@openvz.org?part=1
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-10 22:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 22:27 [Devel] [PATCH hci-8.1 v2 0/3] ext4, xfs: discard the balloon on FITRIM Denis V. Lunev
2026-11-10 22:27 ` [Devel] [PATCH hci-8.1 v2 1/3] xfs: release the balloon inode when xfs_balloon_get() refuses it Denis V. Lunev
2026-11-10 22:31 ` no-reply [this message]
2026-11-10 22:27 ` [Devel] [PATCH hci-8.1 v2 2/3] ext4: discard the balloon on FITRIM Denis V. Lunev
2026-11-10 22:35 ` no-reply
2026-11-10 22:27 ` [Devel] [PATCH hci-8.1 v2 3/3] xfs: " Denis V. Lunev
2026-11-10 22:36 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1c7969acc-8cfce846-1e77-4e3b-9a0b-9d59bab3548e-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=den@openvz.org \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox