OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: no-reply@sashiko.virtuozzo.com
To: khorenko@virtuozzo.com, Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v2 1/5] ms/eventfs: Hold eventfs_mutex and SRCU when remount walks events
Date: Thu, 12 Nov 2026 00:15:26 +0000	[thread overview]
Message-ID: <010701a1cd1bfe8b-5f37d627-9247-43fb-b281-a8c6169cae02-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261112000926.381308-3-eva.kurchatova@virtuozzo.com>

> From: David Carlier <devnexen@gmail.com>
> 
> Commit 340f0c7067a9 ("eventfs: Update all the eventfs_inodes from the
> events descriptor") had eventfs_set_attrs() recurse through ei->children
> on remount.  The walk only holds the rcu_read_lock() taken by
> tracefs_apply_options() over tracefs_inodes, which is wrong:
> 
>   - list_for_each_entry over ei->children races with the list_del_rcu()
>     in eventfs_remove_rec() -- LIST_POISON1 deref, same shape as
>     d2603279c7d6.
>   - eventfs_inodes are freed via call_srcu(&eventfs_srcu, ...).
>     rcu_read_lock() does not extend an SRCU grace period, so ti->private
>     can be reclaimed under the walk.
>   - The writes to ei->attr race with eventfs_set_attr(), which holds
>     eventfs_mutex.
> [ ... ]
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-154529
> Feature: fix ms/tracefs
> 
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261112000926.381308-2-eva.kurchatova@virtuozzo.com?part=1


_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  reply	other threads:[~2026-11-12  0:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  0:07 [Devel] [PATCH hci-8.1 v2 0/5] ms/eventfs: fix kernel panic on NULL dereference Eva Kurchatova
2026-11-12  0:07 ` [Devel] [PATCH hci-8.1 v2 1/5] ms/eventfs: Hold eventfs_mutex and SRCU when remount walks events Eva Kurchatova
2026-11-12  0:15   ` no-reply [this message]
2026-11-12 16:43   ` Konstantin Khorenko
2026-11-12  0:07 ` [Devel] [PATCH hci-8.1 v2 2/5] ms/eventfs: Fix use-after-free in eventfs_remove_rec() Eva Kurchatova
2026-11-12  0:13   ` no-reply
2026-11-12 16:43   ` Konstantin Khorenko
2026-11-12  0:07 ` [Devel] [PATCH hci-8.1 v2 3/5] ms/eventfs: Use children field for rcu head and add memory barriers Eva Kurchatova
2026-11-12  0:16   ` no-reply
2026-11-12  4:18     ` Eva Kurchatova (Virtuozzo)
2026-11-12 16:43   ` Konstantin Khorenko
2026-11-12  0:07 ` [Devel] [PATCH hci-8.1 v2 4/5] ms/eventfs: fix SRCU read lock leak in eventfs_iterate() Eva Kurchatova
2026-11-12  0:15   ` no-reply
2026-11-12 16:43   ` Konstantin Khorenko
2026-11-12  0:07 ` [Devel] [PATCH hci-8.1 v2 5/5] ms/eventfs: Initialize ei->children and ei->list in init_ei() Eva Kurchatova
2026-11-12  0:16   ` no-reply
2026-11-12 16:43   ` Konstantin Khorenko
2026-11-12 16:43 ` [Devel] [PATCH hci-8.1 v2 0/5] ms/eventfs: fix kernel panic on NULL dereference Konstantin Khorenko
2026-11-12 16:50 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=010701a1cd1bfe8b-5f37d627-9247-43fb-b281-a8c6169cae02-000000@eu-central-1.amazonses.com \
    --to=no-reply@sashiko.virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=eva.kurchatova@virtuozzo.com \
    --cc=khorenko@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox