From: no-reply@sashiko.virtuozzo.com
To: khorenko@virtuozzo.com, alexander.ivanov@virtuozzo.com,
Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 3/3] dm-qcow2: let discards of one L2 page wait for in-flight writes together
Date: Thu, 12 Nov 2026 11:24:53 +0000 [thread overview]
Message-ID: <010701a1cf80e4bc-d8a67fb4-28d7-4a9c-b60c-245bad842733-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261112111205.736027-4-andrey.zhadchenko@virtuozzo.com>
> Only one discard at a time switches the generation of an L2 page and
> waits for the previous one to drain. Others queue behind it and then
> do the same one by one, so N discards of clusters mapped by one L2
> page take N drain cycles under write load. This is the common case:
> discards updating the same L2 page complete its writeback together
> and come to process_indexes_end() in one batch.
>
> A discard, which finds a switch in progress while no write is counted
> in the new generation yet, has exactly the same writes to wait for as
> the discard which switched. Let it join: wait for the same previous
> generation instead of queueing for its own switch. If that generation
> is already empty, nothing is in flight and the discard goes on
> immediately.
>
> Count the discards waiting for the previous generation instead of
> keeping a flag, and allow the next switch when the last of them is
> released.
>
> https://virtuozzo.atlassian.net/browse/VSTOR-154659
> Feature: dm-qcow2: block device over QCOW2 files driver
> Signed-off-by: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261112111205.736027-1-andrey.zhadchenko@virtuozzo.com?part=3
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-12 11:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 11:12 [Devel] [PATCH hci-8.1 0/3] dm-qcow2: do not free a discarded cluster under in-flight writes Andrey Zhadchenko
2026-11-12 11:12 ` [Devel] [PATCH hci-8.1 1/3] dm-qcow2: count in-flight data writes per L2 page Andrey Zhadchenko
2026-11-12 11:22 ` no-reply
2026-11-12 18:59 ` Konstantin Khorenko
2026-11-12 11:12 ` [Devel] [PATCH hci-8.1 2/3] dm-qcow2: wait for in-flight writes before freeing a discarded cluster Andrey Zhadchenko
2026-11-12 11:26 ` no-reply
2026-11-12 11:47 ` Andrey Zhadchenko
2026-11-12 18:59 ` Konstantin Khorenko
2026-11-12 11:12 ` [Devel] [PATCH hci-8.1 3/3] dm-qcow2: let discards of one L2 page wait for in-flight writes together Andrey Zhadchenko
2026-11-12 11:24 ` no-reply [this message]
2026-11-12 18:59 ` Konstantin Khorenko
2026-11-12 12:40 ` [Devel] [PATCH hci-8.1 0/3] dm-qcow2: do not free a discarded cluster under in-flight writes Alexander Ivanov
2026-11-12 18:59 ` Konstantin Khorenko
2026-11-12 19:00 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1cf80e4bc-d8a67fb4-28d7-4a9c-b60c-245bad842733-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=alexander.ivanov@virtuozzo.com \
--cc=andrey.zhadchenko@virtuozzo.com \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox