From: no-reply@sashiko.virtuozzo.com
To: Mirian Shilakadze <mirian.shilakadze@virtuozzo.com>,
khorenko@virtuozzo.com, ptikhomirov@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH vz10 5/6] fs: give the mount relaxations of a pseudosuper VE only to setup tasks
Date: Mon, 16 Nov 2026 10:56:46 +0000 [thread overview]
Message-ID: <010701a1e400986c-a3c98883-e159-4eb0-a15f-22de8aa54c34-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261116104552.102938-6-mirian.shilakadze@virtuozzo.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] fs: subject overstates setup-only scope; host_entered open-codes
pseudosuper test
--
commit 7f9d1b2c96b4b01e7ac65283588597610de48bff
Author: Mirian Shilakadze <mirian.shilakadze@virtuozzo.com>
fs: give the mount relaxations of a pseudosuper VE only to setup tasks
This commit replaces the plain ve->is_pseudosuper checks in the device mount option filter and the VE mount limit with ve_current_is_pseudosuper(). It also adds a separate exemption in ve_try_reserve_mount() for host tasks that entered the VE after it started.
> diff --git a/fs/namespace.c b/fs/namespace.c
> index d622d9b72d32..20a03419bc0c 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
[ ... ]
> @@ -3367,8 +3367,16 @@ int ve_devmnt_verify(struct ve_struct *ve, dev_t dev, char *opts, bool new_mount
> static inline int ve_try_reserve_mount(struct ve_struct *ve)
> {
> - int ret = ve_is_super(ve) || ve->is_pseudosuper ||
> - ve_is_super(get_exec_env());
> + struct mm_struct *mm = current->mm;
> + /*
> + * A host task that joined @ve after it started, such as the CRIU
> + * helper that mounts proc for a nested pid namespace, is not a setup
> + * task but still skips the limit while @ve is pseudosuper.
> + */
> + bool host_entered = ve->is_pseudosuper && task_ve(current) == ve &&
> + mm && mm->vps_dumpable == VD_VE_ENTER_TASK;
[Severity: Low]
This isn't a bug, but the subject says the relaxations go only to setup
tasks, while the mount limit now also exempts VD_VE_ENTER_TASK tasks. The
device mount option filter in ve_devmnt_process() and ve_devmnt_verify()
still uses only ve_current_is_pseudosuper(), so the two relaxations now
differ. Could the subject and opening paragraph say so?
host_entered also repeats the is_pseudosuper, task_ve(current) == ve, mm
and vps_dumpable tests from ve_current_is_pseudosuper() in
kernel/ve/ve.c, changing only the marker value. Would a named helper next
to ve_current_is_pseudosuper() be easier to keep in sync?
> + int ret = ve_is_super(ve) || ve_current_is_pseudosuper(ve) ||
> + ve_is_super(get_exec_env()) || host_entered;
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261116104552.102938-1-mirian.shilakadze@virtuozzo.com?part=5
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-16 10:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 10:45 [Devel] [PATCH vz10 0/6] ve: give the pseudosuper privileges only to the tasks setting up a VE Mirian Shilakadze
2026-11-16 10:45 ` [Devel] [PATCH vz10 1/6] ve: tell ve_setup_task() which VE the task comes from Mirian Shilakadze
2026-11-16 10:50 ` no-reply
2026-11-16 10:45 ` [Devel] [PATCH vz10 2/6] ve: hide only the tasks the host sends into a VE Mirian Shilakadze
2026-11-16 10:50 ` no-reply
2026-11-16 17:17 ` Konstantin Khorenko
2026-11-16 10:45 ` [Devel] [PATCH vz10 3/6] ve: hide the tasks that set up a starting VE from the rest of it Mirian Shilakadze
2026-11-16 10:55 ` no-reply
2026-11-16 17:17 ` Konstantin Khorenko
2026-11-16 10:45 ` [Devel] [PATCH vz10 4/6] cgroup: give the CT root file writes and hidden roots only to setup tasks Mirian Shilakadze
2026-11-16 10:53 ` no-reply
2026-11-16 17:17 ` Konstantin Khorenko
2026-11-16 10:45 ` [Devel] [PATCH vz10 5/6] fs: give the mount relaxations of a pseudosuper VE " Mirian Shilakadze
2026-11-16 10:56 ` no-reply [this message]
2026-11-16 17:17 ` Konstantin Khorenko
2026-11-16 10:45 ` [Devel] [PATCH vz10 6/6] ve: give the remaining pseudosuper relaxations " Mirian Shilakadze
2026-11-16 10:56 ` no-reply
2026-11-16 17:17 ` Konstantin Khorenko
2026-11-16 17:17 ` [Devel] [PATCH vz10 0/6] ve: give the pseudosuper privileges only to the tasks setting up a VE Konstantin Khorenko
2026-11-17 10:21 ` Mirian Shilakadze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1e400986c-a3c98883-e159-4eb0-a15f-22de8aa54c34-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
--cc=mirian.shilakadze@virtuozzo.com \
--cc=ptikhomirov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox