From: no-reply@sashiko.virtuozzo.com
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>, khorenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 1/2] ms/mptcp: do not reschedule the RTX timer for fallback sockets
Date: Mon, 16 Nov 2026 15:02:48 +0000 [thread overview]
Message-ID: <010701a1e4e1d718-6b6a52e0-1ed3-48af-bceb-0f12149e4b15-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261116145652.625598-2-eva.kurchatova@virtuozzo.com>
> From: Paolo Abeni <pabeni@redhat.com>
>
> On fallback socket the retrans timer is a quite convoluted no-op, but
> currently nothing prevents the MPTCP core to keep rescheduling it.
>
> Additionally gate RTX timer reset to the msk not being fallen back to
> TCP yet. To avoid adding multiple tests in fast-path, use a new flags
> bit for such condition.
>
> The RTX enable bit is clear at close time and set before the msk could
> start retransmitting, with a couple of caveats:
>
> - passive sockets inherit the bit from the listener msk; set the bit on
> such socket to avoid flipping it in the fast-path, even if the
> listener will obviously never retransmit.
> [ ... ]
>
> https://virtuozzo.atlassian.net/browse/VSTOR-154928
> Feature: fix ms/net
>
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261116145652.625598-1-eva.kurchatova@virtuozzo.com?part=1
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-16 15:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 14:43 [Devel] [PATCH hci-8.1 0/2] ms/mptcp: backport mainline fixes Eva Kurchatova
2026-11-16 14:43 ` [Devel] [PATCH hci-8.1 1/2] ms/mptcp: do not reschedule the RTX timer for fallback sockets Eva Kurchatova
2026-11-16 15:02 ` no-reply [this message]
2026-11-16 14:43 ` [Devel] [PATCH hci-8.1 2/2] ms/mptcp: fix subflow bitfield misuse Eva Kurchatova
2026-11-16 15:00 ` no-reply
2026-11-16 17:03 ` [Devel] [PATCH hci-8.1 0/2] ms/mptcp: backport mainline fixes Konstantin Khorenko
2026-11-16 17:04 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1e4e1d718-6b6a52e0-1ed3-48af-bceb-0f12149e4b15-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=devel@openvz.org \
--cc=eva.kurchatova@virtuozzo.com \
--cc=khorenko@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox