OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: no-reply@sashiko.virtuozzo.com
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>, khorenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 1/2] ms/ext4: free the sbi after a grace period
Date: Tue, 17 Nov 2026 06:02:02 +0000	[thread overview]
Message-ID: <010701a1e8191ba2-59d745e4-e642-40f4-8521-de1737ec94d2-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261117055330.810827-2-eva.kurchatova@virtuozzo.com>

> From: Christian Brauner <brauner@kernel.org>
> 
> [ Upstream commit c17b44266a1f9fcb49b894d4611d1254bf1aa313 ]
> 
> ext4_get_link() follows a symlink that keeps its target in a data block
> in rcu pathwalk mode with ext4_getblk(EXT4_GET_BLOCKS_CACHED_NOWAIT).
> That reads s_mount_state in the ASSERT() of ext4_getblk() and again in
> ext4_es_lookup_extent(), and the lookup bumps the extent status hit or
> miss counter, all through sb->s_fs_info.
> 
> ext4_put_super() destroys those counters, clears sb->s_fs_info and frees
> the sbi without waiting for a grace period. A pathwalk that is still in
> ext4_get_link() when the last reference to the mount goes away then
> dereferences a NULL s_fs_info, the freed sbi or the destroyed percpu
> counters.
> [ ... ]
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-155414
> Feature: fix ms/fs
> 
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261117055330.810827-1-eva.kurchatova@virtuozzo.com?part=1


_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  reply	other threads:[~2026-11-17  6:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  5:52 [Devel] [PATCH hci-8.1 0/2] ms/fs: backport RCU pathwalk UAF fixes Eva Kurchatova
2026-11-17  5:52 ` [Devel] [PATCH hci-8.1 1/2] ms/ext4: free the sbi after a grace period Eva Kurchatova
2026-11-17  6:02   ` no-reply [this message]
2026-11-17  5:52 ` [Devel] [PATCH hci-8.1 2/2] ms/unicode: free the map " Eva Kurchatova
2026-11-17  5:59   ` no-reply
2026-11-17 15:15 ` [Devel] [PATCH hci-8.1 0/2] ms/fs: backport RCU pathwalk UAF fixes Konstantin Khorenko
2026-11-17 15:15 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=010701a1e8191ba2-59d745e4-e642-40f4-8521-de1737ec94d2-000000@eu-central-1.amazonses.com \
    --to=no-reply@sashiko.virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=eva.kurchatova@virtuozzo.com \
    --cc=khorenko@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox