From: no-reply@sashiko.virtuozzo.com
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>, khorenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 2/2] ms/mptcp: avoid dup SUB_CLOSED events after disconnect
Date: Tue, 17 Nov 2026 07:51:55 +0000 [thread overview]
Message-ID: <010701a1e87db701-292fa014-4b0b-4e43-9b05-9c5c8e319861-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261117074627.820727-3-eva.kurchatova@virtuozzo.com>
> From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
>
> [ Upstream commit 280d654324e33f8e6e3641f76764694c7b64c5db ]
>
> In case of subflow disconnect(), which can also happen with the first
> subflow in case of errors like timeout or reset, mptcp_subflow_ctx_reset
> will reset most fields from the mptcp_subflow_context structure,
> including close_event_done. Then, when another subflow is closed, yet
> another SUB_CLOSED event for the disconnected initial subflow is sent.
> Because of the previous reset, there are no source address and
> destination port.
>
> A solution is then to also check the subflow's local id: it shouldn't be
> negative anyway.
>
> [ ... ]
>
> https://virtuozzo.atlassian.net/browse/VSTOR-155419
> Feature: fix ms/net
>
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261117074627.820727-1-eva.kurchatova@virtuozzo.com?part=2
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-17 7:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 7:44 [Devel] [PATCH hci-8.1 0/2] ms/mptcp: backport connection reset fixes Eva Kurchatova
2026-11-17 7:44 ` [Devel] [PATCH hci-8.1 1/2] ms/mptcp: reset msk state on early connect failure Eva Kurchatova
2026-11-17 7:51 ` no-reply
2026-11-17 7:44 ` [Devel] [PATCH hci-8.1 2/2] ms/mptcp: avoid dup SUB_CLOSED events after disconnect Eva Kurchatova
2026-11-17 7:51 ` no-reply [this message]
2026-11-17 15:12 ` [Devel] [PATCH hci-8.1 0/2] ms/mptcp: backport connection reset fixes Konstantin Khorenko
2026-11-17 15:13 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a1e87db701-292fa014-4b0b-4e43-9b05-9c5c8e319861-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=devel@openvz.org \
--cc=eva.kurchatova@virtuozzo.com \
--cc=khorenko@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox